Re: [Spice-devel] [PATCH spice-gtk 1/5] usb-device-manager: Avoid needless re-numeration of usb devs under Linux

2013-04-23 Thread Christophe Fergeau
On Tue, Apr 23, 2013 at 02:19:48PM +0200, Hans de Goede wrote: > libusb_get_device_list() is not exactly a cheap call (lots of sysfs and > usbfs accesses), so it is worth to avoid it where possible. > > This patch restores the old (pre win32 support addition) of dealing with > libusb-devices under

Re: [Spice-devel] [PATCH spice-gtk 5/5] usb-device-manager: Fix stray '\n'-s in g_warning calls

2013-04-23 Thread Christophe Fergeau
ACK On Tue, Apr 23, 2013 at 02:19:52PM +0200, Hans de Goede wrote: > Signed-off-by: Hans de Goede > --- > gtk/usb-device-manager.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c > index 7575417..b7f24da 100644 > --

Re: [Spice-devel] [PATCH spice-gtk 3/5] usb-device-manager: Add spice_usb_device_manager_get_devices_with_filter (fdo#63807)

2013-04-23 Thread Christophe Fergeau
On Tue, Apr 23, 2013 at 02:19:50PM +0200, Hans de Goede wrote: > Signed-off-by: Hans de Goede > --- > doc/reference/spice-gtk-sections.txt | 1 + > gtk/map-file | 1 + > gtk/usb-device-manager.c | 46 > +--- > gtk/usb-device-m

Re: [Spice-devel] [PATCH spice-gtk 4/5] usb-device-manager: Fix redirect_on_connect_rules mem-leak

2013-04-23 Thread Christophe Fergeau
On Tue, Apr 23, 2013 at 02:19:51PM +0200, Hans de Goede wrote: > Signed-off-by: Hans de Goede > --- > gtk/usb-device-manager.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c > index 75406a4..7575417 100644 > --- a/gtk/usb-device-manag

Re: [Spice-devel] [PATCH spice-gtk 2/5] usb-device-manager: Error check spice_usb_device_manager_device_to_libdev calls

2013-04-23 Thread Christophe Fergeau
On Tue, Apr 23, 2013 at 02:19:49PM +0200, Hans de Goede wrote: > Under Windows all calls to spice_usb_device_manager_device_to_libdev may fail, > so error check them all. I don't think I'd make that conditional on the windows code as this makes things less readable, and this does not hurt to have

Re: [Spice-devel] [PATCH spice] server: Add public spice_qxl_driver_unload method

2013-04-23 Thread Alon Levy
> With a SPICE_DISPLAY_CAP_MONITORS_CONFIG capable client, the client needs to > know what part of the primary to use for each monitor. If the guest driver > does not support this, the server sends messages to the client for a > single monitor spanning the entire primary. > > As soon as the guest

Re: [Spice-devel] [PATCH win-agent] Revert "Refresh monitor config only when needed"

2013-04-23 Thread Christophe Fergeau
On Tue, Apr 23, 2013 at 05:08:02PM +0200, Marc-André Lureau wrote: > This reverts commit 67c1bcf49367d1726033b298a8ab016b4e22cf23. > > Also add a comment why the refresh is necessary there. The original > issue, reentering call, doesn't seem reproducible... ACK then. Christophe pgpXvIil2jmmC.p

Re: [Spice-devel] [spice-gtk] option: Allow multiple options in --disable-effects

2013-04-23 Thread Marc-André Lureau
ack - Mensaje original - > Commit 82c367 added checks that the value passed to --disable-effects > is valid, but it does not take into account that it's perfectly valid > to pass multiple values separated by commas. This commit splits > the value passed to --disable-effects and checks each

[Spice-devel] [spice-gtk] option: Allow multiple options in --disable-effects

2013-04-23 Thread Christophe Fergeau
Commit 82c367 added checks that the value passed to --disable-effects is valid, but it does not take into account that it's perfectly valid to pass multiple values separated by commas. This commit splits the value passed to --disable-effects and checks each component separatey. Fixes rhbz#955277 -

Re: [Spice-devel] Testing Linux multi-monitor functionality

2013-04-23 Thread Jikku Venkat
1) the suggested qemu-kvm command line options did not appear to make any difference, with Fedora 18 as the client and with both Fedora 18 or Centos 6.4 guests) 2) Tried Fedora 18 (64-bit) guest - Also only one display is configured and shows up - xrandr reported only a single display (named

[Spice-devel] [PATCH win-agent] Revert "Refresh monitor config only when needed"

2013-04-23 Thread Marc-André Lureau
This reverts commit 67c1bcf49367d1726033b298a8ab016b4e22cf23. Also add a comment why the refresh is necessary there. The original issue, reentering call, doesn't seem reproducible... https://bugzilla.redhat.com/show_bug.cgi?id=912793 --- vdagent/vdagent.cpp | 4 +++- 1 file changed, 3 insertions

Re: [Spice-devel] [PATCH spice-gtk] main: do not send monitor config if monitor state didn't change

2013-04-23 Thread Hans de Goede
ACK. On 04/23/2013 02:48 PM, Marc-André Lureau wrote: Don't send monitor config after spice_main_set_display_enabled() if the monitor state didn't change. This solves monitor "flashing", reconfiguring in a loop: https://bugzilla.redhat.com/show_bug.cgi?id=952327 --- gtk/channel-main.c | 2 ++

[Spice-devel] [PATCH spice-gtk] main: do not send monitor config if monitor state didn't change

2013-04-23 Thread Marc-André Lureau
Don't send monitor config after spice_main_set_display_enabled() if the monitor state didn't change. This solves monitor "flashing", reconfiguring in a loop: https://bugzilla.redhat.com/show_bug.cgi?id=952327 --- gtk/channel-main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gtk/channel

[Spice-devel] [PATCH spice-gtk 5/5] usb-device-manager: Fix stray '\n'-s in g_warning calls

2013-04-23 Thread Hans de Goede
Signed-off-by: Hans de Goede --- gtk/usb-device-manager.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c index 7575417..b7f24da 100644 --- a/gtk/usb-device-manager.c +++ b/gtk/usb-device-manager.c @@ -385,7 +385,7 @@ sta

[Spice-devel] [PATCH spice-gtk 4/5] usb-device-manager: Fix redirect_on_connect_rules mem-leak

2013-04-23 Thread Hans de Goede
Signed-off-by: Hans de Goede --- gtk/usb-device-manager.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c index 75406a4..7575417 100644 --- a/gtk/usb-device-manager.c +++ b/gtk/usb-device-manager.c @@ -314,6 +314,7 @@ static void spice_usb_d

[Spice-devel] [PATCH spice-gtk 3/5] usb-device-manager: Add spice_usb_device_manager_get_devices_with_filter (fdo#63807)

2013-04-23 Thread Hans de Goede
Signed-off-by: Hans de Goede --- doc/reference/spice-gtk-sections.txt | 1 + gtk/map-file | 1 + gtk/usb-device-manager.c | 46 +--- gtk/usb-device-manager.h | 2 ++ 4 files changed, 47 insertions(+), 3 deletions(-

[Spice-devel] [PATCH spice-gtk 2/5] usb-device-manager: Error check spice_usb_device_manager_device_to_libdev calls

2013-04-23 Thread Hans de Goede
Under Windows all calls to spice_usb_device_manager_device_to_libdev may fail, so error check them all. Signed-off-by: Hans de Goede --- gtk/usb-device-manager.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c

[Spice-devel] [PATCH spice-gtk 1/5] usb-device-manager: Avoid needless re-numeration of usb devs under Linux

2013-04-23 Thread Hans de Goede
libusb_get_device_list() is not exactly a cheap call (lots of sysfs and usbfs accesses), so it is worth to avoid it where possible. This patch restores the old (pre win32 support addition) of dealing with libusb-devices under Linux, it keeps the device from the first lookup in spice_usb_device_man

Re: [Spice-devel] [PATCH spice] server: Add public spice_qxl_driver_unload method

2013-04-23 Thread Hans de Goede
Hi, On 04/23/2013 11:54 AM, Marc-André Lureau wrote: Hi, Thanks for catching this. Have you evaluated clearing the flag in spice_qxl_create_primary_surface_async() ? Yes, but that gets used by multi-head aware drivers too, so that won't work. Regards, Hans _

Re: [Spice-devel] [Users] Server 2k8

2013-04-23 Thread David Jaša
Alon Levy píše v Út 23. 04. 2013 v 06:48 -0400: > > Ryan Wilkinson píše v Po 22. 04. 2013 v 14:43 -0600: > > > Sounds like I'm missing something. We're looking at using Windows > > > Server 2k8 as a workstation OS as the licensing seems to be more > > > reasonable for vdi. > > > > Ah, OK. Then it

Re: [Spice-devel] [Users] Server 2k8

2013-04-23 Thread Alon Levy
> Ryan Wilkinson píše v Po 22. 04. 2013 v 14:43 -0600: > > Sounds like I'm missing something. We're looking at using Windows > > Server 2k8 as a workstation OS as the licensing seems to be more > > reasonable for vdi. > > Ah, OK. Then it would be reasonable to add server systems as supported > to

Re: [Spice-devel] [PATCH win-agent] Try harder to enable monitors

2013-04-23 Thread Christophe Fergeau
On Tue, Apr 23, 2013 at 11:35:25AM +0200, Marc-André Lureau wrote: > On Tue, Apr 23, 2013 at 10:31 AM, Christophe Fergeau > wrote: > > > Isn't it possible to do that where the "attach" was before in case the > > screen is off? If we know the screen is off, there is not much point in > > trying th

Re: [Spice-devel] how to limit each spice-client only can access its own usb device

2013-04-23 Thread David Jaša
bigclouds píše v Út 23. 04. 2013 v 16:15 +0800: > hi. > let us suppose virt-view can redirect usb device to server.(i think > this function has been implemented) > many people connect to their guestVM over spice(virt-view). > each person attach a usb-storage, how is that? one can see all > peopl

Re: [Spice-devel] [PATCH spice] server: Add public spice_qxl_driver_unload method

2013-04-23 Thread Marc-André Lureau
Hi, Thanks for catching this. Have you evaluated clearing the flag in spice_qxl_create_primary_surface_async() ? ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH win-agent] Try harder to enable monitors

2013-04-23 Thread Marc-André Lureau
On Tue, Apr 23, 2013 at 10:31 AM, Christophe Fergeau wrote: > Isn't it possible to do that where the "attach" was before in case the > screen is off? If we know the screen is off, there is not much point in > trying the CreateDC as this will fail. > I don't know what can give information about "t

Re: [Spice-devel] [Users] Server 2k8

2013-04-23 Thread David Jaša
Ryan Wilkinson píše v Po 22. 04. 2013 v 14:43 -0600: > Sounds like I'm missing something. We're looking at using Windows > Server 2k8 as a workstation OS as the licensing seems to be more > reasonable for vdi. Ah, OK. Then it would be reasonable to add server systems as supported to driver metadat

Re: [Spice-devel] [PATCH win-agent] Try harder to enable monitors

2013-04-23 Thread Christophe Fergeau
On Mon, Apr 22, 2013 at 11:08:30PM +0200, Marc-André Lureau wrote: > 0ba6e2936 was trying to fix CreateDC() failing when the monitor is > disabled, unfortunately, enabling monitor with an arbitrary resolution > may still fail (the previous resolution, or the current one). > > This patch address th

Re: [Spice-devel] how to limit each spice-client only can access its own usb device

2013-04-23 Thread bigclouds
hi. let us suppose virt-view can redirect usb device to server.(i think this function has been implemented) many people connect to their guestVM over spice(virt-view).each person attach a usb-storage, how is that? one can see all people's usb-storage in his guestVM. now i want to

[Spice-devel] [PATCH] qxl: Call spice_qxl_driver_unload from qxl_enter_vga_mode

2013-04-23 Thread Hans de Goede
With a SPICE_DISPLAY_CAP_MONITORS_CONFIG capable client, the client needs to know what part of the primary to use for each monitor. If the guest driver does not support this, the server sends messages to the client for a single monitor spanning the entire primary. As soon as the guest calls spice_

[Spice-devel] [PATCH spice] server: Add public spice_qxl_driver_unload method

2013-04-23 Thread Hans de Goede
With a SPICE_DISPLAY_CAP_MONITORS_CONFIG capable client, the client needs to know what part of the primary to use for each monitor. If the guest driver does not support this, the server sends messages to the client for a single monitor spanning the entire primary. As soon as the guest calls spice_