Re: [Spice-devel] [spice-gtk] Fix GNetworkAddress leak when opening spice session

2013-04-13 Thread Christophe Fergeau
On Sat, Apr 13, 2013 at 10:21:40AM -0400, Marc-André Lureau wrote: > Is the connectable referenced during the async op? It has to, or this would be racy. I've checked the code now, and it indeed does: void g_socket_client_connect_async (GSocketClient *client,

Re: [Spice-devel] [spice-gtk] Fix GNetworkAddress leak when opening spice session

2013-04-13 Thread Marc-André Lureau
Is the connectable referenced during the async op? - Mensaje original - > ACK. > > On 04/13/2013 01:34 PM, Christophe Fergeau wrote: > > --- > > gtk/spice-session.c | 9 +++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/gtk/spice-session.c b/gtk/spice-s

Re: [Spice-devel] [spice-gtk] Fix GNetworkAddress leak when opening spice session

2013-04-13 Thread Hans de Goede
ACK. On 04/13/2013 01:34 PM, Christophe Fergeau wrote: --- gtk/spice-session.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/gtk/spice-session.c b/gtk/spice-session.c index f472027..44d42f2 100644 --- a/gtk/spice-session.c +++ b/gtk/spice-session.c @@ -1744,8 +1

[Spice-devel] [spice-gtk] Fix GNetworkAddress leak when opening spice session

2013-04-13 Thread Christophe Fergeau
--- gtk/spice-session.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/gtk/spice-session.c b/gtk/spice-session.c index f472027..44d42f2 100644 --- a/gtk/spice-session.c +++ b/gtk/spice-session.c @@ -1744,8 +1744,13 @@ static gboolean open_host_idle_cb(gpointer data)

Re: [Spice-devel] [PATCH] Fix typo in src/vdagentd.c

2013-04-13 Thread Hans de Goede
Hi, Thanks for the patch, pushed to the official git repo. Regards, Hans On 04/12/2013 06:19 PM, Liang Guo wrote: Signed-off-by: Liang Guo --- src/vdagentd.c |2 +- 1 个文件被修改,插入 1 行(+),删除 1 行(-) diff --git a/src/vdagentd.c b/src/vdagentd.c index fbbe315..888a80a 100644 --- a/src/vdage