Hi,
ACK series, but before release the spice-common patch titled:
"[spice-common PATCH] supply missing IS_IMAGE_TYPE_* elements for
LZ_IMAGE_TYPE_A8"
Should be pushed to spice-common and the spice-common sub-module
of spice-gtk should be updated.
Regards,
Hans
On 04/09/2013 09:02 PM, Marc-And
---
NEWS | 10 ++
1 file changed, 10 insertions(+)
diff --git a/NEWS b/NEWS
index 37dfd27..2a741eb 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,13 @@
+v0.19
+=
+
+This is a bugfix only release, except the snappy name change
+- snappy has been renamed to spicy-screenshot
+- Several file-xfe
new symbols in spice-glib, bump before release
---
gtk/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gtk/Makefile.am b/gtk/Makefile.am
index 2ba27a8..f5f1906 100644
--- a/gtk/Makefile.am
+++ b/gtk/Makefile.am
@@ -170,7 +170,7 @@ nodist_libspice_client_gtkinclude_H
Following discussion on the ML:
http://lists.freedesktop.org/archives/spice-devel/2013-April/012953.html
---
README | 2 +-
gtk/Makefile.am | 12 ++--
gtk/snappy.c| 178
po/POTFILES.in | 2 +-
4 files changed, 8 insertions
you probably want to update Makefile.am for make distcheck to pass (even as
a submodule).
otherwise, looks good
On Tue, Apr 9, 2013 at 6:00 PM, Christophe Fergeau wrote:
> In addition to Laszlo's commit fixing rhbz#928973, we can add
> some compile-time assertion to lz_common.h to help catch si
In addition to Laszlo's commit fixing rhbz#928973, we can add
some compile-time assertion to lz_common.h to help catch similar
bugs in the future.
This uses gnulib's verify.h to make sure at compile-time that
the various constant arrays used in lz_common.h are of the expected
size.
I've checked tha
Hi,
you should give a try to virt-viewer build @
http://spice-space.org/download.html instead of the old spice-client.
I'm quite sure that you won't hit this bug there and you'll get 1+ year
worth of features that landed just there and not in the old client...
David
andya píše v Út 02. 04. 2013
Ack.
Thanks,
Yonit.
On 04/09/2013 08:02 AM, Laszlo Ersek wrote:
The IS_IMAGE_TYPE_PLT and IS_IMAGE_TYPE_RGB arrays are supposed to decide
whether each image type is PLT or RGB. Dependent on the result, one of the
PLT_PIXELS_PER_BYTE and RGB_BYTES_PER_PIXEL arrays can be indexed.
Commit c0b048eb
Hi,
On 04/09/2013 03:25 PM, agil...@redhat.com wrote:
On 04/09/2013 04:12 PM, Hans de Goede wrote:
Hi,
On 04/09/2013 03:02 PM, Arnon Gilboa wrote:
for the case path contains a space, see CreateService() doc:
http://msdn.microsoft.com/en-us/library/windows/desktop/ms682450.aspx
rhbz #918635
-
On 04/09/2013 04:12 PM, Hans de Goede wrote:
Hi,
On 04/09/2013 03:02 PM, Arnon Gilboa wrote:
for the case path contains a space, see CreateService() doc:
http://msdn.microsoft.com/en-us/library/windows/desktop/ms682450.aspx
rhbz #918635
---
vdservice/vdservice.cpp |8 ++--
1 files c
On Tue, Apr 09, 2013 at 03:05:16PM +0200, Peter Hatina wrote:
> of course, it is not. That's why I put there a rhbz link.
We usually try to get bugs fixed upstream first, and then
to backport that to the RHEL package, so having rhbz links in upstream
commits against git master isn't unusual.
If t
Hi,
On 04/09/2013 03:02 PM, Arnon Gilboa wrote:
for the case path contains a space, see CreateService() doc:
http://msdn.microsoft.com/en-us/library/windows/desktop/ms682450.aspx
rhbz #918635
---
vdservice/vdservice.cpp |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff
Hi,
of course, it is not. That's why I put there a rhbz link.
On 04/09/2013 02:20 PM, Christophe Fergeau wrote:
> On Tue, Apr 09, 2013 at 12:16:38PM +0200, Peter Hatina wrote:
>> Hi,
>>
>> this should fix
>> https://bugzilla.redhat.com/show_bug.cgi?id=882339
^^
>>
>> Are we ok with this short
Hi,
On 04/09/2013 02:16 PM, Marc-André Lureau wrote:
Allow to change locally display resolution without sending to remote,
This is useful to keep local information without boring the remote
s/boring/bothering/ ? Other then that ACK series.
Regards,
Hans
__
for the case path contains a space, see CreateService() doc:
http://msdn.microsoft.com/en-us/library/windows/desktop/ms682450.aspx
rhbz #918635
---
vdservice/vdservice.cpp |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice
On Tue, Apr 09, 2013 at 12:16:38PM +0200, Peter Hatina wrote:
> Hi,
>
> this should fix https://bugzilla.redhat.com/show_bug.cgi?id=882339
>
> Are we ok with this short diff?
This patch is not against git master if I'm not mistaken (the unlink() are
no longer there, nor the ControllerWaitHelper
spice-gtk keep the main channel monitor configuration in sync, but
shouldn't send back to the remote if disabled, as this may results in
different settings, for example if the remote has switched to
16 bits.
---
gtk/spice-widget.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --g
Allow to change locally display resolution without sending to remote,
This is useful to keep local information without boring the remote
---
gtk/channel-main.c | 37 +++--
gtk/channel-main.h | 2 ++
gtk/map-file| 1 +
gtk/spice-glib-sym-file
The IS_IMAGE_TYPE_PLT and IS_IMAGE_TYPE_RGB arrays are supposed to decide
whether each image type is PLT or RGB. Dependent on the result, one of the
PLT_PIXELS_PER_BYTE and RGB_BYTES_PER_PIXEL arrays can be indexed.
Commit c0b048eb introduced the LZ_IMAGE_TYPE_A8 enum constant and grew the
RGB_BYT
Looks good, ack.
On 04/09/2013 12:16 PM, Peter Hatina wrote:
Hi,
this should fix https://bugzilla.redhat.com/show_bug.cgi?id=882339
Are we ok with this short diff?
---
SpiceXPI/src/plugin/plugin.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/SpiceXPI/src/plugin/plugin.cpp b/Spic
On Tue, Apr 09, 2013 at 12:07:00PM +0200, Hans de Goede wrote:
> Hi,
>
> First of all thanks for reviewing this set!
>
> Are you still thinking about:
> Patch 2/16: Revert "channel-main: Fix dangling references to freed
> file-xfer-tasks on agent cancel"
> Patch 11/16: channel-main: Don't close
ACK..
Christophe
On Fri, Mar 29, 2013 at 12:40:23PM +0100, Hans de Goede wrote:
> If file_xfer_completed gets called while callbacks are pending we should
> not call g_input_stream_close_async, because:
> 1) Doing so while another operation is pending on the file_stream will fail
> 2) Doing so wh
Hi,
this should fix https://bugzilla.redhat.com/show_bug.cgi?id=882339
Are we ok with this short diff?
---
SpiceXPI/src/plugin/plugin.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXPI/src/plugin/plugin.cpp
index 4a88e45..d5ca720 100644
--- a/Spi
ACK
On Fri, Mar 29, 2013 at 12:40:20PM +0100, Hans de Goede wrote:
> So that the channel sticks around while their callbacks are completing.
>
> Signed-off-by: Hans de Goede
> ---
> gtk/channel-main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gtk/channel-main.c
Hi,
On 04/09/2013 12:02 PM, Christophe Fergeau wrote:
On Fri, Mar 29, 2013 at 12:40:14PM +0100, Hans de Goede wrote:
The fix from commit 19313a133af0d2404b29914b5937219127ad455b is incomplete,
this commit added code to file_xfer_close_cb, to remove any reference to
the task being closed from th
Hi,
First of all thanks for reviewing this set!
Are you still thinking about:
Patch 2/16: Revert "channel-main: Fix dangling references to freed file-xfer-tasks
on agent cancel"
Patch 11/16: channel-main: Don't close the file_stream if callbacks are pending
Or did something eat your mails on
On Fri, Mar 29, 2013 at 12:40:14PM +0100, Hans de Goede wrote:
> The fix from commit 19313a133af0d2404b29914b5937219127ad455b is incomplete,
> this commit added code to file_xfer_close_cb, to remove any reference to
> the task being closed from the flushing queue.
>
> But file_xfer_flushed / file_
On Fri, Mar 29, 2013 at 12:40:27PM +0100, Hans de Goede wrote:
> Signed-off-by: Hans de Goede
> ---
> gtk/channel-main.c | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/gtk/channel-main.c b/gtk/channel-main.c
> index 7513ead..01c0659 100644
> --- a/gtk/channel-main.c
> +++
On Fri, Mar 29, 2013 at 12:40:28PM +0100, Hans de Goede wrote:
> Since the agent channel can have a significant latency, it is possible
> for a cancel send from the client to the agent and a status message from
> the agent to cross each other. If this happens then the file-xfer will no
> longer be
On Fri, Mar 29, 2013 at 12:40:26PM +0100, Hans de Goede wrote:
> We should never have pending callbacks when we receive a file-xfer start or
> end (success) message from the agent.
ACK (I'd probably move this right after the addition of task->pending, but
not very important).
Christophe
>
> Sign
ACK.
On Fri, Mar 29, 2013 at 12:40:25PM +0100, Hans de Goede wrote:
> If we fail to open a file, task->file_stream will be NULL, so we should
> not call g_input_stream_close on it.
>
> Signed-off-by: Hans de Goede
> ---
> gtk/channel-main.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff
On Fri, Mar 29, 2013 at 12:40:24PM +0100, Hans de Goede wrote:
> So that it can used for cleanup before we've a file_stream.
>
> Note this also gets rid of the weird double initialization of the local
> stream variable.
>
> Signed-off-by: Hans de Goede
> ---
> gtk/channel-main.c | 15 --
ACK, nice cleanup.
Christophe
On Fri, Mar 29, 2013 at 12:40:22PM +0100, Hans de Goede wrote:
> Signed-off-by: Hans de Goede
> ---
> gtk/channel-main.c | 37 +++--
> 1 file changed, 11 insertions(+), 26 deletions(-)
>
> diff --git a/gtk/channel-main.c b/gtk/chann
33 matches
Mail list logo
