Re: [Spice-devel] [PATCH spice-gtk] channel-playback/record: Refuse audio-vol-msgs with 0 channels

2013-04-02 Thread Marc-André Lureau
looks good, ack - Mensaje original - > Older servers send these, explicitly warn about this, rather then triggering > the following error later: > > (remote-viewer:8726): GSpice-WARNING **: set_sink_input_volume() failed: > Invalid argument > > Signed-off-by: Hans de Goede > --- > gtk/

[Spice-devel] [PATCH spice-gtk] channel-playback/record: Refuse audio-vol-msgs with 0 channels

2013-04-02 Thread Hans de Goede
Older servers send these, explicitly warn about this, rather then triggering the following error later: (remote-viewer:8726): GSpice-WARNING **: set_sink_input_volume() failed: Invalid argument Signed-off-by: Hans de Goede --- gtk/channel-playback.c | 5 + gtk/channel-record.c | 5 +

Re: [Spice-devel] [PATCH spice-gtk] spice-pulse: Fix set_sink_input_volume() failed on seamless migration

2013-04-02 Thread Hans de Goede
Hi, On 04/01/2013 11:11 PM, Marc-André Lureau wrote: Hi I think we can agree that we should *never* deliberately call functions with invalid parameters. So we need to *explicitly* check for nchannels == 0, rather then relying on pa_context_set_sink_input_volume to check this for us. I ag

Re: [Spice-devel] [PATCH spice-gtk] RFC: win32: do not handle win keys when the keyboard is not grabbed

2013-04-02 Thread Hans de Goede
ACK. On 04/02/2013 06:15 PM, Marc-André Lureau wrote: Special-case on win32, filter out the win keys when not having the keyboard grab. This is to avoid the win keys to be received both by the guest and the client, which can be undesirable in general. https://bugzilla.redhat.com/show_bug.cgi?id

[Spice-devel] [PATCH spice-gtk] RFC: win32: do not handle win keys when the keyboard is not grabbed

2013-04-02 Thread Marc-André Lureau
Special-case on win32, filter out the win keys when not having the keyboard grab. This is to avoid the win keys to be received both by the guest and the client, which can be undesirable in general. https://bugzilla.redhat.com/show_bug.cgi?id=873341 --- gtk/spice-widget.c | 8 1 file chan

[Spice-devel] [ Spice-devel ] Qemu 1.4 : mouse button inactive

2013-04-02 Thread nicolas prochazka
Hello, Since qemu 1.4 , with linux guest ( centos 6.4 , Kubuntu 12.10) , mouse buttons does not work. mouse move is ok . With Windows guest there's no problem. With qemu 1.2.0 , there's no problem. Cmd line : ( create by libvirt ) /usr/bin/qemu-system-x86_64 -machine accel=kvm -name 7-ap-lh002 -S

[Spice-devel] Spice-Client Windows + SSL Bug+fix ?

2013-04-02 Thread andya
I tried to use SSL with the Windowsclient. version:spice-0.12.2 found the same problem : bug Bug 38615 - Spicec (win32) & SSL => Runtimeerror + potential fix for it . but the bug no changes,why? Greetings Thomas Tyminski Berlin, Germany thanks!___ S

Re: [Spice-devel] [spice-common PATCH] region.c: fix region_bounds_intersects

2013-04-02 Thread Hans de Goede
ACK. On 04/02/2013 02:51 PM, Yonit Halperin wrote: region_bounds_intersects mistakingly ignored one of the input regions, and compared the other region to itself. --- common/region.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/region.c b/common/region.c index cd

[Spice-devel] [spice-common PATCH] region.c: fix region_bounds_intersects

2013-04-02 Thread Yonit Halperin
region_bounds_intersects mistakingly ignored one of the input regions, and compared the other region to itself. --- common/region.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/region.c b/common/region.c index cd9ade0..14a27ed 100644 --- a/common/region.c +++ b/common