hi~
I would like to know what are the restrictions of clients' number in
multihead？
Thanks in advance
yuanyuan
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://l
Since the agent channel can have a significant latency, it is possible
for a cancel send from the client to the agent and a status message from
the agent to cross each other. If this happens then the file-xfer will no
longer be on the list.
Printing a g_warning on this (rare but triggerable) condi
Signed-off-by: Hans de Goede
---
gtk/channel-main.c | 12
1 file changed, 12 insertions(+)
diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index 7513ead..01c0659 100644
--- a/gtk/channel-main.c
+++ b/gtk/channel-main.c
@@ -165,6 +165,7 @@ static gboolean main_migrate_handshake_
We should never have pending callbacks when we receive a file-xfer start or
end (success) message from the agent.
Signed-off-by: Hans de Goede
---
gtk/channel-main.c | 8
1 file changed, 8 insertions(+)
diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index 5a05651..7513ead 100644
If we fail to open a file, task->file_stream will be NULL, so we should
not call g_input_stream_close on it.
Signed-off-by: Hans de Goede
---
gtk/channel-main.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index c7ac12d..5a05651 100644
--- a/gt
So that it can used for cleanup before we've a file_stream.
Note this also gets rid of the weird double initialization of the local
stream variable.
Signed-off-by: Hans de Goede
---
gtk/channel-main.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/gtk/channe
If file_xfer_completed gets called while callbacks are pending we should
not call g_input_stream_close_async, because:
1) Doing so while another operation is pending on the file_stream will fail
2) Doing so while a non file_stream callback is pending may result in the
task being freed before the ca
Signed-off-by: Hans de Goede
---
gtk/channel-main.c | 37 +++--
1 file changed, 11 insertions(+), 26 deletions(-)
diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index 10ba175..b0d60eb 100644
--- a/gtk/channel-main.c
+++ b/gtk/channel-main.c
@@ -163,6 +163,7
Make file_xfer_failed usable for all file_stream closing.
Signed-off-by: Hans de Goede
---
gtk/channel-main.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index bd27ef4..10ba175 100644
--- a/gtk/channel-main.c
+++ b/g
So that the channel sticks around while their callbacks are completing.
Signed-off-by: Hans de Goede
---
gtk/channel-main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index 8e8a3a5..bd27ef4 100644
--- a/gtk/channel-main.c
+++ b/g
Discard any partially received messages from the agent on agent stop.
Signed-off-by: Hans de Goede
---
gtk/channel-main.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index 672fbcf..8e8a3a5 100644
--- a/gtk/channel-main.c
+++
Signed-off-by: Hans de Goede
---
gtk/channel-main.c | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index 4e766d3..672fbcf 100644
--- a/gtk/channel-main.c
+++ b/gtk/channel-main.c
@@ -327,22 +327,34 @@ static void spi
xfer_id > UINT32_MAX is never true since xfer_id is an uint32_t, and
thus explicit wrapping is not necessary since it will wrap every
UINT32_MAX + 1 itereations anyways.
Signed-off-by: Hans de Goede
---
gtk/channel-main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/gtk/channel-main.c b/
Call g_simple_async_result_is_valid on the passed in result to verify it is
what we expect.
Signed-off-by: Hans de Goede
---
gtk/channel-main.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index 5f981c4..5d18366 100644
--- a/gtk
Call g_simple_async_result_is_valid before using the result.
Signed-off-by: Hans de Goede
---
gtk/channel-main.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index 257ded5..5f981c4 100644
--- a/gtk/channel-main.c
+++ b/gtk/ch
The fix from commit 19313a133af0d2404b29914b5937219127ad455b is incomplete,
this commit added code to file_xfer_close_cb, to remove any reference to
the task being closed from the flushing queue.
But file_xfer_flushed / file_xfer_flush_async execute file_xfer_data_flushed_cb
from an idle handler,
Currently the user can drag-drop text onto the widget, and it will try to
open it as a file, not good, this fixes this.
Signed-off-by: Hans de Goede
---
gtk/spice-widget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c
index fb8094e..2
Here is v2 of my file xfer robustness / error handling series.
The main change since v1 is that I've reworked the handling for getting
cancelling trasnfers while a callback is pending, since the previous series
missed some scenarios where the file-xfer-task would be destroyed while
callbacks refer
Hi,
On 03/10/2013 03:44 PM, Hans de Goede wrote:
Hi,
First of all thanks for the review.
On 03/10/2013 03:28 PM, Marc-André Lureau wrote:
On Sat, Mar 9, 2013 at 12:06 PM, Hans de Goede wrote:
So that the channel sticks around while their callbacks are completing.
I am not sure this is a g
On seamless migration "switch-over" the playback_volume_changed callback gets
called, and at this time the channel object's nchannels property is 0,
leading to a warning like this:
(remote-viewer:8726): GSpice-WARNING **: set_sink_input_volume() failed:
Invalid argument
This patch fixes this.
S
2 closely related changes in one:
1) When leaving the read or write loop because the chardev has been stopped
active should not be updated. It has been set to FALSE by
spice_char_device_stop and should stay FALSE
2) The updating of dev->active should be done *before* unref-ing dev
Signed-off-by: H
The write-retry timer should not be set when we're leaving
spice_char_device_write_to_device because the char-dev has been stopped.
Signed-off-by: Hans de Goede
---
server/char_device.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/server/char_device.c b/server/
Before this patch the write-loop in spice_char_device_write_to_device would
break on running becoming 0, after having written some data, without updating
the buffer status, causing the same data to be written *again* when started.
Signed-off-by: Hans de Goede
---
server/char_device.c | 5 +
Hi,
On Thu, Mar 28, 2013 at 09:25:55PM -0700, Todd And Margo Chester wrote:
> And Windows W7 complains about the driver not being signed.
> (I figured a way to get around it).
Yes that's a known limitation with these free drivers.
>
> Is there any sign of any update to spice-guest-tools in
> ou
24 matches
Mail list logo
