On Mon, Mar 11, 2013 at 10:00 AM, Christophe Fergeau wrote:
> There are various issues with this release, could you try to disable the
> balloon service (blnsvr.exe)?
> If this does not help, can you try removing the vioserial driver? This
> will break c&p/automatic resolution, but this would at l
On Tue, Mar 12, 2013 at 01:00:42PM +0100, Marc-André Lureau wrote:
> On Tue, Mar 12, 2013 at 12:22 PM, Christophe Fergeau
> wrote:
> > Copyright 2009-2011, Red Hat Inc.
> > + * Copyright 2013, Red Hat Inc.
>
> I would just update the range, instead of adding extra line (one for
> each year?).
Really sorry to go back to it but I simply could not manage to find the
answer myself. I explored the code of the client, server, even pixman… but
I really couldn’t find what those mask flags are used for. Any tip?
Vincent
On Wed, Mar 6, 2013 at 2:48 PM, Jeremy White wrote:
> On 03/05/2013 09:
On Tue, Mar 12, 2013 at 2:55 PM, Christophe Fergeau wrote:
> Yup, the Windows version of this function will be using dynamic allocation
> as we need to get the client name from the registry, split it, ...
You could make use of g_strdupv() instead perhaps?
--
Marc-André Lureau
__
On Tue, Mar 12, 2013 at 01:37:06PM +0100, Marc-André Lureau wrote:
> after this patch:
>
> "LoadPlugin: failed to initialize"..., 212LoadPlugin: failed to
> initialize shared library
> /home/elmarco/.mozilla/plugins/libnsISpicec.so
> [/home/elmarco/.mozilla/plugins/libnsISpicec.so: undefined symbo
On Tue, Mar 12, 2013 at 01:32:13PM +0100, Marc-André Lureau wrote:
> On Tue, Mar 12, 2013 at 12:23 PM, Christophe Fergeau
> wrote:
> > void SpiceController::GetClientPaths(GStrv *client_argv, GStrv
> > *fallback_argv)
> > +{
> > +if (client_argv != NULL) {
> > +*client_argv = g_new0(c
On Tue, Mar 12, 2013 at 12:32:55PM +0100, Marc-André Lureau wrote:
> ack (please push for the next series to be reviewed)
Sorry, I just saw that email, I've now pushed the series with the added
configure log you asked for, but this comes after sending the next series.
Christophe
pgpqEzTRZz_Cz.p
after this patch:
"LoadPlugin: failed to initialize"..., 212LoadPlugin: failed to
initialize shared library
/home/elmarco/.mozilla/plugins/libnsISpicec.so
[/home/elmarco/.mozilla/plugins/libnsISpicec.so: undefined symbol:
_ZN19SpiceControllerUnix14GetClientPathsEPPPcS2_
On Tue, Mar 12, 2013 at 1
On Tue, Mar 12, 2013 at 12:23 PM, Christophe Fergeau
wrote:
> void SpiceController::GetClientPaths(GStrv *client_argv, GStrv *fallback_argv)
> +{
> +if (client_argv != NULL) {
> +*client_argv = g_new0(char *, 2);
> +(*client_argv)[0] = g_strdup("/usr/libexec/spice-xpi-client");
On 08/03/2013 18:24, Flo wrote:
now I renewed my System and tested it with virt-viewer on a very good
Laptop with ubuntu. The Performance is nearly 100% perfect. Sometimes
it is a little bit laggy, notably when I play videos in fullscreen.
When I go with the mouse cursor over a running youtube
You could also fix this deprecation
warning: 'GThread* g_thread_create(GThreadFunc, gpointer, gboolean,
GError**)' is deprecated (declared at
/usr/include/glib-2.0/glib/deprecated/gthread.h:100): Use
'g_thread_new' instead [-Wdeprecated-declarations]
--
Marc-André Lureau
__
On Tue, Mar 12, 2013 at 12:23 PM, Christophe Fergeau
wrote:
> +/* FIXME: we are not in the main thread!! */
> +fake_this->m_plugin->OnSpiceClientExit(status);
That scares me, but it looks like you didn't introduce that, so it's
okay I guess.
Apparently, it was done in "Drop sigchld handl
On Tue, Mar 12, 2013 at 12:22 PM, Christophe Fergeau
wrote:
> Copyright 2009-2011, Red Hat Inc.
> + * Copyright 2013, Red Hat Inc.
I would just update the range, instead of adding extra line (one for
each year?).
--
Marc-André Lureau
___
Spice-de
On Tue, Mar 12, 2013 at 12:22 PM, Christophe Fergeau
wrote:
> This has the big advantage of being portable, in addition to removing
> some code. Big disadvantage is that this adds a dependency on gio.
> ---
> SpiceXPI/src/plugin/plugin.cpp | 67
> +-
> Spi
Hi,
Great work on debugging this! ACK.
Regards,
Hans
On 03/12/2013 01:00 PM, Arnon Gilboa wrote:
CxImage DIB to PNG encoding seems to ignore pallete in some scenarios.
This issue happens when copying a png from FireFox, but with IE it's ok.
rhbz #919150
---
vdagent/vdagent.cpp | 11
CxImage DIB to PNG encoding seems to ignore pallete in some scenarios.
This issue happens when copying a png from FireFox, but with IE it's ok.
rhbz #919150
---
vdagent/vdagent.cpp | 11 ---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/vdagent/vdagent.cpp b/vdagent/vda
Hi,
First: I have build the spice-server with adaptivestreaming.v2 successfully,
but how does KVM/qemu know where it the corresponding files are located?
Second: I already have installed spice-server from Fedora18 Repo. Is it a
problem when I build it by myself and overwrite the existing files?
ack (please push for the next series to be reviewed)
On Mon, Mar 11, 2013 at 12:52 PM, Christophe Fergeau
wrote:
> On Mon, Mar 11, 2013 at 12:24:03PM +0100, Marc-André Lureau wrote:
>> How do you apply this? if fails on both current master, and after the
>> previous 10 patches.
>
> As indicated i
It contains all the generic code, then platform-specific controller
implementations will inherit from it and overload the non-generic parts
abstract methods.
---
SpiceXPI/src/plugin/Makefile.am | 2 +
SpiceXPI/src/plugin/controller-unix.cpp | 209 +++---
SpiceXPI/src/
g_usleep is more portable than sleep()
---
SpiceXPI/src/plugin/controller-unix.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SpiceXPI/src/plugin/controller-unix.cpp
b/SpiceXPI/src/plugin/controller-unix.cpp
index 743e00b..ddbd8c0 100644
--- a/SpiceXPI/src/plugin/controll
The SPICE client paths will be different on Windows and Unix so add
a helper function returning the paths to use to spawn the clients.
---
SpiceXPI/src/plugin/controller-unix.cpp | 66 -
SpiceXPI/src/plugin/controller.h| 1 +
2 files changed, 49 insertions(
Communication with the client is done differently on Windows and
Linux (named pipe VS unix socket), so move this platform-specific
setup to a distinct method.
---
SpiceXPI/src/plugin/controller-unix.cpp | 15 +++
SpiceXPI/src/plugin/controller.h| 2 ++
2 files changed, 13 inse
This removes quite a lot of OS-specific code.
---
SpiceXPI/src/plugin/controller-unix.cpp | 143 +---
SpiceXPI/src/plugin/controller.h| 7 +-
configure.ac| 2 +-
3 files changed, 85 insertions(+), 67 deletions(-)
diff --git a/Spi
This is platform specific, and is related to starting the
receiver of controller messages, so let's move it with the rest
of the platform-specific code.
---
SpiceXPI/src/plugin/controller-unix.cpp | 106 +-
SpiceXPI/src/plugin/controller.h| 13 +++-
SpiceXPI/sr
It's only used internally, external code calls Connect(int retries)
---
SpiceXPI/src/plugin/controller.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SpiceXPI/src/plugin/controller.h b/SpiceXPI/src/plugin/controller.h
index 9f372a4..5bbf291 100644
--- a/SpiceXPI/src/plugin/c
---
SpiceXPI/src/plugin/controller-unix.cpp | 6 --
SpiceXPI/src/plugin/controller.h| 1 -
2 files changed, 7 deletions(-)
diff --git a/SpiceXPI/src/plugin/controller-unix.cpp
b/SpiceXPI/src/plugin/controller-unix.cpp
index d2a59f3..e2a513c 100644
--- a/SpiceXPI/src/plugin/controller
---
SpiceXPI/src/plugin/controller-unix.cpp | 2 ++
SpiceXPI/src/plugin/controller.h| 2 ++
SpiceXPI/src/plugin/plugin.cpp | 2 ++
3 files changed, 6 insertions(+)
diff --git a/SpiceXPI/src/plugin/controller-unix.cpp
b/SpiceXPI/src/plugin/controller-unix.cpp
index b912c27..d2a59
It mostly contain low-level controller/plugin communication code,
and this is mainly non-portable code, let's rename this file to
make this explicit. We will then add a controller.cpp file
containing the generic code, and a controller-win.cpp file
with the Windows specific code.
---
SpiceXPI/src/p
This has the big advantage of being portable, in addition to removing
some code. Big disadvantage is that this adds a dependency on gio.
---
SpiceXPI/src/plugin/plugin.cpp | 67 +-
SpiceXPI/src/plugin/plugin.h | 2 ++
configure.ac | 2 +
This makes it more readable, and moves OS-specific code to separate
functions.
---
SpiceXPI/src/plugin/plugin.cpp | 170 +++--
SpiceXPI/src/plugin/plugin.h | 3 +
2 files changed, 99 insertions(+), 74 deletions(-)
diff --git a/SpiceXPI/src/plugin/plugin.cpp
Hey,
Here is the next patch series for spice-xpi. This one reworks the existing code
to
* make some of the code generic by using glib functionality instead of
directly using libc
* move all the platform-specific code to a ControllerUnix class, and
leave the generic code in a parent Controller
31 matches
Mail list logo
