[Spice-devel] Spice for commercial use

2013-03-06 Thread Tom Holmes
Hello! Can Spice be used for commercial use, if so are there licensing fees that are applied? Would you say Spice is comparable to RDP, ICA and PCOIP? Can Spice be used to access a Windows Desktop? Thank you so much!Tom __

Re: [Spice-devel] XSpice and Xen

2013-03-06 Thread bing
I packaged xen-4.3-unstable with spice support for Fedora 18, you can find the source rpm at ftp://ftp.it.uts.edu.au/fcit/fedora/18/SRPMS/xen-4.3-unstable.1.fc18.src.rpm bing On 03/02/2013 10:13 PM, Flo wrote: Hi, except of Spice4Xen, which isn't up to date, there is no implementation of the

[Spice-devel] [PATCH] win: usb: use port_number instead of device_address

2013-03-06 Thread Uri Lublin
It seems that device_address is not consistent and port_number is for Windows. For example the device_address may change when the WinUSB driver is installed. This seems to happen more for Win7 clients. USB devices are being redir'ed by their bus_number and device_address. When the device_address b

Re: [Spice-devel] virt-viewer toogles numlock state...

2013-03-06 Thread Klaus Hochlehnert
Sorry for the confusion. With spice client I meant the "physical client host" running Ubuntu Desktop 12.04 (amd64). As spice client software I used virt-viewer 0.5.5 and spice-gtk version is 0.18 Klaus -Ursprüngliche Nachricht- Von: Christophe Fergeau [mailto:cferg...@redhat.com] Gesen

Re: [Spice-devel] [PATCH spice-protocol 2/2] Prepare for a 0.12.5 release

2013-03-06 Thread Alon Levy
Both look good, as well as the whole spice-server 3 patchset using the message. Ack series. - Original Message - > Signed-off-by: Hans de Goede > --- > NEWS | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/NEWS b/NEWS > index df5d31c..a602292 100644 > --- a/NEWS > +++ b/NE

Re: [Spice-devel] [PATCH spice 3/3] server/reds: Send the agent a CLIENT_DISCONNECTED msg on client disconnect

2013-03-06 Thread Alon Levy
Looks good to me, couldn't resist a nitpick though. > Client -> agent messages can spawn multiple VDIChunks. When this > happens > the agent re-assembles the chunks into a complete VDAgentMessage > before > processing it. The server only guarentees coherency at the chunk > level, > so it is not po

Re: [Spice-devel] qxl X.org driver bo abstraction for user mode setting

2013-03-06 Thread Jeremy White
> Well it shouldn't change anything from Xspice execpt I broke the build > or something. XSpice was okay, the dfps mode within Xspice was broken. One I think was a bug in your port, the other was a bug in my code exposed by the (new) crash if you try to create a 0 height pixmap. Patches sent. C

[Spice-devel] [xf86-PATCH 2/2] Initialize our update region at surface creation, avoids 0 size regions

2013-03-06 Thread Jeremy White
Signed-off-by: Jeremy White --- src/dfps.c |1 + 1 file changed, 1 insertion(+) diff --git a/src/dfps.c b/src/dfps.c index e5a2273..6ac29f9 100644 --- a/src/dfps.c +++ b/src/dfps.c @@ -253,6 +253,7 @@ static PixmapPtr dfps_create_pixmap (ScreenPtr screen, int w, int h, int depth, info

[Spice-devel] [xf86-PATCH 1/2] We're uploading a drawable from the primary surface, use it.

2013-03-06 Thread Jeremy White
Signed-off-by: Jeremy White --- src/qxl_surface.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qxl_surface.c b/src/qxl_surface.c index fc1bdf9..d1644a4 100644 --- a/src/qxl_surface.c +++ b/src/qxl_surface.c @@ -294,7 +294,7 @@ upload_one_primary_region(qxl_screen_t *

Re: [Spice-devel] [PATCH spice-html5] handling cursor caching

2013-03-06 Thread Jeremy White
Hi Vincent, On 03/06/2013 04:46 AM, Vincent Desprez wrote: > A very small patch to handle cursor caching in spice-html. Indeed until > now the cursor shape wasn't cached so it appeared correctly only once. Your patch look great, with one exception - you really need to treat the flags field as a b

[Spice-devel] [linux-vdagent PATCH 10/10] vdagent*: Handle VDAGENTD_CLIENT_DISCONNECTED messages

2013-03-06 Thread Hans de Goede
Also add some extra detection for the client having gone away for when running on an older spice-server which does not send VDAGENTD_CLIENT_DISCONNECTED on client disconnect. Signed-off-by: Hans de Goede --- src/vdagent.c| 6 +- src/vdagentd-proto-strings.h | 5 +++-- src/v

[Spice-devel] [linux-vdagent PATCH 09/10] vdagentd: Track which file-xfer id belongs to which session-agent

2013-03-06 Thread Hans de Goede
So that file-xfers which are still on progress on user-switch keep working, and so that vdagentd can send the client a file-xfer cancel if the per-session vdagent goes away while a file-xfer is active. Signed-off-by: Hans de Goede --- Makefile.am| 4 ++-- src/vdagentd.c | 73 +++

[Spice-devel] [linux-vdagent PATCH 08/10] file-xfers: Fix unlinking of files on error / cancel

2013-03-06 Thread Hans de Goede
Store the complete path, rather then just the basename in task->file_name, so that unlinking on error actually works. Signed-off-by: Hans de Goede --- src/vdagent-file-xfers.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/vdagent-file-xfers.c b/src/vdagent-file-xf

[Spice-devel] [linux-vdagent PATCH 07/10] file-xfers: Handle writing errors

2013-03-06 Thread Hans de Goede
Signed-off-by: Hans de Goede --- src/vdagent-file-xfers.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/src/vdagent-file-xfers.c b/src/vdagent-file-xfers.c index faff743..959a491 100644 --- a/src/vdagent-file-xfers.c +++ b/src/vdagent-fil

[Spice-devel] [linux-vdagent PATCH 06/10] file-xfers: Report status to sender (the client) on xfer completion

2013-03-06 Thread Hans de Goede
Signed-off-by: Hans de Goede --- src/vdagent-file-xfers.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/vdagent-file-xfers.c b/src/vdagent-file-xfers.c index 898b77f..faff743 100644 --- a/src/vdagent-file-xfers.c +++ b/src/vdagent-file-xfers.c @@ -255,7 +255,7 @

[Spice-devel] [linux-vdagent PATCH 04/10] configure.ac: Bump spice-protocol requires to 0.12.5

2013-03-06 Thread Hans de Goede
This is needed for file-xfer support. Signed-off-by: Hans de Goede --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 68afb4e..4b36fa7 100644 --- a/configure.ac +++ b/configure.ac @@ -78,7 +78,7 @@ AC_ARG_ENABLE([static-uinput],

[Spice-devel] [linux-vdagent PATCH 05/10] file-xfers: Create dir before trying to create the file

2013-03-06 Thread Hans de Goede
This is necesarry to allow the client to send folder-hierarchies. Signed-off-by: Hans de Goede --- src/vdagent-file-xfers.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/vdagent-file-xfers.c b/src/vdagent-file-xfers.c index de38eca..898b77f 100644 --- a

[Spice-devel] [linux-vdagent PATCH 03/10] vdagent-virtio-port: Add vdagent_virtio_port_reset()

2013-03-06 Thread Hans de Goede
Signed-off-by: Hans de Goede --- src/vdagent-virtio-port.c | 10 ++ src/vdagent-virtio-port.h | 1 + 2 files changed, 11 insertions(+) diff --git a/src/vdagent-virtio-port.c b/src/vdagent-virtio-port.c index 7e9a3e6..f56428e 100644 --- a/src/vdagent-virtio-port.c +++ b/src/vdagent-virti

[Spice-devel] [linux-vdagent PATCH 02/10] vdagent-virtio-port: Fix use after free

2013-03-06 Thread Hans de Goede
Signed-off-by: Hans de Goede --- src/vdagent-virtio-port.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/vdagent-virtio-port.c b/src/vdagent-virtio-port.c index de4b748..7e9a3e6 100644 --- a/src/vdagent-virtio-port.c +++ b/src/vdagent-virtio-port.c @@ -392,6 +392,8 @@ static void vdag

[Spice-devel] [linux-vdagent PATCH 01/10] vdagent: Don't try to reconnect when not daemonized

2013-03-06 Thread Hans de Goede
Signed-off-by: Hans de Goede --- src/vdagent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vdagent.c b/src/vdagent.c index ba199de..0161c7a 100644 --- a/src/vdagent.c +++ b/src/vdagent.c @@ -261,7 +261,7 @@ reconnect: vdagent_file_xfers_destroy(vdagent_file_xfers)

[Spice-devel] [PATCH spice 3/3] server/reds: Send the agent a CLIENT_DISCONNECTED msg on client disconnect

2013-03-06 Thread Hans de Goede
Client -> agent messages can spawn multiple VDIChunks. When this happens the agent re-assembles the chunks into a complete VDAgentMessage before processing it. The server only guarentees coherency at the chunk level, so it is not possible for a partial chunk to get delivered to the agent. But it i

[Spice-devel] [PATCH spice 2/3] char_device: Add spice_char_device_write_buffer_get_server_no_token()

2013-03-06 Thread Hans de Goede
To allow the server to send agent messages without needing to wait for a self-token. IE for sending VD_AGENT_CLIENT_DISCONNECTED messages. Signed-off-by: Hans de Goede --- server/char_device.c | 41 ++--- server/char_device.h | 3 +++ 2 files changed, 29 inse

[Spice-devel] [PATCH spice 1/3] Update spice-common

2013-03-06 Thread Hans de Goede
Signed-off-by: Hans de Goede --- spice-common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-common b/spice-common index b46d36b..4751423 16 --- a/spice-common +++ b/spice-common @@ -1 +1 @@ -Subproject commit b46d36bc1c01ca17a64262e157022fd21ad1e795 +Subproject com

[Spice-devel] [PATCH spice-protocol 2/2] Prepare for a 0.12.5 release

2013-03-06 Thread Hans de Goede
Signed-off-by: Hans de Goede --- NEWS | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS b/NEWS index df5d31c..a602292 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,8 @@ +Major changes in 0.12.5 +=== +* Add agent file xfer success status +* Add a client-disconnected agent

[Spice-devel] [PATCH spice-protocol 1/2] vd_agent: Add a new VD_AGENT_CLIENT_DISCONNECTED message

2013-03-06 Thread Hans de Goede
Client -> agent messages can spawn multiple VDIChunks. When this happens the agent re-assembles the chunks into a complete VDAgentMessage before processing it. The server only guarentees coherency at the chunk level, so it is not possible for a partial chunk to get delivered to the agent. But it i

Re: [Spice-devel] improving spice-html5 performance

2013-03-06 Thread Jeremy White
On 03/05/2013 09:58 AM, Alon Levy wrote: >> >> >> Hi, >> >> I am currrently trying to correct the glitches when using Win7 with >> qxl driver. Amoung the warning messages I find these ones: "FIXME: >> DrawCopy we don't handle mask flag: xxx" and "FIXME: DrawCopy >> unhandled image flags: xxx". My g

[Spice-devel] [PATCH spice-html5] handling cursor caching

2013-03-06 Thread Vincent Desprez
A very small patch to handle cursor caching in spice-html. Indeed until now the cursor shape wasn't cached so it appeared correctly only once. Independently from that I didn’t see my latest contribution to spice-html5 from January 22 in the git repository ( http://cgit.freedesktop.org/spice/spice-h

Re: [Spice-devel] spice crashes

2013-03-06 Thread Christophe Fergeau
On Tue, Mar 05, 2013 at 10:26:30PM +, Klaus Hochlehnert wrote: > uninstalling blnsvr.exe did it for me. No more crashes. Ugh, /me not happy to hear that :( blnsvr.exe installation is something new in spice-guest-tools 0.52, maybe I'll have to disable it... Thanks for your findings, Christophe

Re: [Spice-devel] REQ: latest virt-viewer binaries for windows

2013-03-06 Thread Christophe Fergeau
On Tue, Mar 05, 2013 at 05:20:23PM -0500, Grant C. wrote: > On 3/5/2013 3:15 AM, Christophe Fergeau wrote: > >Hi, > > > >On Mon, Mar 04, 2013 at 05:33:03PM -0500, Grant C. wrote: > >>On 3/4/2013 10:37 AM, Christophe Fergeau wrote: > >>>Thanks a lot for looking into that. Have you tried the latest c

Re: [Spice-devel] virt-viewer toogles numlock state...

2013-03-06 Thread Christophe Fergeau
On Tue, Mar 05, 2013 at 10:32:55PM +, Klaus Hochlehnert wrote: > Hi, > > on three spice clients that uses virt-viewer I've seen today that it toggles > the numlock state when logging off from a Windows 7 guest. > > First connect with logon > - Numlock LED is on and the number block is workin