Re: [Spice-devel] [PATCH spice-gtk 1/2] spice-widget: Search monitor info by display monitor-id

ack - Mensaje original - > As discussed indexing the display-channel's monitors property by > monitor-id > causes problems with the vdagent's new sparse monitor config support. > > Searching the monitors property by monitor-id avoids these problems. > > Signed-off-by: Hans de Goede > --

Re: [Spice-devel] [PATCH spice-gtk] spice-widget: update_monitor_area: Fix memory-leak on whole fallback

ack eh! I remember I saw that one, and forgot to fix it! - Mensaje original - > When we've successfully gotten the monitors display-channel property, > but > still end up falling back to whole-display mode, we still need to > free > the monitors array. > > Signed-off-by: Hans de Goede >

Re: [Spice-devel] [PATCH spice-gtk] channel-main: Fix monitors_align to not shuffle monitor order

ack - Mensaje original - > Before this patch monitor_align was calling qsort directly on the > VDAgentMonConfig monitors array, but VDAgentMonConfig does not > contain > an id, so the order matters! > > This fixes (for example) 2 issues with having 3 windows/monitors on a > row > numbered

Re: [Spice-devel] win7 guest display flipped

- Mensaje original - > Hi, > > Did this ever work: > > start win7 guest (I'm using 64 bit), desktop, screen resolution, > choose one of the flipped options (landscape/portrait) - I get an > error dialog: > title: Change Settings > Contents: Unable to save display settings. I can ch

[Spice-devel] win7 guest display flipped

Hi, Did this ever work: start win7 guest (I'm using 64 bit), desktop, screen resolution, choose one of the flipped options (landscape/portrait) - I get an error dialog: title: Change Settings Contents: Unable to save display settings. Choosing both of the non flipped modes (landscape, portrai

Re: [Spice-devel] settings for qxl memory size

> Thanks for your reply, > I did more tests with this new patch for qxl, but it still doesn't > work: > http://lists.xen.org/archives/html/xen-devel/2013-01/msg01405.html Hi Davide, Perhaps you should ask on xen-devel? I am curios about this effort but I don't think anyone involved with it is o

Re: [Spice-devel] settings for qxl memory size

Thanks for your reply, I did more tests with this new patch for qxl, but it still doesn't work: http://lists.xen.org/archives/html/xen-devel/2013-01/msg01405.html I get this error in the logs: main_channel_link: add main channel client main_channel_handle_parsed: net test: latency 55.458000 ms, b

[Spice-devel] [PATCH spice-gtk] channel-main: Fix monitors_align to not shuffle monitor order

Before this patch monitor_align was calling qsort directly on the VDAgentMonConfig monitors array, but VDAgentMonConfig does not contain an id, so the order matters! This fixes (for example) 2 issues with having 3 windows/monitors on a row numbered 1-3, ordered left-to-right as 1-2-3, and then cha

[Spice-devel] [PATCH spice-gtk] spice-widget: update_monitor_area: Fix memory-leak on whole fallback

When we've successfully gotten the monitors display-channel property, but still end up falling back to whole-display mode, we still need to free the monitors array. Signed-off-by: Hans de Goede --- gtk/spice-widget.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gtk/spice-widget.c b/gtk/sp

[Spice-devel] [PATCH spice-gtk 1/2] spice-widget: Search monitor info by display monitor-id

As discussed indexing the display-channel's monitors property by monitor-id causes problems with the vdagent's new sparse monitor config support. Searching the monitors property by monitor-id avoids these problems. Signed-off-by: Hans de Goede --- gtk/spice-widget.c | 14 ++ 1 file

[Spice-devel] [PATCH spice-gtk 0/2] Add support for VD_AGENT_CAP_SPARSE_MONITORS_CONFIG (v2)

Here is v2 of my VD_AGENT_CAP_SPARSE_MONITORS_CONFIG patch-set. Changes since v1: -replace patch to make display-channel:monitors sparse with a patch to make spice-widget search it by monitor_id, rather then using monitor_id as index into it Regards, Hans __

[Spice-devel] [PATCH spice-gtk 2/2] channel-main: Add support for VD_AGENT_CAP_SPARSE_MONITORS_CONFIG (rhbz#881072)

Signed-off-by: Hans de Goede --- gtk/channel-main.c | 20 ++-- spice-common | 2 +- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/gtk/channel-main.c b/gtk/channel-main.c index 706c119..dfd2245 100644 --- a/gtk/channel-main.c +++ b/gtk/channel-main.c @@ -10

[Spice-devel] [PATCH spice-common] spice-common: Update spice-protocol to include VD_AGENT_CAP_SPARSE_MONITORS_CONFIG

Signed-off-by: Hans de Goede --- spice-protocol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-protocol b/spice-protocol index a484ca8..1919857 16 --- a/spice-protocol +++ b/spice-protocol @@ -1 +1 @@ -Subproject commit a484ca8095556f7f75979f14179a258884b1164f +Subp

Re: [Spice-devel] [PATCH vd_agent V3 4/4] file-xfer: Add file-xfer support for linux agent

Hi, thank you for your review On Wed, Jan 16, 2013 at 9:29 PM, Marc-André Lureau wrote: > Hi > > On Wed, Dec 5, 2012 at 5:27 AM, Dunrong Huang wrote: >> The patch makes linux agent support file-xfer feature. >> >> Signed-off-by: Dunrong Huang >> --- >> src/vdagent.c | 171 >>

Re: [Spice-devel] [xf86 qxl driver PATCH 0/5] qxl_driver: adjust monitors_config to memory remap

Hi, As mentioned in 5/5 I agree we should add some sort of checksum mechanism to the monitors_config, or change things so that it does not move around ... But that is something for another series on top, so ACK series. Regards, Hans On 01/17/2013 03:26 PM, Uri Lublin wrote: This patch-set f