Hi
- Mensaje original -
> > Ah, I think this is correct as the current model doesn't allow
> > qxl-0
> > and qxl-2 outputs enabled, while qxl-1 is disabled.
>
> That is not entirely true, currently one cannot do that through an
> agent message, but one can "easily" do it using the xrandr
Hi 黄敦荣!
I pushed your patches in spice-protocol & spice-gtk git.
I'll try to review the agent patches soon, if nobody beats me to it.
At least I can tell it works :)
Thanks a lot for your work,
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-de
Hi,
On 01/11/2013 11:45 PM, Marc-André Lureau wrote:
Hi
On Fri, Jan 11, 2013 at 10:51 PM, Hans de Goede wrote:
spice-widget.c: update_monitor_area()
c = &g_array_index(monitors, SpiceDisplayMonitorConfig, d->monitor_id);
virt-viewer-session-spice.c: virt_viewer_session_spice_disp
Hi,
On 01/12/2013 12:04 AM, Jeremy White wrote:
On 01/11/2013 04:02 PM, Hans de Goede wrote:
Hi,
On 01/11/2013 10:34 PM, Jeremy White wrote:
This makes the default display not stretch for 4096x768.
Hmm this seems to expose a problem with your previous patch then,
as this second patch is not
On 01/11/2013 04:02 PM, Hans de Goede wrote:
> Hi,
>
> On 01/11/2013 10:34 PM, Jeremy White wrote:
>> This makes the default display not stretch for 4096x768.
>
> Hmm this seems to expose a problem with your previous patch then,
> as this second patch is not acceptable. Currently the user can
> o
ack
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
Hi
Thanks for fixing this, it really looks obvious now that you say it!
On Thu, Jan 10, 2013 at 11:52 PM, Hans de Goede wrote:
> 1) Code which immediately after the decref replaces worker->monitors_config
>with a new monitors_config:
>worker_update_monitors_config()
>set_monitors_con
Hi
On Fri, Jan 11, 2013 at 10:51 PM, Hans de Goede wrote:
>
> spice-widget.c: update_monitor_area()
>
> c = &g_array_index(monitors, SpiceDisplayMonitorConfig, d->monitor_id);
>
>
> virt-viewer-session-spice.c: virt_viewer_session_spice_display_monitors():
>
> display = g_ptr_array_
Hello!
A new release to celebrate 2013 and fix a brown-paper bag bug that
slipped in v0.15, here we go:
- Fix crash with SSL connection (#890464)
- Send monitor config to the agent on
spice_main_set_display_enabled() (#881072)
- Fix channel leak and wrong condition in spice_channel_fl
Hi,
On 01/11/2013 10:34 PM, Jeremy White wrote:
This makes the default display not stretch for 4096x768.
Hmm this seems to expose a problem with your previous patch then,
as this second patch is not acceptable. Currently the user can
on the fly add new monitors to guests running the agent by
s
Hi,
On 01/11/2013 10:33 PM, Jeremy White wrote:
But still default to 1024x768 if no other mode is given.
Hmm, this is going to need some careful testing, but other then that ack.
Regards,
Hans
Signed-off-by: Jeremy White
---
src/qxl_driver.c | 81 ++---
Hi,
On 01/11/2013 09:02 PM, Marc-André Lureau wrote:
Hi
My understanding of this patch is that you send all monitors config,
regardless if there are disabled. This is a bit wasteful, but not a
real problem.
Why is that needed if the implementation handle "missing" monitors id
as disabled? (whi
Hi,
On 01/11/2013 08:55 PM, Marc-André Lureau wrote:
Hi
On Thu, Jan 10, 2013 at 11:52 PM, Hans de Goede wrote:
Both the spice-widget code, as well as remote-viewer expect that
monitors[i]->id == i, but if ie only the qxl-0 and qxl-2 outputs are
enabled this is not true.
Can you detail where
This makes the default display not stretch for 4096x768.
Signed-off-by: Jeremy White
---
src/qxl_driver.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index c7a07cb..3dae401 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -78,
But still default to 1024x768 if no other mode is given.
Signed-off-by: Jeremy White
---
src/qxl_driver.c | 81 ++
1 file changed, 20 insertions(+), 61 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index e2d08c7..c7a07cb 1006
Hi
My understanding of this patch is that you send all monitors config,
regardless if there are disabled. This is a bit wasteful, but not a
real problem.
Why is that needed if the implementation handle "missing" monitors id
as disabled? (which is what the current implementation should do, no?)
O
Hi
On Thu, Jan 10, 2013 at 11:52 PM, Hans de Goede wrote:
> Both the spice-widget code, as well as remote-viewer expect that
> monitors[i]->id == i, but if ie only the qxl-0 and qxl-2 outputs are
> enabled this is not true.
Can you detail where and how there is such expectation in
remote-viewer
Ping?
More than half a year has been passed away, but the patch is
still needed for current 0.12.2 version...
(patchwork url: http://patchwork.freedesktop.org/patch/10546/ )
Thanks,
/mjt
04.06.2012 13:35, Christophe Fergeau wrote:
ACK
Christophe
On Sat, Jun 02, 2012 at 05:33:42PM +0400, Mic
18 matches
Mail list logo
