Re: [Spice-devel] [PATCH vdagent 2/2] vdagentd: Fix building warning

2012-12-09 Thread Christophe Fergeau
This one looks good, ACK. Christophe On Wed, Dec 05, 2012 at 04:01:59PM +0800, Dunrong Huang wrote: > Move some variable declarations to right place. > > Signed-off-by: Dunrong Huang > --- > src/vdagentd.c | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/s

Re: [Spice-devel] [PATCH vdagent 1/2] vdagent-x11-randr: Fix building warning

2012-12-09 Thread Christophe Fergeau
Hey, On Wed, Dec 05, 2012 at 04:01:58PM +0800, Dunrong Huang wrote: > This patch can be safely applied since it just deletes unused variables. > > Signed-off-by: Dunrong Huang > --- > src/vdagent-x11-randr.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/src/vd

Re: [Spice-devel] Windows Guest Tools 0.2

2012-12-09 Thread Klaus Hochlehnert
Hi Christophe, just found a small issue... When upgrading from spice-guest-tools-0.1 without uninstalling them first I got an error that the vdagent can't be copied. The vdagent service was still running. Maybe you could add stopping the service at the beginning of the installation procedure.

[Spice-devel] Translating the Spice protocol using spice-client-glib

2012-12-09 Thread Michael Jumper
Hello, I am looking to use spice-client-glib (which seems to be the only low-level client library available) to implement a plugin for guacd which translates between the Spice protocol and the Guacamole protocol, thus adding Spice support to Guacamole (an HTML5 remote desktop gateway). At the sur

[Spice-devel] [PATCH] spicy: port_data: check write return value

2012-12-09 Thread Uri Lublin
Fixes the following build warning (but does not really check write return value): spicy.c: In function ‘port_data’: spicy.c:1711:10: error: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Werror=unused-result] Reported by Yaniv Kaul --- Alternatively, if we reall

Re: [Spice-devel] [PATCH] build-sys: remove *vdi_port* from Makefile.am

2012-12-09 Thread Uri Lublin
On 12/09/2012 11:42 AM, Arnon Gilboa wrote: --- Makefile.am |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/Makefile.am b/Makefile.am index 9b73def..3bd66aa 100644 --- a/Makefile.am +++ b/Makefile.am @@ -31,13 +31,7 @@ vdagent_SOURCES =\

[Spice-devel] [PATCH] build-sys: remove *vdi_port* from Makefile.am

2012-12-09 Thread Arnon Gilboa
--- Makefile.am |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/Makefile.am b/Makefile.am index 9b73def..3bd66aa 100644 --- a/Makefile.am +++ b/Makefile.am @@ -31,13 +31,7 @@ vdagent_SOURCES =\ vdagent/desktop_layout.h\ vdag

Re: [Spice-devel] [PATCH] vdagent: when SetClipboardData fails, set clipboard control event to stop wait

2012-12-09 Thread Uri Lublin
On 11/27/2012 11:16 AM, Arnon Gilboa wrote: Currently, a SetClipboardData failure is followed by useless wait for timeout (VD_CLIPBOARD_TIMEOUT_MS) --- vdagent/vdagent.cpp | 30 -- 1 files changed, 16 insertions(+), 14 deletions(-) diff --git a/vdagent/vdagent.cp

Re: [Spice-devel] [PATCH] vdservice: set process handle for vdagent launched on session>0

2012-12-09 Thread Uri Lublin
On 11/25/2012 05:14 PM, Arnon Gilboa wrote: The problem on XP was failing to terminate agent running on session>0, since during agent process creation, a handle was not set, so it was NULL. Therefore, the new agent created (at the session we switched to) was unable to open vitio-serial which was