Re: [Spice-devel] [PATCH spice-gtk] channel: rely on couroutine instead of channel state

2012-12-02 Thread Hans de Goede
Hi, On 12/02/2012 03:16 PM, Marc-André Lureau wrote: On Sun, Dec 2, 2012 at 12:34 PM, Hans de Goede mailto:hdego...@redhat.com>> wrote: Hmm, this seems like an unrelated change/fix and one which could do with its own commit message. Otherwise ack. It's actually related, I removed a

Re: [Spice-devel] [PATCH spice-gtk] channel: rely on couroutine instead of channel state

2012-12-02 Thread Marc-André Lureau
On Sun, Dec 2, 2012 at 12:35 PM, Hans de Goede wrote: > Sounds like a nice cleanup to me. Or maybe further > split the recv_ functions into a recv_ and send_next_bit > parts and then have a channel_handle_link() > calling all the send_ and recv_ parts? I think that might > Yeah, but as a first

Re: [Spice-devel] [PATCH spice-gtk] channel: rely on couroutine instead of channel state

2012-12-02 Thread Marc-André Lureau
On Sun, Dec 2, 2012 at 12:34 PM, Hans de Goede wrote: > Hmm, this seems like an unrelated change/fix and one which could do with > its own > commit message. Otherwise ack. > It's actually related, I removed a case in the current iterate_read() (I replaced with a pre-condition instead): +g_r

Re: [Spice-devel] [PATCH spice-server] agent: fix mishandling of agent data received from the client after agent disconnection

2012-12-02 Thread Hans de Goede
Hi, Thanks for your work on this! Fix looks good, ACK. Regards, Hans On 11/30/2012 05:28 PM, Yonit Halperin wrote: The server can receive from the client agent data even when the agent is disconnected. This can happen if the client sends the agent data before it receives the AGENT_DISCONN

Re: [Spice-devel] [PATCH spice-gtk] channel: rely on couroutine instead of channel state

2012-12-02 Thread Hans de Goede
Hi, On 11/30/2012 09:17 PM, Marc-André Lureau wrote: On Fri, Nov 30, 2012 at 9:12 PM, Marc-André Lureau mailto:marcandre.lur...@gmail.com>> wrote: spice_channel_send_link(channel); +spice_channel_recv_link_hdr(channel); +spice_channel_recv_link_msg(channel); +

Re: [Spice-devel] [PATCH spice-gtk] channel: rely on couroutine instead of channel state

2012-12-02 Thread Hans de Goede
Hi, On 11/30/2012 09:12 PM, Marc-André Lureau wrote: We can simplify the channel state callback and simplify a little the code by relying on coroutine state instead. --- gtk/spice-channel-priv.h | 3 --- gtk/spice-channel.c | 34 +- 2 files changed, 9 in

Re: [Spice-devel] [PATCH spice 2/2] server: add "port" channel support

2012-12-02 Thread Hans de Goede
Hi, On 11/30/2012 01:51 PM, Marc-André Lureau wrote: A Spice port channel carry arbitrary data between the Spice client and the Spice server. It may be used to provide additional services on top of a Spice connection. For example, a channel can be associated with the qemu monitor for the client

Re: [Spice-devel] [PATCH spice 1/2] server: bump SPICE_SERVER_VERSION to 0.12.2

2012-12-02 Thread Hans de Goede
Ack. On 11/30/2012 01:51 PM, Marc-André Lureau wrote: --- server/spice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/spice.h b/server/spice.h index bcf6da8..22f17d6 100644 --- a/server/spice.h +++ b/server/spice.h @@ -23,7 +23,7 @@ #include #include -#def

Re: [Spice-devel] Native USB redirection does not work - (remote-viewer) did not claim interface 0 before use

2012-12-02 Thread Sigbjorn Lie
On 12/02/2012 11:58 AM, Hans de Goede wrote: Hi, On 11/30/2012 03:40 PM, Sigbjorn Lie wrote: Hi, I have disabled pcscd with chkconfig and rebooted. After the reboot I attempted to connect to the VDI and share my smart card reader again. The same issue occured. ifdhandler is still messing

Re: [Spice-devel] [PATCH spice-gtk 1/3] channel: add flush_async()

2012-12-02 Thread Hans de Goede
Hi, Looks good to me, ACK series Regards, Hans On 11/30/2012 01:43 PM, Marc-André Lureau wrote: Add spice_channel_flush_async() that asynchronously will write all the pending channel data. --- doc/reference/spice-gtk-sections.txt | 2 + gtk/map-file | 2 + gtk

Re: [Spice-devel] [PATCH spice-protocol] Add port channel enum values

2012-12-02 Thread Hans de Goede
Also ACK. On 11/30/2012 01:42 PM, Marc-André Lureau wrote: The channel is based on Spicevmc which simply tunnels data between client and server. A few messages have been added: SPICE_MSG_PORT_INIT: Describes the port state and fqdn name, should be sent only once when the client connects. SPICE

Re: [Spice-devel] [PATCH spice-common] Add a "port" channel

2012-12-02 Thread Hans de Goede
Hi, Cool patchset, something like this is exactly what Alon and I envisioned when we changed the usbredir channel code into a generic spicevmc channel. Although our idea was to say that channel ids > 128 were reserved for user-defined use, rather then your fqdn approach with the init message, bu

Re: [Spice-devel] Native USB redirection does not work - (remote-viewer) did not claim interface 0 before use

2012-12-02 Thread Hans de Goede
Hi, On 11/30/2012 03:40 PM, Sigbjorn Lie wrote: Hi, I have disabled pcscd with chkconfig and rebooted. After the reboot I attempted to connect to the VDI and share my smart card reader again. The same issue occured. ifdhandler is still messing with the reader while spice tries to use it, I

Re: [Spice-devel] [Qemu-devel] [PATCH 2/6] spice-qemu-char: write to chardev whatever amount it can read

2012-12-02 Thread Alon Levy
> The current code waits until the chardev can read MIN(len, VMC_MAX) > But some chardev may never reach than amount, in fact some of them > will only ever accept write of 1. Fix the min computation and remove > the VMC_MAX constant. Looks good to me. > > Signed-off-by: Marc-André Lureau > ---

Re: [Spice-devel] cut/paste failure on Windows 7 guest

2012-12-02 Thread Arnon Gilboa
Han Pilmeyer wrote: Thanks for your efforts Arnon, On 02/12/2012 08:23, Arnon Gilboa wrote: Lots of virtio-serial driver bugs, which are very relevant to cut/paste, were recently fixed. The driver on the above link seem to be outdated. I'll try to find a link for an updated upstream version.

Re: [Spice-devel] cut/paste failure on Windows 7 guest

2012-12-02 Thread Han Pilmeyer
Thanks for your efforts Arnon, On 02/12/2012 08:23, Arnon Gilboa wrote: Lots of virtio-serial driver bugs, which are very relevant to cut/paste, were recently fixed. The driver on the above link seem to be outdated. I'll try to find a link for an updated upstream version. Note that the drive