[Spice-devel] [PATCH] Fix 'Inalid' typo in error messages

2012-11-26 Thread Christophe Fergeau
When the server is started with invalid arguments, 'Invalid' is typo'ed. --- usbredirserver/usbredirserver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usbredirserver/usbredirserver.c b/usbredirserver/usbredirserver.c index 1525f1b..7a108c8 100644 --- a/usbredirserver/

Re: [Spice-devel] [PATCH spice-server 1/7] char_device.c: add ref count for write-to-device buffers

2012-11-26 Thread Yonit Halperin
On 11/22/2012 04:58 AM, Hans de Goede wrote: Hi, Looks good, one minor comment though, see my remarks inline. I'll fix it. Thanks for the review. On 11/21/2012 08:42 PM, Yonit Halperin wrote: The ref count is used in order to keep buffers that were in the write queue and now are part of mig

Re: [Spice-devel] [PATCH 2/3] build: Use glib2

2012-11-26 Thread Christophe Fergeau
Hi, On Sat, Nov 24, 2012 at 07:22:53PM +0100, Paolo Bonzini wrote: > Il 23/11/2012 16:58, Christophe Fergeau ha scritto: > > +PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= 2.22]) > > +SPICE_REQUIRES+=" glib-2.0 >= 2.22" > > + > > Note that QEMU only requires 2.12, or 2.20 on Windows. Ah thanks for the

Re: [Spice-devel] [PATCH spice-protocol V2] vd_agent.h: drag-and-drop support

2012-11-26 Thread Hans de Goede
Hi, On 11/26/2012 05:30 AM, Dunrong Huang wrote: Hi, 2012/11/23 Hans de Goede : Hi Dunrong Huang, Thanks for your continued work on this! And sorry that we keep tweaking the protocol, but getting the protocol right is very important as we cannot change that later. I know it and very agree

Re: [Spice-devel] [PATCH spice-protocol V2] vd_agent.h: drag-and-drop support

2012-11-26 Thread Dunrong Huang
Hi, 2012/11/23 Hans de Goede : > Hi Dunrong Huang, > > Thanks for your continued work on this! > > And sorry that we keep tweaking the protocol, but getting the > protocol right is very important as we cannot change that later. > I know it and very agree with you, :-) The following is my summary

Re: [Spice-devel] [PATCH 1/3] Don't build client by default

2012-11-26 Thread Alon Levy
ACK Note that packages will need to be updated. - Original Message - > It has been superseded by virt-viewer/remote-viewer > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index d02ea19..a12e119 100644 > --- a/co

[Spice-devel] [PATCH] vdservice: set process handle for vdagent launched on session>0

2012-11-26 Thread Arnon Gilboa
The problem on XP was failing to terminate agent running on session>0, since during agent process creation, a handle was not set, so it was NULL. Therefore, the new agent created (at the session we switched to) was unable to open vitio-serial which was still used by the other running agent instance