Re: [Spice-devel] [PATCH] snd channel: fix accessing freed memory

2012-10-11 Thread Marc-André Lureau
- Mensaje original - > snd_channel_put freed "channel", and then channel->worker was > accessed. do you mean "channel->worker" is freed instead, (since other channel member are accessed)? ___ Spice-devel mailing list Spice-devel@lists.freedesk

[Spice-devel] [PATCH] snd channel: fix accessing freed memory

2012-10-11 Thread Yonit Halperin
snd_channel_put freed "channel", and then channel->worker was accessed. It caused segmentation faults during connections and disconnections of the client. --- server/snd_worker.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server/snd_worker.c b/server/snd_worker.c

Re: [Spice-devel] USB-redirection

2012-10-11 Thread Trebor Forban
Hello David, with my "normal" ubuntu-12.04 started under an openbox-xsession usb-redirection is working correctly. Looking at the ps output I can see a plethora of services running, that are not in my debootstrapped environment. Any Ideas what services might be necessary to get usb-redirection wor

Re: [Spice-devel] USB-redirection

2012-10-11 Thread David Jaša
Trebor Forban píše v Čt 11. 10. 2012 v 14:14 +0200: > Hello all, > > I guess I'm still at a loss. I still have the problem that usb device > are showing up twice. > > I've built the following debs: > > swos-celt_0.5.1.3-1_amd64.deb > swos-libusbx_20121010151121-1_amd64.deb > swos-qemu_1.2.0-1_am

Re: [Spice-devel] [PATCH] server: net_test: put a limit on the calculated bitrate #698225

2012-10-11 Thread Uri Lublin
On 10/11/2012 10:50 AM, Uri Lublin wrote: When calculating bitrate of a local connection, the result can be too high. That happens when "roundtrip" and "latency" are very close, which only happens on fast networks. The decision that we are not in WAN network is correct, but the calculated number

Re: [Spice-devel] No hardware acceleration on win7

2012-10-11 Thread David Jaša
Tom Wijmenga píše v Čt 11. 10. 2012 v 14:48 +0200: > Thanks for the response David, > > Running the following command gave me BSOD's about 5 seconds after booting you need to install a driver for virtio-blk first. The best way to do it is during installation (attach virtio iso or floppy image fro

Re: [Spice-devel] No hardware acceleration on win7

2012-10-11 Thread Tom Wijmenga
Thanks for the response David, Running the following command gave me BSOD's about 5 seconds after booting kvm-spice -cpu host -name test-win7 -enable-kvm -m 3000 -M pc-1.2 -net nic,macaddr=DE:AD:BE:EF:95:D0 -net tap,script=/etc/qemu-ifup -usb -drive file=/var/vmmachines/test-win7.img,if=virtio,c

[Spice-devel] [PATCH] server: red_dispatcher: check major/minor of qxl for client_monitors_config

2012-10-11 Thread Uri Lublin
This solves a problem with new spice-server and old qemu-kvm, where spice thinks qif->client_monitors_config exists, while it does not exist in qemu-kvm. Also "major > required_major" was added to the condition. Also only the specific RedDispatcher is checked (and not all dispatchers). --- server

Re: [Spice-devel] No hardware acceleration on win7

2012-10-11 Thread David Jaša
Tom Wijmenga píše v Čt 11. 10. 2012 v 08:56 +0200: > Hi there, > > > > After installing Spice on Ubuntu Quantal Quetzal and setting up a Win7 > host with the QXL drivers (which are found correctly), things aren’t > working as they should. The performance of the graphical layer isn’t > optimal.

Re: [Spice-devel] USB-redirection

2012-10-11 Thread Trebor Forban
Hello all, I guess I'm still at a loss. I still have the problem that usb device are showing up twice. I've built the following debs: swos-celt_0.5.1.3-1_amd64.deb swos-libusbx_20121010151121-1_amd64.deb swos-qemu_1.2.0-1_amd64.deb swos-slirp_20121010151121-1_amd64.deb swos-spice_0.12.0-1_amd64.

[Spice-devel] [ spice-devel : spice-gtk keyboard mapping problem ]

2012-10-11 Thread nicolas prochazka
Hello, I'm using azerty keyboard : 1 - spice-gtk 0.14 under linux ( remote-viewer or spicy ) , keyboard mapping is good. 2 - spice-gtk windows binary version ( http://www.spice-space.org/download/gtk/windows/virt-viewer-0.5.3_x86.exe ) ;, keyboard mapping is wrong Exemple on azerty : a-Z are qwert

Re: [Spice-devel] Failed to compile spice client for windows x86_64

2012-10-11 Thread Arnon Gilboa
Christophe Fergeau wrote: On Wed, Oct 10, 2012 at 10:02:48AM +0800, me,apporc wrote: I feel it 's wired, there must be something wrong with this source code. Because i need some features from new version spice client, usb redir eg. I have to compile it from source. Could any one give me some

Re: [Spice-devel] Does physical video card help?

2012-10-11 Thread Marc-André Lureau
Hi - Mensaje original - > I'm always wondering how SPICE works, takes advantage of physical > video card or just CPU calculation? > It's CPU based. > If i replace the old physical video card with a better one or plug in > an extra one, will my SPICE performance be better? > Sadly, no

[Spice-devel] [PATCH] miniport/qxl: FillVideoMode: only allow word aligned strides

2012-10-11 Thread Alon Levy
This is a pixman requirement. If it isn't enforced spice crashes, qemu with it. That should be fixed, but there is no simple way to allow for non word aligned strides, and the only down side is that for 16 bit modes we will require even widths. And we already have the same implementation detail in

Re: [Spice-devel] [PATCH] server: net_test: put a limit on the calculated bitrate #698225

2012-10-11 Thread Hans de Goede
ACK. On 10/11/2012 10:50 AM, Uri Lublin wrote: When calculating bitrate of a local connection, the result can be too high. That happens when "roundtrip" and "latency" are very close, which only happens on fast networks. The decision that we are not in WAN network is correct, but the calculated n

Re: [Spice-devel] [PATCH spice-gtk] Add spice-usbredir-filter alias for spice-usbredir-auto-redirect-filter (v2)

2012-10-11 Thread Hans de Goede
Hi, On 10/11/2012 10:50 AM, Marc-André Lureau wrote: - Mensaje original - looks good, ack - Mensaje original - For commandline backward compatibility with older spice-gtk versions. Changes in v2: -warn about spice-usbredir-filter being deprecated when it gets used Signed-o

Re: [Spice-devel] [PATCH spice-gtk] Add spice-usbredir-filter alias for spice-usbredir-auto-redirect-filter (v2)

2012-10-11 Thread Marc-André Lureau
- Mensaje original - > looks good, ack > > - Mensaje original - > > For commandline backward compatibility with older spice-gtk > > versions. > > > > Changes in v2: > > -warn about spice-usbredir-filter being deprecated when it gets > > used > > > > Signed-off-by: Hans de Goede

[Spice-devel] [PATCH] server: net_test: put a limit on the calculated bitrate #698225

2012-10-11 Thread Uri Lublin
When calculating bitrate of a local connection, the result can be too high. That happens when "roundtrip" and "latency" are very close, which only happens on fast networks. The decision that we are not in WAN network is correct, but the calculated number shown in the log message is not. This patch

Re: [Spice-devel] [PATCH spice-gtk] Add spice-usbredir-filter alias for spice-usbredir-auto-redirect-filter (v2)

2012-10-11 Thread Marc-André Lureau
looks good, ack - Mensaje original - > For commandline backward compatibility with older spice-gtk versions. > > Changes in v2: > -warn about spice-usbredir-filter being deprecated when it gets used > > Signed-off-by: Hans de Goede > --- > gtk/spice-option.c | 13 + > 1 fil

[Spice-devel] [PATCH spice-gtk] Add spice-usbredir-filter alias for spice-usbredir-auto-redirect-filter (v2)

2012-10-11 Thread Hans de Goede
For commandline backward compatibility with older spice-gtk versions. Changes in v2: -warn about spice-usbredir-filter being deprecated when it gets used Signed-off-by: Hans de Goede --- gtk/spice-option.c | 13 + 1 file changed, 13 insertions(+) diff --git a/gtk/spice-option.c b/g

Re: [Spice-devel] [PATCH spice-gtk] Add spice-usbredir-filter alias for spice-usbredir-auto-redirect-filter

2012-10-11 Thread Christophe Fergeau
Hey, I'd go with a G_OPTION_ARG_CALLBACK option in order to be able to display a g_warning("This option is deprecated and has been superseded by --spice-usbredir-...); Christophe On Thu, Oct 11, 2012 at 10:01:00AM +0200, Hans de Goede wrote: > For commandline backward compatibility with older sp

Re: [Spice-devel] [qxl-win] miniport: QXLEscape: use 5/5/5 16 bit

2012-10-11 Thread Christophe Fergeau
Looks good to me, ACK from me (but you might want to wait for someone more knowledgeable about this to look at it ;) Christophe On Wed, Oct 10, 2012 at 04:21:53PM +0200, Alon Levy wrote: > Change IOCTL_QXL_SET_CUSTOM_DISPLAY to use 5/6/5 (via SetCustomDisplay). > > The replaced 5/6/5 is not supp

Re: [Spice-devel] [PATCH spice-gtk 1/5] Rename spice-usbredir-filter option to spice-usbredir-auto-redirect-filter

2012-10-11 Thread Hans de Goede
Hi, On 10/10/2012 06:51 PM, Marc-André Lureau wrote: TBH I would prefer to just go for a clean break rather then doing some compat stuff. Is that ok with you? I consider changing command line argument of --spice-* a break. I also favour the regular deprecation solution that teuf described.

[Spice-devel] [PATCH spice-gtk] Add spice-usbredir-filter alias for spice-usbredir-auto-redirect-filter

2012-10-11 Thread Hans de Goede
For commandline backward compatibility with older spice-gtk versions. Signed-off-by: Hans de Goede --- gtk/spice-option.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gtk/spice-option.c b/gtk/spice-option.c index 85c9e55..6ee9b07 100644 --- a/gtk/spice-option.c +++ b/gtk/spice-option.c