[Spice-devel] [PATCH] Bump SPICE_INTERFACE_QXL_VERSION_MINOR

2012-09-10 Thread Søren Sandmann Pedersen
From: Søren Sandmann Pedersen Then check that we have the right version before accessing the set_client_capabilities() function. --- server/red_worker.c |8 ++-- server/spice.h |2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/server/red_worker.c b/server/red

Re: [Spice-devel] [Spice-commits] 5 commits - client/display_channel.cpp server/red_worker.c server/spice.h

2012-09-10 Thread Søren Sandmann
Alon Levy writes: > The solution is the SPICE_INTERFACE_QXL_MAJOR & SPICE_INTERFACE_QXL_MINOR > versions which are stored in the compiled qemu binary in > hw/qxl.c:qxl_interface > > Any change to the QXLInterface must be accompanied by a change to > those two constants, in the usual manner - maj

[Spice-devel] [spice-protocol PATCH] Release 0.12.2

2012-09-10 Thread Alon Levy
New in this release: display channel: A8 surface capability qxl: client present, client capabilities, client monitors configuration and guest capabilities. --- This is on top of the two outstanding spice-protocol patches, required for qemu to use the new api for client monitors configuration

[Spice-devel] [PATCH 7/7] server/tests: agent mock, guest_capabilities test

2012-09-10 Thread Alon Levy
--- server/tests/Makefile.am | 8 ++ server/tests/basic_event_loop.c| 2 +- server/tests/test_display_base.c | 46 ++ server/tests/test_display_base.h | 1 + server/tests/test_display_no_ssl.c | 1 + server/tests/test_gu

[Spice-devel] [PATCH 6/7] spice-server 0.11.5

2012-09-10 Thread Alon Levy
Added api: spice_qxl_guest_capabilities_set QXL interface (3.2) client_monitors_config set_client_capabilities --- configure.ac | 6 +++--- server/spice.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 3882fb6..aa67c79 100644 --- a/

[Spice-devel] [PATCH 5/7] server: Filter VD_AGENT_MONITORS_CONFIG

2012-09-10 Thread Alon Levy
If the guest supports client monitors config we pass it the VDAgentMonitorsConfig message via the QXLInterface::client_monitors_config api instead of via the vdagent. --- server/agent-msg-filter.c | 8 ++ server/agent-msg-filter.h | 1 + server/reds.c | 65 +++

[Spice-devel] [PATCH 4/7] server/red_dispatcher: client_monitors_config support

2012-09-10 Thread Alon Levy
Adds two functions: red_dispatcher_use_client_monitors_config: - checks the guest for the QXL_GUEST_CAP_CLIENT_MONITORS_CONFIG_ISR cap, and that QXLInterface is new enough to support cap checking and client_monitors_config callback, returns TRUE if so. - red_dispatcher_client_monitors_

[Spice-devel] [PATCH 3/7] server: add QXLInterface::client_monitors_config

2012-09-10 Thread Alon Levy
Used to implement guest monitor configuration change similarly to real hardware in conjunction with the new qemu interrupt QXL_INTERRUPT_CLIENT_MONITORS_CONFIG. Together with the added guest capabilities allows to select the right mode during runtime. This makes a linux qxl driver similar to existi

[Spice-devel] [PATCH 2/7] server/spice.h: add spice_qxl_guest_capabilities_set

2012-09-10 Thread Alon Levy
Allow spice to know about guest driver capabilities. Implements spice api complement to qemu QXL_IO_CAPABILITIES_SET. Implementation in red_dispatcher. Stores a copy of guest capabilities. --- server/red_dispatcher.c | 20 server/spice-server.syms | 1 + server/spice.h

[Spice-devel] [PATCH 1/7] server/red_dispatcher: change a printerr to debug

2012-09-10 Thread Alon Levy
--- server/red_dispatcher.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/red_dispatcher.c b/server/red_dispatcher.c index 69d4f0a..3a4229e 100644 --- a/server/red_dispatcher.c +++ b/server/red_dispatcher.c @@ -91,7 +91,7 @@ static void red_dispatcher_set_display_peer(

[Spice-devel] [PATCH 0/7] guest features and client_monitors_config

2012-09-10 Thread Alon Levy
To implement the KMS driver correctly we want an interrupt from the host whenever a change in the monitors configuration is done. So far we achieved the same end via the guest agent. This patchset introduces api for the qemu to notify spice about guest features, and for spice to notify qemu about t

Re: [Spice-devel] Failure to compile [was: [Spice-commits] gtk/channel-display.c]

2012-09-10 Thread Yaniv Kaul
On 09/10/2012 05:57 PM, Alon Levy wrote: On Mon, Sep 10, 2012 at 12:08:30PM +0300, Yaniv Kaul wrote: Confirmed, great and thanks. I'd be happy if we could avoid such situations in the future. I know we (used to?) have a build-bot for Spice. Is it alive and working? It was working a few weeks ag

Re: [Spice-devel] spice @ arm

2012-09-10 Thread Peter Robinson
On Mon, Sep 10, 2012 at 9:59 AM, Alon Levy wrote: >> Hi, >> >> FYI: spice reportly works just fine on arm, see: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=613529 >> >> Just a little configure patch is required. > > So this is running the spicec client? we need to get remote-viewer working

Re: [Spice-devel] Failure to compile [was: [Spice-commits] gtk/channel-display.c]

2012-09-10 Thread Alon Levy
> On Mon, Sep 10, 2012 at 12:08:30PM +0300, Yaniv Kaul wrote: > > Confirmed, great and thanks. > > I'd be happy if we could avoid such situations in the future. I > > know > > we (used to?) have a build-bot for Spice. Is it alive and working? > > It was working a few weeks ago since I got a broken

Re: [Spice-devel] [PATCH 2/3] vdagent: don't stop due to UIPI blocking

2012-09-10 Thread Alon Levy
ACK with one question. > User Interface Privilege Isolation is usually used only for specific > windows of > system security applications (anti-viruses etc.), so with this patch > mouse will > be irresponsive for these windows but keep working for the rest. A > complete > solution might be switchi

[Spice-devel] [spice-gtk] build-sys: Fix symbol versioning

2012-09-10 Thread Christophe Fergeau
My changes in bug 5bf72a2e had a typo which broke symbol versioning of libspice-client-gtk.so when -Wl,--version-script is available... --- gtk/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk/Makefile.am b/gtk/Makefile.am index 928f914..06cc6e1 100644 --- a/gtk/

[Spice-devel] [spice-gtk] build-sys: Fix symbol versioning

2012-09-10 Thread Christophe Fergeau
My changes in bug 5bf72a2e had a typo which broke symbol versioning of libspice-client-gtk.so when -Wl,--version-script is available... --- gtk/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk/Makefile.am b/gtk/Makefile.am index 928f914..06cc6e1 100644 --- a/gtk/

[Spice-devel] [spice-protocol PATCH 2/2] qxl_dev.h: add client monitors configuration notification to guest

2012-09-10 Thread Alon Levy
so far we have used the agent to notify the guest of a request to change the monitors configurations (heads) on the qxl device. This patch introduces a new interrupt and new fields in the qxl rom to notify the guest about a new request, similarly to how physical hardware notifies the driver. To av

[Spice-devel] [spice-protocol PATCH 1/2] qxl_dev.h: add guest capabilities

2012-09-10 Thread Alon Levy
guest can advertise it's capabilities to the host. The caps are stored on the guest ram header, there is a fixed maximum of 512 caps. Any change is advertised with a new io QXL_IO_CAPABILITIES_SET. --- spice/qxl_dev.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/spice/qxl

Re: [Spice-devel] Failure to compile [was: [Spice-commits] gtk/channel-display.c]

2012-09-10 Thread Christophe Fergeau
On Mon, Sep 10, 2012 at 12:08:30PM +0300, Yaniv Kaul wrote: > Confirmed, great and thanks. > I'd be happy if we could avoid such situations in the future. I know > we (used to?) have a build-bot for Spice. Is it alive and working? It was working a few weeks ago since I got a broken build email aft

Re: [Spice-devel] Failure to compile [was: [Spice-commits] gtk/channel-display.c]

2012-09-10 Thread Yaniv Kaul
On 09/10/2012 11:57 AM, Christophe Fergeau wrote: Hey, On Sat, Sep 08, 2012 at 04:54:53PM -0400, Yaniv Kaul wrote: channel-display.c: In function 'spice_display_channel_reset_capabilities': channel-display.c:685:247: error: 'SPICE_DISPLAY_CAP_A8_SURFACE' undeclared (first use in this function)

Re: [Spice-devel] [warning reduction 00/11] Eliminating warnings in xf86-video-qxl

2012-09-10 Thread Alon Levy
> The following patch series remove nearly all warnings from > xf86-video-qxl. > > The final one does not remove a warning, but documents the related > code > with a TODO as the warning appears to be correct. > > You still get a large number of redudant decl warnings from two xorg > include > fil

Re: [Spice-devel] spice @ arm

2012-09-10 Thread Alon Levy
> Hi, > > FYI: spice reportly works just fine on arm, see: > > https://bugzilla.redhat.com/show_bug.cgi?id=613529 > > Just a little configure patch is required. So this is running the spicec client? we need to get remote-viewer working then. I've done n900 package a long time ago, so I think t

Re: [Spice-devel] Failure to compile [was: [Spice-commits] gtk/channel-display.c]

2012-09-10 Thread Christophe Fergeau
Hey, On Sat, Sep 08, 2012 at 04:54:53PM -0400, Yaniv Kaul wrote: > channel-display.c: In function 'spice_display_channel_reset_capabilities': > channel-display.c:685:247: error: 'SPICE_DISPLAY_CAP_A8_SURFACE' undeclared > (first use in this function) > channel-display.c:685:247: note: each undecl

Re: [Spice-devel] [PATCH spice-gtk] G_GNUC_DEPRECATED_FOR must be defined publicly

2012-09-10 Thread Christophe Fergeau
On Fri, Sep 07, 2012 at 04:59:31PM +0200, Marc-André Lureau wrote: > It's not enough to define G_GNUC_DEPRECATED_FOR in glib-compat.h, > since this header is not public. Instead, let's define our own > public SPICE_DEPRECATED_FOR macro, and clean-up double definition. > --- > gtk/glib-compat.h | 1

[Spice-devel] [PATCH 3/3] vdservice: restart vdagent if killed manually

2012-09-10 Thread Arnon Gilboa
win7-only issue rhbz#845222 --- vdservice/vdservice.cpp | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index 696f3da..b48cbeb 100644 --- a/vdservice/vdservice.cpp +++ b/vdservice/vdservice.cpp @@ -590,6 +590,16

[Spice-devel] [PATCH 2/3] vdagent: don't stop due to UIPI blocking

2012-09-10 Thread Arnon Gilboa
User Interface Privilege Isolation is usually used only for specific windows of system security applications (anti-viruses etc.), so with this patch mouse will be irresponsive for these windows but keep working for the rest. A complete solution might be switching to server mouse mode while the agen

[Spice-devel] [PATCH 1/3] vdagent: add message_queue for messages written to pipe

2012-09-10 Thread Arnon Gilboa
This is only part of the message corruption solution. The other part is fixing virtio-serial / spice-qemu-char throttling code. -replace write_[lock/unlock/completion] calls with [new/enqueue]_message -remove clipboard specific _out_msg_* class members -remove ugly loop - while (a->_out_msg && a->