Re: [Spice-devel] Any Volunteers to rewrite spice by Object-C

2012-08-09 Thread mzawdx wang
Yes. For commercial purposes , the license will cause lots of problems. 2012/8/7 Christophe Fergeau > On Tue, Aug 07, 2012 at 07:13:20AM -0400, John A. Sullivan III wrote: > > On Tue, 2012-08-07 at 10:23 +0200, Christophe Fergeau wrote: > > > On Tue, Aug 07, 2012 at 12:19:00AM +0200, David Ja

[Spice-devel] [PATCH](resend) [spice-html5] Add the scroll to the cursor offset

2012-08-09 Thread Aric Stewart
Checking with a more complaint browser proves that scrollLeft is also needed. Signed-off-by: Aric Stewart --- spicemsg.js |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spicemsg.js b/spicemsg.js index 41b001d..79c76bc 100644 --- a/spicemsg.js +++ b/spicemsg.js @@ -639

Re: [Spice-devel] [PATCH 1/7] spice-ppc: Adds powerppc compilation support

2012-08-09 Thread Christophe Fergeau
On Thu, Aug 09, 2012 at 04:52:01PM +0200, Paolo Bonzini wrote: > Il 07/08/2012 20:39, Erlon Cruz ha scritto: > > -AC_MSG_CHECKING(for x86 or x86-64 platform) > > +AC_MSG_CHECKING(for x86,x86-64 or powerpc64 platform) > > case $host_cpu in > >i386|i486|i586|i686|i786|k6|k7|arm|armv7) > > va

Re: [Spice-devel] [PATCH] spice-ppc: adds powerpc64 mem barriers

2012-08-09 Thread Paolo Bonzini
Il 08/08/2012 14:52, Erlon Cruz ha scritto: >>> >> +#elif defined __PPC64__ >>> >> +#define spice_mb() __asm__ __volatile__ ("sync" : : : "memory") >> > >> > Do we need a full sync here? Would an lwsync be enough? >> > Without this, what happens? Is compilation broken? Are things buggy? > Hi Chri

Re: [Spice-devel] [PATCH 5/7] spice-ppc: avoid casts to lessers types!

2012-08-09 Thread Paolo Bonzini
Il 07/08/2012 20:39, Erlon Cruz ha scritto: > From: Fabiano Fidêncio > > It's breaking PPC's keyboard functionality, once this cast is > getting the first byte (from left to right) on any architecture, > what's wrong when we think in a PPC (we should get the last one, > instead).

Re: [Spice-devel] [PATCH 1/7] spice-ppc: Adds powerppc compilation support

2012-08-09 Thread Paolo Bonzini
Il 07/08/2012 20:39, Erlon Cruz ha scritto: > -AC_MSG_CHECKING(for x86 or x86-64 platform) > +AC_MSG_CHECKING(for x86,x86-64 or powerpc64 platform) > case $host_cpu in >i386|i486|i586|i686|i786|k6|k7|arm|armv7) > variant=32 > @@ -64,13 +64,19 @@ case $host_cpu in >x86_64) > var

Re: [Spice-devel] [PATCH win-qxl] miniport: fix invalid memory access from previous patch

2012-08-09 Thread Christophe Fergeau
On Thu, Aug 09, 2012 at 01:46:50PM +0300, Alon Levy wrote: > On Wed, Aug 08, 2012 at 08:13:29PM +0200, Marc-André Lureau wrote: > > miniport/qxl.c | 18 ++ > > 1 file changed, 10 insertions(+), 8 deletions(-) > > > > diff --git a/miniport/qxl.c b/miniport/qxl.c > > index 44c2a40

Re: [Spice-devel] [PATCH] Enable compilation on systems with older render libraries.

2012-08-09 Thread Jeremy White
On 08/09/2012 04:25 AM, Christophe Fergeau wrote: > On Wed, Aug 08, 2012 at 03:03:25PM -0500, Jeremy White wrote: >> --- >> src/uxa/uxa-render.c |2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/src/uxa/uxa-render.c b/src/uxa/uxa-render.c >> index ac80c45..b5554e7 100644 >> --- a/sr

Re: [Spice-devel] [PATCH 4/7] spice-ppc: fix glz magic endianess

2012-08-09 Thread Christophe Fergeau
On Thu, Aug 09, 2012 at 08:37:46AM -0300, Erlon Cruz wrote: > On Wed, Aug 8, 2012 at 5:18 AM, Christophe Fergeau > wrote: > > On Tue, Aug 07, 2012 at 03:43:11PM -0300, Erlon Cruz wrote: > >> From: Erlon Cruz > >> > >> Signed-off-by: Erlon R. Cruz > >> Signed-off-by: Fabiano Fidêncio > >> Signe

Re: [Spice-devel] [PATCH 4/7] spice-ppc: fix glz magic endianess

2012-08-09 Thread Erlon Cruz
On Wed, Aug 8, 2012 at 5:18 AM, Christophe Fergeau wrote: > On Tue, Aug 07, 2012 at 03:43:11PM -0300, Erlon Cruz wrote: >> From: Erlon Cruz >> >> Signed-off-by: Erlon R. Cruz >> Signed-off-by: Fabiano Fidêncio >> Signed-off-by: Rafael F. Santos >> --- >> server/glz_encoder.c |2 +- >> 1 f

Re: [Spice-devel] [PATCH win-qxl] miniport: fix invalid memory access from previous patch

2012-08-09 Thread Alon Levy
On Wed, Aug 08, 2012 at 08:13:29PM +0200, Marc-André Lureau wrote: > The patch 253b781773190afef313390542f2d68995e302d7 implementing custom > display resolution is accessing unowned memory regions. ACK with or without split. > > Interestingly, the driver worked fine on Windows XP but BSOD on Win

Re: [Spice-devel] [PATCH] Enable compilation on systems with older render libraries.

2012-08-09 Thread Christophe Fergeau
On Wed, Aug 08, 2012 at 03:03:25PM -0500, Jeremy White wrote: > --- > src/uxa/uxa-render.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/uxa/uxa-render.c b/src/uxa/uxa-render.c > index ac80c45..b5554e7 100644 > --- a/src/uxa/uxa-render.c > +++ b/src/uxa/uxa-render.c > @@ -137,

Re: [Spice-devel] [PATCH] Technically, the xorg/ prefix should not be specified. It generally works, because xorg/ is usually hung off /usr/include. This enables compliation that correctly respects a

2012-08-09 Thread Christophe Fergeau
On Wed, Aug 08, 2012 at 03:03:54PM -0500, Jeremy White wrote: > --- > src/spiceqxl_inputs.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src/spiceqxl_inputs.c b/src/spiceqxl_inputs.c > index 62ef19f..a031b83 100644 > --- a/src/spiceqxl_inputs.c > +++ b/s

Re: [Spice-devel] [PATCH] spice-common: don't install spice-protocol

2012-08-09 Thread Christophe Fergeau
On Wed, Aug 08, 2012 at 07:46:02PM +0200, Marc-André Lureau wrote: > Revert to usage of DIST_SUBDIRS to avoid make install under > spice-protocol. Use an updated version of git.mk that fixes .gitignore > generation under DIST_SUBDIRS. These 2 unrelated sentences are a strong hint that the commits

Re: [Spice-devel] [PATCH 2/7] spice-ppc: Fixing endianess for channel startup negotiation

2012-08-09 Thread Christophe Fergeau
On Wed, Aug 08, 2012 at 10:24:15AM -0300, Erlon Cruz wrote: > On Wed, Aug 8, 2012 at 7:19 AM, Christophe Fergeau > wrote: > > I think it would be better to write a sync_write equivalent which reads an > > array 4 bytes at a time and swaps them before sending, this will avoid the > > need for the

Re: [Spice-devel] spice-gtk usb-redirection

2012-08-09 Thread Hans de Goede
Hi, On 08/09/2012 05:15 AM, Jackson wrote: Yes, in the second case qemu is the tcp client, and the ip and port number are that of the usbredirserver process which is acting as the usbredir-host. that means I have to know the IP address to describe the qemu cmdline before a spice-client connect