Re: [Spice-devel] [PATCH 1/6] usbclerk: dos2unix

2012-07-23 Thread Hans de Goede
Hi, Series looks good, only remark I have is that with 6/6 you're not passing in interface information, that really is not a good idea, since for almost all devices if you want to filter on usb classes (which you usually do) the interesting bits are in the interface info. Now it might be that wh

Re: [Spice-devel] [PATCH v2] bump version to 0.11.1 for new spice_qxl_monitors_config_async

2012-07-23 Thread Marc-André Lureau
ack - Mensaje original - > bump current and age since only additions where done. > new server library is libspice-server.so.1.2.0 . > --- > configure.ac |6 +++--- > server/spice.h |2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/configure.ac b/configu

Re: [Spice-devel] Tripping assertions in spice-common/common/ring.h

2012-07-23 Thread Nahum Shalman
On 07/22/2012 02:14 PM, Yonit Halperin wrote: Hi, the trace implies some problem in the drawables tree structure. Please describe in more details how you reproduce it: which web site, which browser you use, what operations you execute on the web site? In addition, what is the qxl driver versio

[Spice-devel] [PATCH v2] bump version to 0.11.1 for new spice_qxl_monitors_config_async

2012-07-23 Thread Alon Levy
bump current and age since only additions where done. new server library is libspice-server.so.1.2.0 . --- configure.ac |6 +++--- server/spice.h |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 75a062c..bed0464 100644 --- a/configur

[Spice-devel] [PATCH] bump version to 0.11.1 for new spice_qxl_monitors_config_async

2012-07-23 Thread Alon Levy
--- configure.ac |2 +- server/spice.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 75a062c..afad73b 100644 --- a/configure.ac +++ b/configure.ac @@ -12,7 +12,7 @@ AC_PREREQ([2.57]) m4_define([SPICE_MAJOR], 0) m4_define([SPIC

Re: [Spice-devel] [PATCH xf86-qxl 14/27] Add some error message if pci revision < 4

2012-07-23 Thread Marc-André Lureau
On Mon, Jul 16, 2012 at 5:38 PM, Marc-André Lureau wrote: > --- > src/qxl_driver.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/qxl_driver.c b/src/qxl_driver.c > index e1cd097..a24932f 100644 > --- a/src/qxl_driver.c > +++ b/src/qxl_driver.c > @@ -1897,7 +189

[Spice-devel] [PATCH 6/6] usbclerk: add device filter support

2012-07-23 Thread Arnon Gilboa
read from HKLM\Software\USBClerk\filter_rules same format as in client --- usbclerk.cpp| 69 +++ usbclerk.vcproj | 40 +++ 2 files changed, 109 insertions(+), 0 deletions(-) diff --git a/usbclerk.cpp b/usbcler

[Spice-devel] [PATCH 5/6] usbclerk: add usbredirfilter & stdint.h

2012-07-23 Thread Arnon Gilboa
until switching to mingw build --- stdint.h | 256 + usbredirfilter.c | 260 ++ usbredirfilter.h | 127 ++ 3 files changed, 643 insertions(+), 0 deletions(-)

[Spice-devel] [PATCH 4/6] usbclerk: refactor device lookup

2012-07-23 Thread Arnon Gilboa
--- usbclerk.cpp | 33 - 1 files changed, 20 insertions(+), 13 deletions(-) diff --git a/usbclerk.cpp b/usbclerk.cpp index e01489b..09f1e66 100644 --- a/usbclerk.cpp +++ b/usbclerk.cpp @@ -39,6 +39,7 @@ private: bool remove_winusb_driver(int vid, int pid);

[Spice-devel] [PATCH 3/6] usbclerk: add logging to driver removal

2012-07-23 Thread Arnon Gilboa
--- usbclerk.cpp | 24 +++- 1 files changed, 19 insertions(+), 5 deletions(-) diff --git a/usbclerk.cpp b/usbclerk.cpp index 9100811..e01489b 100644 --- a/usbclerk.cpp +++ b/usbclerk.cpp @@ -470,17 +470,31 @@ bool USBClerk::remove_dev(HDEVINFO devs, PSP_DEVINFO_DATA dev_inf

[Spice-devel] [PATCH 2/6] usbclerk: move wdi driver extraction path to system32

2012-07-23 Thread Arnon Gilboa
prevents user from replacing the drivers --- usbclerk.cpp | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/usbclerk.cpp b/usbclerk.cpp index 441f4a1..9100811 100644 --- a/usbclerk.cpp +++ b/usbclerk.cpp @@ -17,7 +17,7 @@ #define USB_CLERK_LOG_PATH TEXT(

[Spice-devel] [PATCH 1/6] usbclerk: dos2unix

2012-07-23 Thread Arnon Gilboa
--- usbclerk.cpp | 72 +- 1 files changed, 36 insertions(+), 36 deletions(-) diff --git a/usbclerk.cpp b/usbclerk.cpp index 792f544..441f4a1 100644 --- a/usbclerk.cpp +++ b/usbclerk.cpp @@ -1,6 +1,6 @@ #include #include -#include +#in