[Spice-devel] [Announce] Release spice-protocol 0.12.0

Hi, A fresh protocol release adding support for arbitrary resolutions, and multiple monitors per channel. cb76215928afda701e199da2f3937ea7 spice-protocol-0.12.0.tar.bz2 f67cc92adbc406f5fb800c56e0b6b0fb spice-protocol-0.12.0.tar.gz Available at its usual location: http://spice-space.org/downloa

Re: [Spice-devel] [PATCH 1/2] server: factor out bitmap_fmt_is_rgb

On Mon, Jul 16, 2012 at 11:40:51AM -0400, Marc-André Lureau wrote: > > > - Mensaje original - > > --- > > server/red_common.h | 11 +++ > > server/red_worker.c | 15 +++ > > 2 files changed, 18 insertions(+), 8 deletions(-) > > > > diff --git a/server/red_common.

Re: [Spice-devel] [PATCH] build-sys: fix make distcheck

On Mon, Jul 16, 2012 at 06:19:20PM +0300, Alon Levy wrote: > On Mon, Jul 16, 2012 at 05:06:06PM +0200, Christophe Fergeau wrote: > > Have you tried $(top_builddir) instead of ../ ? > > No. Where do I find out about those variables? Somewhere in autoconf documentation I guess ;) http://www.gnu.org

[Spice-devel] [PATCH xf86-qxl 27/27] Return a preferred mode matching the current mode

This make gnome-settings-daemon not switch resolution automatically to the largest available. --- src/qxl_driver.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 0d15ccd..daa7606 100644 --- a/src/qxl_drive

[Spice-devel] [PATCH xf86-qxl 26/27] Change output status when update monitors config

--- src/qxl_driver.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 42bcc13..0d15ccd 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -964,6 +964,7 @@ qxl_update_monitors_config(qxl_screen_t *qxl) int i;

[Spice-devel] [PATCH xf86-qxl 25/27] Bypass rrcrtc.c screen size bounds check

--- src/qxl_driver.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 9039e50..42bcc13 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -40,6 +40,7 @@ #include #include +#include #include "mspace.h" @@ -1555,6 +1556,11 @@ qxl

Re: [Spice-devel] [PATCH] server: add monitors_config support

ack - Mensaje original - > a SpiceMsgDisplayMonitorsConfig is sent on two occasions: > * as a result of a spice_qxl_monitors_config_async > * whenever a client connects and there is a previously set monitors >config > > Sending the new message is protected by a new cap, > SPICE_DISP

[Spice-devel] [PATCH xf86-qxl 24/27] Avoid calling qxl_update_monitors_config() with invalid config

During startup, the monitors are not yet enabled/set. and we can avoid sending invalid/transient config. --- src/qxl_driver.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index ba2c5b0..9039e50 100644 --- a/src/qxl_driver.c +++ b/s

[Spice-devel] [PATCH xf86-qxl 23/27] Split crtc_set_mode_major()

Avoid sending many monitor config changes during qxl_create_desired_modes() --- src/qxl_driver.c | 46 -- 1 file changed, 32 insertions(+), 14 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 5b70c96..ba2c5b0 100644 --- a/src/qxl_dr

[Spice-devel] [PATCH xf86-qxl 22/27] Add check_crtc() helper, to catch crtc/monitor config errors

--- src/qxl_driver.c | 35 +-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index e621501..5b70c96 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -58,10 +58,13 @@ extern void compat_init_scrn(ScrnIn

Re: [Spice-devel] [PATCH 1/2] server: factor out bitmap_fmt_is_rgb

- Mensaje original - > --- > server/red_common.h | 11 +++ > server/red_worker.c | 15 +++ > 2 files changed, 18 insertions(+), 8 deletions(-) > > diff --git a/server/red_common.h b/server/red_common.h > index cb7bf71..b9dcd49 100644 > --- a/server/red_common.h >

[Spice-devel] [PATCH xf86-qxl 20/27] get rid of one of the gcc warnings

--- src/mspace.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mspace.h b/src/mspace.h index 46a6a56..bd5fbae 100644 --- a/src/mspace.h +++ b/src/mspace.h @@ -9,7 +9,7 @@ extern "C" { //typedef unsigned long size_t; typedef void (*mspace_abort_t)(void *user_data);

[Spice-devel] [PATCH xf86-qxl 19/27] qxl_driver/qxl_initialize_x_modes: remove modes not fitting framebuffer

From: Alon Levy --- src/qxl_driver.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index dd97a21..025f8ed 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1955,11 +1955,21 @@ qxl_initialize_x_modes(qxl_screen_t *

[Spice-devel] [PATCH xf86-qxl 18/27] qxl_driver: add infra for surface0 resizing

From: Alon Levy Most importantly, don't allow randr resize if it is too large for the currently allocated mspace. Ifdeffed out almost working code for reallocating the primary mspace (qxl->mem). --- src/qxl.h|1 + src/qxl_driver.c | 189 +++---

[Spice-devel] [PATCH xf86-qxl 17/27] add qxl_edid

From: Alon Levy Taken from Virtual Box, following exactly the same logic: gnome-settings-daemon relies on the serial given in the edid to set the resolution to the same one last used on that screen. Since this is not what we want with a virtual machine, we produce a serial that is different for e

[Spice-devel] [PATCH xf86-qxl 16/27] (for later) qxl_ring: add helpers (debugging/unused)

From: Alon Levy --- src/qxl.h |4 src/qxl_ring.c | 20 2 files changed, 24 insertions(+) diff --git a/src/qxl.h b/src/qxl.h index 44c9b47..c221a06 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -327,6 +327,10 @@ Bool qxl_ring_pop (struct qxl_

[Spice-devel] [PATCH xf86-qxl 15/27] qxl_driver: qxl_init_randr: limit width/height to 8192, real check done on randr screen resize callback

From: Alon Levy --- src/qxl_driver.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index a24932f..f792d07 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1775,28 +1775,12 @@ qxl_init_randr(ScrnInfoPtr pScr

[Spice-devel] [PATCH xf86-qxl 14/27] Add some error message if pci revision < 4

--- src/qxl_driver.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index e1cd097..a24932f 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1897,7 +1897,9 @@ qxl_pre_init(ScrnInfoPtr pScrn, int flags) qxl->pci_tag = pciTag

[Spice-devel] [PATCH xf86-qxl 13/27] qxl_driver: introduce qxl_crtc, crtc private

From: Alon Levy Additionally prevents disabling of the primary crtc. --- src/qxl.h|6 ++ src/qxl_driver.c | 25 - 2 files changed, 26 insertions(+), 5 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index 6c97f1f..44c9b47 100644 --- a/src/qxl.h +++ b/sr

[Spice-devel] [PATCH xf86-qxl 12/27] qxl_driver: implement randr, arbitrary resolution, multiple monitors (big dump)

From: Alon Levy Send a MonitorsUpdate - this should definitely be split into it's own patch. Require revision 4 - this is needed just for MonitorsUpdate, should go with it. Adds new config: OPTION_NUM_HEADS, defaults to 4. --- src/Makefile.am |2 + src/qxl.h | 21 +- src/qxl_dr

[Spice-devel] [PATCH xf86-qxl 11/27] qxl_surface: add download_box_no_update

From: Alon Levy --- src/qxl_surface.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/qxl_surface.c b/src/qxl_surface.c index aef90ec..a5f8c9e 100644 --- a/src/qxl_surface.c +++ b/src/qxl_surface.c @@ -898,6 +898,16 @@ qxl_surface_flush (qxl_surface_t

[Spice-devel] [PATCH xf86-qxl 10/27] qxl_surface: normalize surface_send names, add option to surface_destroy to send/not send destroy message

From: Alon Levy --- src/qxl_surface.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/qxl_surface.c b/src/qxl_surface.c index 347503d..aef90ec 100644 --- a/src/qxl_surface.c +++ b/src/qxl_surface.c @@ -752,7 +752,7 @@ unlink_surface (qxl_surface_t *surface

[Spice-devel] [PATCH xf86-qxl 09/27] spiceqxl_io_port: mark FLUSH_SURFACES_ASYNC as unimplemented, do half of it

From: Alon Levy --- src/spiceqxl_io_port.c |4 1 file changed, 4 insertions(+) diff --git a/src/spiceqxl_io_port.c b/src/spiceqxl_io_port.c index f599b4e..9d92f93 100644 --- a/src/spiceqxl_io_port.c +++ b/src/spiceqxl_io_port.c @@ -275,6 +275,10 @@ void ioport_write(qxl_screen_t *qxl,

[Spice-devel] [PATCH] server: add monitors_config support

a SpiceMsgDisplayMonitorsConfig is sent on two occasions: * as a result of a spice_qxl_monitors_config_async * whenever a client connects and there is a previously set monitors config Sending the new message is protected by a new cap, SPICE_DISPLAY_CAP_MONITORS_CONFIG More elaborately: spice

[Spice-devel] [PATCH xf86-qxl 08/27] qxl_screen_init: move uxa_resources_init down to after qxl_switch_mode has run

From: Alon Levy --- src/qxl_driver.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 2b0d567..b0967dc 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1207,13 +1207,6 @@ qxl_screen_init(SCREEN_INIT_ARGS_DECL)

[Spice-devel] [PATCH xf86-qxl 07/27] qxl_close_screen: disable fb access, prevent segfaults in uxa later on

From: Alon Levy I don't have a stacktrace to show any segfault unfortunately. --- src/qxl_driver.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 3cf3137..2b0d567 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -638,6 +638,12 @@ qxl

[Spice-devel] [PATCH xf86-qxl 06/27] qxl_driver: move mspace_set_*_func earlier

From: Alon Levy --- src/qxl_driver.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 90619e6..3cf3137 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -503,8 +503,7 @@ qxl_map_memory(qxl_screen_t *qxl, int scrnIndex)

[Spice-devel] [PATCH xf86-qxl 05/27] fix two segfaults in qxl_free_surface

From: Alon Levy Both results from ProcFreePixmap being called in unanticipated circumstances: cache->all_surfaces is NULL surface->host_image is NULL To reproduce the following scripts work, in tandem: create xterms, destroy them chvt xterm_test import os import su

[Spice-devel] [PATCH xf86-qxl 04/27] qxl: remove qxl_screen_t->stride

From: Alon Levy --- src/qxl.h |1 - src/qxl_driver.c |1 - src/qxl_surface.c |2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index 1db0581..c2d2369 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -158,7 +158,6 @@ struct _qxl_screen_t

[Spice-devel] [PATCH xf86-qxl 03/27] spiceqxl_inputs: don't hide the pointer global typedef

From: Alon Levy --- src/spiceqxl_inputs.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/src/spiceqxl_inputs.c b/src/spiceqxl_inputs.c index 62ef19f..898ef40 100644 --- a/src/spiceqxl_inputs.c +++ b/src/spiceqxl_inputs.c @@ -285,7 +285,7 @@ s

[Spice-devel] [PATCH xf86-qxl 02/27] uxa: fix bad argument type from removed index API change (s/SCREEN_ARG_TYPE/SCRN_ARG_TYPE/)

From: Alon Levy --- src/uxa/uxa-priv.h |2 +- src/uxa/uxa.c |5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/uxa/uxa-priv.h b/src/uxa/uxa-priv.h index 7a3c85e..ad83963 100644 --- a/src/uxa/uxa-priv.h +++ b/src/uxa/uxa-priv.h @@ -111,7 +111,7 @@ typedef st

[Spice-devel] [PATCH xf86-qxl 01/27] whitespace fix

From: Alon Levy --- src/qxl_driver.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index e4c477a..0df6883 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -750,7 +750,7 @@ qxl_create_screen_resources(ScreenPtr pScreen) pScr

[Spice-devel] [PATCH xf86-qxl 00/27] add arbitrary resolution and multiple monitors

Hi, With this patch series, the QXL driver implements arbitrary resolutions and multiple monitors via xrandr interface (to fully test this feature, you'll need the related changes in spice-gtk, vdagent, and virt-viewer) All the patches by Alon are ack'ed by me. Alon already reviewed some of my pa

[Spice-devel] [PATCH 2/2] server: don't abort on guest images with missing palettes

--- server/red_parse_qxl.c |9 + server/red_worker.c|4 2 files changed, 13 insertions(+) diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c index e6c2705..daae897 100644 --- a/server/red_parse_qxl.c +++ b/server/red_parse_qxl.c @@ -328,6 +328,10 @@ static Spice

[Spice-devel] [PATCH 1/2] server: factor out bitmap_fmt_is_rgb

--- server/red_common.h | 11 +++ server/red_worker.c | 15 +++ 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/server/red_common.h b/server/red_common.h index cb7bf71..b9dcd49 100644 --- a/server/red_common.h +++ b/server/red_common.h @@ -35,4 +35,15 @@ enu

Re: [Spice-devel] [PATCH] build-sys: fix make distcheck

On Mon, Jul 16, 2012 at 11:26:28AM -0400, Marc-André Lureau wrote: > > > - Mensaje original - > > On Mon, Jul 16, 2012 at 05:06:42PM +0200, Marc-André Lureau wrote: > > > Hi > > > > > > On Mon, Jul 16, 2012 at 5:00 PM, Alon Levy > > > wrote: > > > > Drop this, instead use the following:

Re: [Spice-devel] [PATCH spice 2/3] build-sys: remove cegui/slirp and mandatory client from dist-check

On Mon, Jul 16, 2012 at 05:13:02PM +0200, Marc-André Lureau wrote: > On Mon, Jul 16, 2012 at 5:03 PM, Christophe Fergeau > wrote: > > Why this change? > > well, it is just spice-common make distcheck fix update. It's unrelated to this commit then, isn't it? Christophe pgpTXIL7GjHi4.pgp Desc

Re: [Spice-devel] [PATCH spice 2/3] build-sys: remove cegui/slirp and mandatory client from dist-check

On Mon, Jul 16, 2012 at 5:13 PM, Marc-André Lureau wrote: > On Mon, Jul 16, 2012 at 5:03 PM, Christophe Fergeau > wrote: >> Why this change? > > well, it is just spice-common make distcheck fix update. I'll drop it for now from this commit, and until we fix spice-common. -- Marc-André Lureau

Re: [Spice-devel] [PATCH] build-sys: fix make distcheck

- Mensaje original - > On Mon, Jul 16, 2012 at 05:06:42PM +0200, Marc-André Lureau wrote: > > Hi > > > > On Mon, Jul 16, 2012 at 5:00 PM, Alon Levy > > wrote: > > > Drop this, instead use the following: > > > > > > > > > commit d0cbc0518fcb0ad5f441387a4530c63ff377ba48 > > > Author: Alon

Re: [Spice-devel] [PATCH] build-sys: fix make distcheck

On Mon, Jul 16, 2012 at 05:06:42PM +0200, Marc-André Lureau wrote: > Hi > > On Mon, Jul 16, 2012 at 5:00 PM, Alon Levy wrote: > > Drop this, instead use the following: > > > > > > commit d0cbc0518fcb0ad5f441387a4530c63ff377ba48 > > Author: Alon Levy > > Date: Mon Jul 16 12:04:34 2012 +0300 > >

Re: [Spice-devel] [PATCH] build-sys: fix make distcheck

On Mon, Jul 16, 2012 at 05:06:06PM +0200, Christophe Fergeau wrote: > On Mon, Jul 16, 2012 at 06:00:45PM +0300, Alon Levy wrote: > > On Mon, Jul 16, 2012 at 04:16:54PM +0200, Marc-André Lureau wrote: > > > - don't try to overwrite read-only enums.h > > > > I thought you were speaking about fixing

Re: [Spice-devel] [PATCH spice 2/3] build-sys: remove cegui/slirp and mandatory client from dist-check

On Mon, Jul 16, 2012 at 5:03 PM, Christophe Fergeau wrote: > Why this change? well, it is just spice-common make distcheck fix update. -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/ma

Re: [Spice-devel] [PATCH] build-sys: fix make distcheck

Hi On Mon, Jul 16, 2012 at 5:00 PM, Alon Levy wrote: > Drop this, instead use the following: > > > commit d0cbc0518fcb0ad5f441387a4530c63ff377ba48 > Author: Alon Levy > Date: Mon Jul 16 12:04:34 2012 +0300 > > enums.h: generate in build directory, passes distcheck > > diff --git a/common/M

Re: [Spice-devel] [PATCH] build-sys: fix make distcheck

On Mon, Jul 16, 2012 at 06:00:45PM +0300, Alon Levy wrote: > On Mon, Jul 16, 2012 at 04:16:54PM +0200, Marc-André Lureau wrote: > > - don't try to overwrite read-only enums.h > > I thought you were speaking about fixing non related enums.h problem. > For enums.h I have a fix already that changed $

Re: [Spice-devel] [PATCH spice 3/3] tests: add missing file to .gitignore

ACK On Mon, Jul 16, 2012 at 04:17:26PM +0200, Marc-André Lureau wrote: > TODO: some day, switch to git.mk > --- > server/tests/.gitignore |1 + > 1 file changed, 1 insertion(+) > > diff --git a/server/tests/.gitignore b/server/tests/.gitignore > index d587e25..74687d1 100644 > --- a/server/t

Re: [Spice-devel] [PATCH spice 2/3] build-sys: remove cegui/slirp and mandatory client from dist-check

On Mon, Jul 16, 2012 at 04:17:25PM +0200, Marc-André Lureau wrote: > The spicec client is no longer actively maintained. > > By removing cegui from distcheck, we can avoid extra build time and > dependencies (>150Mb extra cegui/boost on fedora) > > Slirp is not available in most distributions, af

Re: [Spice-devel] [PATCH spice 1/3] build-sys: define GL flags if enabled

On Mon, Jul 16, 2012 at 04:17:24PM +0200, Marc-André Lureau wrote: > The server too can use opengl, independently from client. Dunno how I missed the USE_OPENGL occurrences in server/ when I merged this patch... Should we get rid of opengl one day? I think it's disabled on most distros, isn't it?

Re: [Spice-devel] [PATCH spice 1/3] build-sys: define GL flags if enabled

On Mon, Jul 16, 2012 at 04:17:24PM +0200, Marc-André Lureau wrote: > The server too can use opengl, independently from client. ACK series. > --- > configure.ac |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 8f9474e..75a062c 100644

Re: [Spice-devel] [PATCH] build-sys: fix make distcheck

On Mon, Jul 16, 2012 at 04:16:54PM +0200, Marc-André Lureau wrote: > - don't try to overwrite read-only enums.h I thought you were speaking about fixing non related enums.h problem. For enums.h I have a fix already that changed $(top_srcdir) to ../ like Christophe suggested, so it changes _build f

Re: [Spice-devel] [Spice-commits] spice/enums.h

On Mon, Jul 16, 2012 at 03:02:36PM +0200, Marc-André Lureau wrote: > Hi > > On Mon, Jul 16, 2012 at 2:53 PM, Alon Levy wrote: > > [could you please keep me in cc/to?] > > I use GMail reply-to-all, and it doesn't include you. Sorry when that > happens, but I don't pay attention to that field. I a

[Spice-devel] [PATCH spice 3/3] tests: add missing file to .gitignore

TODO: some day, switch to git.mk --- server/tests/.gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/server/tests/.gitignore b/server/tests/.gitignore index d587e25..74687d1 100644 --- a/server/tests/.gitignore +++ b/server/tests/.gitignore @@ -4,3 +4,4 @@ test_empty_success test_j

[Spice-devel] [PATCH spice 2/3] build-sys: remove cegui/slirp and mandatory client from dist-check

The spicec client is no longer actively maintained. By removing cegui from distcheck, we can avoid extra build time and dependencies (>150Mb extra cegui/boost on fedora) Slirp is not available in most distributions, afaict, making it hard to build consistantly accross various systems. The client

[Spice-devel] [PATCH spice 1/3] build-sys: define GL flags if enabled

The server too can use opengl, independently from client. --- configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 8f9474e..75a062c 100644 --- a/configure.ac +++ b/configure.ac @@ -272,7 +272,7 @@ SPICE_REQUIRES+=" openssl" # AC_SUB

[Spice-devel] [PATCH] build-sys: fix make distcheck

- don't try to overwrite read-only enums.h - DIST_SUBDIRS is no longer needed --- Makefile.am|1 - common/Makefile.am |5 - 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 79f7903..30c4f37 100644 --- a/Makefile.am +++ b/Makefile.am

Re: [Spice-devel] [Spice-commits] spice/enums.h

Hi On Mon, Jul 16, 2012 at 2:53 PM, Alon Levy wrote: > [could you please keep me in cc/to?] I use GMail reply-to-all, and it doesn't include you. Sorry when that happens, but I don't pay attention to that field. I assume reply-to-all will do the right thing. I guess that page explains the reaso

Re: [Spice-devel] [Spice-commits] spice/enums.h

On Mon, Jul 16, 2012 at 02:47:35PM +0200, Marc-André Lureau wrote: > On Mon, Jul 16, 2012 at 2:45 PM, Alon Levy wrote: > > On Mon, Jul 16, 2012 at 02:26:20PM +0200, Marc-André Lureau wrote: > >> On Fri, Jun 22, 2012 at 4:21 PM, Alon Levy > >> wrote: > >> >SPICE_MSGC_SMARTCARD_DATA = 101, > >

Re: [Spice-devel] [Spice-commits] spice/enums.h

On Mon, Jul 16, 2012 at 2:45 PM, Alon Levy wrote: > On Mon, Jul 16, 2012 at 02:26:20PM +0200, Marc-André Lureau wrote: >> On Fri, Jun 22, 2012 at 4:21 PM, Alon Levy >> wrote: >> >SPICE_MSGC_SMARTCARD_DATA = 101, >> > +SPICE_MSGC_SMARTCARD_HEADER = 101, >> > +SPICE_MSGC_SMARTCARD_ERRO

Re: [Spice-devel] [Spice-commits] spice/enums.h

On Mon, Jul 16, 2012 at 02:26:20PM +0200, Marc-André Lureau wrote: > On Fri, Jun 22, 2012 at 4:21 PM, Alon Levy > wrote: > >SPICE_MSGC_SMARTCARD_DATA = 101, > > +SPICE_MSGC_SMARTCARD_HEADER = 101, > > +SPICE_MSGC_SMARTCARD_ERROR = 101, > > +SPICE_MSGC_SMARTCARD_ATR = 101, > > +

Re: [Spice-devel] [PATCH] validate tcp port values

Hi Peter, On 07/16/2012 12:03 PM, Peter Hatina wrote: Review, please. Looks good to me, ack. Uri. --- SpiceXPI/src/plugin/plugin.cpp | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXPI/src/plugi

Re: [Spice-devel] [Spice-commits] spice/enums.h

On Fri, Jun 22, 2012 at 4:21 PM, Alon Levy wrote: >SPICE_MSGC_SMARTCARD_DATA = 101, > +SPICE_MSGC_SMARTCARD_HEADER = 101, > +SPICE_MSGC_SMARTCARD_ERROR = 101, > +SPICE_MSGC_SMARTCARD_ATR = 101, > +SPICE_MSGC_SMARTCARD_READER_ADD = 101, Is this normal? -- Marc-André Lureau __

Re: [Spice-devel] [PATCH v2] server: factor out bitmap_fmt_is_rgb

On Mon, Jul 16, 2012 at 01:22:37PM +0200, Marc-André Lureau wrote: > On Mon, Jul 16, 2012 at 10:40 AM, Alon Levy wrote: > > --- > > server/red_common.h| 10 ++ > > server/red_parse_qxl.c |6 +- > > server/red_worker.c| 15 +++ > > 3 files changed, 18 insert

Re: [Spice-devel] [PATCH v2] server: factor out bitmap_fmt_is_rgb

On Mon, Jul 16, 2012 at 10:40 AM, Alon Levy wrote: > --- > server/red_common.h| 10 ++ > server/red_parse_qxl.c |6 +- > server/red_worker.c| 15 +++ > 3 files changed, 18 insertions(+), 13 deletions(-) > > diff --git a/server/red_common.h b/server/red_comm

Re: [Spice-devel] [PATCH spice-gtk 23/25] Handle MonitorsConfig::max_allowed

thanks, I updated the patch with your comment changes. On Mon, Jul 16, 2012 at 8:48 AM, Alon Levy wrote: > On Fri, Jul 13, 2012 at 12:29:20AM +0200, Marc-André Lureau wrote: > > I'm not sure how, but it needs to be damn clear that this value can > change during the client lifetime. Documentation

[Spice-devel] [PATCH] validate tcp port values

Review, please. --- SpiceXPI/src/plugin/plugin.cpp | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXPI/src/plugin/plugin.cpp index b7f61ba..cb4bc8e 100644 --- a/SpiceXPI/src/plugin/plugin.cpp +++ b/SpiceX

[Spice-devel] [PATCH v2] server: factor out bitmap_fmt_is_rgb

--- server/red_common.h| 10 ++ server/red_parse_qxl.c |6 +- server/red_worker.c| 15 +++ 3 files changed, 18 insertions(+), 13 deletions(-) diff --git a/server/red_common.h b/server/red_common.h index cb7bf71..7b14f9a 100644 --- a/server/red_common.h +++

Re: [Spice-devel] [PATCH] server: factor out bitmap_fmt_is_rgb

On Mon, Jul 16, 2012 at 11:33:58AM +0300, Alon Levy wrote: > --- > server/red_common.h| 10 ++ > server/red_parse_qxl.c |6 +- > server/red_worker.c| 15 +++ > spice-common |2 +- oops, I'll resend without spice-common. > 4 files changed, 19

[Spice-devel] [PATCH] server: factor out bitmap_fmt_is_rgb

--- server/red_common.h| 10 ++ server/red_parse_qxl.c |6 +- server/red_worker.c| 15 +++ spice-common |2 +- 4 files changed, 19 insertions(+), 14 deletions(-) diff --git a/server/red_common.h b/server/red_common.h index cb7bf71..7b14f9a 100

Re: [Spice-devel] [PATCH spice-protocol] support multiple monitors on a single display channel

On Mon, Jul 16, 2012 at 09:27:59AM +0200, Christophe Fergeau wrote: > On Sat, Jul 14, 2012 at 05:08:24PM +0300, Alon Levy wrote: > > On Fri, Jul 13, 2012 at 11:39:06AM +0200, Christophe Fergeau wrote: > > > On Thu, Jul 12, 2012 at 07:49:45PM +0300, Alon Levy wrote: > > > > Adds on device: > > > >

Re: [Spice-devel] [PATCH spice-protocol] support multiple monitors on a single display channel

On Mon, Jul 16, 2012 at 09:27:59AM +0200, Christophe Fergeau wrote: > On Sat, Jul 14, 2012 at 05:08:24PM +0300, Alon Levy wrote: > > On Fri, Jul 13, 2012 at 11:39:06AM +0200, Christophe Fergeau wrote: > > > On Thu, Jul 12, 2012 at 07:49:45PM +0300, Alon Levy wrote: > > > > Adds on device: > > > >

Re: [Spice-devel] [PATCH spice-protocol] support multiple monitors on a single display channel

On Sat, Jul 14, 2012 at 05:08:24PM +0300, Alon Levy wrote: > On Fri, Jul 13, 2012 at 11:39:06AM +0200, Christophe Fergeau wrote: > > On Thu, Jul 12, 2012 at 07:49:45PM +0300, Alon Levy wrote: > > > Adds on device: > > > > > > RAM > > > Header > > > monitors_config - pointer > > > > > > QXLMon

Re: [Spice-devel] [PATCH spice-gtk 00/25] support multiple monitors on a single display

On Fri, Jul 13, 2012 at 12:28:57AM +0200, Marc-André Lureau wrote: > Hi, Ack series. I understand you prefer to keep the patches like this instead of merging (for instance the last one could be merged earlier). I don't mind either way. > > This is the patch series to support multiple monitors o

Re: [Spice-devel] [PATCH spice-gtk 23/25] Handle MonitorsConfig::max_allowed

On Fri, Jul 13, 2012 at 12:29:20AM +0200, Marc-André Lureau wrote: I'm not sure how, but it needs to be damn clear that this value can change during the client lifetime. Documentation change suggested below. > --- > gtk/channel-display.c | 27 +-- > spice-common

Re: [Spice-devel] [PATCH spice-gtk 18/25] spicy: learn to deal with monitors

On Fri, Jul 13, 2012 at 12:29:15AM +0200, Marc-André Lureau wrote: > --- > gtk/spicy.c | 98 > ++- > 1 file changed, 84 insertions(+), 14 deletions(-) > > diff --git a/gtk/spicy.c b/gtk/spicy.c > index 5ffe3b7..ac2088e 100644 > --- a/gtk/