Re: [Spice-devel] [PATCH spice-gtk 10/25] widget: add monitor property with ctor

I added spice_display_new_with_monitor() to gtk-doc section, along with Since: 0.13 marker. -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH spice-gtk 25/25] Enable the display early when the widget is created

The spice_main_set_display_enabled() function is used to mark the display/monitor config as enabled. In order to simplify client implementation, the widget enables the matching display automatically when the channel mark is received. This is only for legacy reason, and my lack of und

[Spice-devel] [PATCH spice-gtk 24/25] Add SpiceDisplay:ready property

There are several condition to meet in order to have a widget ready to be displayed: the monitor must exist, the area must intersect, and the display mark must be reached. This property will help clients to know when the widget display is ready. Until now, it was relying on the channel mark s

[Spice-devel] [PATCH spice-gtk 23/25] Handle MonitorsConfig::max_allowed

--- gtk/channel-display.c | 27 +-- spice-common |2 +- 2 files changed, 26 insertions(+), 3 deletions(-) diff --git a/gtk/channel-display.c b/gtk/channel-display.c index b701d1b..02650e4 100644 --- a/gtk/channel-display.c +++ b/gtk/channel-display.c @@ -71,

[Spice-devel] [PATCH spice-gtk 22/25] main: send monitor config immediately

The only way this can be called currently is via the main/system coroutine. Remove display timer if any. --- gtk/channel-main.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/gtk/channel-main.c b/gtk/channel-main.c index d7830ae..0c15dfa 100644 --- a/gtk/channel-ma

[Spice-devel] [PATCH spice-gtk 21/25] Implement simple monitors alignment

--- gtk/channel-main.c | 72 +--- 1 file changed, 69 insertions(+), 3 deletions(-) diff --git a/gtk/channel-main.c b/gtk/channel-main.c index 3c173c6..d7830ae 100644 --- a/gtk/channel-main.c +++ b/gtk/channel-main.c @@ -15,6 +15,10 @@ You shou

[Spice-devel] [PATCH spice-gtk 20/25] widget: use display monitors configuration

Use display::monitors property to manage display area. Call update_area_monitor() to update the widget area depending on monitor configuration --- gtk/spice-widget.c | 65 spice-common |2 +- 2 files changed, 57 insertions(+), 10 del

[Spice-devel] [PATCH spice-gtk 19/25] spicy: disable display when deleting window

--- gtk/spicy.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/gtk/spicy.c b/gtk/spicy.c index ac2088e..44b5c2c 100644 --- a/gtk/spicy.c +++ b/gtk/spicy.c @@ -96,6 +96,7 @@ G_DEFINE_TYPE (SpiceWindow, spice_window, G_TYPE_OBJECT); struct spice_connection {

[Spice-devel] [PATCH spice-gtk 18/25] spicy: learn to deal with monitors

--- gtk/spicy.c | 98 ++- 1 file changed, 84 insertions(+), 14 deletions(-) diff --git a/gtk/spicy.c b/gtk/spicy.c index 5ffe3b7..ac2088e 100644 --- a/gtk/spicy.c +++ b/gtk/spicy.c @@ -62,7 +62,8 @@ typedef struct _SpiceWindowClass SpiceWi

[Spice-devel] [PATCH spice-gtk 17/25] Make-up a MonitorConfig if the server doesn't provide one

This allows easier compatibility for clients that don't have to check and interact differently depending on channel capabilities. --- gtk/channel-display.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/gtk/channel-display.c b/gtk/channel-display.c index e6fd38

[Spice-devel] [PATCH spice-gtk 16/25] Handle SPICE_MSG_DISPLAY_MONITORS_CONFIG

--- gtk/channel-display.c | 33 + 1 file changed, 33 insertions(+) diff --git a/gtk/channel-display.c b/gtk/channel-display.c index 13aa810..e6fd388 100644 --- a/gtk/channel-display.c +++ b/gtk/channel-display.c @@ -1457,6 +1457,37 @@ static void display_handle_s

[Spice-devel] [PATCH spice-gtk 15/25] Don't attempt to draw an invalid area

If we don't intersect, the area is invalid or of size 0. --- gtk/spice-widget.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c index 0ab00fe..6b4ae96 100644 --- a/gtk/spice-widget.c +++ b/gtk/spice-widget.c @@ -878,7 +878,8 @@ s

[Spice-devel] [PATCH spice-gtk 14/25] Use monitor_id to compute display_id

--- gtk/channel-main.c |4 ++-- gtk/spice-widget.c | 17 +++-- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/gtk/channel-main.c b/gtk/channel-main.c index 9e97b8b..3c173c6 100644 --- a/gtk/channel-main.c +++ b/gtk/channel-main.c @@ -1829,7 +1829,7 @@ gboolean s

[Spice-devel] [PATCH spice-gtk 13/25] Document spice_main_send_monitor_config()

--- gtk/channel-main.c |9 + 1 file changed, 9 insertions(+) diff --git a/gtk/channel-main.c b/gtk/channel-main.c index 1d83bfa..9e97b8b 100644 --- a/gtk/channel-main.c +++ b/gtk/channel-main.c @@ -849,6 +849,15 @@ static void agent_msg_queue_many(SpiceMainChannel *channel, int type,

[Spice-devel] [PATCH spice-gtk 12/25] widget: don't forget to disconnect all signals handlers

We forgot about display-mark. Use spice_g_signal_connect_object() helper, which will disconnect properly in all circunstances. --- gtk/spice-widget.c | 122 ++-- 1 file changed, 32 insertions(+), 90 deletions(-) diff --git a/gtk/spice-widget.c b/gt

[Spice-devel] [PATCH spice-gtk 11/25] spice_channel_connect() success if state >= CONNECTING

We may have several widget trying to re-connect the channels now. It is fine to return successfully if we are already connecting or connected. --- gtk/spice-channel.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c index 793e36f..54d

[Spice-devel] [PATCH spice-gtk 10/25] widget: add monitor property with ctor

--- gtk/map-file|1 + gtk/spice-widget-priv.h |1 + gtk/spice-widget.c | 47 +-- gtk/spice-widget.h |4 +++- 4 files changed, 50 insertions(+), 3 deletions(-) diff --git a/gtk/map-file b/gtk/map-file index c58bab5..0d

[Spice-devel] [PATCH spice-gtk 09/25] Claim SPICE_DISPLAY_CAP_MONITORS_CONFIG

--- gtk/channel-display.c |1 + 1 file changed, 1 insertion(+) diff --git a/gtk/channel-display.c b/gtk/channel-display.c index e7772aa..13aa810 100644 --- a/gtk/channel-display.c +++ b/gtk/channel-display.c @@ -653,6 +653,7 @@ static HDC create_compatible_dc(void) static void spice_display_

[Spice-devel] [PATCH spice-gtk 08/25] Add spice_display_get_primary()

--- gtk/channel-display.c | 37 + gtk/channel-display.h | 14 +- gtk/map-file |1 + 3 files changed, 51 insertions(+), 1 deletion(-) diff --git a/gtk/channel-display.c b/gtk/channel-display.c index 681482b..e7772aa 100644 --- a/gtk/

[Spice-devel] [PATCH spice-gtk 07/25] display: add readonly monitors property

--- gtk/channel-display.c | 27 +++ gtk/channel-display.h | 10 ++ 2 files changed, 37 insertions(+) diff --git a/gtk/channel-display.c b/gtk/channel-display.c index 952628c..681482b 100644 --- a/gtk/channel-display.c +++ b/gtk/channel-display.c @@ -70,6 +70,7

[Spice-devel] [PATCH spice-gtk 06/25] glib-compat: add g_clear_pointer

A helpful macro from glib 2.34 --- gtk/glib-compat.h | 20 1 file changed, 20 insertions(+) diff --git a/gtk/glib-compat.h b/gtk/glib-compat.h index bd8f3de..aa750b2 100644 --- a/gtk/glib-compat.h +++ b/gtk/glib-compat.h @@ -106,4 +106,24 @@ GType spice_main_context_get_typ

[Spice-devel] [PATCH spice-gtk 05/25] Change surface_id to a guint32

That's the correct type used by the protocol. --- gtk/channel-display-priv.h |2 +- gtk/channel-display.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gtk/channel-display-priv.h b/gtk/channel-display-priv.h index d327c28..ff0f484 100644 --- a/gtk/channel-dis

[Spice-devel] [PATCH spice-gtk 04/25] widget: add main channel before other channels

Make sure that the d->main channel member can be referenced when adding further channels, when we perform their setup. --- gtk/spice-widget.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c index 237d832..4d0f9be 100644 --- a/g

[Spice-devel] [PATCH spice-gtk 03/25] Add missing agent cap description

--- gtk/channel-main.c |1 + 1 file changed, 1 insertion(+) diff --git a/gtk/channel-main.c b/gtk/channel-main.c index 70861e6..1d83bfa 100644 --- a/gtk/channel-main.c +++ b/gtk/channel-main.c @@ -149,6 +149,7 @@ static const char *agent_caps[] = { [ VD_AGENT_CAP_CLIPBOARD ] =

[Spice-devel] [PATCH spice-gtk 02/25] display: learn to restrict display to an area

Each spice widget can now restrict the area of the primary surface they show and interact with by setting the private area member. A nice clean-up would be to seperate an area object that would deal with clipping, input translation and color conversion, but the resulting code would be similar anyw

[Spice-devel] [PATCH spice-gtk 01/25] widget: simplify redraw call

--- gtk/spice-widget.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c index e892591..095224c 100644 --- a/gtk/spice-widget.c +++ b/gtk/spice-widget.c @@ -1637,8 +1637,7 @@ static void mark(SpiceChannel *channel, gint mark, gpointer

[Spice-devel] [PATCH spice-gtk 00/25] support multiple monitors on a single display

Hi, This is the patch series to support multiple monitors on a single display channel. It requires the spice-common & spice-protocol patches that Alon submitted. The relationship between a display channel and its widget is no longer limited to 1-to-1 and can be 1-to-many. Each widget can show and

Re: [Spice-devel] [PATCH 2/2] server: don't abort on guest images with missing palettes

On Thu, Jul 12, 2012 at 7:46 PM, Alon Levy wrote: > +if (!BITMAP_FMT_IS_RGB[qxl->bitmap.format] && !qxl->bitmap.palette) { Could it be possible to make this a common inline function, and doing a check of format range there too? -- Marc-André Lureau __

Re: [Spice-devel] [PATCH spice-common] support multiple monitors in single display channel

ack On Thu, Jul 12, 2012 at 6:52 PM, Alon Levy wrote: > See spice-protocol commit for details: > da908f89b581fd4725da997fdaea209f8e6548f6 > support multiple monitors on a single display channel > --- > common/messages.h | 16 > spice-protocol|2 +- > spice.proto

Re: [Spice-devel] [PATCH spice-protocol] support multiple monitors on a single display channel

ack On Thu, Jul 12, 2012 at 6:49 PM, Alon Levy wrote: > Adds on device: > > RAM > Header > monitors_config - pointer > > QXLMonitorsConfig > count == n > max_allowed = N >= 0 > QXLHead 1 > ... > QXLHead n >id, surface_id, x, y, width, height, flags > > IO: > QXL_IO_MONITORS_CON

Re: [Spice-devel] [PATCH 1/2] server/reds: more fixes for wrong spice_error in d2c99b59

ack On Thu, Jul 12, 2012 at 7:46 PM, Alon Levy wrote: > --- > server/reds.c | 136 > - > 1 file changed, 68 insertions(+), 68 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index c33c86c..e3ea154 100644 > --- a/server/reds.

[Spice-devel] Vacation hansg July 13th - July 20th

Hi All, I'm going on vacation for a week starting tomorrow, and I will *not* be reading email, etc. during that time. Regards, Hans ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-deve

[Spice-devel] [PATCH 2/2] server: don't abort on guest images with missing palettes

--- server/red_parse_qxl.c |9 + server/red_worker.c|4 2 files changed, 13 insertions(+) diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c index e6c2705..bae9135 100644 --- a/server/red_parse_qxl.c +++ b/server/red_parse_qxl.c @@ -328,6 +328,10 @@ static Spice

[Spice-devel] [PATCH 1/2] server/reds: more fixes for wrong spice_error in d2c99b59

--- server/reds.c | 136 - 1 file changed, 68 insertions(+), 68 deletions(-) diff --git a/server/reds.c b/server/reds.c index c33c86c..e3ea154 100644 --- a/server/reds.c +++ b/server/reds.c @@ -1958,7 +1958,7 @@ static void reds_handle_auth

[Spice-devel] [PATCH spice-common] support multiple monitors in single display channel

See spice-protocol commit for details: da908f89b581fd4725da997fdaea209f8e6548f6 support multiple monitors on a single display channel --- common/messages.h | 16 spice-protocol|2 +- spice.proto | 16 3 files changed, 33 insertions(+), 1 deleti

[Spice-devel] [PATCH spice-protocol] support multiple monitors on a single display channel

Adds on device: RAM Header monitors_config - pointer QXLMonitorsConfig count == n max_allowed = N >= 0 QXLHead 1 ... QXLHead n id, surface_id, x, y, width, height, flags IO: QXL_IO_MONITORS_CONFIG server flushes command ring, then calls server callback for changing monitors

Re: [Spice-devel] [PATCH] usb-device-manager: mingw: connect: cleanup device if it's libdev is missing

Hi, On 07/12/2012 04:07 PM, Uri Lublin wrote: For Windows client, when connecting a device to the guest, if a libusb device (libdev) does not exist, cleanup and forget about that device. Most likely, the device was plugged out at driver installation time, and its remove-device event was ignored

[Spice-devel] [PATCH] usb-device-manager: mingw: connect: cleanup device if it's libdev is missing

For Windows client, when connecting a device to the guest, if a libusb device (libdev) does not exist, cleanup and forget about that device. Most likely, the device was plugged out at driver installation time, and its remove-device event was ignored. --- An alternative patch for the same fix can

Re: [Spice-devel] [PATCH] migration/channel-inputs: reset motion count after migration

ack - Mensaje original - > The motion count must stay synchronized with the server, otherwise, > it is possible that we will stop sending motion events to the server > after migration. > > rhbz#835997 > --- > gtk/channel-inputs.c | 10 ++ > 1 files changed, 10 insertions(+), 0

[Spice-devel] [PATCH] migration/channel-inputs: reset motion count after migration

The motion count must stay synchronized with the server, otherwise, it is possible that we will stop sending motion events to the server after migration. rhbz#835997 --- gtk/channel-inputs.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/gtk/channel-inputs.c b/

Re: [Spice-devel] [PATCH] validate tcp port values

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/11/2012 02:03 PM, Uri Lublin wrote: > On 07/11/2012 02:03 PM, Peter Hatina wrote: >> Hi, >> >> I had a request to validate TCP port values in spice-xpi, so does >> this make sense for you? >> >> More info at https://bugzilla.redhat.com/show_bug

[Spice-devel] virtio device/drive hangs after live migrate

Hi,all! Currently I'm trying to use the current libvirt/qemu-kvm/spice to do the live migrate for the WindowsXP guests. This is the env I use: 1. libvirt-0.9.12 + qemu-kvm-1.1.0 + spice-gtk-0.11 + spice-guest-tools-0.1.exe(this is the qxl/virtio drivers/services) 2. src/dest host: all ubuntu1