Re: [Spice-devel] spice-gtk automount inhibit patchset v4

2012-06-26 Thread Hans de Goede
Hi, On 06/26/2012 02:16 PM, Marc-André Lureau wrote: ack series Thanks for all the review work you did on this series! Note I'm only pushing 1-3 now and I won't be pushing the rest until the matching gnome-session changes are accepted upstream. Regards, Hans On Tue, Jun 26, 2012 at 1:4

Re: [Spice-devel] spice-gtk automount inhibit patchset v4

2012-06-26 Thread Marc-André Lureau
ack series On Tue, Jun 26, 2012 at 1:48 PM, Hans de Goede wrote: > Hi All, > > Here is v4 of my automount inhibit patchset, history: > > v1: Initial release, toggling automount preference settings > v2: Rewrite to use a proper inhibit interface added to gnome-session > v3: Rewrite to get rid of t

[Spice-devel] [PATCH spice-gtk 6/6] spice-widget: Don't change usbredir/automount settings while redirecting

2012-06-26 Thread Hans de Goede
The keyboard focus may change while usb-device-manager is in the process of redirecting a usb-device (as this may show a policykit dialog). Making autoredir/automount setting changes while this is happening is not a good idea! Since usb-device-manager already sets keyboard_grab_inhibit when it is

[Spice-devel] [PATCH spice-gtk 5/6] spice-gtk-session: hookup automount inhibiting

2012-06-26 Thread Hans de Goede
Inhibit automounting when usb-autoredirection is active. Signed-off-by: Hans de Goede --- gtk/spice-gtk-session.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/gtk/spice-gtk-session.c b/gtk/spice-gtk-session.c index 1df63f5..0a2c4a1 100644 --- a/gt

[Spice-devel] [PATCH spice-gtk 4/6] Add a desktop-integration helper class

2012-06-26 Thread Hans de Goede
We need to integrate closely with the desktop environment of the user in several cases. Some examples are disabling auto-mounting when auto-usbredir is active (rhbz#812972), and disabling the screensaver when fullscreen (fdo#34793). Unfortuntely these kinds of things require desktop environment sp

[Spice-devel] [PATCH spice-gtk 3/6] spice-gtk-session: rename update_keyboard_focus to request_auto_usbredir

2012-06-26 Thread Hans de Goede
To better reflect what then function does, also rename the tracking variable inside spice-gtk-session to match. Signed-off-by: Hans de Goede --- gtk/spice-gtk-session-priv.h |2 +- gtk/spice-gtk-session.c | 16 gtk/spice-widget.c |4 ++-- 3 files changed

[Spice-devel] [PATCH spice-gtk 2/6] spice-gtk-session: Fix keyboard focus tracking

2012-06-26 Thread Hans de Goede
This patch changes the "do we have focus?" tracking, to keeping a counter with how many widgets have focus. The reason for this is that sometimes multiple spice-widgets can have focus at the same time, yes really! Sometimes (rarely, hard to reproduce) the focus in event for one window arrives befor

[Spice-devel] [PATCH spice-gtk 1/6] spice-gtk-session: Only update usb "auto-connect" when doing "auto-usb-redir"

2012-06-26 Thread Hans de Goede
Only update the UsbDeviceManager's "auto-connect" property when "auto-usb-redir" is set, otherwise leave it as is. This allows apps to control UsbDeviceManager's "auto-connect" directly, without it getting reset on every keyboard focus change. Signed-off-by: Hans de Goede --- gtk/spice-gtk-sessi

[Spice-devel] spice-gtk automount inhibit patchset v4

2012-06-26 Thread Hans de Goede
Hi All, Here is v4 of my automount inhibit patchset, history: v1: Initial release, toggling automount preference settings v2: Rewrite to use a proper inhibit interface added to gnome-session v3: Rewrite to get rid of the toplevel window id lists v4: Fix rename patch bodge-up Use g_get_prgname

Re: [Spice-devel] [PATCH spice-gtk 3/6] spice-gtk-session: rename update_keyboard_focus to request_auto_usbredir

2012-06-26 Thread Hans de Goede
Hi, On 06/26/2012 11:42 AM, Marc-André Lureau wrote: On Tue, Jun 26, 2012 at 10:32 AM, Hans de Goede wrote: +void spice_gtk_session_request_auto_usbredir(SpiceGtkSession *self, gboolean state) You need to fix the naming, or compilation fails here

Re: [Spice-devel] [PATCH spice-gtk 3/6] spice-gtk-session: rename update_keyboard_focus to request_auto_usbredir

2012-06-26 Thread Marc-André Lureau
On Tue, Jun 26, 2012 at 10:32 AM, Hans de Goede wrote: > +void spice_gtk_session_request_auto_usbredir(SpiceGtkSession *self, >                                              gboolean state) You need to fix the naming, or compilation fails here: ./.libs/libspice-client-gtk-3.0.so: undefined refere

[Spice-devel] [PATCH spice-gtk 6/6] spice-widget: Don't change usbredir/automount settings while redirecting

2012-06-26 Thread Hans de Goede
The keyboard focus may change while usb-device-manager is in the process of redirecting a usb-device (as this may show a policykit dialog). Making autoredir/automount setting changes while this is happening is not a good idea! Since usb-device-manager already sets keyboard_grab_inhibit when it is

[Spice-devel] [PATCH spice-gtk 5/6] spice-gtk-session: hookup automount inhibiting

2012-06-26 Thread Hans de Goede
Inhibit automounting when usb-autoredirection is active. Signed-off-by: Hans de Goede --- gtk/spice-gtk-session-priv.h |2 +- gtk/spice-gtk-session.c | 23 ++- gtk/spice-widget.c |4 ++-- 3 files changed, 25 insertions(+), 4 deletions(-) diff --git a

[Spice-devel] [PATCH spice-gtk 4/6] Add a desktop-integration helper class

2012-06-26 Thread Hans de Goede
We need to integrate closely with the desktop environment of the user in several cases. Some examples are disabling auto-mounting when auto-usbredir is active (rhbz#812972), and disabling the screensaver when fullscreen (fdo#34793). Unfortuntely these kinds of things require desktop environment sp

[Spice-devel] [PATCH spice-gtk 3/6] spice-gtk-session: rename update_keyboard_focus to request_auto_usbredir

2012-06-26 Thread Hans de Goede
To better reflect what then function does, also rename the tracking variable inside spice-gtk-session to match. Signed-off-by: Hans de Goede --- gtk/spice-gtk-session-priv.h |2 +- gtk/spice-gtk-session.c | 16 gtk/spice-widget.c |4 ++-- 3 files changed

[Spice-devel] [PATCH spice-gtk 2/6] spice-gtk-session: Fix keyboard focus tracking

2012-06-26 Thread Hans de Goede
This patch changes the "do we have focus?" tracking, to keeping a counter with how many widgets have focus. The reason for this is that sometimes multiple spice-widgets can have focus at the same time, yes really! Sometimes (rarely, hard to reproduce) the focus in event for one window arrives befor

[Spice-devel] [PATCH spice-gtk 1/6] spice-gtk-session: Only update usb "auto-connect" when doing "auto-usb-redir"

2012-06-26 Thread Hans de Goede
Only update the UsbDeviceManager's "auto-connect" property when "auto-usb-redir" is set, otherwise leave it as is. This allows apps to control UsbDeviceManager's "auto-connect" directly, without it getting reset on every keyboard focus change. Signed-off-by: Hans de Goede --- gtk/spice-gtk-sessi

Re: [Spice-devel] Spice on virt-viewer windows

2012-06-26 Thread Rozen Lin
Hi,Ale, virt-viewer use the domainName set by libvirt, you may try remote-viewer spice://hostIP. BR. On Mon, 2012-06-25 at 17:11 +0200, Ale Bot wrote: > Hi, i've tryed virt-viewer to connect to one Virtual Machine in a > fedora Kvm Host, but what is the URI that i must put in my client on > vi

[Spice-devel] Spice on virt-viewer windows

2012-06-26 Thread Ale Bot
Hi, i've tryed virt-viewer to connect to one Virtual Machine in a fedora Kvm Host, but what is the URI that i must put in my client on virt-viewer for windows? i have tryed the IP of host but this is the response:"Cannot determine the connection type from URI" -- Alessandro Bottamedi - www.botla