Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-13 Thread Gerd Hoffmann
Hi, >> I suspect there is no way around resampling support though. We'll need >> it for compatibility reasons, so sound keeps working if only one side is >> able to operate at 48 kHz. > > The ability to resample OTOH probably isn't a silly thing to have, and > can be fairly easily set up as an

Re: [Spice-devel] [PATCH spice-gtk 1/3] spice-gtk-session: Only update usb "auto-connect" when doing "auto-usb-redir"

2012-06-13 Thread Marc-André Lureau
ack On Wed, Jun 13, 2012 at 7:07 PM, Hans de Goede wrote: > Only update the UsbDeviceManager's "auto-connect" property when > "auto-usb-redir" is set, otherwise leave it as is. This allows apps to > control UsbDeviceManager's "auto-connect" directly, without it getting reset > on every keyboard f

Re: [Spice-devel] [PATCH spice-gtk 2/3] Add a desktop-integration helper class

2012-06-13 Thread Marc-André Lureau
Hi On Wed, Jun 13, 2012 at 7:07 PM, Hans de Goede wrote: > We need to integrate closely with the desktop environment of the user in > several cases. Some examples are disabling auto-mounting when auto-usbredir > is active (rhbz#812972), and disabling the screensaver when fullscreen > (fdo#34793)

[Spice-devel] [PATCH] Compute totalPixmapSize using the same logic as in dix/pixmap.c, rather than hard coding 100.

2012-06-13 Thread Jeremy White
This was found while building with a modified X server; one with a PixmapRec size of 224, not 64 :-/. --- src/qxl_driver.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 5519f57..135c269 100644 --- a/src/qxl_driver.c +++ b/sr

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-13 Thread Ron
On Wed, Jun 13, 2012 at 01:49:59PM +0200, Gerd Hoffmann wrote: > Hi, > > >> IMHO we should undust Alons opus patches *now* and get stuff ready. > >> Given the sample rate issue a bit more work that just switching the > >> codec, so it will need some time anyway. > > > > I replied to Ron private

[Spice-devel] [PATCH spice-gtk 3/3] usb-device-manager: Add automount disable / restore functionality

2012-06-13 Thread Hans de Goede
Signed-off-by: Hans de Goede --- doc/reference/spice-gtk-sections.txt |2 + gtk/map-file |2 + gtk/usb-device-manager.c | 130 -- gtk/usb-device-manager.h |5 ++ 4 files changed, 132 insertions(+), 7 dele

[Spice-devel] [PATCH spice-gtk 2/3] Add a desktop-integration helper class

2012-06-13 Thread Hans de Goede
We need to integrate closely with the desktop environment of the user in several cases. Some examples are disabling auto-mounting when auto-usbredir is active (rhbz#812972), and disabling the screensaver when fullscreen (fdo#34793). Unfortuntely these kinds of things require desktop environment sp

[Spice-devel] [PATCH spice-gtk 1/3] spice-gtk-session: Only update usb "auto-connect" when doing "auto-usb-redir"

2012-06-13 Thread Hans de Goede
Only update the UsbDeviceManager's "auto-connect" property when "auto-usb-redir" is set, otherwise leave it as is. This allows apps to control UsbDeviceManager's "auto-connect" directly, without it getting reset on every keyboard focus change. Signed-off-by: Hans de Goede --- gtk/spice-gtk-sessi

Re: [Spice-devel] Failure to compile: error: 'SpiceUsbDeviceManagerPrivate' has no member named 'auto_conn_filter_rules'

2012-06-13 Thread Christophe Fergeau
On Wed, Jun 13, 2012 at 04:26:17PM +0300, Yaniv Kaul wrote: > F17/x64, git hash faa2599188a91102945e607e765e3caf0ba1071d: > > make[4]: Entering directory `/home/ykaul/spice-gtk/gtk' > CC decode-glz.lo > CC usb-device-manager.lo > usb-device-manager.c: In function 'spice_usb_device_mana

[Spice-devel] Failure to compile: error: 'SpiceUsbDeviceManagerPrivate' has no member named 'auto_conn_filter_rules'

2012-06-13 Thread Yaniv Kaul
F17/x64, git hash faa2599188a91102945e607e765e3caf0ba1071d: make[4]: Entering directory `/home/ykaul/spice-gtk/gtk' CC decode-glz.lo CC usb-device-manager.lo usb-device-manager.c: In function 'spice_usb_device_manager_finalize': usb-device-manager.c:239:14: error: 'SpiceUsbDeviceManag

Re: [Spice-devel] [spice-gtk] Fix build when usbredir is disabled

2012-06-13 Thread Marc-André Lureau
sure, ack - Mensaje original - > I broke it with my leak fixes > --- > gtk/usb-device-manager.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c > index a3e6ff9..25cb14a 100644 > --- a/gtk/usb-device-manager.c

[Spice-devel] [spice-gtk] Fix build when usbredir is disabled

2012-06-13 Thread Christophe Fergeau
I broke it with my leak fixes --- gtk/usb-device-manager.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c index a3e6ff9..25cb14a 100644 --- a/gtk/usb-device-manager.c +++ b/gtk/usb-device-manager.c @@ -233,10 +233,10 @@ st

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-13 Thread Gerd Hoffmann
Hi, >> IMHO we should undust Alons opus patches *now* and get stuff ready. >> Given the sample rate issue a bit more work that just switching the >> codec, so it will need some time anyway. > > I replied to Ron privately but let me repeat my problems last time > around. They are certainly not u

Re: [Spice-devel] [spice-gtk] Fix various memory leaks

2012-06-13 Thread Daniel P. Berrange
On Wed, Jun 13, 2012 at 12:42:16PM +0200, Christophe Fergeau wrote: > On Wed, Jun 13, 2012 at 01:37:22PM +0300, Alon Levy wrote: > > > diff --git a/gtk/vncdisplaykeymap.c b/gtk/vncdisplaykeymap.c > > > index 26a71a4..a6ef38c 100644 > > > --- a/gtk/vncdisplaykeymap.c > > > +++ b/gtk/vncdisplaykeymap

Re: [Spice-devel] [spice-gtk] Fix various memory leaks

2012-06-13 Thread Christophe Fergeau
On Wed, Jun 13, 2012 at 01:37:22PM +0300, Alon Levy wrote: > > diff --git a/gtk/vncdisplaykeymap.c b/gtk/vncdisplaykeymap.c > > index 26a71a4..a6ef38c 100644 > > --- a/gtk/vncdisplaykeymap.c > > +++ b/gtk/vncdisplaykeymap.c > > @@ -159,7 +159,7 @@ const guint16 const > > *vnc_display_keymap_gdk2xt

Re: [Spice-devel] [spice-gtk] Fix various memory leaks

2012-06-13 Thread Alon Levy
On Wed, Jun 13, 2012 at 12:15:39PM +0200, Christophe Fergeau wrote: > ==25063== 12,827 (2,032 direct, 10,795 indirect) bytes in 127 blocks are > definitely lost in loss record 9,477 of 9,502 > ==25063==at 0x4A0884D: malloc (vg_replace_malloc.c:263) > ==25063==by 0x3DE384D2BE: g_malloc (gme

Re: [Spice-devel] [spice-gtk] Fix various memory leaks

2012-06-13 Thread Marc-André Lureau
ack On Wed, Jun 13, 2012 at 12:15 PM, Christophe Fergeau wrote: > ==25063== 12,827 (2,032 direct, 10,795 indirect) bytes in 127 blocks are > definitely lost in loss record 9,477 of 9,502 > ==25063==    at 0x4A0884D: malloc (vg_replace_malloc.c:263) > ==25063==    by 0x3DE384D2BE: g_malloc (gmem.

[Spice-devel] [spice-gtk] Fix various memory leaks

2012-06-13 Thread Christophe Fergeau
==25063== 12,827 (2,032 direct, 10,795 indirect) bytes in 127 blocks are definitely lost in loss record 9,477 of 9,502 ==25063==at 0x4A0884D: malloc (vg_replace_malloc.c:263) ==25063==by 0x3DE384D2BE: g_malloc (gmem.c:159) ==25063==by 0x3DE38616B1: g_slice_alloc (gslice.c:1003) ==25063

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-13 Thread Alon Levy
On Wed, Jun 13, 2012 at 09:51:24AM +0400, Michael Tokarev wrote: > On 13.06.2012 04:57, Brian Vetter wrote: > > As an outside observer with nothing really at stake here, it would seem > > that rather than Debian providing a hobbled version of the spice client > > that uses raw audio (disables Cel

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-13 Thread Alon Levy
On Wed, Jun 13, 2012 at 09:25:59AM +0200, Gerd Hoffmann wrote: > Hi, > > >> More official than the codec working group declaring it to be in its > >> finally frozen form, or the codec specification being submitted to and > >> approved by the IESG for publication? > > > > You keep refering to st

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-13 Thread Gerd Hoffmann
Hi, >> More official than the codec working group declaring it to be in its >> finally frozen form, or the codec specification being submitted to and >> approved by the IESG for publication? > > You keep refering to standards, while I am talking about what we can > actually rely on, the impleme