[Spice-devel] [PATCH] Make celt to be optional

2012-06-11 Thread Liang Guo
Like patch [1] for spice, This patch will make celt to be optional for spice-gtk. [1] http://lists.freedesktop.org/archives/spice-devel/2012-June/009410.html Signed-off-by: Liang Guo --- configure.ac | 24 +++- gtk/channel-playback.c | 23 ++

[Spice-devel] shift+f11 can not exit fullscreen

2012-06-11 Thread flooding Controlled
Hi all: I am now using spice-gtk-0.12 on a linux client, when I run "spicy -h 127.0.0.1 -p 5900", it connected successfully, and I pressed "shift + f11", spicy window turned to be fullscreen, but when I pressed "shift + f11" again in order to exit the fullscreen mode, it failed. I debug t

Re: [Spice-devel] The spice client with usbredir support

2012-06-11 Thread Rozen Lin
Thanks, but I found the current remote-viewer in virt-viewer-win32 pkg is not released with usbredir support, am I right? can I add the needed libusb for it to work? Best regards. On Mon, 2012-06-11 at 12:32 +0200, David Jaša wrote: > Hi, > > usbredir is only supported in the new client based on

Re: [Spice-devel] Windows guest tools

2012-06-11 Thread Marten Lehmann
Hello, I used this ISO to install Windows Server 2008 R2 with VirtIO Storage, maybe Windows setup has used the Windows 7 drivers. But the ISO doesn't contain vdagent and vdservice, so it would be great if you could rebuild the Windows Guest Installer with vdagent und vdservice for win2k8r2.

Re: [Spice-devel] Development process?

2012-06-11 Thread Hans de Goede
Hi, On 06/11/2012 04:45 PM, Jeremy White wrote: Forgive me if this is FAQ'd elsewhere, but I did not find it in a short hunt, and I'm curious. Documentation is not our strong point, help with that is greatly appreciated :) Who has commit access to the main trees, For all the repositories u

[Spice-devel] Development process?

2012-06-11 Thread Jeremy White
Forgive me if this is FAQ'd elsewhere, but I did not find it in a short hunt, and I'm curious. Who has commit access to the main trees, and how is the decision to commit made? I see acks flying by from time to time; I presume that is part of the process. But I also saw several patches appear in

[Spice-devel] Any progress on agent support for Xspice?

2012-06-11 Thread Eike Hein
A few months ago we had a brief discussion about plans to add agent support to Xspice, primarily to get clipboard synchronization going. Has there been any progress since? -- Best regards, Eike Hein ___ Spice-devel mailing list Spice-devel@lists.free

Re: [Spice-devel] [PATCH spice-gtk 2/4] Deprecate spice_channel_set_capability()

2012-06-11 Thread Marc-André Lureau
- Mensaje original - > On Fri, Jun 08, 2012 at 12:13:27PM +0200, Marc-André Lureau wrote: > > This was initially public to eventually let a derived class > > implement more capabilities. Even though it is technically > > doable to derive and tweak exisiting channels, there is a > > lack o

Re: [Spice-devel] [PATCH win-agent] build-sys: statically build agent

2012-06-11 Thread Marc-André Lureau
hi - Mensaje original - > > > Why the -DOLDMSVCRT? > > > > See 60e850c6e48c5223d00591e1d85ad1a31dcd44c5 > > So this was forgotten in this commit? or has it become necessary > because we > want static linking with mingw libraries? It's just to help user to compile with mingw (our main ta

Re: [Spice-devel] [PATCH spice-gtk 4/4] Fix incorrect format string

2012-06-11 Thread Christophe Fergeau
ACK On Fri, Jun 08, 2012 at 12:13:29PM +0200, Marc-André Lureau wrote: > --- > gtk/channel-playback.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gtk/channel-playback.c b/gtk/channel-playback.c > index 1485267..61501c8 100644 > --- a/gtk/channel-playback.c > +++ b

Re: [Spice-devel] [PATCH spice-gtk 3/4] Fix video playback with GStreamer backend

2012-06-11 Thread Christophe Fergeau
On Fri, Jun 08, 2012 at 12:13:28PM +0200, Marc-André Lureau wrote: > The playback audio delay is not correctly adjusted, we should take > min_latency, set by gst_bin_do_latency_func (). No clue about this one, I'll have to trust you on that one, at least it does not look wrong, ACK > --- > gtk/s

Re: [Spice-devel] [PATCH spice-gtk 2/4] Deprecate spice_channel_set_capability()

2012-06-11 Thread Christophe Fergeau
On Fri, Jun 08, 2012 at 12:13:27PM +0200, Marc-André Lureau wrote: > This was initially public to eventually let a derived class > implement more capabilities. Even though it is technically > doable to derive and tweak exisiting channels, there is a > lack of support in spice-gtk for doing that. A

Re: [Spice-devel] [PATCH spice-gtk 1/4] Learn to disable specific capability by their name

2012-06-11 Thread Christophe Fergeau
A bit hackish, mainly because spice_channel_set_capability is exported, but well.. My main comment will be on the changelog ;) "Learn to disable specific capability by their name Allows to run spice-gtk with SPICE_FOO_CAP_BAR=0 disable channel FOO capability BAR." I'd change this to something l

Re: [Spice-devel] [PATCH win-agent] build-sys: statically build agent

2012-06-11 Thread Christophe Fergeau
On Mon, Jun 11, 2012 at 06:20:35AM -0400, Marc-André Lureau wrote: > Hi > > - Mensaje original - > > On Fri, Jun 08, 2012 at 01:14:02PM +0200, Marc-André Lureau wrote: > > > Fix build by default when using mingw (when more compiler are > > > supported we could do case by case) > > > > > >

Re: [Spice-devel] The spice client with usbredir support

2012-06-11 Thread Christophe Fergeau
On Mon, Jun 11, 2012 at 05:39:01PM +0800, Rozen Lin wrote: >And this is easy to build Linux client, but rather tough to build the > Win32 one, for the cross-compiling on the Mingw is very gory especailly > for the gtk porting, is there any wiki on the building and setting of > this? Can you de

Re: [Spice-devel] rfc seamless migration

2012-06-11 Thread David Jaša
Hi, Alon Levy píše v Ne 10. 06. 2012 v 17:44 +0300: > On Sun, Jun 10, 2012 at 04:32:54PM +0200, Hans de Goede wrote: > > Hi, > > > > On 06/10/2012 11:05 AM, Yonit Halperin wrote: > > >Hi, > > > > > >As the qemu team rejected integrating spice connection migration in qemu > > >migration process,

Re: [Spice-devel] The spice client with usbredir support

2012-06-11 Thread David Jaša
Hi, usbredir is only supported in the new client based on spice-gtk. It won't be implemented in old cegui client. The windows port of the new client with usbredir is ongoing effort, it should be finished in few months. You can track its developments here on ML and you can get prerelease of it (wi

Re: [Spice-devel] [PATCH win-agent] build-sys: statically build agent

2012-06-11 Thread Marc-André Lureau
Hi - Mensaje original - > On Fri, Jun 08, 2012 at 01:14:02PM +0200, Marc-André Lureau wrote: > > Fix build by default when using mingw (when more compiler are > > supported we could do case by case) > > > > Since we are statically building, strip resulting binary (we > > also use lto, who

Re: [Spice-devel] can't connect with virt-viewer on windows

2012-06-11 Thread Christophe Fergeau
On Sat, Jun 09, 2012 at 06:05:20PM -0400, Marc-André Lureau wrote: > remote-viewer is the same client, but doesn't use libvirt, but a URI > instead. A spice URI is just like what you imagined, spice://server:port. or spice://server?port=foo&tls_port=bar if you want to use an encrypted connection.

Re: [Spice-devel] Windows guest tools

2012-06-11 Thread Christophe Fergeau
On Sat, Jun 09, 2012 at 10:36:30PM +0200, Marten Lehmann wrote: > Hello, > > I downloaded "Windows guest tools - spice-guest-tools-0.1.exe" from > http://spice-space.org/download.html and tried to install it on > Windows 8 Preview and Windows Server 2008 R2. Both times the > installer complained a

Re: [Spice-devel] [PATCH win-agent] build-sys: statically build agent

2012-06-11 Thread Christophe Fergeau
On Fri, Jun 08, 2012 at 01:14:02PM +0200, Marc-André Lureau wrote: > Fix build by default when using mingw (when more compiler are > supported we could do case by case) > > Since we are statically building, strip resulting binary (we > also use lto, whole-program but that doesn't seem to change >

[Spice-devel] The spice client with usbredir support

2012-06-11 Thread Rozen Lin
Hi, All! Currently it seems the usbredir support has only been implemented in the spice-gtk client, right? And this is easy to build Linux client, but rather tough to build the Win32 one, for the cross-compiling on the Mingw is very gory especailly for the gtk porting, is there any wiki on th

Re: [Spice-devel] Windows guest tools updates

2012-06-11 Thread Christophe Fergeau
On Thu, Jun 07, 2012 at 02:32:35PM +0200, Davide Canova wrote: > Is there any build of the Windows guest tools that includes the last > commits? (something newer than > http://spice-space.org/download/binaries/spice-guest-tools-0.1.exe) > I wanted to check if the last commits solve some of the prob

Re: [Spice-devel] [spice-gtk 1/2] spice_channel_coroutine: emit signals in all error cases

2012-06-11 Thread Marc-André Lureau
ack On Mon, Jun 11, 2012 at 11:17 AM, Christophe Fergeau wrote: > There are several very unlikely failures where no signal is emitted > to indicate the failure. Since applications rely on these signals > to detect spice-gtk connection failures, it's important to emit > one in all error cases.

Re: [Spice-devel] [spice-gtk 2/2] spice_channel_coroutine: fix function exit in error path

2012-06-11 Thread Marc-André Lureau
ack On Mon, Jun 11, 2012 at 11:17 AM, Christophe Fergeau wrote: > spice_channel_coroutine returns a void *, but one of its error path > is doing 'return FALSE'. This commit replaces this return with a > 'goto cleanup' since this is what is done in the other error paths. > --- >  gtk/spice-channel

[Spice-devel] [spice-gtk 2/2] spice_channel_coroutine: fix function exit in error path

2012-06-11 Thread Christophe Fergeau
spice_channel_coroutine returns a void *, but one of its error path is doing 'return FALSE'. This commit replaces this return with a 'goto cleanup' since this is what is done in the other error paths. --- gtk/spice-channel.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gt

[Spice-devel] [spice-gtk 1/2] spice_channel_coroutine: emit signals in all error cases

2012-06-11 Thread Christophe Fergeau
There are several very unlikely failures where no signal is emitted to indicate the failure. Since applications rely on these signals to detect spice-gtk connection failures, it's important to emit one in all error cases. --- gtk/spice-channel.c |4 1 file changed, 4 insertions(+) diff -

Re: [Spice-devel] rfc seamless migration

2012-06-11 Thread Yonit Halperin
Hi, On 06/11/2012 10:25 AM, Gerd Hoffmann wrote: Hi, I'm still not a big fan of the concept of server data going through the client, this means the server will need to seriously sanity check what it receives to avoid potentially new attacks on it. I'm wondering why not do the following: 1)

Re: [Spice-devel] rfc seamless migration

2012-06-11 Thread Alon Levy
On Mon, Jun 11, 2012 at 09:25:46AM +0200, Gerd Hoffmann wrote: > Hi, > > > I'm still not a big fan of the concept of server data going through the > > client, this means the server > > will need to seriously sanity check what it receives to avoid > > potentially new attacks on it. > > > > I'm w

Re: [Spice-devel] rfc seamless migration

2012-06-11 Thread Gerd Hoffmann
Hi, > I'm still not a big fan of the concept of server data going through the > client, this means the server > will need to seriously sanity check what it receives to avoid > potentially new attacks on it. > > I'm wondering why not do the following: > > 1) spicevmc device gets a savevm call,