Re: [Spice-devel] [ usbredir ] usb device (sagem card reader ) not working

2012-05-30 Thread nicolas prochazka
Hi, 1 - Yes i've first tried without any debug, same effect. 2 - I also tried with qemu-kvm 1.1 rc3 and with your qemu-kvm-1.0-usbredir branch , same effect Regards, Nicolas 2012/5/30 Hans de Goede : > Hi, > > > On 05/29/2012 05:01 PM, nicolas prochazka wrote: >> >> Hello, >> I'm trying to use

Re: [Spice-devel] [usbredir v2 PATCH] usbredirfilter: Win32: implement strtok_r to be used by windows (win_strtok_r)

2012-05-30 Thread Christophe Fergeau
On Mon, May 28, 2012 at 11:04:54AM +0200, Hans de Goede wrote: > Hi, > > On 05/24/2012 04:40 PM, Uri Lublin wrote: > >mingw imlpements neigther strtok_r nor strtok_s. > > > >So here is a simple implementation of strtok_r (for windows). > >It assumes the delimiter is a single character, which is >

Re: [Spice-devel] [spice-gtk Win32 v2 PATCH 4/5] Windows mingw: usb: Dynamically install a libusb driver for USB devices

2012-05-30 Thread Uri Lublin
Hi Hans, Thanks for your review and comments. On 05/22/2012 11:24 AM, Hans de Goede wrote: On 05/20/2012 06:34 PM, Uri Lublin wrote: - Added win-usb-driver-install.[ch] - Added usbclerk.h if OS_WIN32 diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c index 2b6ce28..c373447 100

Re: [Spice-devel] [ usbredir ] usb device (sagem card reader ) not working

2012-05-30 Thread Hans de Goede
Hi, On 05/29/2012 05:01 PM, nicolas prochazka wrote: Hello, I'm trying to use this usb device : http://www.ingenico.com/en/products/payment_terminals/healthcare/twin30-plus_fm0cqjcy.html under windows guest, this usb device is mounting but not recognized it's seems to be a special usb device , t

Re: [Spice-devel] [RFC PATCH 1/4] notifiers: add support for async notifiers handlers

2012-05-30 Thread Alon Levy
On Wed, May 30, 2012 at 12:02:36PM +0300, Yonit Halperin wrote: > Signed-off-by: Yonit Halperin One empty line that snuck in below. > --- > input.c |2 +- > migration.c |2 +- > notify.c | 79 > +++--- > notify.h | 5

[Spice-devel] [RFC PATCH 4/4] migration: replace migration state change notifier with async notifiers

2012-05-30 Thread Yonit Halperin
Note that this patch leaves the current notifier handlers synchronous, i.e., they call the notifier completion callback immediately. Signed-off-by: Yonit Halperin --- migration.c | 84 +- migration.h |8 - ui/spice-core.c |

[Spice-devel] [RFC PATCH 3/4] migration: moving migration completion code to a separated routine

2012-05-30 Thread Yonit Halperin
Preparation for asynchronous migration state change notifiers. Signed-off-by: Yonit Halperin --- migration.c | 31 --- migration.h |1 + 2 files changed, 17 insertions(+), 15 deletions(-) diff --git a/migration.c b/migration.c index 91c807d..c86611d 100644 ---

[Spice-devel] [RFC PATCH 2/4] migration: moving migration start code to a separated routine

2012-05-30 Thread Yonit Halperin
Preparation for asynchronous migration state change notifiers. Signed-off-by: Yonit Halperin --- migration.c | 73 +- migration.h |2 + 2 files changed, 58 insertions(+), 17 deletions(-) diff --git a/migration.c b/migration.c index a

[Spice-devel] [RFC PATCH 1/4] notifiers: add support for async notifiers handlers

2012-05-30 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- input.c |2 +- migration.c |2 +- notify.c | 79 +++--- notify.h | 55 --- qemu-timer.c |2 +- vl.c |2 +- 6 files changed, 129 inser

[Spice-devel] [RFC PATCH 0/4] asynchronous migration state change handlers

2012-05-30 Thread Yonit Halperin
Hi, This patch series introduces async handlers for notifiers, and integrates them with migration state change notifications. Asynchronous migration completion notifier is essential for allowing spice to cleanly complete the src server connection to the client and transfer it to the target. Curr

Re: [Spice-devel] [spice-gtk Win32 v2 PATCH 4/5] Windows mingw: usb: Dynamically install a libusb driver for USB devices

2012-05-30 Thread Uri Lublin
On 05/22/2012 01:29 AM, Marc-André Lureau wrote: Hi Marc-Andre, Thanks for the review. I'll fix all your comments that are not mentioned below. +void spice_usb_drv_install_finished(SpiceUsbDeviceManager *self, + libusb_device *device, int status) nitpick, It's a bit better to keep same pr