Il 22/05/2012 14:50, Christophe Fergeau ha scritto:
>> >
>> > @@ -1226,9 +1230,9 @@ int _tmain(int argc, TCHAR* argv[], TCHAR* envp[])
>> > }
>> > VDService* vdservice = VDService::get();
>> > if (argc > 1) {
>> > -if (lstrcmpi(argv[1], TEXT("install")) == 0) {
>> > +
On Tue, May 22, 2012 at 04:30:33PM +0200, Hans de Goede wrote:
> Hi,
>
> Why not simply memset the struct to 0 before initializing its fields,
> that should make valgrind happy and is a good idea in general (as it
> puts 0 rather then random crap in fields which you forget to init).
Sure, that wo
Hi,
Why not simply memset the struct to 0 before initializing its fields,
that should make valgrind happy and is a good idea in general (as it
puts 0 rather then random crap in fields which you forget to init).
Regards,
Hans
On 05/22/2012 04:27 PM, Alon Levy wrote:
The hole remains uninitial
The hole remains uninitialized variable when allocating an instance of
QXLDevSurfaceCreate on the stack and setting each field individually,
producing an uninteresting valgrind warning. The reordering fixes this.
It also requires bumping the version of the server.
---
What's the suggested course he
On Mon, May 21, 2012 at 05:29:24PM +0200, Marc-André Lureau wrote:
> ping
And I forgot to ask if vc build has been tested?
Christophe
pgp1xL7NdOnIW.pgp
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://li
On Mon, May 21, 2012 at 05:29:24PM +0200, Marc-André Lureau wrote:
> ping
ACK patches 1-8 (still not a big fan of the spice-protocol submodule though
;) except for the main/lstrcpmi patch (forgot it's number). I think someone
had reviewed patch 9?
Christophe
pgpmPawMSnVIB.pgp
Description: PGP s
More code churn than actual changes in this one makes it harder than
necessary to review...
Looks good though.
Christophe
On Wed, May 16, 2012 at 08:15:29PM +0200, Marc-André Lureau wrote:
> ---
> Makefile.am | 38 +++---
> configure.ac |1 +
> 2 files chan
On Wed, May 16, 2012 at 08:15:28PM +0200, Marc-André Lureau wrote:
> Apparently, it comes with a recent version of C library (msvcrt90?),
> but I don't know if we can/should ship also a MS dll. Probably it used
> to work with an inlined version with VS headers.
>
> The build can be tweaked to use
On Wed, May 16, 2012 at 08:15:26PM +0200, Marc-André Lureau wrote:
> ---
> vdagent/vdagent.cpp |4
> vdservice/vdservice.cpp |8 ++--
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
> index 5cbe222..2722741 100644
Looks good, ack.
On 05/22/2012 02:03 PM, Marc-André Lureau wrote:
The main channel can change when we are reconnecting to the server,
for example, when querying the password to the user. From there,
the old main channel is destroyed, but we don't track properly the
new main channel.
This fix m
The main channel can change when we are reconnecting to the server,
for example, when querying the password to the user. From there,
the old main channel is destroyed, but we don't track properly the
new main channel.
This fix migration crashing later on, because of missing main channel:
https://b
Hi,
Comments inline.
On 05/20/2012 06:34 PM, Uri Lublin wrote:
- Added win-usb-driver-install.[ch]
- Added usbclerk.h
Operation (on Windows, spice-gtk point of view):
- After some sanity checks, just before redir'ing a USB device
a libusb driver needs to be installed (before libusb can open
On Tue, May 22, 2012 at 12:29:42AM +0200, Marc-André Lureau wrote:
> Hi
>
> > +void spice_usb_drv_install_finished(SpiceUsbDeviceManager *self,
> > + libusb_device *device, int status)
>
> nitpick, It's a bit better to keep same prefix for function name:
> perhaps spice_usb_device_manager_win
Hi,
First of all again what MArc-André said, and also:
diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
index 14b60c9..2b6ce28 100644
--- a/gtk/usb-device-manager.c
+++ b/gtk/usb-device-manager.c
@@ -28,7 +28,14 @@
#ifdef USE_USBREDIR
#include
#include
+#if defined(USE_G
Hi,
What Marc-André said :)
Regards,
Hans
On 05/20/2012 06:34 PM, Uri Lublin wrote:
For windows GUDEV is not required
- GUDEV is alwasy checked as part of USBREDIR, and fails
if USBREDIR but no GUDEV on non-windows.
- Added GUDEV env-variables in gtk/Makefile.am
---
configure.ac|
Looks good, ack.
On 05/20/2012 06:34 PM, Uri Lublin wrote:
This fixes the following compilation error:
channel-usbredir.c: In function 'spice_usbredir_channel_connect_device_async':
channel-usbredir.c:313:9: error: jump skips variable initialization
[-Werror=jump-misses-init]
---
gtk/channel-
16 matches
Mail list logo
