Re: [Spice-devel] [spice-gtk Win32 v2 PATCH 3/5] Windows mingw: usb: add win-usb-dev.[ch]: implement GUdevDevice & GUdevClient

2012-05-21 Thread Marc-André Lureau
Hi > +WIN_USB_FILES= \ > +       win-usb-dev.h                   \ > +       win-usb-dev.c                   \ > +       usbclerk.h                      \ > +       $(NULL) > + > +if OS_WIN32 > +libspice_client_glib_2_0_la_SOURCES += \ > +       $(WIN_USB_FILES) > +else > +EXTRA_DIST += $(WIN_USB_

Re: [Spice-devel] [spice-gtk Win32 v2 PATCH 2/5] Windows mingw: usb: configure.ac: do not require GUDEV for USBREDIR

2012-05-21 Thread Marc-André Lureau
Hi On Sun, May 20, 2012 at 6:34 PM, Uri Lublin wrote: > For windows GUDEV is not required > > - GUDEV is alwasy checked as part of USBREDIR, and fails >  if USBREDIR but no GUDEV on non-windows. misc spelling alwasy/always > - Added GUDEV env-variables in gtk/Makefile.am It's a Makefile variab

Re: [Spice-devel] [spice-gtk Win32 v2 PATCH 4/5] Windows mingw: usb: Dynamically install a libusb driver for USB devices

2012-05-21 Thread Marc-André Lureau
Hi > +void spice_usb_drv_install_finished(SpiceUsbDeviceManager *self, > +     libusb_device *device, int status) nitpick, It's a bit better to keep same prefix for function name: perhaps spice_usb_device_manager_win_device_connect() ? > +{ > +    if (status) { any value of status != 0? I reali

Re: [Spice-devel] [PATCH spice-common] ssl-verify: add a bit of run-time checks

2012-05-21 Thread Hans de Goede
Looks good, ACK. On 05/21/2012 05:28 PM, Marc-André Lureau wrote: ping On Thu, May 17, 2012 at 2:45 PM, Marc-André Lureau wrote: Even if they are not public functions, those conditions can be reached in a invalid state. --- common/ssl_verify.c |5 + 1 file changed, 5 insertions(+)

Re: [Spice-devel] [PATCH spice-gtk] session: correctly set and unset ssl-verify flags

2012-05-21 Thread Hans de Goede
Looks good, ACK. On 05/21/2012 05:28 PM, Marc-André Lureau wrote: ping On Thu, May 17, 2012 at 2:46 PM, Marc-André Lureau wrote: If no cert-subject or pubkey is provided, we should unset the corresponding flags. --- gtk/spice-session.c |8 ++-- spice-common|2 +- 2 f

Re: [Spice-devel] [PATCHv2 win-agent 1/9] build-sys: fix autoreconf -vfi

2012-05-21 Thread Marc-André Lureau
ping On Wed, May 16, 2012 at 8:15 PM, Marc-André Lureau wrote: > --- >  configure.ac |    2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 77d5c25..28c9d23 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -14,7 +14,7 @@ AC_CONFIG_HEAD

Re: [Spice-devel] [PATCH spice-gtk] session: correctly set and unset ssl-verify flags

2012-05-21 Thread Marc-André Lureau
ping On Thu, May 17, 2012 at 2:46 PM, Marc-André Lureau wrote: > If no cert-subject or pubkey is provided, we should unset the corresponding > flags. > --- >  gtk/spice-session.c |    8 ++-- >  spice-common        |    2 +- >  2 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a

Re: [Spice-devel] [PATCH spice-common] ssl-verify: add a bit of run-time checks

2012-05-21 Thread Marc-André Lureau
ping On Thu, May 17, 2012 at 2:45 PM, Marc-André Lureau wrote: > Even if they are not public functions, those conditions can be reached > in a invalid state. > --- >  common/ssl_verify.c |    5 + >  1 file changed, 5 insertions(+) > > diff --git a/common/ssl_verify.c b/common/ssl_verify.c > i

Re: [Spice-devel] QXL on Windows 8

2012-05-21 Thread Alon Levy
On Mon, May 21, 2012 at 10:47:05AM +0200, Mario wrote: > Alon, thank you for your reply. Does this mean there is a bigger step to > support Windows 8? Yes. We need to write a new driver, WDDM one, will probably share much code between it and the current driver. > > > On Mon, 21 May 2012 11:26:1

Re: [Spice-devel] keyboard and Mouse Fails....

2012-05-21 Thread Christophe Fergeau
On Thu, May 17, 2012 at 02:46:32PM -0700, Naga Mohan Pothula wrote: > This issue is not fixed yet. To find out root cause, I disabled VDAgent > at guest and launch session with --full-screen=auto-conf then I'm able to > see this issue. But this issue doesn't happen on all linux clients. I'm > seei

Re: [Spice-devel] [PATCH spice-gtk] Running out of reserved space, break ABI

2012-05-21 Thread Christophe Fergeau
On Mon, May 21, 2012 at 12:26:38PM +0200, Marc-André Lureau wrote: > On Mon, May 21, 2012 at 11:43 AM, Christophe Fergeau > wrote: > > Oh, and before doing that, a 0.13 release would be nice so that we can get > > all the recent git fixes into f17 as an update. > > What fix are you missing? the i

Re: [Spice-devel] [PATCH spice-gtk] Running out of reserved space, break ABI

2012-05-21 Thread Marc-André Lureau
On Mon, May 21, 2012 at 11:43 AM, Christophe Fergeau wrote: > Oh, and before doing that, a 0.13 release would be nice so that we can get > all the recent git fixes into f17 as an update. What fix are you missing? the important fixes have been pushed to f17. -- Marc-André Lureau

Re: [Spice-devel] [PATCH spice-gtk] Running out of reserved space, break ABI

2012-05-21 Thread Marc-André Lureau
On Mon, May 21, 2012 at 11:35 AM, Christophe Fergeau wrote: > The reason for doing this change is not described in the changelog I think. > Are they private structs ? It's mainly for consistency, channels can't be derived. There is no easy way today to override spice_channel_new() and/or provide

Re: [Spice-devel] SASL authentication & plans

2012-05-21 Thread Daniel P. Berrange
On Mon, May 21, 2012 at 12:20:02PM +0200, Tiziano Müller wrote: > Am Montag, den 21.05.2012, 10:57 +0100 schrieb Daniel P. Berrange: > > On Mon, May 21, 2012 at 11:50:48AM +0200, Tiziano Müller wrote: > > > Hi > > > > > > Currently I'm trying to get SASL working and succeeded so far but I've > > >

Re: [Spice-devel] SASL authentication & plans

2012-05-21 Thread Tiziano Müller
Am Montag, den 21.05.2012, 10:57 +0100 schrieb Daniel P. Berrange: > On Mon, May 21, 2012 at 11:50:48AM +0200, Tiziano Müller wrote: > > Hi > > > > Currently I'm trying to get SASL working and succeeded so far but I've > > some questions: > > > > * Is it correct that the username SASL gets is the

Re: [Spice-devel] SASL authentication & plans

2012-05-21 Thread Daniel P. Berrange
On Mon, May 21, 2012 at 11:50:48AM +0200, Tiziano Müller wrote: > Hi > > Currently I'm trying to get SASL working and succeeded so far but I've > some questions: > > * Is it correct that the username SASL gets is the UID of the qemu > process? If yes: what is the plan here (I saw that there's the

[Spice-devel] SASL authentication & plans

2012-05-21 Thread Tiziano Müller
Hi Currently I'm trying to get SASL working and succeeded so far but I've some questions: * Is it correct that the username SASL gets is the UID of the qemu process? If yes: what is the plan here (I saw that there's the username attribute in the RedSASL struct already)? * Is there a way to pass s

Re: [Spice-devel] [PATCH spice-gtk] Running out of reserved space, break ABI

2012-05-21 Thread Christophe Fergeau
On Thu, May 17, 2012 at 04:20:12PM +0200, Marc-André Lureau wrote: > The change abc56811de978ad336a651924a21b920cfe677f0 actually added > a field in a public struct while changing overall struct size, the > fields were also reorder, all of this breaks ABI. > > However, we are running out of free s

Re: [Spice-devel] Precompiled win32 spice-gtk and/or remote-viewer client

2012-05-21 Thread Tiziano Müller
Hoi Marc-André Thanks for the reply. Some time ago I built the spice-gtk client on fedora using mingw32. Since we'll have to ship a custom installer (which sets up the procol handler for 'spice://' style (see http://www.foss-cloud.org/en/index.php/Protocol_Handler_Spice ) I'll probably have to set

Re: [Spice-devel] [PATCH spice-gtk] Running out of reserved space, break ABI

2012-05-21 Thread Christophe Fergeau
Hey, On Thu, May 17, 2012 at 04:20:12PM +0200, Marc-André Lureau wrote: > The change abc56811de978ad336a651924a21b920cfe677f0 actually added > a field in a public struct while changing overall struct size, the > fields were also reorder, all of this breaks ABI. > > However, we are running out of

Re: [Spice-devel] QXL on Windows 8

2012-05-21 Thread Mario
Alon, thank you for your reply. Does this mean there is a bigger step to support Windows 8? On Mon, 21 May 2012 11:26:11 +0300, Alon Levy wrote: On Mon, May 21, 2012 at 10:04:36AM +0200, Mario wrote: Gentlemen, i just tried to compile the latest qxl driver (cloned from GIT) for Windows 8. T

Re: [Spice-devel] QXL on Windows 8

2012-05-21 Thread Alon Levy
On Mon, May 21, 2012 at 10:04:36AM +0200, Mario wrote: > Gentlemen, > > i just tried to compile the latest qxl driver (cloned from GIT) for Windows > 8. The first suprise was the fact that Microsoft introduced a dependency of > having 4 GB Visual Studio installed to use the latest WDK. > > Howeve

[Spice-devel] QXL on Windows 8

2012-05-21 Thread Mario
Gentlemen, i just tried to compile the latest qxl driver (cloned from GIT) for Windows 8. The first suprise was the fact that Microsoft introduced a dependency of having 4 GB Visual Studio installed to use the latest WDK. However the "dirs" file has been converted perfectly. Additional there

Re: [Spice-devel] Image size of the instance VM (qcow2 format)

2012-05-21 Thread Charles . Tsai-蔡清海-研究發展部
Alon, No, our running VM does nothing and it simply just stays in idle. That is the reason we do not know why the image size of the instance VM keeps growing. I posted this issue to qemu-devel for helpful opinions. Thanks. -Original Message- From: Alon Levy [mailto:al...@redhat.com] S

Re: [Spice-devel] Image size of the instance VM (qcow2 format)

2012-05-21 Thread Alon Levy
On Mon, May 21, 2012 at 06:01:05AM +, Charles.Tsai-蔡清海-研究發展部 wrote: > Hi Alon, > > Do you have any idea about this issue? We doubt this issue is caused by the > Windows swap file(virtual memory) that Windows OS pages the memory contents > to it during the run-time. However, we did disable th