Re: [Spice-devel] Render measurements

2012-05-10 Thread Søren Sandmann
Yonit Halperin writes: > Did you check if there are other operations, besides the "nomask" > ones, that can be translated to the current QXL_DRAW commands, mainly > the QXL_DRAW_ROP3 one? Well, X does have some raster ops but they are very rarely used in newer applications. > * The number of ca

Re: [Spice-devel] Memory leak in spice server

2012-05-10 Thread Charles . Tsai-蔡清海-研究發展部
Alon, Yonit gave us a patch and we are verifying it. Will let you know if this patch fixes this issue. -Original Message- From: Alon Levy [mailto:al...@redhat.com] Sent: Thursday, May 10, 2012 1:46 PM To: Charles.Tsai-蔡清海-研究發展部 Cc: spice-devel@lists.freedesktop.org Subje

[Spice-devel] [PATCH 2/2] server/mjpeg_encoder: fix wrong size assigned to dest_len

2012-05-10 Thread Yonit Halperin
It should have been the allocated size and not the occupied one. This led to a lot of unnecessary allocations and deallocations. --- server/mjpeg_encoder.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/server/mjpeg_encoder.c b/server/mjpeg_encoder.c index 3c2fc31..6bb2f

[Spice-devel] [PATCH 1/2] server/mjpeg_encoder: Fix memory leak for the inital output buffer given for each frame

2012-05-10 Thread Yonit Halperin
--- server/mjpeg_encoder.c | 11 +++ server/mjpeg_encoder.h |5 + 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/server/mjpeg_encoder.c b/server/mjpeg_encoder.c index 9c3d079..3c2fc31 100644 --- a/server/mjpeg_encoder.c +++ b/server/mjpeg_encoder.c @@ -101,7 +101,

Re: [Spice-devel] Memory leak in spice server

2012-05-10 Thread Charles . Tsai-蔡清海-研究發展部
Yonit, I will let you know after we verify it. Thanks. -Original Message- From: Yonit Halperin [mailto:yhalp...@redhat.com] Sent: Thursday, May 10, 2012 5:31 PM To: Charles.Tsai-蔡清海-研究發展部 Cc: Alon Levy; spice-devel@lists.freedesktop.org Subject: Re: [Spice-devel] Memory l

Re: [Spice-devel] Memory leak in spice server

2012-05-10 Thread Yonit Halperin
Hi, I think I found a memory leak. The *first* buffer that was given as an output buffer to the mjpeg encoder when encoding a frame, wasn't released when it was replaced by a bigger buffer. Can you check if the attached patch helps? Thanks, Yonit. On 05/10/2012 05:52 AM, Charles.Tsai-蔡清海-研究

Re: [Spice-devel] USB support

2012-05-10 Thread Hans de Goede
Hi, On 05/09/2012 04:11 PM, Nerijus Baliunas wrote: Hello, What is the best option for USB support in ovirt Windows guests now? I see there are quite a lot of recent patches in this area. That depends mostly on which OS you're running on the client, if you're running Linux clients I would use

Re: [Spice-devel] [PATCH spice-gtk] python: fix Spice.Audio binding

2012-05-10 Thread Hans de Goede
ACK. On 05/10/2012 02:59 AM, Marc-André Lureau wrote: The spice_audio_new() function is not correctly generated h2def.py anymore because of the surrounding #ifdef and macros. Add it in the manual.defs instead. Avoid API breakage: 2012-05-10 01:56:48,884 (cli:83): Uncaught exception: Traceback (