Re: [Spice-devel] [protocol RFC 0/2] RANDR support via QXLHead + SpiceHead

2012-05-07 Thread Noel Van Hook
How far away is a multi-head solution, do you think? It sounds like most of the work is in the client and the X driver? Noel On Mon, May 7, 2012 at 12:28 AM, Alon Levy wrote: > Hi, > >  Currently we support multiple monitors by having: >  single pci = single display channel = single client window

Re: [Spice-devel] [spice-gtk Win32 PATCH 3/7] Windows: add win-usb-dev.[ch]: implement GUdevDevice & GUdevClient

2012-05-07 Thread Marc-André Lureau
Hi On Mon, May 7, 2012 at 3:15 PM, Uri Lublin wrote: > From: Arnon Gilboa > > With this patch usb-device-manager can work with little change > on windows too. > > -add uevent signal based on WM_DEVICECHANGE > -add spice_usb_device_manager_set_window for setting winproc >   (which is needed for e

Re: [Spice-devel] [spice-gtk Win32 PATCH 2/7] configure.ac: add --enable_gudev

2012-05-07 Thread Marc-André Lureau
ack On Mon, May 7, 2012 at 3:15 PM, Uri Lublin wrote: > Instead of requiring it when usbredir is configured. > > The default value is "auto", which is "yes" for linux and "no" for Windows > --- >  configure.ac    |   29 - >  gtk/Makefile.am |    2 ++ >  2 files changed

Re: [Spice-devel] [spice-gtk Win32 PATCH 1/7] Move "err" variable definition to beginning of the function

2012-05-07 Thread Marc-André Lureau
ack On Mon, May 7, 2012 at 3:15 PM, Uri Lublin wrote: > This fixes the following compilation error: > channel-usbredir.c: In function 'spice_usbredir_channel_connect_device_async': > channel-usbredir.c:313:9: error: jump skips variable initialization > [-Werror=jump-misses-init] > --- >  gtk/cha

[Spice-devel] Render measurements

2012-05-07 Thread Søren Sandmann
This branch here: http://cgit.freedesktop.org/~sandmann/xf86-video-qxl/log/?h=trackimages will produce various types of information in the X log file when the option "EnableImageStats" is given in xorg.conf. Specifically, it will track whenever an operation triggers a fallback and record the

Re: [Spice-devel] [protocol RFC 0/2] RANDR support via QXLHead + SpiceHead

2012-05-07 Thread Gerd Hoffmann
Hi, >> Are we going to have one more input/cursor channel per head? Probably >> not, but it would be nice to specify. I guess the coordinate will need >> to be adjusted to the respective heads. (ie some messages will be >> relative to heads, other to primary surface: INPUTS_MOUSE_POSITION vs >>

Re: [Spice-devel] [usbredir PATCH 6/6] usbredirfilter: fix filter parsing for windows (mingw)

2012-05-07 Thread Uri Lublin
On 05/03/2012 07:09 PM, Christophe Fergeau wrote: On Thu, May 03, 2012 at 06:04:39PM +0300, Uri Lublin wrote: From: Arnon Gilboa no strtok_r (reentrent) available, so use strtok instead. Wouldn't it be safer to use strtok_s? Any application using threads and strtok and libusbredirparser could

Re: [Spice-devel] [protocol RFC 0/2] RANDR support via QXLHead + SpiceHead

2012-05-07 Thread Alon Levy
On Mon, May 07, 2012 at 02:16:09PM +0200, Marc-André Lureau wrote: > On Mon, May 7, 2012 at 8:28 AM, Alon Levy wrote: > >  RANDR introduces a concept of a CRTC and an OUTPUT. The CRTC scansout a > >  portion of the framebuffer onto one or more OUTPUTs. I propose having a > > 1:1 CRTC:OUTPUT corre

[Spice-devel] [spice-gtk Win32 PATCH 7/7] win-usb-dev: replace sprintf with snprintf

2012-05-07 Thread Uri Lublin
--- gtk/win-usb-dev.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/gtk/win-usb-dev.c b/gtk/win-usb-dev.c index 0a154f6..8a4f268 100644 --- a/gtk/win-usb-dev.c +++ b/gtk/win-usb-dev.c @@ -192,9 +192,9 @@ gboolean get_usb_dev_info(libusb_device *dev, GUdevDeviceInf

[Spice-devel] [spice-gtk Win32 PATCH 6/7] Windows: spicy: listen to USB device plug/unplug events

2012-05-07 Thread Uri Lublin
--- gtk/spicy.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/gtk/spicy.c b/gtk/spicy.c index f44642f..4c9708b 100644 --- a/gtk/spicy.c +++ b/gtk/spicy.c @@ -1319,6 +1319,21 @@ static SpiceWindow *create_spice_window(spice_connection *conn, int id, SpiceC

[Spice-devel] [spice-gtk Win32 PATCH 5/7] Windows usb: Comment out some memory cleanups not working on Windows

2012-05-07 Thread Uri Lublin
It's not nice, but better than crashing. --- gtk/usb-device-manager.c |9 + gtk/usbutil.c|1 + 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c index b60f1f0..377b774 100644 --- a/gtk/usb-device-manager.

[Spice-devel] [spice-gtk Win32 PATCH 4/7] Windows: Install libusb driver dynamically when usbredir'ing a USB device

2012-05-07 Thread Uri Lublin
- Added win-usb-driver-install.[ch] - Added usbclerk.h Operation (on Windows): - After some sanity checks, just before redir'ing a USB device a libusb driver needs to be installed (before libusb can open/access it). - A connection (NamedPipe) is established with usb-clerk, a libusb driver inst

[Spice-devel] [spice-gtk Win32 PATCH 3/7] Windows: add win-usb-dev.[ch]: implement GUdevDevice & GUdevClient

2012-05-07 Thread Uri Lublin
From: Arnon Gilboa With this patch usb-device-manager can work with little change on windows too. -add uevent signal based on WM_DEVICECHANGE -add spice_usb_device_manager_set_window for setting winproc (which is needed for event registration) Modified-by: Uri Lublin --- gtk/Makefile.am

[Spice-devel] [spice-gtk Win32 PATCH 2/7] configure.ac: add --enable_gudev

2012-05-07 Thread Uri Lublin
Instead of requiring it when usbredir is configured. The default value is "auto", which is "yes" for linux and "no" for Windows --- configure.ac| 29 - gtk/Makefile.am |2 ++ 2 files changed, 30 insertions(+), 1 deletions(-) diff --git a/configure.ac b/confi

[Spice-devel] [spice-gtk Win32 PATCH 1/7] Move "err" variable definition to beginning of the function

2012-05-07 Thread Uri Lublin
This fixes the following compilation error: channel-usbredir.c: In function 'spice_usbredir_channel_connect_device_async': channel-usbredir.c:313:9: error: jump skips variable initialization [-Werror=jump-misses-init] --- gtk/channel-usbredir.c |4 +++- 1 files changed, 3 insertions(+), 1 del

[Spice-devel] [spice-gtk Win32 PATCH 0/7] usb-redir support for Windows (mingw32)

2012-05-07 Thread Uri Lublin
Hello, This patchset enables usb-redir support in spice-gtk running on Windows. Patches 1 and 2 fix compilation with mingw32 (e.g. no gudev) Patch 3 adds GUdev like implementation for windows: - listening for USB device plug/unplug evevnts. - notifying registerees of such events. - provide

Re: [Spice-devel] [PATCH] server/reds: add "usbredir" to recognized channel names

2012-05-07 Thread Alon Levy
On Mon, May 07, 2012 at 02:19:43PM +0200, Marc-André Lureau wrote: > On Mon, May 7, 2012 at 1:37 PM, Alon Levy wrote: > > RHBZ: 819484 > > > > Signed-off-by: Alon Levy > > --- > >  server/reds.c |    1 + > >  1 file changed, 1 insertion(+) > > > > diff --git a/server/reds.c b/server/reds.c > > in

Re: [Spice-devel] [PATCH] server/reds: add "usbredir" to recognized channel names

2012-05-07 Thread Marc-André Lureau
On Mon, May 7, 2012 at 1:37 PM, Alon Levy wrote: > RHBZ: 819484 > > Signed-off-by: Alon Levy > --- >  server/reds.c |    1 + >  1 file changed, 1 insertion(+) > > diff --git a/server/reds.c b/server/reds.c > index 1696fbc..26d6f89 100644 > --- a/server/reds.c > +++ b/server/reds.c > @@ -3971,6 +3

Re: [Spice-devel] [protocol RFC 0/2] RANDR support via QXLHead + SpiceHead

2012-05-07 Thread Marc-André Lureau
On Mon, May 7, 2012 at 8:28 AM, Alon Levy wrote: >  RANDR introduces a concept of a CRTC and an OUTPUT. The CRTC scansout a >  portion of the framebuffer onto one or more OUTPUTs. I propose having a 1:1 > CRTC:OUTPUT correspondence and introducing two new commands, one on PCI and > one for the p

Re: [Spice-devel] [protocol RFC 0/2] RANDR support via QXLHead + SpiceHead

2012-05-07 Thread Alon Levy
On Mon, May 07, 2012 at 01:57:37PM +0200, Gerd Hoffmann wrote: > On 05/07/12 12:28, Alon Levy wrote: > > On Mon, May 07, 2012 at 12:01:42PM +0200, Gerd Hoffmann wrote: > >> Hi, > >> > >>> But there is no concept of an additional surface in the guest driver. > >>> RANDR 1.2 (and I think the same f

Re: [Spice-devel] [protocol RFC 2/2] protocol: add SPICE_DISPLAY_CAP_HEAD

2012-05-07 Thread Alon Levy
On Mon, May 07, 2012 at 01:43:58PM +0200, Marc-André Lureau wrote: > On Mon, May 7, 2012 at 8:29 AM, Alon Levy wrote: > > Signifies that the client will support any SpiceDisplayMsgHead sent. > > What happens if the server has the capability but not the client? > > Should the client show the whol

Re: [Spice-devel] [protocol RFC 0/2] RANDR support via QXLHead + SpiceHead

2012-05-07 Thread Gerd Hoffmann
On 05/07/12 12:28, Alon Levy wrote: > On Mon, May 07, 2012 at 12:01:42PM +0200, Gerd Hoffmann wrote: >> Hi, >> >>> But there is no concept of an additional surface in the guest driver. >>> RANDR 1.2 (and I think the same for 1.3, 1.4, since we don't have per >>> CRTC pixmaps) has a single screen

Re: [Spice-devel] [protocol RFC 2/2] protocol: add SPICE_DISPLAY_CAP_HEAD

2012-05-07 Thread Marc-André Lureau
On Mon, May 7, 2012 at 8:29 AM, Alon Levy wrote: > Signifies that the client will support any SpiceDisplayMsgHead sent. What happens if the server has the capability but not the client? Should the client show the whole primary surface with its multiple heads, or quit with an error? Can the serve

[Spice-devel] [PATCH] server/reds: add "usbredir" to recognized channel names

2012-05-07 Thread Alon Levy
RHBZ: 819484 Signed-off-by: Alon Levy --- server/reds.c |1 + 1 file changed, 1 insertion(+) diff --git a/server/reds.c b/server/reds.c index 1696fbc..26d6f89 100644 --- a/server/reds.c +++ b/server/reds.c @@ -3971,6 +3971,7 @@ SPICE_GNUC_VISIBLE int spice_server_set_channel_security(Spice

Re: [Spice-devel] [protocol RFC 0/2] RANDR support via QXLHead + SpiceHead

2012-05-07 Thread Alon Levy
On Mon, May 07, 2012 at 01:36:03PM +0300, Alon Levy wrote: > On Mon, May 07, 2012 at 01:28:58PM +0300, Alon Levy wrote: > > On Mon, May 07, 2012 at 12:01:42PM +0200, Gerd Hoffmann wrote: > > > Hi, > > > > > > > But there is no concept of an additional surface in the guest driver. > > > > RANDR 1

Re: [Spice-devel] [protocol RFC 0/2] RANDR support via QXLHead + SpiceHead

2012-05-07 Thread Alon Levy
On Mon, May 07, 2012 at 01:28:58PM +0300, Alon Levy wrote: > On Mon, May 07, 2012 at 12:01:42PM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > But there is no concept of an additional surface in the guest driver. > > > RANDR 1.2 (and I think the same for 1.3, 1.4, since we don't have per > > > CR

Re: [Spice-devel] [protocol RFC 0/2] RANDR support via QXLHead + SpiceHead

2012-05-07 Thread Alon Levy
On Mon, May 07, 2012 at 12:01:42PM +0200, Gerd Hoffmann wrote: > Hi, > > > But there is no concept of an additional surface in the guest driver. > > RANDR 1.2 (and I think the same for 1.3, 1.4, since we don't have per > > CRTC pixmaps) has a single screen wide pixmap. A screen is one per X > >

Re: [Spice-devel] [protocol RFC 0/2] RANDR support via QXLHead + SpiceHead

2012-05-07 Thread Gerd Hoffmann
Hi, > But there is no concept of an additional surface in the guest driver. > RANDR 1.2 (and I think the same for 1.3, 1.4, since we don't have per > CRTC pixmaps) has a single screen wide pixmap. A screen is one per X > server, so there is just one even if you have multiple heads. And the > CRT

Re: [Spice-devel] [spice-common PATCH] rect.h: rename variable "small" to "sml"

2012-05-07 Thread Uri Lublin
On 05/07/2012 11:22 AM, Yaniv Kaul wrote: - Original Message - Hi, Hmm I don't really like the name sml, but I cannot come up with anything better, so: ACK. small_rect and big_rect? Y. Fine, I'll send another patch. thanks, Uri. ___ S

Re: [Spice-devel] [protocol RFC 0/2] RANDR support via QXLHead + SpiceHead

2012-05-07 Thread Alon Levy
On Mon, May 07, 2012 at 09:03:02AM +0200, Gerd Hoffmann wrote: > Hi, > > > 1. Guest enables a new monitor: > > 2. Guest pushes QXLHead command to command ring > > 3. Server sends SpiceHead message on the ring's display channel. > > 4. Client creates a window out of [x, y, width, height] scan

Re: [Spice-devel] [spice-common PATCH] rect.h: rename variable "small" to "sml"

2012-05-07 Thread Yaniv Kaul
- Original Message - > Hi, > > Hmm I don't really like the name sml, but I cannot come > up with anything better, so: ACK. small_rect and big_rect? Y. > > Regards, > > Hans > > > On 05/07/2012 09:41 AM, Uri Lublin wrote: > > Apparently when compiling spice-gtk with mingw, small is de

Re: [Spice-devel] [spice-common PATCH] rect.h: rename variable "small" to "sml"

2012-05-07 Thread Hans de Goede
Hi, Hmm I don't really like the name sml, but I cannot come up with anything better, so: ACK. Regards, Hans On 05/07/2012 09:41 AM, Uri Lublin wrote: Apparently when compiling spice-gtk with mingw, small is defined as char. I found the following in rpcndr.h under mingw/include (not sure wha

[Spice-devel] [spice-common PATCH] rect.h: rename variable "small" to "sml"

2012-05-07 Thread Uri Lublin
Apparently when compiling spice-gtk with mingw, small is defined as char. I found the following in rpcndr.h under mingw/include (not sure what includes it) #define small char This fixes the following compilation errer: In file included from ../spice-common/common/canvas_base.c:36:0,

Re: [Spice-devel] [protocol RFC 0/2] RANDR support via QXLHead + SpiceHead

2012-05-07 Thread Hans de Goede
Hi, On 05/07/2012 09:03 AM, Gerd Hoffmann wrote: Hi, 1. Guest enables a new monitor: 2. Guest pushes QXLHead command to command ring 3. Server sends SpiceHead message on the ring's display channel. 4. Client creates a window out of [x, y, width, height] scanning out of the primary

Re: [Spice-devel] [protocol RFC 0/2] RANDR support via QXLHead + SpiceHead

2012-05-07 Thread Gerd Hoffmann
Hi, > 1. Guest enables a new monitor: > 2. Guest pushes QXLHead command to command ring > 3. Server sends SpiceHead message on the ring's display channel. > 4. Client creates a window out of [x, y, width, height] scanning out of the > primary surface (there is one associated primary with th