Hi,
On 04/18/2012 12:43 AM, nicolas prochazka wrote:
hello,
git bisect tells me that's this commit seems to be the bad.
f9344933bcc1425cf1e8142dc2f8321522dc00af is the first bad commit
commit f9344933bcc1425cf1e8142dc2f8321522dc00af
Author: Alon Levy
Date: Fri Feb 24 23:19:29 2012 +0200
Note, there may be line-ending issues here is we are not careful. This file is
a msdos formatted file.
There was some inconsistencies in those line-ending that I have normalized.
Signed-off-by: Aric Stewart
---
client/windows/redc.vcproj | 84 ++--
1
hello,
git bisect tells me that's this commit seems to be the bad.
f9344933bcc1425cf1e8142dc2f8321522dc00af is the first bad commit
commit f9344933bcc1425cf1e8142dc2f8321522dc00af
Author: Alon Levy
Date: Fri Feb 24 23:19:29 2012 +0200
qxl: remove flipped
Tested on linux and windows g
Hi,
On 04/17/2012 04:58 PM, nicolas prochazka wrote:
I've also tested with :
qemu last git master : segfault
qemu 1.0.1 : ok
spice from git master.
Ah, then it is likely caused by the qxl fixes I recently
cherry-picked into my tree. Can you try checking out
commit 4c245e5ecbc7d5c30c8e8bb4bfcd
This involves:
generating .c instead of .cpp files
Not including "common.h"
Standardizing some parameters
Signed-off-by: Aric Stewart
---
client/windows/generate.bat |4 ++--
client/windows/generate1.bat |4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/client/w
Yeah, i am wondering a bit about this also.
I know under c++ sizeof and empty struct will return 1
gnu c will return 0
msvc++ fails.
adding a uint8_t padding member will make it always return 1. I am not
sure if that is going to be an issue.
I am totally not an expert on the wire protocol, w
Not sure if this applies since I'm looking at the spice-gtk 0.11 source, but
the generated_demarshallers.c code includes a function parse_SpiceMsgEmpty.
Within it it uses "sizeof(SpiceMsgEmpty)" and some pointer/allocator math for
demarshalling a SpiceEmptyMsg. I'm no expert here, but I would th
On Tue, Apr 17, 2012 at 08:05:04PM +0400, Michael Tokarev wrote:
> The error_{1,2} labels in this functions are backwards.
ACK, pushing.
>
> Signed-off-by: Michael Tokarev
> ---
> server/snd_worker.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/server/snd_wo
Hey,
Good catch, ack.
Christophe
On Tue, Apr 17, 2012 at 08:05:04PM +0400, Michael Tokarev wrote:
> The error_{1,2} labels in this functions are backwards.
>
> Signed-off-by: Michael Tokarev
> ---
> server/snd_worker.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff -
On Tue, Apr 17, 2012 at 06:58:59PM +0300, Alon Levy wrote:
> On Tue, Apr 17, 2012 at 09:36:52AM -0500, Aric Stewart wrote:
> > ---
> > common/log.c | 12
> > 1 files changed, 12 insertions(+), 0 deletions(-)
> >
>
> ACK and pushing.
>
> > diff --git a/common/log.c b/common/log.c
Empty structures are undefined in C, gcc handles them without issue
assigning a size of 0. However MSVC++ generates a hard error (C2015)
this allows messages.h to be included in c files compiled by MSVC++.
Signed-off-by: Aric Stewart
---
common/messages.h |1 +
1 files changed, 1 insertio
The error_{1,2} labels in this functions are backwards.
Signed-off-by: Michael Tokarev
---
server/snd_worker.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/snd_worker.c b/server/snd_worker.c
index 7bdd399..caffe67 100644
--- a/server/snd_worker.c
+++ b/server
On Tue, Apr 17, 2012 at 09:36:52AM -0500, Aric Stewart wrote:
> ---
> common/log.c | 12
> 1 files changed, 12 insertions(+), 0 deletions(-)
>
ACK and pushing.
> diff --git a/common/log.c b/common/log.c
> index ef4da06..3cbcef6 100644
> --- a/common/log.c
> +++ b/common/log.c
> @
On Tue, Apr 17, 2012 at 08:15:22AM -0500, Aric Stewart wrote:
> Hello all,
>
> Working away at making the current tip of spice build the win32 client. I
> have run into another problem.
>
> Since the last working win32 cllient build the code generated by
> spice_codegen.py has shifted from C
It is not an MFC project so simply including windef.h is better and
allows for compiling with the Express editions of Visual Studio.
---
client/windows/redc.rc |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/client/windows/redc.rc b/client/windows/redc.rc
index 5f08539.
I've also tested with :
qemu last git master : segfault
qemu 1.0.1 : ok
spice from git master.
( windows guest with qxl install ) ,
vnc client connect , switch to 640x480 -> 1024x768 => segfault.
or connect with vnc client when windows guest boot ( connect just
after bios boot, before vga switchi
---
common/log.c | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/common/log.c b/common/log.c
index ef4da06..3cbcef6 100644
--- a/common/log.c
+++ b/common/log.c
@@ -22,7 +22,9 @@
#include
#include
#include
+#ifndef _MSC_VER
#include
+#endif
#include
Hello all,
Working away at making the current tip of spice build the win32
client. I have run into another problem.
Since the last working win32 cllient build the code generated by
spice_codegen.py has shifted from CPP files to C files. The generated
files include messages.h.
Inside
On 04/17/2012 01:12 PM, Yonit Halperin wrote:
Also replaced sprintf with snprintf
---
server/red_worker.c | 14 --
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 5350195..99a8948 100644
--- a/server/red_worker.c
+++
Series looks good.
Christophe
On Tue, Apr 17, 2012 at 01:12:10PM +0300, Yonit Halperin wrote:
> ---
> common/rect.h | 11 +++
> 1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/common/rect.h b/common/rect.h
> index a63d785..655e9e8 100644
> --- a/common/rect.h
> +++
On Tue, Apr 17, 2012 at 02:11:13PM +0200, Christophe Fergeau wrote:
> On Tue, Apr 17, 2012 at 02:51:33PM +0300, Alon Levy wrote:
> > On Tue, Apr 17, 2012 at 01:37:26PM +0200, Christophe Fergeau wrote:
> > > On Tue, Apr 17, 2012 at 01:46:26PM +0300, Alon Levy wrote:
> > > > On Tue, Apr 17, 2012 at 0
Hi,
On 04/17/2012 02:13 PM, nicolas prochazka wrote:
hello,
sorry i'm already using qemu-kvm-1.0-usbredir for my test
not qemu-1.0-usbredir.
I'm using spice from git master. (
2439c0dc90bcfd83d3e0eb4f08f19ef2face2118 ) april 5
Looks like you've found a real bug then :| I'll put looking
into t
hello,
sorry i'm already using qemu-kvm-1.0-usbredir for my test
not qemu-1.0-usbredir.
I'm using spice from git master. (
2439c0dc90bcfd83d3e0eb4f08f19ef2face2118 ) april 5
Regards,
Nicolas Prochazka.
2012/4/17 Hans de Goede :
> Hi,
>
>
> On 04/17/2012 12:42 PM, nicolas prochazka wrote:
>>
>> H
On Tue, Apr 17, 2012 at 02:51:33PM +0300, Alon Levy wrote:
> On Tue, Apr 17, 2012 at 01:37:26PM +0200, Christophe Fergeau wrote:
> > On Tue, Apr 17, 2012 at 01:46:26PM +0300, Alon Levy wrote:
> > > On Tue, Apr 17, 2012 at 01:12:26PM +0300, Yonit Halperin wrote:
> > > > ---
> > > > server/red_worke
Ah, my apologies. I will admit I have a bit of a hybrid environment. I
do almost all my development on my mac and have a windows box for
testing/building. It must have been during my editing of the file in vi
that it got the EOL characters changed.
I will modify my git send formatting to not
Hello Attila
I have to agree. Performance in terms of video playback is terrible (they're
saying that it's now possible with sr3). But they were much better on vpn than
we are.
Lubos
On Apr 14, 2012, at 11:05 AM, Attila Sukosd wrote:
> Hi,
>
> As someone already mentioned, Sunrays use their
On Tue, Apr 17, 2012 at 01:37:26PM +0200, Christophe Fergeau wrote:
> On Tue, Apr 17, 2012 at 01:46:26PM +0300, Alon Levy wrote:
> > On Tue, Apr 17, 2012 at 01:12:26PM +0300, Yonit Halperin wrote:
> > > ---
> > > server/red_worker.c |5 +++--
> > > 1 files changed, 3 insertions(+), 2 deletions
Hi,
On 04/17/2012 12:42 PM, nicolas prochazka wrote:
Hello,
I'm using qemu 1.0-usbredir from hans git.
If i'm starting a windows guest with :
/usr/local/bin/qemu -name TEST_QXL010 -readconfig
/etc/ich9-ehci-uhci.cfg -device usb-tablet -spice
addr=10.98.98.1,port=11959,disable-ticketing -vga
On Tue, Apr 17, 2012 at 01:46:26PM +0300, Alon Levy wrote:
> On Tue, Apr 17, 2012 at 01:12:26PM +0300, Yonit Halperin wrote:
> > ---
> > server/red_worker.c |5 +++--
> > 1 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/server/red_worker.c b/server/red_worker.c
> > index
Hi Nicolas,
does it happen when you omit usbredir devices?
David
nicolas prochazka píše v Út 17. 04. 2012 v 12:42 +0200:
> Hello,
> I'm using qemu 1.0-usbredir from hans git.
> If i'm starting a windows guest with :
>
> /usr/local/bin/qemu -name TEST_QXL010 -readconfig
> /etc/ich9-ehci-uhci
On 04/17/2012 01:46 PM, Alon Levy wrote:
On Tue, Apr 17, 2012 at 01:12:26PM +0300, Yonit Halperin wrote:
---
server/red_worker.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 07782c8..5350195 100644
--- a/server/re
On Tue, Apr 17, 2012 at 01:12:26PM +0300, Yonit Halperin wrote:
> ---
> server/red_worker.c |5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 07782c8..5350195 100644
> --- a/server/red_worker.c
> +++ b/server/red_wo
Hello,
I'm using qemu 1.0-usbredir from hans git.
If i'm starting a windows guest with :
/usr/local/bin/qemu -name TEST_QXL010 -readconfig
/etc/ich9-ehci-uhci.cfg -device usb-tablet -spice
addr=10.98.98.1,port=11959,disable-ticketing -vga qxl -device
virtio-serial -chardev spicevmc,id=vdagent,d
---
gtk/channel-display-priv.h |5 +
gtk/channel-display.c | 19 +++
2 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/gtk/channel-display-priv.h b/gtk/channel-display-priv.h
index 1969697..8aac8d8 100644
--- a/gtk/channel-display-priv.h
+++ b/gtk/chann
When a channel receives SPICE_MSG_QOS_QUERY, it responds to the server
with SPICE_MSGC_QOS_ACK right after it recieves one more message.
---
gtk/channel-base.c |7 +++
gtk/spice-channel-priv.h |3 +++
gtk/spice-channel.c | 22 ++
spice-common
When playing a youtube video on Windows guest, the driver sometimes sends
images which contain the videe frames, but also other parts of the
screen (e.g., the you tube process bar). In order to prevent glitches, we send
these
images as part of the stream, using SPICE_MSG_DISPLAY_STREAM_DATA_SIZED.
---
server/red_worker.c | 49 +
1 files changed, 49 insertions(+), 0 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 6c86ba8..b55860b 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -80,6 +80,7 @@
#include
Previously, the mjpeg quality was always 70. The frame rate was tuned
according to the frames' congestion in the pipe.
This patch sets the mjpeg quality and frame rate according
to the compressed size of the frames and the currently available bit
rate.
The compression size is estimated for differen
The mjpeg_encoder should be client specific, and not shared between
different clients**, for the following reasons:
(1) Since we use abbreviated jpeg datastream for mjpeg, employing the same
mjpeg_encoder for different clients might cause errors when the
clients decode the jpeg data.
(2) Th
---
server/red_worker.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 2de96d2..1e74662 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -9719,6 +9719,7 @@ static CommonChannelClient
*common_channel_client_
If the client's channel has SPICE_COMMON_CAP_QOS_QUERY, the server
channel's can send it SPICE_MSG_QOS_QUERY. The client is supposed to
respond by SPICE_MSG_QOS_ACK right after it receives the one message
that follows SPICE_MSG_QOS_QUERY.
For channels that are characterized mainly by transmissions
display channel: Supplying timeouts interface to red_channel, in order to allow
periodic network monitoring (see next 2 patches).
---
server/red_worker.c | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index c66e397..
Each thread can create a spice_timer_queue, for managing its
own timers.
---
server/Makefile.am |2 +
server/spice_timer_queue.c | 266
server/spice_timer_queue.h | 41 +++
3 files changed, 309 insertions(+), 0 deletions(-)
create mo
When playing a youtube video on Windows guest, the driver sometimes sends
images which contain the video frames, but also other parts of the
screen (e.g., the youtube process bar). In order to prevent glitches, we send
these
images as part of the stream, using SPICE_MSG_DISPLAY_STREAM_DATA_SIZED.
spice-common changes: STREAM_DATA_SIZED message was added in order to support
video streams with frames that their size is different from the initial size
that the stream was created with.
This patch also includes server and client adjustments to the new
SpiceMsgDisplayStreamData.
---
client/disp
Also replaced sprintf with snprintf
---
server/red_worker.c | 14 --
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 5350195..99a8948 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -1014,7 +1014,7 @@ static
---
server/red_worker.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 07782c8..5350195 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -11348,10 +11348,11 @@ static void dump_bitmap(RedWorker *worker,
Spi
If the client's channel has SPICE_COMMON_CAP_QOS_QUERY,
the server's channel can send SPICE_MSG_QOS_QUERY to the client.
In response, the client is expected to send back SPICE_MSG_QOS_ACK
immediately after it receives the message following the query, and
before handling the message. The server can
Add SPICE_MSG_DISPLAY_STREAM_DATA_SIZED, for stream_data message
that also contains the size and destination box of the data.
The server can send such messages only to clients with
SPICE_DISPLAY_CAP_SIZED_STREAM.
---
common/messages.h | 15 ++-
spice.proto | 19 ++
For STREAM_DATA_SIZED and QOS_QUERY messages.
---
spice-protocol |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/spice-protocol b/spice-protocol
index 2d24f61..c921863 16
--- a/spice-protocol
+++ b/spice-protocol
@@ -1 +1 @@
-Subproject commit 2d24f61aae4f92746940fd1c
---
common/rect.h | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/common/rect.h b/common/rect.h
index 655e9e8..a9c1b08 100644
--- a/common/rect.h
+++ b/common/rect.h
@@ -80,6 +80,11 @@ static INLINE int rect_contains(const SpiceRect *big, const
SpiceRect *small)
---
common/rect.h | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/common/rect.h b/common/rect.h
index a63d785..655e9e8 100644
--- a/common/rect.h
+++ b/common/rect.h
@@ -74,6 +74,12 @@ static INLINE int rect_is_same_size(const SpiceRect *r1,
const SpiceRect *r2
If the client's channel has SPICE_COMMON_CAP_QOS_QUERY,
the server's channel can send SPICE_MSG_QOS_QUERY to the client.
In response, the client is expected to send back SPICE_MSG_QOS_ACK
immediately after it receives the message following the query, and
before handling this message. The server can
Add SPICE_MSG_DISPLAY_STREAM_DATA_SIZED, for stream_data message
that in addition to the mjpeg data, also contains the
(1) width and height of the compressed frame.
(2) the destination box of the frame.
The server can send such messages only to clients with
SPICE_DISPLAY_CAP_SIZED_STREAM.
When pla
Diff from v1:
- spice-protocol: more details in commit message
- spice-common:
- squashed the copy-paste fix for rect_get_area to the right patch
- removed the ring_add_tail patch
- spice:
- refactored the mjpeg quality/fps tuning; I moved it to mjpeg_encoder, and
also made some s
Hello
-device qxl adds one more qxl device to your guest. In fact it will open you
one more client window in case thatyou have proper drivers installed. Each
client window represents display on the guest.
So it's not multi session.
Lubos
- Original Message -
From: "周伟"
To: "spice-dev
Hi
what does spice multi monitor mean? Does it mean one computer with 2 or more
monitors? or multi session, that can support more than one spicy from
different computer.
I was trying to use spice in ubuntu 10.04.4, and I start win7 guest with -vga
qxl -device qxl, and see 2 graphic cards in dev
Great news Alon, Aric.
Lubos
- Original Message -
From: "Alon Levy"
To: "Aric Stewart"
Cc: spice-devel@lists.freedesktop.org
Sent: Tuesday, April 17, 2012 9:34:11 AM
Subject: Re: [Spice-devel] Introduction and Hello
On Mon, Apr 16, 2012 at 02:25:33PM -0500, Aric Stewart wrote:
> Hello,
On Mon, Apr 16, 2012 at 01:10:01PM -0500, Aric Stewart wrote:
>
> the python script is now in spice-common and client_marshallers.h needs to
> be included instead of marshallers.h
Third, the patch doesn't apply because of EOL issues. You should be
using no EOL convertion magic. If you use msysgit
On Mon, Apr 16, 2012 at 01:10:01PM -0500, Aric Stewart wrote:
>
In the future could you send the patches inlined and not attached? I use
git format-patch or git send-email directly.
> the python script is now in spice-common and client_marshallers.h needs to
> be included instead of marshallers.
On Mon, Apr 16, 2012 at 02:25:33PM -0500, Aric Stewart wrote:
> Hello,
>
> My name is Aric Stewart. Primarily a WINE hacker, due to interest from a
> client I am starting work on spice. I will mostly be focusing on the win32
> client to begin with but we will see where work progresses.
>
> I
On Mon, Apr 16, 2012 at 02:17:37PM -0500, Aric Stewart wrote:
>
> This patch completes the copy from 4d8f39020ac83602c1647d4af04e8b19bf74ed6e
> which missed this file.
ACK, pushing.
> ---
> client/windows/getopt.h | 56
> +++
> 1 files changed, 56 i
On Mon, Apr 16, 2012 at 01:10:01PM -0500, Aric Stewart wrote:
>
> the python script is now in spice-common and client_marshallers.h needs to
> be included instead of marshallers.h
Looks good, haven't tested but I'll assume you did :)
ACK, and pushing.
> ---
> client/windows/generate.bat |
On Mon, Apr 16, 2012 at 11:47:25AM -0500, Aric Stewart wrote:
> ---
> common/gdi_canvas.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>
ACK. I'll push
> diff --git a/common/gdi_canvas.c b/common/gdi_canvas.c
> index 4c5daea..0a04bf8 100644
> --- a/common/gdi_canvas.c
> +++
64 matches
Mail list logo
