- Mensaje original -
> On 04/10/2012 05:57 PM, Rahul Upadhyaya wrote:
> > Hi Folks,
> >
> > I wasn't able to access the console via the Admin portal. As I
> > learnt there is a requirement of Spice-xpi plugin. I could not
> > find
> > the plugin for firefox/chrome on windo
On 04/10/2012 05:57 PM, Rahul Upadhyaya wrote:
Hi Folks,
I wasn't able to access the console via the Admin portal. As I
learnt there is a requirement of Spice-xpi plugin. I could not find
the plugin for firefox/chrome on windows/ubuntu. However, when I
tried from firefox on a fed
Hi
- Mensaje original -
> ACK
>
> On Tue, Apr 10, 2012 at 01:26:36PM +0200, Marc-André Lureau wrote:
> > cursor_set() didn't un-hide correctly by setting "show_cursor" to
> > NULL.
>
> This is in client-mode that this wasn't done, right? ACK otherwise
correct
___
ACK
On Tue, Apr 10, 2012 at 01:26:36PM +0200, Marc-André Lureau wrote:
> cursor_set() didn't un-hide correctly by setting "show_cursor" to
> NULL.
This is in client-mode that this wasn't done, right? ACK otherwise
Christophe
>
> The code is simplified a bit in server mode case, where the new cu
Hi,
please wait with the review for this one. I may have a better way to
identify such frames, using the current tree. If it works, I will send
it in v2.
On 04/08/2012 06:43 PM, Yonit Halperin wrote:
When playing a youtube video on Windows guest, the driver sometimes sends
images which contai
Hi Jacek,
this is the reply I got from people who know more than me about the
subject.
> Hi David,
>
> Currently, IGEL supports SPICE client on both their Windows and Linux
> platforms and of course, SPICE is supported on any other WES7, XPe
> Windows-based platform. Wyse will be supporting on
Uri Lublin píše v Ne 08. 04. 2012 v 17:11 +0300:
> On 04/03/2012 07:12 PM, David Jaša wrote:
> > Hi Christophe,
> >
> > Christophe Fergeau píše v Út 03. 04. 2012 v 16:38 +0200:
> >> The secure channel names need to be fixed for compatibility with
> >> older spice versions. However, it's better to d
On 04/10/2012 03:48 PM, Christophe Fergeau wrote:
On Sun, Apr 08, 2012 at 06:43:19PM +0300, Yonit Halperin wrote:
Previously, the mjpeg quality was always 70. The frame rate was tuned
according to the frames' congestion in the pipe.
This patch sets the mjpeg quality and frame rate according
to t
On Tue, Apr 10, 2012 at 03:53:17PM +0300, Yonit Halperin wrote:
> On 04/10/2012 03:34 PM, Christophe Fergeau wrote:
> >On Sun, Apr 08, 2012 at 06:43:15PM +0300, Yonit Halperin wrote:
> >>+static void red_channel_client_net_monitor_qos_timer(void *opaque)
> >>+{
> >>+RedChannelClient *rcc = opaq
On Tue, Apr 10, 2012 at 02:06:25PM +0200, Christophe Fergeau wrote:
> On Tue, Apr 10, 2012 at 02:59:02PM +0300, Alon Levy wrote:
> > On Tue, Apr 10, 2012 at 12:18:11PM +0200, Christophe Fergeau wrote:
> > > On Mon, Apr 09, 2012 at 08:33:10PM +0300, Alon Levy wrote:
> > > > ---
> > > > src/qxl_driv
Why not, it's properly #ifdef'ed contrary to some unused "might be useful
for debugging" variables...
ACK
Christophe
On Sun, Apr 08, 2012 at 06:43:20PM +0300, Yonit Halperin wrote:
>
> Signed-off-by: Yonit Halperin
> ---
> server/red_worker.c | 50
On 04/10/2012 03:34 PM, Christophe Fergeau wrote:
On Sun, Apr 08, 2012 at 06:43:15PM +0300, Yonit Halperin wrote:
If the client's channel has SPICE_COMMON_CAP_QOS_QUERY, the server
channel's can send it SPICE_MSG_QOS_QUERY. The client is supposed to
respond by SPICE_MSG_QOS_ACK right after it re
On Sun, Apr 08, 2012 at 06:43:19PM +0300, Yonit Halperin wrote:
> Previously, the mjpeg quality was always 70. The frame rate was tuned
> according to the frames' congestion in the pipe.
> This patch sets the mjpeg quality and frame rate according
> to the compressed size of the frames and the curr
Maybe RedChannelClient could have a "monitor_network" member which channels
would directly set when they are created? This would avoid adding yet
another argument to these create functions.
No strong feeling either way, it's just some food for thoughts :)
Christophe
On Sun, Apr 08, 2012 at 06:43:
On Sun, Apr 08, 2012 at 06:43:15PM +0300, Yonit Halperin wrote:
> If the client's channel has SPICE_COMMON_CAP_QOS_QUERY, the server
> channel's can send it SPICE_MSG_QOS_QUERY. The client is supposed to
> respond by SPICE_MSG_QOS_ACK right after it receives the one message
> that follows SPICE_MSG
On 04/10/2012 02:55 PM, Christophe Fergeau wrote:
On Sun, Apr 08, 2012 at 06:43:14PM +0300, Yonit Halperin wrote:
Each thread can create a spice_timer_queue, for managing its
own timers.
Signed-off-by: Yonit Halperin
---
server/Makefile.am |2 +
server/spice_timer_queue.c | 245
On Tue, Apr 10, 2012 at 02:59:02PM +0300, Alon Levy wrote:
> On Tue, Apr 10, 2012 at 12:18:11PM +0200, Christophe Fergeau wrote:
> > On Mon, Apr 09, 2012 at 08:33:10PM +0300, Alon Levy wrote:
> > > ---
> > > src/qxl_driver.c |6 --
> > > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
On Tue, Apr 10, 2012 at 02:49:56PM +0300, Alon Levy wrote:
Eek, this isn't spice-protocol of course, it's xf86-video-qxl. Other
then that, review away!
> This patchset has been tested with latest Xorg and qxl, and with Xspice. It
> doesn't introduce any new functionality. It adds a callback holde
On Tue, Apr 10, 2012 at 12:26:23PM +0200, Christophe Fergeau wrote:
> ACK
> do we want to hide these attributes in slightly more readable #define?
I'll see if there are any other users, if so I'll do an additional
patch.
>
> Christophe
>
> On Mon, Apr 09, 2012 at 08:33:14PM +0300, Alon Levy wro
On Tue, Apr 10, 2012 at 12:21:54PM +0200, Christophe Fergeau wrote:
> On Mon, Apr 09, 2012 at 08:33:13PM +0300, Alon Levy wrote:
> > ---
> > src/qxl_surface.c |2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/src/qxl_surface.c b/src/qxl_surface.c
> > index 6761bf6..a283d5e 10064
On Tue, Apr 10, 2012 at 12:28:31PM +0200, Christophe Fergeau wrote:
> Same question as the other patch, wouldn't we be better off just doing
> (char *)"xspice pointer" casts? Or disabling this warning?
Same answer.
>
> Christophe
>
> On Mon, Apr 09, 2012 at 08:33:11PM +0300, Alon Levy wrote:
>
On Tue, Apr 10, 2012 at 12:18:11PM +0200, Christophe Fergeau wrote:
> On Mon, Apr 09, 2012 at 08:33:10PM +0300, Alon Levy wrote:
> > ---
> > src/qxl_driver.c |6 --
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/qxl_driver.c b/src/qxl_driver.c
> > index 5c826
On Sun, Apr 08, 2012 at 06:43:14PM +0300, Yonit Halperin wrote:
> Each thread can create a spice_timer_queue, for managing its
> own timers.
>
> Signed-off-by: Yonit Halperin
> ---
> server/Makefile.am |2 +
> server/spice_timer_queue.c | 245
> +
---
src/qxl.h |1 -
src/qxlhw_pci.c|7 +++
src/qxlhw_pci.h|1 +
src/spiceqxl_display.c |9 ++---
src/spiceqxl_driver.c |3 ++-
src/spiceqxl_io_port.c |5 +++--
6 files changed, 19 insertions(+), 7 deletions(-)
diff --git a/src/qxl.h b/
Also some minor cleanup - make qxlhw_pci_get_ram_header for !xspice
---
src/qxlhw_pci.c |5 +
src/qxlhw_pci.h |2 ++
2 files changed, 7 insertions(+)
diff --git a/src/qxlhw_pci.c b/src/qxlhw_pci.c
index e1918c8..0d483fc 100644
--- a/src/qxlhw_pci.c
+++ b/src/qxlhw_pci.c
@@ -93,6 +93,9
---
src/qxl_surface.c |3 +--
src/qxlhw.c |5 +
src/qxlhw.h |4
src/qxlhw_pci.c |9 +
4 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/src/qxl_surface.c b/src/qxl_surface.c
index 25ace13..3394158 100644
--- a/src/qxl_surface.c
+++ b/src
rely on qxlhw_check_device to initialize pScrn->videoRam and qxl->surface0_size
---
src/qxl_driver.c |9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index 14bac17..67562aa 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -9
---
src/qxl_surface.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/src/qxl_surface.c b/src/qxl_surface.c
index 9e9c364..25ace13 100644
--- a/src/qxl_surface.c
+++ b/src/qxl_surface.c
@@ -363,14 +363,6 @@ init_surface_cmd (struct QXLSurfaceCmd *cmd,
surface_c
---
src/spiceqxl_io_port.c | 36 +---
1 file changed, 1 insertion(+), 35 deletions(-)
diff --git a/src/spiceqxl_io_port.c b/src/spiceqxl_io_port.c
index 0b8acc8..db7d715 100644
--- a/src/spiceqxl_io_port.c
+++ b/src/spiceqxl_io_port.c
@@ -173,39 +173,6 @@ static
---
src/qxl_driver.c | 46 ++
1 file changed, 2 insertions(+), 44 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index 972aa4a..14bac17 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -810,47 +810,6 @@ print_modes (qxl_screen_t
---
src/qxl_driver.c |9 ++--
src/qxl_surface.c |2 +-
src/qxlhw.c | 10 +
src/qxlhw.h |6 ++
src/qxlhw_pci.c | 61 +
5 files changed, 80 insertions(+), 8 deletions(-)
diff --git a/src/qxl_driver.c
---
src/qxl.h |3 ---
src/qxlhw_pci.c |5 -
2 files changed, 8 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index 25e6322..8ef29ee 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -133,9 +133,6 @@ struct _qxl_screen_t
EntityInfoPtr entity;
#ifndef XSPICE
-vo
---
src/qxl.h | 10 --
src/qxl_surface.c |5 ++---
src/qxlhw.c |5 +
src/qxlhw.h |3 +++
src/qxlhw_pci.c | 21 ++---
5 files changed, 28 insertions(+), 16 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index 626abc3..25e6322 10064
---
src/qxl.h |6 --
1 file changed, 6 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index 7f1ae6a..626abc3 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -140,12 +140,6 @@ struct _qxl_screen_t
intbytes_per_pixel;
-/* Commands */
-struct q
---
src/qxl_surface.c |3 +--
src/qxlhw.c |5 +
src/qxlhw.h |5 +
src/qxlhw_pci.c |8
4 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/src/qxl_surface.c b/src/qxl_surface.c
index dbfc7fe..0ce9877 100644
--- a/src/qxl_surface.c
+++ b/src
---
src/qxl_driver.c |9 +
src/qxlhw.c |5 +
src/qxlhw.h |2 ++
src/qxlhw_pci.c | 15 +++
4 files changed, 23 insertions(+), 8 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index c551282..3de060d 100644
--- a/src/qxl_driver.c
+++ b/
---
src/qxl.h |8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index 466b505..7f1ae6a 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -339,16 +339,10 @@ voidqxl_drop_image_cache (qxl_screen_t
*qxl);
/*
- * I/O port comman
---
src/qxl.h | 10 --
src/qxlhw_pci.c |7 ---
2 files changed, 17 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index a386651..466b505 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -175,16 +175,6 @@ struct _qxl_screen_t
ScrnInfoPtrpScrn;
---
src/qxl.h |8
1 file changed, 8 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index 585f204..a386651 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -224,14 +224,6 @@ struct _qxl_screen_t
#endif /* XSPICE */
};
-static inline uint64_t
-physical_address (qxl_screen_t *qxl, void *v
---
src/qxl_surface.c |5 -
1 file changed, 5 deletions(-)
diff --git a/src/qxl_surface.c b/src/qxl_surface.c
index 0b8c884..dbfc7fe 100644
--- a/src/qxl_surface.c
+++ b/src/qxl_surface.c
@@ -890,8 +890,6 @@ real_upload_box (qxl_surface_t *surface, int x1, int y1,
int x2, int y2)
im
---
src/qxl.h | 12
1 file changed, 12 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index 7cdf787..585f204 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -233,18 +233,6 @@ physical_address (qxl_screen_t *qxl, void *virtual,
uint8_t slot_id)
}
static inline void *
-virtual_addres
---
src/qxl.h |2 --
src/qxlhw_pci.c |1 -
2 files changed, 3 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index 6cedba3..7cdf787 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -127,8 +127,6 @@ struct _qxl_screen_t
struct qxlhw * hw;
/* These are the names QXL u
---
src/qxl.h|5
src/qxl_driver.c | 71 --
2 files changed, 76 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index c58f7ff..6cedba3 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -371,11 +371,6 @@ void qxl_drop_im
qxlhw_surface_alloc will do it anyway.
---
src/qxl_surface.c |5 +
src/qxlhw_pci.c |8 ++--
2 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/src/qxl_surface.c b/src/qxl_surface.c
index 6a6242e..0b8c884 100644
--- a/src/qxl_surface.c
+++ b/src/qxl_surface.c
@@ -521,
---
src/qxl.h |1 -
src/qxlhw_pci.c |1 -
2 files changed, 2 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index 03bb74e..c58f7ff 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -127,7 +127,6 @@ struct _qxl_screen_t
struct qxlhw * hw;
/* These are the names QXL us
---
src/qxl_image.c | 16 +---
src/qxlhw.c |6 ++
src/qxlhw.h |2 ++
src/qxlhw_pci.c | 21 +
4 files changed, 30 insertions(+), 15 deletions(-)
diff --git a/src/qxl_image.c b/src/qxl_image.c
index 1f057f7..adf4076 100644
--- a/src/qxl_image.
---
src/qxl.h|2 --
src/qxl_driver.c | 47 ---
2 files changed, 49 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index ef51469..03bb74e 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -374,8 +374,6 @@ void qxl_drop_image_cache
---
src/qxl_surface.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/qxl_surface.c b/src/qxl_surface.c
index 7554ca6..6a6242e 100644
--- a/src/qxl_surface.c
+++ b/src/qxl_surface.c
@@ -1167,7 +1167,9 @@ qxl_surface_copy (qxl_surface_t *dest,
}
else
{
-
---
src/qxl.h |7 +++
src/qxl_image.c | 101 +
src/qxlhw.c | 13 ++
src/qxlhw.h | 10 +
src/qxlhw_pci.c | 134 +++
5 files changed, 166 insertions(+), 99 deletions(-)
diff -
---
src/qxl_image.c | 181 +--
1 file changed, 97 insertions(+), 84 deletions(-)
diff --git a/src/qxl_image.c b/src/qxl_image.c
index b0ffef9..8cd6e49 100644
--- a/src/qxl_image.c
+++ b/src/qxl_image.c
@@ -130,102 +130,115 @@ remove_image_info
---
src/qxl_image.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/qxl_image.c b/src/qxl_image.c
index 3931ec7..b0ffef9 100644
--- a/src/qxl_image.c
+++ b/src/qxl_image.c
@@ -272,15 +272,15 @@ qxl_image_destroy (qxl_screen_t *qxl,
remove_image_info (info
---
src/qxl_surface.c | 128 +
1 file changed, 61 insertions(+), 67 deletions(-)
diff --git a/src/qxl_surface.c b/src/qxl_surface.c
index 73a44b3..7554ca6 100644
--- a/src/qxl_surface.c
+++ b/src/qxl_surface.c
@@ -388,19 +388,15 @@ enum ROPDesc
---
src/qxl_surface.c | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/src/qxl_surface.c b/src/qxl_surface.c
index 1ce6fe5..73a44b3 100644
--- a/src/qxl_surface.c
+++ b/src/qxl_surface.c
@@ -431,10 +431,9 @@ make_drawable (qxl_screen_t *qxl, int surface,
---
src/qxl.h |3 ++
src/qxl_surface.c | 46 ++
src/qxlhw.c | 21 ++
src/qxlhw.h | 23 ++-
src/qxlhw_pci.c | 82 +
5 files changed, 137 insertions(+), 38 deleti
---
src/qxl_surface.c | 134 ++---
1 file changed, 67 insertions(+), 67 deletions(-)
diff --git a/src/qxl_surface.c b/src/qxl_surface.c
index 137c1c7..96cfb5a 100644
--- a/src/qxl_surface.c
+++ b/src/qxl_surface.c
@@ -35,7 +35,7 @@
* A 'dead' sur
---
src/qxl_surface.c | 44 +++-
1 file changed, 15 insertions(+), 29 deletions(-)
diff --git a/src/qxl_surface.c b/src/qxl_surface.c
index 1747dca..137c1c7 100644
--- a/src/qxl_surface.c
+++ b/src/qxl_surface.c
@@ -356,34 +356,21 @@ qxl_surface_cache_cre
cursor commands are now allocated on the stack in qxl_cursor.c and only
allocated on the pci bar in qxlhw_pci.
---
src/qxl.h|1 -
src/qxl_cursor.c | 58 ++
src/qxlhw.c |5 +
src/qxlhw.h |4
src/qxlhw_pci.c
---
src/qxl.h| 10 --
src/qxl_driver.c |5 -
2 files changed, 15 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index 0b00474..4ca68a3 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -133,7 +133,6 @@ struct _qxl_screen_t
intnum_modes
---
src/qxl.h |1 -
src/qxl_driver.c | 26 --
src/qxl_surface.c | 24
src/qxlhw.c |5 +
src/qxlhw.h |2 ++
src/qxlhw_pci.c | 26 ++
6 files changed, 45 insertions(+), 39 deletions(
data_alloc and data_free unused yet.
---
src/qxl_driver.c | 32 +-
src/qxl_mem.h |1 -
src/qxl_surface.c |4 +-
src/qxlhw.c | 12
src/qxlhw.h | 12
src/qxlhw_pci.c | 184 +
6 files changed, 211
---
src/qxl_driver.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index 6ffbfa9..a4c5912 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -950,7 +950,7 @@ qxl_leave_vt(int scrnIndex, int flags)
qxl->vt_surfaces = qxl_surfa
---
src/qxl_driver.c | 38 --
src/qxlhw.c | 10 ++
src/qxlhw.h |5 +
src/qxlhw_pci.c | 24
4 files changed, 43 insertions(+), 34 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index a39d8c
---
src/qxl.h |1 -
src/qxl_driver.c | 29 ++---
src/qxl_surface.c | 16 +++-
src/qxlhw.c |5 +
src/qxlhw.h |5 +
src/qxlhw_pci.c | 23 +++
6 files changed, 46 insertions(+), 33 deletions(-)
d
Four callbacks are added to the qxlhw struct:
device_reset
reset
map_memory
unmap_memory
* The relevant code is moved from qxl_driver.c to qxlhw_pci.c
* qxl_ring.h gets a qxlhw reference and uses qxlhw_pci_ioport_write
* pci specific functions are introduced for ram, rom and ram
---
src/qxl.h | 14 ++
src/qxl_driver.c |1 +
src/qxl_image.c |1 +
src/qxl_mem.c |1 +
src/qxl_mem.h | 21 +
src/qxl_surface.c |1 +
6 files changed, 27 insertions(+), 12 deletions(-)
create mode 100644 src/qxl_mem.h
diff --
---
src/qxl.h|2 ++
src/qxl_driver.c |2 ++
2 files changed, 4 insertions(+)
diff --git a/src/qxl.h b/src/qxl.h
index 9b3459c..f3f1446 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -69,6 +69,7 @@
#define PCI_CHIP_QXL_01FF 0x01ff
struct qxl_ring;
+struct qxlhw;
typedef stru
qxl_driver_t will not access io ports and pci resources directly, but
through an opaque struct qxlhw which will have two implementations,
qxlhw_pci and qxlhw_drm.
---
src/Makefile.am |4
src/qxl.h |3 +++
src/qxlhw.c | 19 +++
src/qxlhw.h | 16 +++
split qxl ring definitions to separate header file from qxl.h.
---
src/qxl.h | 29 +
src/qxl_cursor.c |1 +
src/qxl_driver.c |1 +
src/qxl_ring.c|1 +
src/qxl_ring.h| 35 +++
src/qxl_surface.c |1 +
6
---
src/qxl.h | 13 -
src/spiceqxl_io_port.c |2 +-
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index 06cd76c..df2d368 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -425,14 +425,17 @@ void qxl_create_primary(qxl_screen_t *qxl);
v
This patchset has been tested with latest Xorg and qxl, and with Xspice. It
doesn't introduce any new functionality. It adds a callback holder struct
called qxlhw that will abstract the differences between the user space driver
and the drm driver. This will allow continued development in the same
r
I'd move this right after the 5th patch, ACK otherwise
On Sun, Apr 08, 2012 at 06:43:16PM +0300, Yonit Halperin wrote:
> display channel: Supplying timeouts interface to red_channel, in order to
> allow
> periodic network monitoring.
>
> Signed-off-by: Yonit Halperin
> ---
> server/red_worker
cursor_set() didn't un-hide correctly by setting "show_cursor" to
NULL.
The code is simplified a bit in server mode case, where the new cursor
will be invalidated and shown during cursor move only, instead of
twice (checked no regression with dual-head server mode)
---
gtk/spice-widget.c | 18 +
Alon Levy píše v Út 10. 04. 2012 v 13:41 +0300:
> On Tue, Apr 10, 2012 at 12:08:31PM +0200, David Jaša wrote:
> > Alon Levy píše v So 07. 04. 2012 v 13:21 +0300:
> > > On Fri, Apr 06, 2012 at 09:11:11PM +0200, David Jaša wrote:
> > > > Hi David,
> > > >
> > > > David Mansfield píše v Pá 06. 04. 20
On Tue, Apr 10, 2012 at 11:40:32AM +0200, Christophe Fergeau wrote:
> On Tue, Apr 10, 2012 at 11:28:34AM +0200, Marc-André Lureau wrote:
> > On Tue, Apr 10, 2012 at 11:09 AM, Christophe Fergeau
> > wrote:
> > > For what it's worth, one scenario where it's easier to go wrong than
> > > before
> >
On Tue, Apr 10, 2012 at 12:08:31PM +0200, David Jaša wrote:
> Alon Levy píše v So 07. 04. 2012 v 13:21 +0300:
> > On Fri, Apr 06, 2012 at 09:11:11PM +0200, David Jaša wrote:
> > > Hi David,
> > >
> > > David Mansfield píše v Pá 06. 04. 2012 v 14:17 -0400:
> > > >
> > > > On 04/06/2012 03:05 AM, A
On Tue, Apr 10, 2012 at 01:37:25PM +0300, Yonit Halperin wrote:
>
> On 04/10/2012 01:31 PM, Christophe Fergeau wrote:
> >On Sun, Apr 08, 2012 at 06:43:13PM +0300, Yonit Halperin wrote:
> >>SpiceMsgDisplayStreamData now contains SpiceStreamDataHeader,
> >>which is shared with SpiceMsgDisplayStreamD
On 04/10/2012 01:31 PM, Christophe Fergeau wrote:
On Sun, Apr 08, 2012 at 06:43:13PM +0300, Yonit Halperin wrote:
SpiceMsgDisplayStreamData now contains SpiceStreamDataHeader,
which is shared with SpiceMsgDisplayStreamDataSized.
Signed-off-by: Yonit Halperin
---
client/display_channel.cpp |
On Sun, Apr 08, 2012 at 06:43:13PM +0300, Yonit Halperin wrote:
> SpiceMsgDisplayStreamData now contains SpiceStreamDataHeader,
> which is shared with SpiceMsgDisplayStreamDataSized.
>
> Signed-off-by: Yonit Halperin
> ---
> client/display_channel.cpp |6 --
> 1 files changed, 4 insertio
Looks good
On Sun, Apr 08, 2012 at 06:42:37PM +0300, Yonit Halperin wrote:
> Add SPICE_MSG_DISPLAY_STREAM_DATA_SIZED, for stream_data message
> that also contains the size and destination box of the data.
> The server can send such messages only to clients with
> SPICE_DISPLAY_CAP_SIZED_STREAM.
>
On 04/10/2012 01:06 PM, Christophe Fergeau wrote:
On Sun, Apr 08, 2012 at 06:42:35PM +0300, Yonit Halperin wrote:
Signed-off-by: Yonit Halperin
---
common/ring.h | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/common/ring.h b/common/ring.h
index 7fba50e..71
Same question as the other patch, wouldn't we be better off just doing
(char *)"xspice pointer" casts? Or disabling this warning?
Christophe
On Mon, Apr 09, 2012 at 08:33:11PM +0300, Alon Levy wrote:
> ---
> src/spiceqxl_inputs.c | 64
> -
> 1 f
ACK
On Mon, Apr 09, 2012 at 08:33:19PM +0300, Alon Levy wrote:
> ---
> src/qxl_driver.c |2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/qxl_driver.c b/src/qxl_driver.c
> index eb09662..77fc40b 100644
> --- a/src/qxl_driver.c
> +++ b/src/qxl_driver.c
> @@ -129,6 +129,7 @@ qxl_ava
ACK
On Mon, Apr 09, 2012 at 08:33:17PM +0300, Alon Levy wrote:
> qxl_surface.c:735:6: warning: declaration of 'i' shadows a previous
> local [-Wshadow]
> ---
> src/qxl_surface.c |1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/qxl_surface.c b/src/qxl_surface.c
> index a283d5e..76b55
ACK
On Mon, Apr 09, 2012 at 08:33:16PM +0300, Alon Levy wrote:
> ---
> src/mspace.c | 11 ++-
> src/mspace.h |5 -
> 2 files changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/src/mspace.c b/src/mspace.c
> index 94d50e6..17d976a 100644
> --- a/src/mspace.c
> +++ b/src/ms
ACK
do we want to hide these attributes in slightly more readable #define?
Christophe
On Mon, Apr 09, 2012 at 08:33:14PM +0300, Alon Levy wrote:
> ---
> src/spiceqxl_io_port.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/spiceqxl_io_port.c b/src/spiceqxl_io_po
ACK
On Mon, Apr 09, 2012 at 08:33:15PM +0300, Alon Levy wrote:
> ---
> src/spiceqxl_io_port.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/spiceqxl_io_port.c b/src/spiceqxl_io_port.c
> index 050e7b9..f599b4e 100644
> --- a/src/spiceqxl_io_port.c
> +++ b/src/spic
ACK
On Mon, Apr 09, 2012 at 08:33:07PM +0300, Alon Levy wrote:
> ---
> src/spiceqxl_io_port.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/spiceqxl_io_port.c b/src/spiceqxl_io_port.c
> index da99225..ea02ac1 100644
> --- a/src/spiceqxl_io_port.c
> +++ b/src/
On Mon, Apr 09, 2012 at 08:33:13PM +0300, Alon Levy wrote:
> ---
> src/qxl_surface.c |2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/qxl_surface.c b/src/qxl_surface.c
> index 6761bf6..a283d5e 100644
> --- a/src/qxl_surface.c
> +++ b/src/qxl_surface.c
> @@ -863,6 +863,8 @@ qxl_su
On Mon, Apr 09, 2012 at 08:33:10PM +0300, Alon Levy wrote:
> ---
> src/qxl_driver.c |6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/src/qxl_driver.c b/src/qxl_driver.c
> index 5c826f3..82a6ff1 100644
> --- a/src/qxl_driver.c
> +++ b/src/qxl_driver.c
> @@ -1617,6
On Tue, Apr 10, 2012 at 12:12 PM, Yonit Halperin wrote:
> The message contains the destination rectangle of the data, and the width
> and hight of the compressed image. I can add more details to the commit
> message.
The more details in the commit message, the better!
thanks
--
Marc-André Lure
On 04/10/2012 01:12 PM, Christophe Fergeau wrote:
On Sun, Apr 08, 2012 at 06:42:10PM +0300, Yonit Halperin wrote:
Add SPICE_MSG_DISPLAY_STREAM_DATA_SIZED, for stream_data message
that also contains the size and destination box of the data.
The server can send such messages only to clients with
S
On Sun, Apr 08, 2012 at 06:42:10PM +0300, Yonit Halperin wrote:
> Add SPICE_MSG_DISPLAY_STREAM_DATA_SIZED, for stream_data message
> that also contains the size and destination box of the data.
> The server can send such messages only to clients with
> SPICE_DISPLAY_CAP_SIZED_STREAM.
Will every im
On 04/09/2012 09:26 PM, Xiao Guangrong wrote:
> Yes, if Xwindow is not enabled, the benefit is limited. :)
I'm more interested in migration.
We could optimize the framebuffer by disabling dirty logging when
VNC/Spice is not connected (which should usually be the case), or when
the SDL window is m
On 04/10/2012 12:22 PM, Marc-André Lureau wrote:
On Sun, Apr 8, 2012 at 5:42 PM, Yonit Halperin wrote:
Add SPICE_MSG_DISPLAY_STREAM_DATA_SIZED, for stream_data message
that also contains the size and destination box of the data.
The server can send such messages only to clients with
SPICE_DISPL
Alon Levy píše v So 07. 04. 2012 v 13:21 +0300:
> On Fri, Apr 06, 2012 at 09:11:11PM +0200, David Jaša wrote:
> > Hi David,
> >
> > David Mansfield píše v Pá 06. 04. 2012 v 14:17 -0400:
> > >
> > > On 04/06/2012 03:05 AM, Alon Levy wrote:
> > > > On Thu, Apr 05, 2012 at 12:52:53PM -0400, David Ma
On 04/10/2012 12:25 PM, Marc-André Lureau wrote:
Hi
On Tue, Apr 10, 2012 at 11:19 AM, Yonit Halperin wrote:
On 04/10/2012 12:13 PM, Marc-André Lureau wrote:
On Sun, Apr 8, 2012 at 5:42 PM, Yonit Halperin
wrote:
If the client's channel has SPICE_COMMON_CAP_QOS_QUERY,
the server's channel
On Sun, Apr 08, 2012 at 06:42:35PM +0300, Yonit Halperin wrote:
>
> Signed-off-by: Yonit Halperin
> ---
> common/ring.h | 10 ++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/common/ring.h b/common/ring.h
> index 7fba50e..7163aaa 100644
> --- a/common/ring.h
> +
On Tue, Apr 10, 2012 at 11:28:34AM +0200, Marc-André Lureau wrote:
> On Tue, Apr 10, 2012 at 11:09 AM, Christophe Fergeau
> wrote:
> > For what it's worth, one scenario where it's easier to go wrong than before
> > is when distro patches have to be added to the protocol headers (for
> > example en
ACK, I favour unsigned int for loop indexes which start at 0, but
that's just a nit
Christophe
On Sun, Apr 08, 2012 at 06:43:10PM +0300, Yonit Halperin wrote:
>
> Signed-off-by: Yonit Halperin
> ---
> server/red_worker.c |5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> dif
On Sun, Apr 08, 2012 at 06:43:11PM +0300, Yonit Halperin wrote:
>
> Signed-off-by: Yonit Halperin
> ---
> server/red_worker.c | 10 ++
> 1 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 5350195..b2fa348 100644
> --- a/
1 - 100 of 110 matches
Mail list logo
