[Spice-devel] [PATCH xf86-video-qxl 13/13] qxl_driver: ifdef out qxl_wait_for_io_command if not XSPICE

--- src/qxl_driver.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index eb09662..77fc40b 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -129,6 +129,7 @@ qxl_available_options (int chipid, int busid) return DefaultOptions; } +#ifndef

[Spice-devel] [PATCH xf86-video-qxl 12/13] add vim headers to set tabstop to 8

--- src/qxl.h|1 + src/qxl_cursor.c |1 + src/qxl_driver.c |1 + src/qxl_image.c |1 + src/qxl_mem.c|1 + src/qxl_option_helpers.c |1 + src/qxl_ring.c |1 + src/qxl_surface.c|1 + 8 files change

[Spice-devel] [PATCH xf86-video-qxl 11/13] qxl_surface.c: fix -Wshadow warning

qxl_surface.c:735:6: warning: declaration of 'i' shadows a previous local [-Wshadow] --- src/qxl_surface.c |1 - 1 file changed, 1 deletion(-) diff --git a/src/qxl_surface.c b/src/qxl_surface.c index a283d5e..76b5579 100644 --- a/src/qxl_surface.c +++ b/src/qxl_surface.c @@ -730,7 +730,6 @@ s

[Spice-devel] [PATCH xf86-video-qxl 10/13] mspace: no more warnings

--- src/mspace.c | 11 ++- src/mspace.h |5 - 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/mspace.c b/src/mspace.c index 94d50e6..17d976a 100644 --- a/src/mspace.c +++ b/src/mspace.c @@ -21,8 +21,6 @@ #include #include "mspace.h" -#pragma warning( disa

[Spice-devel] [PATCH xf86-video-qxl 09/13] spiceqxl_io_port: use pointer_to_u64 (fix warning)

--- src/spiceqxl_io_port.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spiceqxl_io_port.c b/src/spiceqxl_io_port.c index 050e7b9..f599b4e 100644 --- a/src/spiceqxl_io_port.c +++ b/src/spiceqxl_io_port.c @@ -175,7 +175,7 @@ static void qxl_destroy_primary(qxl_screen_t

[Spice-devel] [PATCH xf86-video-qxl 08/13] spiceqxl_io_port: use attribute printf (fix warning)

--- src/spiceqxl_io_port.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spiceqxl_io_port.c b/src/spiceqxl_io_port.c index ea02ac1..050e7b9 100644 --- a/src/spiceqxl_io_port.c +++ b/src/spiceqxl_io_port.c @@ -58,7 +58,7 @@ static int spiceqxl_io_port_debug_level = -

[Spice-devel] [PATCH xf86-video-qxl 07/13] (questionable) qxl_surface: qxl_surface_prepare_access: handle unused but set warning with (void)

--- src/qxl_surface.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qxl_surface.c b/src/qxl_surface.c index 6761bf6..a283d5e 100644 --- a/src/qxl_surface.c +++ b/src/qxl_surface.c @@ -863,6 +863,8 @@ qxl_surface_prepare_access (qxl_surface_t *surface, stride = pixman_image_g

[Spice-devel] [PATCH xf86-video-qxl 06/13] xspice: cleanup: avoid const cast warnings on option initializers

--- src/qxl_driver.c | 14 ++ src/spiceqxl_inputs.c |4 ++-- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 82a6ff1..e696c97 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -58,6 +58,12 @@ extern void compat_

[Spice-devel] [PATCH xf86-video-qxl 05/13] spiceqxl_inputs: fix const discard at initialization warnings

--- src/spiceqxl_inputs.c | 64 - 1 file changed, 37 insertions(+), 27 deletions(-) diff --git a/src/spiceqxl_inputs.c b/src/spiceqxl_inputs.c index 62ef19f..5cfa823 100644 --- a/src/spiceqxl_inputs.c +++ b/src/spiceqxl_inputs.c @@ -46,26 +46,6 @@

[Spice-devel] [PATCH xf86-video-qxl 04/13] qxl_driver: cleanup: fix const cast warnings

--- src/qxl_driver.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 5c826f3..82a6ff1 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1617,6 +1617,8 @@ static PciChipsets qxlPciChips[] = #endif #endif /* !XSPICE */

[Spice-devel] [PATCH xf86-video-qxl 03/13] murmurhash3: fix "always_inline function might not be inlinable" warning

"__attribute__((always_inline))" does not replace "inline" and they still need to be used together. This fixes "always_inline function might not be inlinable [-Wattributes]" warning in gcc 4.7 --- src/murmurhash3.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/murmurha

[Spice-devel] [PATCH xf86-video-qxl 02/13] qxl_ring: remove volatile. doesn't accomplish anything the mem_barrier doesn't also accomplish, and removes warnings when using memcpy

--- src/qxl_ring.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/qxl_ring.c b/src/qxl_ring.c index fcbaaa7..adb92ba 100644 --- a/src/qxl_ring.c +++ b/src/qxl_ring.c @@ -41,7 +41,7 @@ struct ring struct qxl_ring { -volatile struct ring *ring; +st

[Spice-devel] [PATCH xf86-video-qxl 01/13] spiceqxl: Xspice is spelled with a lower s

--- src/spiceqxl_io_port.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/spiceqxl_io_port.c b/src/spiceqxl_io_port.c index da99225..ea02ac1 100644 --- a/src/spiceqxl_io_port.c +++ b/src/spiceqxl_io_port.c @@ -252,10 +252,10 @@ void ioport_write(qxl_screen_t *qxl, u

[Spice-devel] [PATCH xf86-video-qxl 00/13] warnings fixes for xf86-video-qxl

This fixes all warnings except for uxa related ones - haven't yet figured out were that code came from. Fixing it's warnings are left for later. Alon Levy (13): spiceqxl: Xspice is spelled with a lower s qxl_ring: remove volatile. doesn't accomplish anything the mem_barrier doesn't also ac

Re: [Spice-devel] [spice-protocol] qxl_dev: fix const cast warning for QXL_R[AO]M_MAGIC

ACK. On 04/09/2012 07:05 PM, Alon Levy wrote: --- spice/qxl_dev.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h index 5e6ce06..741a1f6 100644 --- a/spice/qxl_dev.h +++ b/spice/qxl_dev.h @@ -53,8 +53,8 @@ enum { #define QXL_DEVIC

[Spice-devel] [spice-protocol] qxl_dev: fix const cast warning for QXL_R[AO]M_MAGIC

--- spice/qxl_dev.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h index 5e6ce06..741a1f6 100644 --- a/spice/qxl_dev.h +++ b/spice/qxl_dev.h @@ -53,8 +53,8 @@ enum { #define QXL_DEVICE_ID_DEVEL 0x01ff #define QXL_REVISION_DEVEL 0x01

Re: [Spice-devel] WinXP with Standard PC CPU model continuously restarts..

Hi Alon, This issue happens whether we remove virtio-serial/QXL or not. Have seen the issue in both cases(not using -smp option and  Qemu with virt-manager uses -smp 1) I think below specified 3 options don't matter for this issue. Thanks\Naga. From: Alon Lev