Hi,
On 04/03/2012 04:40 PM, Marc-André Lureau wrote:
>
>
> - Mensaje original -
>> On Tue, Apr 03, 2012 at 03:56:12PM +0200, Peter Hatina wrote:
>>> On 04/03/2012 03:39 PM, Marc-André Lureau wrote:
- Mensaje original -
>
> void nsPluginInstance::Connect(
On Tue, Apr 03, 2012 at 11:21:07PM +0200, Marc-André Lureau wrote:
> On Tue, Apr 3, 2012 at 6:12 PM, David Jaša wrote:
> > The s- idio^W^W^W^Wlegacy goes much further, see the ovirt-engine
> > sources what you can expect:
> > http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=blob;f=backend/manag
On Tue, Apr 3, 2012 at 6:12 PM, David Jaša wrote:
> The s- idio^W^W^W^Wlegacy goes much further, see the ovirt-engine
> sources what you can expect:
> http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=blob;f=backend/manager/tools/engine-config/src/main/resources/engine-config.properties#l109
Hm
This patch may not be needed (see discussion of patch 1).
On 04/03/2012 03:07 PM, Christophe Fergeau wrote:
---
data/test.html |5 +
1 file changed, 5 insertions(+)
diff --git a/data/test.html b/data/test.html
index ff7743b..3384a56 100644
--- a/data/test.html
+++ b/data/test.html
@@
All 4 patches look good, ACK series
On 04/03/2012 04:38 PM, Christophe Fergeau wrote:
The secure channel names need to be fixed for compatibility with
older spice versions. However, it's better to do it directly when
m_secure_channels is set rather than waiting until its first use
---
SpiceXPI
Hey,
On Tue, Apr 03, 2012 at 07:44:51PM +0200, Hans de Goede wrote:
> Eh, my idea wrt sending usbredir enable / disable to the spice-client was to
> base
> it on the usb_listen_port setting, if usb_listen_port is set we are using old
> usb,
> so disable the new usb (thus send disabled to the cli
ACK.
On 04/03/2012 03:14 PM, Christophe Fergeau wrote:
---
data/spice-protocol.vapi |4
gtk/controller/controller.vala | 12
spice-common |2 +-
3 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/data/spice-protocol.vapi b/data
ACK
On 04/03/2012 03:07 PM, Christophe Fergeau wrote:
spice-xpi doesn't currently support changing properties after the
initial connection, so set the USB filter during initial connection
so that USB filters can be tested.
---
data/test.html |1 +
1 file changed, 1 insertion(+)
diff --gi
ACK.
On 04/03/2012 03:07 PM, Christophe Fergeau wrote:
The Firefox plugin exposes the UsbAutoShare property and the SetUsbFilter
method that were not wired until now. This commit propagates their value to
the nsPluginInstance object. Next step will be to transmit them to
the controller.
---
Sp
Hi,
Eh, my idea wrt sending usbredir enable / disable to the spice-client was to
base
it on the usb_listen_port setting, if usb_listen_port is set we are using old
usb,
so disable the new usb (thus send disabled to the client over the controller).
If usb_listen_port is not set then the idea is
Hello All,
Is using "virsh update-device" the only way to change a running VM's SPICE
password?
Thanks,
Tony
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
Hi Christophe,
Christophe Fergeau píše v Út 03. 04. 2012 v 16:38 +0200:
> The secure channel names need to be fixed for compatibility with
> older spice versions. However, it's better to do it directly when
> m_secure_channels is set rather than waiting until its first use
> ---
> SpiceXPI/src/pl
Marc-André Lureau píše v Út 03. 04. 2012 v 08:39 -0400:
>
> - Mensaje original -
> > +if (port < 0 && sport < 0)
> > +{
> > +if (port < 0)
> > +LOG_ERROR("invalid port: " << m_port);
> > +if (sport < 0)
> > +LOG_ERROR("invalid secure port: "
Alon,
All right. I got it. Thanks.
-Original Message-
From: Alon Levy [mailto:al...@redhat.com]
Sent: Tuesday, April 03, 2012 9:33 PM
To: Charles.Tsai-蔡清海-研究發展部
Cc: Hans de Goede; spice-devel@lists.freedesktop.org
Subject: Re: [Spice-devel] [RFC] register vmc interface early for name !=
- Mensaje original -
> On Tue, Apr 03, 2012 at 03:56:12PM +0200, Peter Hatina wrote:
> > On 04/03/2012 03:39 PM, Marc-André Lureau wrote:
> > >
> > >
> > > - Mensaje original -
> > >>
> > >> void nsPluginInstance::Connect()
> > >> {
> > >> +const int port = portToInt(m_p
Use %z modifier for ssize_t variables, and for an uint32_t variable,
the %l modifier shouldn't be neeeded.
---
SpiceXPI/src/plugin/controller.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SpiceXPI/src/plugin/controller.cpp
b/SpiceXPI/src/plugin/controller.cpp
index 4c
---
SpiceXPI/src/plugin/plugin.cpp | 15 ---
SpiceXPI/src/plugin/plugin.h |1 -
2 files changed, 16 deletions(-)
diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXPI/src/plugin/plugin.cpp
index 008688a..cef4f58 100644
--- a/SpiceXPI/src/plugin/plugin.cpp
+++ b/SpiceXPI/src/p
All callers were using std::string::c_str(), better to move this
call to SendStr instead of doing it everywhere.
---
SpiceXPI/src/plugin/plugin.cpp | 28 ++--
SpiceXPI/src/plugin/plugin.h |2 +-
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/SpiceX
The secure channel names need to be fixed for compatibility with
older spice versions. However, it's better to do it directly when
m_secure_channels is set rather than waiting until its first use
---
SpiceXPI/src/plugin/plugin.cpp | 29 ++---
1 file changed, 14 insertions
On Tue, Apr 03, 2012 at 03:56:12PM +0200, Peter Hatina wrote:
> On 04/03/2012 03:39 PM, Marc-André Lureau wrote:
> >
> >
> > - Mensaje original -
> >>
> >> void nsPluginInstance::Connect()
> >> {
> >> +const int port = portToInt(m_port);
> >> +const int sport = portToInt(m_sec
- Mensaje original -
> You mean, when there is one of the values valid and the other
> invalid?
> That's what I was asking on #spice. I do not know, if
> spicec/virt-viewer
> can work only with secure port. With unencrypted port, it works.
It could work, in some cases, but I thought the
On 04/03/2012 03:39 PM, Marc-André Lureau wrote:
>
>
> - Mensaje original -
>>
>> void nsPluginInstance::Connect()
>> {
>> +const int port = portToInt(m_port);
>> +const int sport = portToInt(m_secure_port);
>> +
>> +if (port < 0)
>> +LOG_ERROR("invalid port: " <<
- Mensaje original -
>
> void nsPluginInstance::Connect()
> {
> +const int port = portToInt(m_port);
> +const int sport = portToInt(m_secure_port);
> +
> +if (port < 0)
> +LOG_ERROR("invalid port: " << m_port);
> +if (sport < 0)
> +LOG_ERROR("invalid se
---
SpiceXPI/src/plugin/plugin.cpp | 32 ++--
1 files changed, 30 insertions(+), 2 deletions(-)
diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXPI/src/plugin/plugin.cpp
index de7afd0..19f7716 100644
--- a/SpiceXPI/src/plugin/plugin.cpp
+++ b/SpiceXPI/src/plugin/p
On Tue, Apr 03, 2012 at 01:21:09PM +, Charles.Tsai-蔡清海-研究發展部 wrote:
> Alon,
>
> >>when " spice_chr_guest_open" is called, it is ignored if subtype == vdprint.
> >>chr->chr_guest_open = spice_chr_guest_open;
>
> Here, I just want to avoid "vdprint" from being created twice when
> "chr->chr_gu
On Tue, Apr 03, 2012 at 03:18:34PM +0200, Hans de Goede wrote:
> So that one can autogen.sh on RHEL-6.
ACK.
>
> Signed-off-by: Hans de Goede
> ---
> configure.ac |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 1178069..e70e786 10
Alon,
>>when " spice_chr_guest_open" is called, it is ignored if subtype == vdprint.
>>chr->chr_guest_open = spice_chr_guest_open;
Here, I just want to avoid "vdprint" from being created twice when
"chr->chr_guest_open" is called.
"chr->chr_guest_open" is still called when gust OS open the print
So that one can autogen.sh on RHEL-6.
Signed-off-by: Hans de Goede
---
configure.ac |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 1178069..e70e786 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,4 +1,4 @@
-AC_PREREQ([2.68])
+AC_PREREQ
---
data/spice-protocol.vapi |4
gtk/controller/controller.vala | 12
spice-common |2 +-
3 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/data/spice-protocol.vapi b/data/spice-protocol.vapi
index 4b88175..66f1373 100644
--- a/data/
On Tue, Apr 03, 2012 at 11:13:41AM +, Charles.Tsai-蔡清海-研究發展部 wrote:
> Alon,
>
> After I read the code, I got some idea on how to modify the code.
> For the printing channel, I will call "spice_chr_guest_open" early than
> it supposed to be.
> As such, the spice client can se
spice-xpi doesn't currently support changing properties after the
initial connection, so set the USB filter during initial connection
so that USB filters can be tested.
---
data/test.html |1 +
1 file changed, 1 insertion(+)
diff --git a/data/test.html b/data/test.html
index 3384a56..67f9d5c
---
data/test.html |5 +
1 file changed, 5 insertions(+)
diff --git a/data/test.html b/data/test.html
index ff7743b..3384a56 100644
--- a/data/test.html
+++ b/data/test.html
@@ -112,6 +112,7 @@ function setConnectVars()
if(document.getElementById("NoTaskMgrExecutionToggled").check
The Firefox plugin exposes the UsbAutoShare property and the SetUsbFilter
method that were not wired until now. This commit propagates their value to
the nsPluginInstance object. Next step will be to transmit them to
the controller.
---
SpiceXPI/src/plugin/plugin.cpp | 19 +--
Sp
This is a boolean property that enables/disables USB redirection.
---
SpiceXPI/src/plugin/nsISpicec.idl|1 +
SpiceXPI/src/plugin/nsScriptablePeer.cpp |7 +++
SpiceXPI/src/plugin/nsScriptablePeer.h |1 +
SpiceXPI/src/plugin/plugin.cpp | 12
SpiceXP
- Mensaje original -
> +if (port < 0 && sport < 0)
> +{
> +if (port < 0)
> +LOG_ERROR("invalid port: " << m_port);
> +if (sport < 0)
> +LOG_ERROR("invalid secure port: " << m_secure_port);
> +return;
> +}
If one of the value is
On Tue, Apr 03, 2012 at 02:28:07PM +0200, Peter Hatina wrote:
> Hi,
>
> can you do a review for me?
>
> From 18f6fcabe35be03fe88f1a08b79e22ef505bbacd Mon Sep 17 00:00:00 2001
> From: Peter Hatina
> Date: Tue, 3 Apr 2012 13:35:55 +0200
> Subject: [PATCH] Validate port values
>
> ---
> SpiceXPI/
Hi,
On 04/03/2012 02:13 PM, Christophe Fergeau wrote:
On Tue, Apr 03, 2012 at 07:38:10AM -0400, Marc-André Lureau wrote:
- Mensaje original -
This adds 3 new controller messages:
CONTROLLER_ENABLE_USB (ControllerValue, boolean)
CONTROLLER_ENABLE_USB_AUTOSHARE (ControllerValue, boole
Hi,
can you do a review for me?
>From 18f6fcabe35be03fe88f1a08b79e22ef505bbacd Mon Sep 17 00:00:00 2001
From: Peter Hatina
Date: Tue, 3 Apr 2012 13:35:55 +0200
Subject: [PATCH] Validate port values
---
SpiceXPI/src/plugin/plugin.cpp | 29 +++--
1 files changed, 27 ins
On Tue, Apr 03, 2012 at 07:38:10AM -0400, Marc-André Lureau wrote:
>
>
> - Mensaje original -
> > This adds 3 new controller messages:
> >
> > CONTROLLER_ENABLE_USB (ControllerValue, boolean)
> > CONTROLLER_ENABLE_USB_AUTOSHARE (ControllerValue, boolean)
> > CONTROLLER_USB_FILTER (Contro
hello,
sorry for delay,
patch is fine.
Nicolas
2012/4/2 Marc-André Lureau :
> Hi
>
> - Mensaje original -
>> hello
>> patch from Marc-André Lureau :
>>
>> [Spice-devel] [PATCH spice-gtk 1/2] build: fix build with glib < 2.32
>>
>> does not cover
>> channel-usbredir.c file
>>
>> compilati
- Mensaje original -
> This adds 3 new controller messages:
>
> CONTROLLER_ENABLE_USB (ControllerValue, boolean)
> CONTROLLER_ENABLE_USB_AUTOSHARE (ControllerValue, boolean)
> CONTROLLER_USB_FILTER (ControllerData, string)
>
> This fixes rhbz #807295
I wonder if it would be worth speci
Alon,
After I read the code, I got some idea on how to modify the code.
For the printing channel, I will call "spice_chr_guest_open" early than
it supposed to be.
As such, the spice client can see the printing channel and initialize
it.
when " spice_chr_guest_ope
On Tue, Apr 03, 2012 at 12:11:53PM +0200, Gianluca Cecchi wrote:
> 2012/4/3 Alon Levy:
> > On Tue, Apr 03, 2012 at 08:40:26AM +, Charles.Tsai-蔡清海-研究發展部 wrote:
> >> Alon,
> >>
> >> Our Windows client code is based on 0.10.1 release and that is, I believe,
> >> the latest one.
> >> "spice-gtk" i
On Tue, Apr 03, 2012 at 10:16:46AM +, Charles.Tsai-蔡清海-研究發展部 wrote:
> Alon,
>
> I am sorry. I don't see your patch.
> I will take a look at the following code and see how I can apply it for
> printing channel.
The diff below is the patch. It doesn't need any changes, if subtype !=
Alon,
I am sorry. I don't see your patch.
I will take a look at the following code and see how I can apply it for
printing channel.
> diff --git a/spice-qemu-char.c b/spice-qemu-char.c index
> 1e735ff..d3ae0b7 100644
> --- a/spice-qemu-char.c
> +++ b/spice-qe
2012/4/3 Alon Levy:
> On Tue, Apr 03, 2012 at 08:40:26AM +, Charles.Tsai-蔡清海-研究發展部 wrote:
>> Alon,
>>
>> Our Windows client code is based on 0.10.1 release and that is, I believe,
>> the latest one.
>> "spice-gtk" is running in LINUX and I believe it is not applicable to
>> Windows platform.
On Tue, Apr 03, 2012 at 09:37:27AM +, Charles.Tsai-蔡清海-研究發展部 wrote:
> Alon,
>
> Do you recommend us to use the new spice client code from
> "http://www.spice-space.org/downloads.html"; link?
> I will try to use it latter on to see what it is difference.
>
> You are right. T
Alon,
Do you recommend us to use the new spice client code from
"http://www.spice-space.org/downloads.html"; link?
I will try to use it latter on to see what it is difference.
You are right. The printing channel is created when the guest OS opens
the virtIO printing chan
On Tue, Apr 03, 2012 at 12:17:32PM +0300, Alon Levy wrote:
> On Tue, Apr 03, 2012 at 08:40:26AM +, Charles.Tsai-蔡清海-研究發展部 wrote:
> > Alon,
> >
> > Our Windows client code is based on 0.10.1 release and that is, I believe,
> > the latest one.
> > "spice-gtk" is running in LINUX and I believe
On Tue, Apr 03, 2012 at 08:40:26AM +, Charles.Tsai-蔡清海-研究發展部 wrote:
> Alon,
>
> Our Windows client code is based on 0.10.1 release and that is, I believe,
> the latest one.
> "spice-gtk" is running in LINUX and I believe it is not applicable to Windows
> platform.
That is wrong. It works o
On Mon, Apr 02, 2012 at 12:23:46PM +0100, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
What's the source for manywarnings.m4 and warnings.m4 ? Could you add a
link somewhere in the commit message?
>
> * m4/manywarnings.m4m, m4/warnings.m4: Import GNULIB warnings
> modules
> * m4/spi
On Tue, Apr 03, 2012 at 01:09:09AM +0200, Marc-André Lureau wrote:
> On Mon, Apr 2, 2012 at 1:23 PM, Daniel P. Berrange
> wrote:
> > From: "Daniel P. Berrange"
> >
> > The red_worker_main method allocates a RedWorker struct instance
> > on the stack. This struct is a full 2 MB in size which is n
On Tue, Apr 03, 2012 at 11:21:47AM +0300, Alon Levy wrote:
> On Mon, Apr 02, 2012 at 12:23:46PM +0100, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange"
>
> What's the source for manywarnings.m4 and warnings.m4 ? Could you add a
> link somewhere in the commit message?
The source is GNULIB
Hey,
On Tue, Apr 03, 2012 at 12:57:27AM +0300, Nerijus Baliunas wrote:
> On Mon, 2 Apr 2012 10:37:25 +0200 Christophe Fergeau
> wrote:
>
> > > Do we have such plugins for Windows users that would like to open
> > > their vms from browser?
> >
> > I don't think we have such plugins yet unfortun
On Tue, Apr 03, 2012 at 11:18:45AM +0300, Alon Levy wrote:
> On Mon, Apr 02, 2012 at 12:23:41PM +0100, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange"
> >
> > The red_worker_main method allocates a RedWorker struct instance
> > on the stack. This struct is a full 2 MB in size which is no
On Tue, Apr 03, 2012 at 10:32:14AM +0200, Christophe Fergeau wrote:
> ---
ACK both.
> spice/controller_prot.h |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/spice/controller_prot.h b/spice/controller_prot.h
> index f7b1f26..355feac 100644
> --- a/spice/controller_pr
Alon,
Our Windows client code is based on 0.10.1 release and that is, I believe, the
latest one.
"spice-gtk" is running in LINUX and I believe it is not applicable to Windows
platform.
Please refer to the following trace to understand what I said. As you can see,
printing channel is register
On Mon, Apr 02, 2012 at 12:30:47PM +0200, Peter Hatina wrote:
> diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXPI/src/plugin/plugin.cpp
> index 25a098b..2274b63 100644
> --- a/SpiceXPI/src/plugin/plugin.cpp
> +++ b/SpiceXPI/src/plugin/plugin.cpp
> @@ -185,15 +185,20 @@ void NS_DestroyPluginIns
This adds 3 new controller messages:
CONTROLLER_ENABLE_USB (ControllerValue, boolean)
CONTROLLER_ENABLE_USB_AUTOSHARE (ControllerValue, boolean)
CONTROLLER_USB_FILTER (ControllerData, string)
This fixes rhbz #807295
---
spice/controller_prot.h |4
1 file changed, 4 insertions(+)
diff -
---
spice/controller_prot.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/spice/controller_prot.h b/spice/controller_prot.h
index f7b1f26..355feac 100644
--- a/spice/controller_prot.h
+++ b/spice/controller_prot.h
@@ -78,7 +78,7 @@ enum {
CONTROLLER_COLOR_DEPTH,
On Mon, Apr 02, 2012 at 12:23:41PM +0100, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> The red_worker_main method allocates a RedWorker struct instance
> on the stack. This struct is a full 2 MB in size which is not
> at all resonable to allocate on the stack.
Why?
>
> * server/r
On Mon, Apr 02, 2012 at 07:44:46AM +, Charles.Tsai-蔡清海-研究發展部 wrote:
> Alon,
>
> In spice client, the creation of the channel is based on
> "init->num_of_channels" that is returned from the spice server.
> Please see the following function to create the spice channel from the
>
62 matches
Mail list logo
