On Mon, Apr 2, 2012 at 1:23 PM, Daniel P. Berrange wrote:
> A followup to the previous patch which enabled more compiler warnings
> for spice-gtk. This one does the same for 'spice'. Less to fix now
> that we have spice-common shared
Ack series, after 6/12 is updated/commented.
thanks
--
Marc
On Mon, Apr 2, 2012 at 1:23 PM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> The red_worker_main method allocates a RedWorker struct instance
> on the stack. This struct is a full 2 MB in size which is not
> at all resonable to allocate on the stack.
>
Ouch.. btw, apparently, it's
On Mon, 2 Apr 2012 10:37:25 +0200 Christophe Fergeau
wrote:
> > Do we have such plugins for Windows users that would like to open
> > their vms from browser?
>
> I don't think we have such plugins yet unfortunately... Something really
> useful would be someone doing a VisualC++ build of spice-x
Hi
- Mensaje original -
> hello
> patch from Marc-André Lureau :
>
> [Spice-devel] [PATCH spice-gtk 1/2] build: fix build with glib < 2.32
>
> does not cover
> channel-usbredir.c file
>
> compilation is not possible.
Can you try the attached patch?
thanksdiff --git a/gtk/channel-usbred
hello
patch from Marc-André Lureau :
[Spice-devel] [PATCH spice-gtk 1/2] build: fix build with glib < 2.32
does not cover
channel-usbredir.c file
compilation is not possible.
Regards,
Nicolas Prochazka.
___
Spice-devel mailing list
Spice-devel@lists.
ack series
- Mensaje original -
> Often (when not resized by the user) even though scaling is enabled,
> we are
> not actually scaling. In this case it is not necessary to scale the
> mouse coordinates, and sometimes it is even harmful.
>
> Signed-off-by: Hans de Goede
> ---
> gtk/spice
ACK
On 04/02/2012 09:43 AM, Yonit Halperin wrote:
rhbz #808986
Signed-off-by: Yonit Halperin
---
src/remote-viewer.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/remote-viewer.c b/src/remote-viewer.c
index 7dda7fe..5f7685f 100644
--- a/src/remote-viewer.c
+
Before this patch we were assuming that the GdkEventMotion value we receive
are always whole (integer) numbers, which is not the case with GTK-3.0.
Signed-off-by: Hans de Goede
---
gtk/spice-widget.c | 20 +++-
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/gtk/
Often (when not resized by the user) even though scaling is enabled, we are
not actually scaling. In this case it is not necessary to scale the
mouse coordinates, and sometimes it is even harmful.
Signed-off-by: Hans de Goede
---
gtk/spice-widget.c |2 +-
1 file changed, 1 insertion(+), 1 de
On Monday, March 19, 2012 02:48:43 PM Paul Lu-???-? wrote:
> Hi Vadim,
> Here is the configuration:
> /usr/local/bin/qemu-system-x86_64 \
> -localtime \
> -boot order=c,menu=on \
> -drive file=/var/lib/libvirt/images/xxx.img \
> -vga qxl \
> -cdrom /home/paul/Downloads/ISO/virtio-win-0.1-1
- Mensaje original -
> On Mon, Apr 02, 2012 at 07:40:31AM -0400, Marc-André Lureau wrote:
> > - Mensaje original -
> > > Alternatively, doing unconditionnally --enable-vala in autogen.sh
> > > would
> > > work for me too I think.
> >
> > That sounds reasonable.
>
> Ok, though on
On Mon, Apr 02, 2012 at 07:40:31AM -0400, Marc-André Lureau wrote:
> - Mensaje original -
> > Alternatively, doing unconditionnally --enable-vala in autogen.sh
> > would
> > work for me too I think.
>
> That sounds reasonable.
Ok, though on second thought I'd rather we also have vala auto
Hi,
On 04/02/2012 01:41 PM, Hans de Goede wrote:
> Hi,
>
> I assumed you've tested things still compile and work after this?
>
> If so ack.
>
> Regards,
>
> Hans
Yes. Btw, the member m_fIPC was not used at all.
>
>
> On 04/02/2012 12:30 PM, Peter Hatina wrote:
>> Hi,
>>
>> can you have a l
Hi,
On 04/02/2012 12:38 PM, Marc-André Lureau wrote:
Hi
- Mensaje original -
Currently, configure doesn't check for vala, nor set vala related
variables unless --enable-vala was passed. autogen.sh automatically
pass --enable-vala if controller.vala.stamp doesn't exist. However,
this is
- Mensaje original -
> Alternatively, doing unconditionnally --enable-vala in autogen.sh
> would
> work for me too I think.
That sounds reasonable.
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mail
Hi,
I assumed you've tested things still compile and work after this?
If so ack.
Regards,
Hans
On 04/02/2012 12:30 PM, Peter Hatina wrote:
Hi,
can you have a look at this, before I can push it to FDO git?
From fef8de569a7268bed272105649941b9dac5f4f98 Mon Sep 17 00:00:00 2001
From: Peter
On Mon, Apr 02, 2012 at 06:38:23AM -0400, Marc-André Lureau wrote:
> Hi
>
> - Mensaje original -
> > Currently, configure doesn't check for vala, nor set vala related
> > variables unless --enable-vala was passed. autogen.sh automatically
> > pass --enable-vala if controller.vala.stamp doe
From: "Daniel P. Berrange"
Tell the compiler that was really do intend to cast from int
to pointer, to prevent warnings about implicit casts
* server/tests/test_display_base.c: Add explicit casts
Signed-off-by: Daniel P. Berrange
---
server/tests/test_display_base.c |4 ++--
1 files chang
From: "Daniel P. Berrange"
* m4/manywarnings.m4m, m4/warnings.m4: Import GNULIB warnings
modules
* m4/spice-compile-warnings.m4: Define SPICE_COMPILE_WARNINGS
* configure.ac: Replace compile warning check with a call to
SPICE_COMPILE_WARNINGS
* client/Makefile.am: Use WARN_CXXFLAGS instead of
From: "Daniel P. Berrange"
* Makefile.am: s/common/spice-common/
Signed-off-by: Daniel P. Berrange
---
client/Makefile.am |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/client/Makefile.am b/client/Makefile.am
index 4913c1e..22d5adf 100644
--- a/client/Makefile.am
+++
From: "Daniel P. Berrange"
* server/smartcard.c: Fix assertion to not check for >= 0 on
unsigned variable
Signed-off-by: Daniel P. Berrange
---
server/smartcard.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/server/smartcard.c b/server/smartcard.c
index 805cb6e.
From: "Daniel P. Berrange"
If a 'goto' statement jumps across a variable declaration
which also has an initializer, the variable is in an undefined
state. Splitting the the declaration & initialization doesn't
change that, but the compiler can at least now detect use of
the unintialized variable
From: "Daniel P. Berrange"
* server/reds.c, server/smartcard.c: s/()/(void)
Signed-off-by: Daniel P. Berrange
---
server/reds.c |2 +-
server/smartcard.c |8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 53fc748..8ae569
From: "Daniel P. Berrange"
The red_worker_main method allocates a RedWorker struct instance
on the stack. This struct is a full 2 MB in size which is not
at all resonable to allocate on the stack.
* server/red_worker.c: Move RedWorker struct to the heap
Signed-off-by: Daniel P. Berrange
---
s
From: "Daniel P. Berrange"
When using setjmp/longjmp the state of local variables can be
undefined in certain scenarios:
[quote man(longjmp)]
The values of automatic variables are unspecified after a
call to longjmp() if they meet all the following criteria:
· they are l
From: "Daniel P. Berrange"
* client/red_channel.cpp: AbortTrigger::on_event can't return
given its current impl
* server/red_worker.c: red_worker_main can't return
Signed-off-by: Daniel P. Berrange
---
client/red_channel.cpp |2 +-
server/red_worker.c|5 ++---
2 files changed, 3
From: "Daniel P. Berrange"
All printf var-args style methods should be annotation with
their format. All format strings must be const strings.
* client/application.cpp, client/cmd_line_parser.cpp,
client/hot_keys.cpp: Avoid non-const format
* client/client_net_socket.cpp: Fix broken format spe
From: "Daniel P. Berrange"
* server/red_worker.c: Add missing const for return type
* server/reds.c: Static strings must be declared const
Signed-off-by: Daniel P. Berrange
---
server/red_worker.c |2 +-
server/reds.c |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
dif
From: "Daniel P. Berrange"
Arithmetic on void * types is non-portable & trivially avoided
* server/dispatcher.c: Use uint8_t for arithmetic
Signed-off-by: Daniel P. Berrange
---
server/dispatcher.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/server/disp
A followup to the previous patch which enabled more compiler warnings
for spice-gtk. This one does the same for 'spice'. Less to fix now
that we have spice-common shared
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesk
- Mensaje original -
> Since --enable-vala may or may not be passed to configure, seeing
> the actual command line that was used is helpful.
To me it's really unnecessary, as the command line that was passed is in
config.log. And we already have a nice message for cases where --enable-v
Hi
- Mensaje original -
> Currently, configure doesn't check for vala, nor set vala related
> variables unless --enable-vala was passed. autogen.sh automatically
> pass --enable-vala if controller.vala.stamp doesn't exist. However,
> this is not enough since if controller.vala is newer tha
Hi,
can you have a look at this, before I can push it to FDO git?
>From fef8de569a7268bed272105649941b9dac5f4f98 Mon Sep 17 00:00:00 2001
From: Peter Hatina
Date: Mon, 2 Apr 2012 12:11:20 +0200
Subject: [PATCH 1/4] remove unused class member
---
SpiceXPI/src/plugin/plugin.h |1 -
1 files c
Since --enable-vala may or may not be passed to configure, seeing
the actual command line that was used is helpful.
---
autogen.sh |1 +
1 file changed, 1 insertion(+)
diff --git a/autogen.sh b/autogen.sh
index 11aedb0..aefd2fd 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -15,6 +15,7 @@ if tes
Currently, configure doesn't check for vala, nor set vala related
variables unless --enable-vala was passed. autogen.sh automatically
pass --enable-vala if controller.vala.stamp doesn't exist. However,
this is not enough since if controller.vala is newer than
controller.vala.stamp, we will need to
Hey,
On Mon, Apr 02, 2012 at 10:42:32AM +0300, Yonit Halperin wrote:
> @@ -482,6 +484,28 @@ void nsPluginInstance::SetUsbAutoShare(PRBool
> aUsbAutoShare)
> // when fixed in RHEVM
> }
>
> +/* attribute string ColorDepth; */
> +char *nsPluginInstance::GetColorDepth() const
> +{
> +retu
ACK.
On 04/02/2012 09:43 AM, Yonit Halperin wrote:
rhbz #808986
Signed-off-by: Yonit Halperin
---
src/remote-viewer.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/remote-viewer.c b/src/remote-viewer.c
index 7dda7fe..5f7685f 100644
--- a/src/remote-viewer.c
ACK.
On 04/02/2012 09:42 AM, Yonit Halperin wrote:
rhbz #747313
Signed-off-by: Yonit Halperin
---
SpiceXPI/src/plugin/nsISpicec.idl|2 ++
SpiceXPI/src/plugin/nsScriptablePeer.cpp | 16 +++-
SpiceXPI/src/plugin/nsScriptablePeer.h |2 ++
SpiceXPI/src/plugin/pl
ACK.
On 04/02/2012 09:42 AM, Yonit Halperin wrote:
rhbz #787449
Signed-off-by: Yonit Halperin
---
data/spice-protocol.vapi |3 +++
gtk/controller/controller.vala |9 +
spice-common |2 +-
3 files changed, 13 insertions(+), 1 deletions(-)
diff --
On Wed, Feb 22, 2012 at 06:12:35PM -0500, Douglas Landgraf wrote:
> Do we have such plugins for Windows users that would like to open
> their vms from browser?
I don't think we have such plugins yet unfortunately... Something really
useful would be someone doing a VisualC++ build of spice-xpi. It
ACK.
On 04/02/2012 09:41 AM, Yonit Halperin wrote:
added the disable-effects and color-depth options to the controller
Signed-off-by: Yonit Halperin
---
spice-protocol |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/spice-protocol b/spice-protocol
index 32da251..8cf9
ACK.
On 04/02/2012 09:41 AM, Yonit Halperin wrote:
rhbz #787447
Signed-off-by: Yonit Halperin
---
spice/controller_prot.h |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/spice/controller_prot.h b/spice/controller_prot.h
index a60b122..f7b1f26 100644
--- a/spice/con
Alon,
In spice client, the creation of the channel is based on
"init->num_of_channels" that is returned from the spice server.
Please see the following function to create the spice channel from the
client
void RedClient::handle_channels(RedPeer::InMessage* message)
{
Spice
rhbz #808986
Signed-off-by: Yonit Halperin
---
src/remote-viewer.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/remote-viewer.c b/src/remote-viewer.c
index 7dda7fe..5f7685f 100644
--- a/src/remote-viewer.c
+++ b/src/remote-viewer.c
@@ -583,7 +583,9 @@ spice_ctr
rhbz #747313
Signed-off-by: Yonit Halperin
---
SpiceXPI/src/plugin/nsISpicec.idl|2 ++
SpiceXPI/src/plugin/nsScriptablePeer.cpp | 16 +++-
SpiceXPI/src/plugin/nsScriptablePeer.h |2 ++
SpiceXPI/src/plugin/plugin.cpp | 26 ++
Spi
rhbz #787449
Signed-off-by: Yonit Halperin
---
data/spice-protocol.vapi |3 +++
gtk/controller/controller.vala |9 +
spice-common |2 +-
3 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/data/spice-protocol.vapi b/data/spice-protocol.vapi
added the disable-effects and color-depth options to the controller
Signed-off-by: Yonit Halperin
---
spice-protocol |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/spice-protocol b/spice-protocol
index 32da251..8cf92f0 16
--- a/spice-protocol
+++ b/spice-protocol
@@
rhbz #787447
Signed-off-by: Yonit Halperin
---
spice/controller_prot.h |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/spice/controller_prot.h b/spice/controller_prot.h
index a60b122..f7b1f26 100644
--- a/spice/controller_prot.h
+++ b/spice/controller_prot.h
@@ -75,6 +
On 04/01/2012 10:41 PM, Marc-André Lureau wrote:
Hi
- Mensaje original -
Indeed - that was the problem - thank you.
I don't know how it was not removed during 'git pull'.
(and already found a spice-gtk bug - the 'shift+F12' combination
seems
to work only as 'left-shift+F12', not 'right-
49 matches
Mail list logo
