[Spice-devel] [PATCH spice-gtk] Use given color depth in monitor configuration

2012-03-16 Thread Marc-André Lureau
The main channel only relied on VD_AGENT_DISPLAY_CONFIG_FLAG_SET_COLOR_DEPTH to set color depth when connecting to a guest. However, that doesn't seem to be enough. Instead send given color depth with monitor configuration. Fix --spice-color-depth option not "apparently" working. --- gtk/channel-

Re: [Spice-devel] [bug spice-gtk] spice-gtk memory leak

2012-03-16 Thread Marc-André Lureau
- Mensaje original - > > Also, running spicy under valgrind leak check tool shows quite > > clearly > > that there is nothing being leaked directly from spice-gtk, it > > seems. > As I told you off-line, It happened to me that remote-viewer > (spice-gtk client) ended up in 1.3GB, Unfortun

Re: [Spice-devel] [bug spice-gtk] spice-gtk memory leak

2012-03-16 Thread Marian Krcmarik
- Original Message - > From: "Marc-André Lureau" > To: "徐舫" > Cc: "spice-devel" > Sent: Friday, March 16, 2012 4:24:50 PM > Subject: Re: [Spice-devel] [bug spice-gtk] spice-gtk memory leak > > On Fri, Mar 16, 2012 at 10:27 AM, 徐舫 wrote: > > But the allocated memory does not free. >

Re: [Spice-devel] [PATCH spice-gtk 1/2] build: fix build with glib < 2.32

2012-03-16 Thread Marc-André Lureau
hi On Fri, Mar 16, 2012 at 5:13 PM, Marc-André Lureau wrote: > +#if GLIB_CHECK_VERSION(2,32,0) > +#define g_mutex_lock(m) g_mutex_lock(&(m)) > +#else > +#endif Oh, this is a leftover, I cleaned it up. -- Marc-André Lureau ___ Spice-devel mailing lis

Re: [Spice-devel] [bug spice-gtk] spice-gtk memory leak

2012-03-16 Thread xufango
Thank you very much. 1) I used Inspector XE 2011 on RHEL6.1 analysis the memory leak problem. Inspector XE 2011 can give the leak location but no call stack. 2) I used most of the spice-gtk code except the spicy.c, and modify no code below the spice-widget.c. Successfully compiled the co

[Spice-devel] [PATCH spice-gtk 2/2] build-sys: if stow is installed, default prefix to it

2012-03-16 Thread Marc-André Lureau
This is going to make life easier for stow users, including myself. --- configure.ac |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 760736a..1ac291f 100644 --- a/configure.ac +++ b/configure.ac @@ -34,6 +34,13 @@ if test "x$ac_cv_pr

[Spice-devel] [PATCH spice-gtk 1/2] build: fix build with glib < 2.32

2012-03-16 Thread Marc-André Lureau
Using GMutex as a static mutex is only possible since 2.32. --- gtk/spice-channel-priv.h |8 +++- gtk/spice-channel.c | 20 ++-- gtk/spice-util-priv.h| 14 ++ 3 files changed, 31 insertions(+), 11 deletions(-) diff --git a/gtk/spice-channel-priv.h

Re: [Spice-devel] [bug spice-gtk] spice-gtk memory leak

2012-03-16 Thread 徐舫
** Thank you very much. 1) I used Inspector XE 2011 on RHEL6.1 analysis the memory leak problem. Inspector XE 2011 can give the leak location but no call stack. 2) I used most of the spice-gtk code except the spicy.c, and modify no code below the spice-widget.c. Successfully compiled the

Re: [Spice-devel] [bug spice-gtk] spice-gtk memory leak

2012-03-16 Thread Marc-André Lureau
On Fri, Mar 16, 2012 at 10:27 AM, 徐舫 wrote: > But the allocated memory does not free. According to massif, the memory usage becomes stable, but your backtrace is correct, the biggest offender is image cache, which can top 150mb. I am not very familiar with the caching logic, so I can't say whethe

[Spice-devel] [bug spice-gtk] spice-gtk memory leak

2012-03-16 Thread 徐舫
We found that spice-gtk exists serious memory leak problem. The call stack is as follow: ---

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-16 Thread Gerd Hoffmann
On 03/15/12 13:36, Hans de Goede wrote: > Hi, > > On 03/15/2012 01:11 PM, Yonit Halperin wrote: >> On 03/13/2012 09:40 AM, Gerd Hoffmann wrote: >>> Hi, >>> It is not easy when you have 2 components, and it is much less easy when you have 3 or 4 components. So why make it more compli