[Spice-devel] [PATCH 5/5] build: use common/client_{de, }marshallers.h

2012-03-14 Thread Marc-André Lureau
--- client/Makefile.am |6 +-- client/demarshallers.h | 27 -- client/marshallers.h | 63 -- client/red_channel.h |4 +- client/red_client.cpp|2 +- client/windows/generate.bat |2 +

[Spice-devel] [PATCH 4/5] build: fix build with new messages.h

2012-03-14 Thread Marc-André Lureau
The new messages.h includes smartcard headers. Make sure we pass the right CFLAGS --- server/tests/Makefile.am |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am index 61fad75..fdaf5cb 100644 --- a/server/tests/Makefile.am +

[Spice-devel] [PATCH 3/5] Copy common/win/my_getopt-1.5/my_getopt.c client/windows/my_getopt.cpp

2012-03-14 Thread Marc-André Lureau
--- client/windows/my_getopt.cpp | 301 +++--- configure.ac |2 - 2 files changed, 280 insertions(+), 23 deletions(-) diff --git a/client/windows/my_getopt.cpp b/client/windows/my_getopt.cpp index 905b717..5237b8e 100644 --- a/client/window

[Spice-devel] [PATCH 0/5] use common submodule

2012-03-14 Thread Marc-André Lureau
Hi, For quite some time, spice-gtk and spice have been using a seperate common/ subdirectory for historical reasons. But the aim has always been to use the same source tree. It hasn't been kept in sync, and I finally decided to take some time to solve this. We agreed in a previous discussion t

[Spice-devel] [PATCH spice-gtk] Fix incorrect array size check

2012-03-14 Thread Marc-André Lureau
--- gtk/spice-channel.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c index 77b066e..be95f00 100644 --- a/gtk/spice-channel.c +++ b/gtk/spice-channel.c @@ -1863,7 +1863,7 @@ const gchar* spice_channel_type_to_string(gint type)

Re: [Spice-devel] [PATCH] Add casts for compatibility purposes

2012-03-14 Thread Marc-André Lureau
Hi On Tue, Feb 14, 2012 at 9:41 AM, Alon Levy wrote: > On Mon, Feb 13, 2012 at 01:53:32PM -0600, Dan McGee wrote: >> Some non-Linux platforms return a (caddr_t *) result for the return >> value of mmap(), which is very unfortunate. Add a (void *) cast to >> explicitly avoid the warning when compi

Re: [Spice-devel] [PATCH spice-gtk] Move undef FORTIFY below config.h

2012-03-14 Thread Daniel P. Berrange
On Wed, Mar 14, 2012 at 08:43:20PM +0100, Marc-André Lureau wrote: > It used to be below, then was moved on top of all, but now it's > defined in config.h. Hopefully below config.h is the right > place. config.h should never have direct includes anyway. > --- > gtk/continuation.c |4 ++-- > 1

[Spice-devel] [PATCH spice-gtk] Move undef FORTIFY below config.h

2012-03-14 Thread Marc-André Lureau
It used to be below, then was moved on top of all, but now it's defined in config.h. Hopefully below config.h is the right place. config.h should never have direct includes anyway. --- gtk/continuation.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gtk/continuation.c

Re: [Spice-devel] [Engine-devel] Hints for building up a spicec connection in Ovirt

2012-03-14 Thread Itamar Heim
On 03/14/2012 04:51 PM, Andrew Wells wrote: I am trying to build a connection manually with spicec (or what ever I need to build the connection with) in Ovirt/RHEV and I am wondering what do I need to form this connection? And if this is the wrong place to ask, can you point me in the correct di

Re: [Spice-devel] [PATCH spice-gtk 1/2] usbredir: Check for existing usb channels after libusb init

2012-03-14 Thread Marc-André Lureau
ack to both On Wed, Mar 14, 2012 at 3:27 PM, Hans de Goede wrote: > Currently trying to view a usbredir enabled vm from virt-manager causes > virt-manager to crash. This crash is caused by the following happening: > > -virt-manager sets up the session, including connecting all the channels > -a s

[Spice-devel] [PATCH spice-server 0.8] client: fix two narrowing conversion c++-11 warnings

2012-03-14 Thread Alon Levy
Warnings are from initializing members of type int from uint32_t. Fix is to change alt_image and red_icon height and width fields to ints. Example warning fixed: res.cpp:58:1: error: narrowing conversion of ‘_red_icon.::width’ from ‘const uint32_t {aka const unsigned int}’ to ‘int’ inside { } is

[Spice-devel] [PATCH spice-gtk 2/2] buildsys: Disable some warnings

2012-03-14 Thread Hans de Goede
Mostly so that they don't turn into errors when building from source: -Wno-missing-field-initializers: Because this has to be close to the most stupid warning gcc has ever produced -Wno-deprecated-declarations Because we use some deprecated functions to avoid #ifdef hell while maintaining compat wi

[Spice-devel] [PATCH spice-gtk 1/2] usbredir: Check for existing usb channels after libusb init

2012-03-14 Thread Hans de Goede
Currently trying to view a usbredir enabled vm from virt-manager causes virt-manager to crash. This crash is caused by the following happening: -virt-manager sets up the session, including connecting all the channels -a spice-gtk internal code path calls spice_usb_device_manager_get() -spice_usb_d

Re: [Spice-devel] repository reorg

2012-03-14 Thread Alon Levy
On Wed, Mar 14, 2012 at 02:09:06PM +0100, Marc-André Lureau wrote: > On Tue, Jun 28, 2011 at 12:32 PM, Christophe Fergeau > wrote: > > On Tue, Jun 28, 2011 at 12:26:18PM +0200, Alon Levy wrote: > >> I'm going along with suggestion 3+, where spice-common is a submodule, > >> not a library. > > > >

Re: [Spice-devel] repository reorg

2012-03-14 Thread Marc-André Lureau
On Tue, Jun 28, 2011 at 12:32 PM, Christophe Fergeau wrote: > On Tue, Jun 28, 2011 at 12:26:18PM +0200, Alon Levy wrote: >> I'm going along with suggestion 3+, where spice-common is a submodule, >> not a library. > > Which doesn't prevent us from making it a library later on. fyi, I started the c

Re: [Spice-devel] [PATCH spice-xpi] ~/.spicec is no longer needed

2012-03-14 Thread Peter Hatina
On 03/13/2012 06:40 PM, Alon Levy wrote: > On Tue, Mar 13, 2012 at 05:39:51PM +0100, Marc-André Lureau wrote: >> ping >> > > I'm just not sure about this - maybe someone who actually uses spice-xpi > can say something about it? > >> On Fri, Mar 9, 2012 at 7:20 PM, Marc-André Lureau >> wrote: >>>

Re: [Spice-devel] Xspice fails on F17 and Ubuntu 12.04

2012-03-14 Thread Alon Levy
On Mon, Mar 12, 2012 at 07:38:41PM +0200, Eugene San wrote: >Hi all, > >Recently I've performed an atempt to setup and run Xspice. > >I have tried on F17 and Ubuntu12.04. >On Fedora I used prebult binary. It runs but client connects and >disconnects immidiatly and silently. I

Re: [Spice-devel] [PATCH spice-gtk] usbredir: Check for existing usb channels after libusb init

2012-03-14 Thread Alon Levy
On Wed, Mar 14, 2012 at 09:55:01AM +0100, Hans de Goede wrote: > Currently trying to view a usbredir enabled vm from virt-manager causes > virt-manager to crash. This crash is caused by the following happening: > > -virt-manager sets up the session, including connecting all the channels > -a spice

[Spice-devel] [PATCH spice-gtk] usbredir: Check for existing usb channels after libusb init

2012-03-14 Thread Hans de Goede
Currently trying to view a usbredir enabled vm from virt-manager causes virt-manager to crash. This crash is caused by the following happening: -virt-manager sets up the session, including connecting all the channels -a spice-gtk internal code path calls spice_usb_device_manager_get() -spice_usb_d

Re: [Spice-devel] [PATCH spice-gtk 00/15] Expand usage of compiler warnings

2012-03-14 Thread Daniel P. Berrange
On Wed, Mar 14, 2012 at 01:44:48AM +0100, Marc-André Lureau wrote: > From 360809ac7fa66e244743aa3d14233ccfb817abd2 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= > Date: Wed, 14 Mar 2012 01:04:17 +0100 > Subject: [PATCH spice-gtk 1/4] Remove deprecation warnings > > --- >