Now that red_worker's EventListener is gone there are no more users of it.
Signed-off-by: Hans de Goede
---
server/red_channel.c |3 ---
server/red_channel.h |1 -
2 files changed, 4 deletions(-)
diff --git a/server/red_channel.c b/server/red_channel.c
index 5f906e6..ecb512d 100644
---
Commit 143a1df24e83e9c1e173c16aeb76d61ffdce9598 changed red_worker_main
from epoll to poll. But epoll has edge triggered semantics (when requested
and we requested them), where as poll is always level triggered. And
red_worker was relying on the edge triggered semantics, as it was always
polling fo
We allow channels to have different core implementations, but we were
relying on reds_stream_free to remove the stream watch on disconnect,
and reds_stream_free always uses the qemu core implementation.
So far we were getting away with this since all the alternative core
implementations always ret
The red_worker EventListener struct is either embedded in one of:
1) DisplayChannelClient
2) CursorChannelClient
3) RedWorker
And as such gets destroyed when these get destroyed, in case 1 & 2 through
a call to red_channel_client_destroy().
So free-ing it when the ref-count becomes 0 is wrong, fo
While git-bisecting another issue I ended up hitting and not recognizing
the bug fixed by commit 7a079b452b026d6ce38f95dcc397fa64b059fffb.
While fixing this (again) I noticed that (even after the fix) not all
users of ChannelCbs first zero it. So this patch ensures that all users of
ChannelCbs fir
Hi All,
This patch series fixes an issue where red_worker thread consume as much CPU
as they can get when a client is connected (the interesting part explaining
what is going on is in the 4th patch.
New in v2 is fixing the regression where multi head would crash, which
did turn out to be a proble
Hi,
On 03/10/2012 08:05 PM, Hans de Goede wrote:
Hi All,
This patch series fixes an issue where red_worker thread consume as much CPU
as they can get when a client is connected (the interesting part explaining
what is going on is in the 4th patch.
Unfortunately with this series I can reproduca
Now that red_worker's EventListener is gone there are no more users of it.
Signed-off-by: Hans de Goede
---
server/red_channel.c |3 ---
server/red_channel.h |1 -
2 files changed, 4 deletions(-)
diff --git a/server/red_channel.c b/server/red_channel.c
index 5f906e6..ecb512d 100644
---
Commit 143a1df24e83e9c1e173c16aeb76d61ffdce9598 changed red_worker_main
from epoll to poll. But epoll has edge triggered semantics (when requested
and we requested them), where as poll is always level triggered. And
red_worker was relying on the edge triggered semantics, as it was always
polling fo
We allow channels to have different core implementations, but we were
relying on reds_stream_free to remove the stream watch on disconnect,
and reds_stream_free always uses the qemu core implementation.
So far we were getting away with this since all the alternative core
implementations always ret
The red_worker EventListener struct is either embedded in one of:
1) DisplayChannelClient
2) CursorChannelClient
3) RedWorker
And as such gets destroyed when these get destroyed, in case 1 & 2 through
a call to red_channel_client_destroy().
So free-ing it when the ref-count becomes 0 is wrong, fo
While git-bisecting another issue I ended up hitting and not recognizing
the bug fixed by commit 7a079b452b026d6ce38f95dcc397fa64b059fffb.
While fixing this (again) I noticed that (even after the fix) not all
users of ChannelCbs first zero it. So this patch ensures that all users of
ChannelCbs fir
Hi All,
This patch series fixes an issue where red_worker thread consume as much CPU
as they can get when a client is connected (the interesting part explaining
what is going on is in the 4th patch.
Unfortunately with this series I can reproducably crash the vm (qemu segfaults)
when using multipl
On Sat, Mar 10, 2012 at 08:56:55AM +0100, Hans de Goede wrote:
> Hi,
>
> Thanks for the patches!
>
> Series looks good, ack! I would like one other spice developer more
> familiar with the server to look at it and ack it too and then
> I (or that other developer) will push it to our git master.
On Fri, Mar 09, 2012 at 12:26:50PM -0500, Nahum Shalman wrote:
> If we allow listening on arbitrary sockets like unix sockets,
> we can get ENOPROTOOPT errors from setsockopt calls that set TCP
> specific options. This should be allowed to happen.
I'm a little concerned that we will ignore actual
On Sat, Mar 10, 2012 at 10:58:27AM +0800, Charles.Tsai-蔡清海-研究發展部 wrote:
> Alon,
>
> I am implementing the code for the printing redirection for spice
> client. In the windows client, I know how to do it. Basically, I just follow
> the footprint of the playbackchannel. However, I still
16 matches
Mail list logo
