Re: [Spice-devel] Build problems with Spice-gtk on Ubuntu 10.04

On Thu, Mar 1, 2012 at 8:00 PM, Naga Mohan Pothula wrote: > Hi, > > I'm getting error "missing valac" even I disabled vala while building > spice-gtk on Ubuntu 10.04. > If I enable vala then i'm getting atleast v0.14.0 is required. Ubuntu 10.04 > supports v0.12.0 only. > How can I avoid this error

[Spice-devel] Build problems with Spice-gtk on Ubuntu 10.04

Hi, I'm getting error "missing valac" even I disabled vala while building spice-gtk on Ubuntu 10.04. If I enable vala then i'm getting atleast v0.14.0 is required. Ubuntu 10.04 supports v0.12.0 only. How can I avoid this error? Thanks for your help, Regards, Naga._

Re: [Spice-devel] Announcing spice-protocol 0.10.1 aka the miniheader release

Hi, the release lacks 0.10.1 tag in git. (I don't know if it has any other meaning than that I can not recognize it as a release in cgit so quickly but even then...) David Hans de Goede píše v Po 16. 01. 2012 v 19:49 +0100: > Hi All, > > I'm happy to announce spice-protocol-0.10.1 > > Major c

Re: [Spice-devel] [Users] spice client support for windows

To expound: The spice console used in both the case of RHEV or ovirt: --> http://ftp.redhat.com/pub/redhat/linux/enterprise/6Server/en/RHEV/ --> SRPMS/rhevm-spice-client-3.0-21.el6.src.rpm We rebuild the above rpm and extr

Re: [Spice-devel] [Users] spice client support for windows

We were able to download the source rpm and build it, then extract the msi files to manually install spice for windows. Jason From: users-boun...@ovirt.org [mailto:users-boun...@ovirt.org] On Behalf Of sawan k r Sent: Thursday, March 01, 2012 10:23 AM To: Marian Krcmarik Cc: spice-devel@lis

Re: [Spice-devel] [Users] spice client support for windows

- Original Message - > From: "Itamar Heim" > To: "sawan k r" > Cc: spice-devel@lists.freedesktop.org, us...@ovirt.org > Sent: Thursday, March 1, 2012 4:46:31 PM > Subject: Re: [Spice-devel] [Users] spice client support for windows > > On 03/01/2012 12:44 PM, sawan k r wrote: > > Hi, >

Re: [Spice-devel] [Users] spice client support for windows

On 03/01/2012 12:44 PM, sawan k r wrote: Hi, I was reading on deploying spice on ovirt here - http://www.ovirt.org/wiki/Testing/Spice There is specific line there that says - A Linux client machine with spice client and spice xpi installed (packages spice-client and spice-xpi in Fedora/RHEL). I

Re: [Spice-devel] [PATCH] Fix spacing in VDAgent initialization list

On Thu, Mar 01, 2012 at 02:36:11PM +0100, Christophe Fergeau wrote: > The convention in vdagent codebase seems to put a space before > the opening parenthesis in initialization list, this commit fixes > 2 inconsistencies related to that. ACK. > --- > vdagent/vdagent.cpp |4 ++-- > 1 files ch

[Spice-devel] [PATCH] Fix spacing in VDAgent initialization list

The convention in vdagent codebase seems to put a space before the opening parenthesis in initialization list, this commit fixes 2 inconsistencies related to that. --- vdagent/vdagent.cpp |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/vdagent/vdagent.cpp b/vdagent/vdag

Re: [Spice-devel] [PATCH spice 1/4] build-sys: cleanup, use autoreconf

On Thu, Mar 1, 2012 at 1:44 PM, Alon Levy wrote: > So what did you mean by: >> >> > --enable-gtk-doc --with-gtk=3.0 $enable_vala >> >> >> oops, this is leftover, I removed it >> > > ? oh ok, this part is removed (I initially copied the autogen.sh file from spice-gtk), so yes, I'll push with this

Re: [Spice-devel] [PATCH spice 1/4] build-sys: cleanup, use autoreconf

On Thu, Mar 01, 2012 at 01:14:02PM +0100, Marc-André Lureau wrote: > On Thu, Mar 1, 2012 at 1:09 PM, Alon Levy wrote: > > ACK series with your own comment on 1/4 fixed. > > It's a comment I removed, what do you mean? The patch contains: +if [ -z "$NOCONFIGURE" ]; then +"$srcdir"/configure -

Re: [Spice-devel] [PATCH spice 1/4] build-sys: cleanup, use autoreconf

On Thu, Mar 1, 2012 at 1:09 PM, Alon Levy wrote: > ACK series with your own comment on 1/4 fixed. It's a comment I removed, what do you mean? -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.

Re: [Spice-devel] [PATCH spice 1/4] build-sys: cleanup, use autoreconf

On Thu, Mar 01, 2012 at 12:19:59PM +0100, Marc-André Lureau wrote: > --- ACK series with your own comment on 1/4 fixed. > Makefile.am |2 + > autogen.sh | 167 +++--- > 2 files changed, 11 insertions(+), 158 deletions(-) > > diff --git a

Re: [Spice-devel] [PATCH v2 spicec windows 1/1] client/windows: fix SetClipboardViewer error handling rhbz#786554

On Thu, Mar 01, 2012 at 01:34:32PM +0200, Arnon Gilboa wrote: > MSDN says the following about SetClipboardViewer(): "If an error occurs or > there > are no other windows in the clipboard viewer chain, the return value is NULL". > Seems like the buggy case was "no other windows in the clipboard vie

Re: [Spice-devel] [PATCH spicec windows 1/1] client/windows: fix SetClipboardViewer error handling rhbz#786554

Alon Levy wrote: On Thu, Mar 01, 2012 at 01:10:51PM +0200, Arnon Gilboa wrote: MSDN says the following about SetClipboardViewer(): "If an error occurs or there are no other windows in the clipboard viewer chain, the return value is NULL". Seems like the buggy case was "no other windows in the

Re: [Spice-devel] [PATCH spice 3/4] build-sys: cleanup server/tests/Makefile.am

On Thu, Mar 01, 2012 at 12:20:01PM +0100, Marc-André Lureau wrote: > --- > server/tests/Makefile.am | 53 + > 1 files changed, 43 insertions(+), 10 deletions(-) > $(NULL) is just to have an eye catching end and be able to line copy any other line wit

Re: [Spice-devel] [PATCH 00/20] vdagent mingw compilation

ACK series, with Alon's min/max fix. Needs some more testing of both VC++ & mingw builds. Christophe Fergeau wrote: Hi, This patch series fixes most of the issues I had when trying to compile vdagent-win with mingw. It also adds an autotools-based build system since as a more convenient way of

Re: [Spice-devel] [PATCH spice 1/4] build-sys: cleanup, use autoreconf

On Thu, Mar 01, 2012 at 12:19:59PM +0100, Marc-André Lureau wrote: > --- > Makefile.am |2 + > autogen.sh | 167 +++--- > 2 files changed, 11 insertions(+), 158 deletions(-) > > diff --git a/Makefile.am b/Makefile.am > index c807359..33bb

Re: [Spice-devel] [PATCH spicec windows 1/1] client/windows: fix SetClipboardViewer error handling rhbz#786554

On Thu, Mar 01, 2012 at 01:10:51PM +0200, Arnon Gilboa wrote: > MSDN says the following about SetClipboardViewer(): "If an error occurs or > there > are no other windows in the clipboard viewer chain, the return value is NULL". > Seems like the buggy case was "no other windows in the clipboard vie

Re: [Spice-devel] [PATCH 05/20] mingw: use explicit std:: namespace for min/max

On Thu, Mar 01, 2012 at 01:47:18PM +0200, Alon Levy wrote: > On Thu, Mar 01, 2012 at 11:17:39AM +0100, Christophe Fergeau wrote: > > --- > > vdagent/desktop_layout.cpp | 34 ++ > > 1 files changed, 30 insertions(+), 4 deletions(-) > > > > diff --git a/vdagent/des

Re: [Spice-devel] [PATCH 00/20] vdagent mingw compilation

On Thu, Mar 01, 2012 at 11:17:34AM +0100, Christophe Fergeau wrote: > Hi, > ACK series, just one suggestion for the std::min/max issue. > This patch series fixes most of the issues I had when trying to compile > vdagent-win with mingw. It also adds an autotools-based build system since > as a mo

Re: [Spice-devel] [PATCH 08/20] mingw: fix initialization list order for VDAgent()

On Thu, Mar 01, 2012 at 11:17:42AM +0100, Christophe Fergeau wrote: > --- > vdagent/vdagent.cpp |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp > index 22e9c59..1cfa96d 100644 > --- a/vdagent/vdagent.cpp > +++ b/vdagent/vd

Re: [Spice-devel] [PATCH 05/20] mingw: use explicit std:: namespace for min/max

On Thu, Mar 01, 2012 at 11:17:39AM +0100, Christophe Fergeau wrote: > --- > vdagent/desktop_layout.cpp | 34 ++ > 1 files changed, 30 insertions(+), 4 deletions(-) > > diff --git a/vdagent/desktop_layout.cpp b/vdagent/desktop_layout.cpp > index f880fd3..b599aa3 1

[Spice-devel] [PATCH v2 spicec windows 1/1] client/windows: fix SetClipboardViewer error handling rhbz#786554

MSDN says the following about SetClipboardViewer(): "If an error occurs or there are no other windows in the clipboard viewer chain, the return value is NULL". Seems like the buggy case was "no other windows in the clipboard viewer chain", which explains the 3rd party clipboard manager workaround d

Re: [Spice-devel] [PATCH spice 1/4] build-sys: cleanup, use autoreconf

On Thu, Mar 1, 2012 at 12:19 PM, Marc-André Lureau wrote: > --enable-gtk-doc --with-gtk=3.0 $enable_vala oops, this is leftover, I removed it -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop

[Spice-devel] [PATCH spice 4/4] build-sys: fix make distcheck

- Do not refer to .c files managed by another makefile (this will fail make distclean) - Do not refer to files by relative path (should use $top_srcdir for ex) - Use LDADD for object linking instead of LDFLAGS, for linker flags --- server/tests/Makefile.am |4 ++-- 1 files changed, 2 inserti

[Spice-devel] [PATCH spice 3/4] build-sys: cleanup server/tests/Makefile.am

--- server/tests/Makefile.am | 53 + 1 files changed, 43 insertions(+), 10 deletions(-) diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am index bc4e00e..31c8372 100644 --- a/server/tests/Makefile.am +++ b/server/tests/Makefile.am @@ -13

[Spice-devel] [PATCH spice 2/4] build-sys: use spice-protocol as submodule

--- .gitmodules|3 +++ Makefile.am|1 + autogen.sh |3 +++ configure.ac |4 +++- spice-protocol |1 + 5 files changed, 11 insertions(+), 1 deletions(-) create mode 100644 .gitmodules create mode 16 spice-protocol diff --git a/.gitmodules b/.gitmodules new f

[Spice-devel] [PATCH spice 1/4] build-sys: cleanup, use autoreconf

--- Makefile.am |2 + autogen.sh | 167 +++--- 2 files changed, 11 insertions(+), 158 deletions(-) diff --git a/Makefile.am b/Makefile.am index c807359..33bb25c 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,3 +1,5 @@ +ACLOCAL_AMFLAGS =

[Spice-devel] [PATCH spicec windows 1/1] client/windows: fix SetClipboardViewer error handling rhbz#786554

MSDN says the following about SetClipboardViewer(): "If an error occurs or there are no other windows in the clipboard viewer chain, the return value is NULL". Seems like the buggy case was "no other windows in the clipboard viewer chain", which explains the 3rd party clipboard manager workaround d

Re: [Spice-devel] (no subject)

On Wed, Feb 29, 2012 at 07:01:53PM +0100, Christophe Fergeau wrote: > Hey, > > Here is a patch series to fix the build of spice-client on mingw. The build > is currently broken with the latest ming32-win-pthreads update because a > function got missing (bug reported upstream). I couldn't test it d

[Spice-devel] [PATCH 20/20] mingw: add Visual C++ files to EXTRA_DIST

--- Makefile.am | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/Makefile.am b/Makefile.am index 5286ddf..2e845ec 100644 --- a/Makefile.am +++ b/Makefile.am @@ -35,4 +35,14 @@ vdservice_LDADD = -lwtsapi32 vdagent_LDADD = $(CXIMAGE_LIBS) vdagent_CXXFLAGS = $(CXIM

[Spice-devel] [PATCH 19/20] mingw: make sure unicode support is enabled

UNICODE and _UNICODE must be defined before including any mingw header for proper unicode support. --- Makefile.am |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile.am b/Makefile.am index 0aa0328..5286ddf 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,6 +1,7 @@ I

[Spice-devel] [PATCH 18/20] mingw: workaround _ftime_s bug

mingw has a _ftime_s prototype in its headers, but no corresponding symbol available at link time. Workaround this issue for now by #defining it to _ftime. This is untested on win64 where the workaround may not be needed. --- common/vdlog.h |8 +++- 1 files changed, 7 insertions(+), 1 del

[Spice-devel] [PATCH 17/20] mingw: add autotools build system

This makes building with mingw much more convenient. --- Makefile.am | 37 +++ configure.ac | 87 + git.mk | 200 ++ 3 files changed, 324 insertions(+), 0 deletions(-) create mode 100644 Makefile.a

[Spice-devel] [PATCH 16/20] mingw: fix format string for wchar_t

%ls (or %S) must be used to printf a wchar_t * --- vdservice/virtio_vdi_port.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vdservice/virtio_vdi_port.cpp b/vdservice/virtio_vdi_port.cpp index c33cee0..31a3862 100644 --- a/vdservice/virtio_vdi_port.cpp +++ b/vdservice

[Spice-devel] [PATCH 15/20] mingw: fix another signed/unsigned warning

VDAgent::_mouse_x and VDAgent::_mouse_y are both signed but are always assigned values from VDAgentMouseState which are unsigned. gcc warns about this so change them to unsigned values. --- vdagent/vdagent.cpp |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/vdagent/vdag

[Spice-devel] [PATCH 14/20] mingw: use const char * in DisplaySetting()

If we use char * instead of const char *, mingw gets confused when calling the constructor with a const char *: it tries to convert it to a mutable string through a std::string conversion and outputs a warning. --- vdagent/display_setting.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(

[Spice-devel] [PATCH 13/20] mingw: don't redefine CTL_CODE if it's already defined

--- vdservice/pci_vdi_port.cpp |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/vdservice/pci_vdi_port.cpp b/vdservice/pci_vdi_port.cpp index fce13bd..4deace1 100644 --- a/vdservice/pci_vdi_port.cpp +++ b/vdservice/pci_vdi_port.cpp @@ -24,9 +24,12 @@ #define METHOD_BUFFE

[Spice-devel] [PATCH 12/20] mingw: workaround ximage.h #defining min/max

This confuses the deque implementation of gcc which uses std::min std::max and causes compile failure. --- vdagent/vdagent.cpp |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp index 06c701d..a288861 100644 --- a/vdagent/vdagent.cpp

[Spice-devel] [PATCH 11/20] mingw: fix signed/unsigned comparison warning

DWORD is an unsigned long, but it's assigned -1 in various places. mingw warns when comparing a DWORD value against -1. This commit casts the -1 to DWORD to avoid the warning. --- vdagent/desktop_layout.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vdagent/desktop_l

[Spice-devel] [PATCH 10/20] mingw: workaround "use of unitialized var" warning

mingw warns about using a variable before it's initialized, but it's a false alarm. Initialize it to 0 to avoid the warning. --- vdagent/vdagent.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp index 3f56292..06c701d 100644 ---

[Spice-devel] [PATCH 09/20] mingw: use unsigned int in for loops when needed

gcc complains about mixed use of signed/unsigned otherwise --- vdagent/vdagent.cpp |8 vdservice/vdservice.cpp |2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp index 1cfa96d..3f56292 100644 --- a/vdagent/vdagent.cp

[Spice-devel] [PATCH 08/20] mingw: fix initialization list order for VDAgent()

--- vdagent/vdagent.cpp |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp index 22e9c59..1cfa96d 100644 --- a/vdagent/vdagent.cpp +++ b/vdagent/vdagent.cpp @@ -176,9 +176,9 @@ VDAgent::VDAgent() , _display_setting (VD_AGENT_R

[Spice-devel] [PATCH 07/20] mingw: remove unused variable

--- vdagent/display_setting.cpp |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/vdagent/display_setting.cpp b/vdagent/display_setting.cpp index 8abef3f..fdf5a31 100644 --- a/vdagent/display_setting.cpp +++ b/vdagent/display_setting.cpp @@ -122,7 +122,6 @@ DWORD DisplaySett

[Spice-devel] [PATCH 06/20] mingw: fix header case

linux systems need it in lower-case, Windows systems shouldn't care. --- vdagent/display_setting.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vdagent/display_setting.cpp b/vdagent/display_setting.cpp index 0116346..8abef3f 100644 --- a/vdagent/display_setting.cpp +

[Spice-devel] [PATCH 05/20] mingw: use explicit std:: namespace for min/max

--- vdagent/desktop_layout.cpp | 34 ++ 1 files changed, 30 insertions(+), 4 deletions(-) diff --git a/vdagent/desktop_layout.cpp b/vdagent/desktop_layout.cpp index f880fd3..b599aa3 100644 --- a/vdagent/desktop_layout.cpp +++ b/vdagent/desktop_layout.cpp @@ -18,6

[Spice-devel] [PATCH 04/20] mingw: use gcc attributes for struct packing

It automatically chooses between using the gcc construct or the visual-c++ construct at compile-time. --- common/vdcommon.h | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/common/vdcommon.h b/common/vdcommon.h index edcfa1e..c5268f4 100644 --- a/common/vdcommon

[Spice-devel] [PATCH 03/20] mingw: disable vc-specific #pragma

--- common/vdcommon.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/common/vdcommon.h b/common/vdcommon.h index 1097720..edcfa1e 100644 --- a/common/vdcommon.h +++ b/common/vdcommon.h @@ -18,7 +18,9 @@ #ifndef _H_VDCOMMON #define _H_VDCOMMON +#if !defined __GNUC__

[Spice-devel] [PATCH 02/20] mingw: don't redefine SIZE_MAX

mingw already has SIZE_MAX defined so don't try to redefine it to avoid a warning. --- common/stdint.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/common/stdint.h b/common/stdint.h index 250efb5..411f5bf 100644 --- a/common/stdint.h +++ b/common/stdint.h @@ -296,7 +29

[Spice-devel] [PATCH 00/20] vdagent mingw compilation

Hi, This patch series fixes most of the issues I had when trying to compile vdagent-win with mingw. It also adds an autotools-based build system since as a more convenient way of building with mingw. With these patches, vdagent can nearly be compiled using mingw. There are still a few pending issu

[Spice-devel] [PATCH 01/20] mingw: fix format string warnings

Most of them are caused by not using %lu to print a DWORD (which is an unsigned long). --- common/vdlog.cpp |2 +- common/vdlog.h|2 +- vdagent/desktop_layout.cpp|4 +- vdagent/display_setting.cpp | 52 +++--- vdagent

Re: [Spice-devel] [PATCH spice-gtk] Allow open_fd() to be called with -1

Ack. On 02/29/2012 02:03 PM, Marc-André Lureau wrote: In this case, a valid fd will be requested via the SpiceChannel::open-fd signal. --- gtk/spice-channel.c |8 ++-- gtk/spice-session.c |8 ++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/gtk/spice-chann

Re: [Spice-devel] [PATCH spice 1/2] build-sys: use spice-protocol as a submodule

On Thu, Mar 01, 2012 at 12:39:40AM +0100, Marc-André Lureau wrote: > --- > .gitmodules|3 + > Makefile.am|3 + > autogen.sh | 167 +++ NACK for the autogen.sh changes, if you want to switch to autoreconf -v --force --install

Re: [Spice-devel] [PATCH spice 2/2] build-sys: fix make distcheck

NACK, I can't even spot the actual fixes in the middle of all this reformatting... Christophe On Thu, Mar 01, 2012 at 12:39:41AM +0100, Marc-André Lureau wrote: > --- > server/tests/Makefile.am | 44 +--- > 1 files changed, 37 insertions(+), 7 deletions(