[Spice-devel] [PATCH spice 2/2] build-sys: fix make distcheck

2012-02-29 Thread Marc-André Lureau
--- server/tests/Makefile.am | 44 +--- 1 files changed, 37 insertions(+), 7 deletions(-) diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am index bc4e00e..ff0e3ed 100644 --- a/server/tests/Makefile.am +++ b/server/tests/Makefile.am @@ -13,2

[Spice-devel] [PATCH spice 1/2] build-sys: use spice-protocol as a submodule

2012-02-29 Thread Marc-André Lureau
--- .gitmodules|3 + Makefile.am|3 + autogen.sh | 167 +++ configure.ac |4 +- spice-protocol |1 + 5 files changed, 20 insertions(+), 158 deletions(-) create mode 100644 .gitmodules create mode 16 spice-prot

[Spice-devel] [PATCH spice 1/2] build-sys: use spice-protocol as a submodule

2012-02-29 Thread Marc-André Lureau
--- .gitmodules|3 + Makefile.am|3 + autogen.sh | 167 +++ configure.ac |4 +- spice-protocol |1 + 5 files changed, 20 insertions(+), 158 deletions(-) create mode 100644 .gitmodules create mode 16 spice-prot

[Spice-devel] [PATCH 6/6] mingw: workaround weird openssl build failure

2012-02-29 Thread Christophe Fergeau
If X509_NAME isn't undefined before including x509v3.h, very weird compilation error occurs. It seems to be caused by duplicate definitions for this symbols coming from wincrypto.h --- common/ssl_verify.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/common/ssl_verify.h

[Spice-devel] [PATCH 5/6] mingw: don't try to redefine alloca

2012-02-29 Thread Christophe Fergeau
mingw already has a #define alloca __builtin_alloca so trying to redefine it triggers a warning. --- common/mem.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/common/mem.h b/common/mem.h index 980ea13..af89ba6 100644 --- a/common/mem.h +++ b/common/mem.h @@ -41,7 +41,9

[Spice-devel] [PATCH 4/6] mingw: fix signed/unsigned comparison warnings

2012-02-29 Thread Christophe Fergeau
--- client/red_client.h|2 +- client/windows/event_sources_p.cpp |2 +- client/windows/red_window.cpp |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/client/red_client.h b/client/red_client.h index 8872ce8..577ccb7 100644 --- a/client/red_clie

[Spice-devel] [PATCH 3/6] mingw: add workaround for _ftime_s issue on mingw

2012-02-29 Thread Christophe Fergeau
mingw has a _ftime_s prototype in its headers, but no corresponding symbol available at link time. Workaround this issue for now by #defining it to _ftime. This is untested on win64 where the workaround may not be needed. --- client/threads.cpp |7 +++ 1 files changed, 7 insertions(+), 0

[Spice-devel] [PATCH 2/6] mingw: #ifdef unneeded #define in common.h

2012-02-29 Thread Christophe Fergeau
common.h has some #define when doing win32 build to workaround a few missing functions on these systems. However, since mingw32 has some of these, this causes either warnings about redefining preprocessor symbols or wreak havoc in mingw headers trying to use these symbols. This commit wraps these s

[Spice-devel] [PATCH 1/6] mingw: use uintptr_t when converting a pointer to an int

2012-02-29 Thread Christophe Fergeau
win64 uses 32 bit long, so we cannot use a long to hold a 64 bit pointer. Thankfully, there's a [u]intptr_t type available exactly for these uses. --- client/canvas.cpp |2 +- client/cursor.cpp |2 +- common/draw.h |4 ++-- common/pixman_utils.c |6 +++--- 4 files c

[Spice-devel] (no subject)

2012-02-29 Thread Christophe Fergeau
Hey, Here is a patch series to fix the build of spice-client on mingw. The build is currently broken with the latest ming32-win-pthreads update because a function got missing (bug reported upstream). I couldn't test it doesn't break VC++ builds because the build seems to be broken before these pat

Re: [Spice-devel] [PATCH spice-gtk 2/2] Add a spice-controller-dump testing tool

2012-02-29 Thread Christophe Fergeau
On Wed, Feb 29, 2012 at 03:04:18PM +0100, Marc-André Lureau wrote: > By default, start a controller listener. > If ran with --menu, start a foreign-menu listener. ACK for this one too > --- > gtk/controller/Makefile.am |5 ++- > gtk/controller/dump.c | 117 > ++

Re: [Spice-devel] [PATCH spice-gtk 1/2] Add controller foreign menu support

2012-02-29 Thread Christophe Fergeau
I'm not fluent in vala, but this looks sane after a quick glance. Christophe On Wed, Feb 29, 2012 at 03:04:17PM +0100, Marc-André Lureau wrote: > --- > data/spice-protocol.vapi | 91 +++ > gtk/controller/Makefile.am | 10 +- > gtk/controller/cust

Re: [Spice-devel] [PATCH 1/2] client: keyboard - add mapping for volume keys

2012-02-29 Thread Alon Levy
On Wed, Feb 29, 2012 at 05:28:30PM +0200, Yonit Halperin wrote: > Add support for sending volume keys scancodes to the guest > RHBZ #552539 Can you add a comment to say where you got the scancodes from? would be useful for future similar patches. ACK for both patches. > > Signed-off-by: Yonit H

[Spice-devel] [PATCH 2/2] client X11: support volume keys when evdev is in use

2012-02-29 Thread Yonit Halperin
Add support for sending volume keys scancodes to the guest RHBZ #552539 Signed-off-by: Yonit Halperin --- client/x11/red_window.cpp |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/client/x11/red_window.cpp b/client/x11/red_window.cpp index b16249e..fda90d5 100644 --

[Spice-devel] [PATCH 1/2] client: keyboard - add mapping for volume keys

2012-02-29 Thread Yonit Halperin
Add support for sending volume keys scancodes to the guest RHBZ #552539 Signed-off-by: Yonit Halperin --- client/inputs_channel.cpp |3 +++ client/red_key.h |3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/client/inputs_channel.cpp b/client/inputs_channel.c

[Spice-devel] Patch to fix the bug in spice-client

2012-02-29 Thread Divya
Hello list I find that spice-client (spicec) does not honour the screen value of DISPLAY variable in multi head setup. spicec started from any of the DISPLAY, opens up the client window on DISPLAY :0.0. I have fixed this issue and attaching the patch herewith. Locally it is working fine for me. I w

[Spice-devel] [PATCH spice-gtk 2/2] Add a spice-controller-dump testing tool

2012-02-29 Thread Marc-André Lureau
By default, start a controller listener. If ran with --menu, start a foreign-menu listener. --- gtk/controller/Makefile.am |5 ++- gtk/controller/dump.c | 117 gtk/controller/test.c | 21 ++-- 3 files changed, 137 insertions(+), 6 d

[Spice-devel] [PATCH spice-gtk 1/2] Add controller foreign menu support

2012-02-29 Thread Marc-André Lureau
--- data/spice-protocol.vapi | 91 +++ gtk/controller/Makefile.am | 10 +- gtk/controller/custom.vapi |9 + gtk/controller/foreign-menu.vala | 207 ++ gtk/controller/menu.vala

Re: [Spice-devel] [PATCH] Fix compilation when smartcard support is disabled

2012-02-29 Thread Alon Levy
On Wed, Feb 29, 2012 at 01:25:48PM +0100, Christophe Fergeau wrote: > On Wed, Feb 29, 2012 at 01:35:20PM +0200, Alon Levy wrote: > > On Wed, Feb 29, 2012 at 12:12:38PM +0100, Christophe Fergeau wrote: > > > The addition of smartcard control to the controller doesn't handle > > > the case when smart

[Spice-devel] [PATCH spice-gtk] Allow open_fd() to be called with -1

2012-02-29 Thread Marc-André Lureau
In this case, a valid fd will be requested via the SpiceChannel::open-fd signal. --- gtk/spice-channel.c |8 ++-- gtk/spice-session.c |8 ++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c index 972a3bb..c1c145a 100644 ---

Re: [Spice-devel] [PATCH] Fix compilation when smartcard support is disabled

2012-02-29 Thread Christophe Fergeau
On Wed, Feb 29, 2012 at 01:35:20PM +0200, Alon Levy wrote: > On Wed, Feb 29, 2012 at 12:12:38PM +0100, Christophe Fergeau wrote: > > The addition of smartcard control to the controller doesn't handle > > the case when smartcard support is disabled at compile time. When > > this is the case, this ca

Re: [Spice-devel] [PATCH] Fix compilation when smartcard support is disabled

2012-02-29 Thread Alon Levy
On Wed, Feb 29, 2012 at 12:12:38PM +0100, Christophe Fergeau wrote: > The addition of smartcard control to the controller doesn't handle > the case when smartcard support is disabled at compile time. When > this is the case, this causes compile errors. ACK. I would probably have just ifdefed the i

[Spice-devel] [PATCH] Fix compilation when smartcard support is disabled

2012-02-29 Thread Christophe Fergeau
The addition of smartcard control to the controller doesn't handle the case when smartcard support is disabled at compile time. When this is the case, this causes compile errors. --- client/application.cpp |2 ++ client/application.h |2 ++ client/controller.cpp |2 ++ client/contro