Christophe, Alon,
Seems I missed saying that this issue happens connecting windows guest from
windows client only.
RedClient::abort_channels function returns always false for this scenario. ie.,
RecordChannel::abort, PlaybackChannel::abort are not getting called.
Hence, RedClient::delete_channe
On Fri, Feb 24, 2012 at 03:20:21PM +0100, Marc-André Lureau wrote:
> When the child exits quickly (failed to start etc..), it doesn't get
> tracked properly and when receiving sigchld, "fake_this" may be NULL
> leading to a crash (fake_this = s_children[info->si_pid])
ACK series.
> ---
> SpiceXP
On Fri, Feb 24, 2012 at 03:20:23PM +0100, Marc-André Lureau wrote:
> - remove invalid or obsolete includes, variables
> - get rid of useless variables
> - make it more silent
> - shorten file location: /foo/baz/bar -> bar
> - prefer $(top_srcdir)/foo/bar vs ../../../foo/bar
> - remove useless confi
On Fri, Feb 24, 2012 at 12:18:59PM +0100, Marc-André Lureau wrote:
> Hi
>
> On Fri, Feb 24, 2012 at 12:10 PM, Alon Levy wrote:
> >
> > I was with you until you suggested to use ldpreload. Is there an actual
> > easy way to do this to redirect error messages somewhere?
>
> ldpreload can be useful
hello,
spice-gtk-0.9 and usbredir 0.3 runs well,
but if i'm trying spice-gtk-0.10 + usbredir 0.4 , it does not.
spicy -h 10.10.4.226 -p 5930 -f
libusb:debug [libusb_init]
libusb:debug [find_usbfs_path] found usbfs at /dev/bus/usb
libusb:debug [op_init] bulk continuation flag supported
libusb:d
glib-compat.c was added to SPICE_GTK_SOURCES_COMMON since with the
new SpiceUsbDeviceWidget libspice-client-gtk now also uses G_TYPE_ERROR
and when compiling with an older glib this gets defined in glib-compat.o
However doing this turns out to be a very BAD idea, since having
glib-compat.o linked
---
SpiceXPI/src/plugin/controller.cpp |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/SpiceXPI/src/plugin/controller.cpp
b/SpiceXPI/src/plugin/controller.cpp
index 131cfc5..23c853b 100644
--- a/SpiceXPI/src/plugin/controller.cpp
+++ b/SpiceXPI/src/plugin/controller.cpp
GLib is used in the defacto library for desktop projects. It includes
logging facilities that can be filtered by domain and level, and can
be redirected or formated in various ways. Instead of pulling an extra
large depedency for a small plugin, let's use what is common to the
desktop.
Afaict, nob
- remove invalid or obsolete includes, variables
- get rid of useless variables
- make it more silent
- shorten file location: /foo/baz/bar -> bar
- prefer $(top_srcdir)/foo/bar vs ../../../foo/bar
- remove useless configure check
- sort a few lines
---
Makefile.am |3 +-
S
---
.gitmodules|3 +++
Makefile.am|1 +
autogen.sh |3 +++
configure.ac |3 ++-
spice-protocol |1 +
5 files changed, 10 insertions(+), 1 deletions(-)
create mode 100644 .gitmodules
create mode 16 spice-protocol
diff --git a/.gitmodules b/.gitmodules
new fi
When the child exits quickly (failed to start etc..), it doesn't get
tracked properly and when receiving sigchld, "fake_this" may be NULL
leading to a crash (fake_this = s_children[info->si_pid])
---
SpiceXPI/src/plugin/plugin.cpp | 34 +++---
1 files changed, 31 inse
ack
- Mensaje original -
> Signed-off-by: Hans de Goede
> ---
> configure.ac |2 ++
> gtk/spice-client-glib-usb-acl-helper.c | 19 +++
> 2 files changed, 21 insertions(+), 0 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index
Hi,
On the download page: http://spice-space.org/download.html , the windows client
is very old: spice-client-win32-0.6.3.zip .
Can some one share me the latest (0.10) 32bit windows binary client ?
Regards,
Dongsheng
___
Spice-devel mailing list
Spice-
Signed-off-by: Hans de Goede
---
configure.ac |2 ++
gtk/spice-client-glib-usb-acl-helper.c | 19 +++
2 files changed, 21 insertions(+), 0 deletions(-)
diff --git a/configure.ac b/configure.ac
index 6e8c8e3..1d24773 100644
--- a/configure.ac
+++ b/
On Fri, Feb 24, 2012 at 01:46:13PM +0200, Alon Levy wrote:
> On Fri, Feb 24, 2012 at 06:08:38AM -0500, Marc-André Lureau wrote:
> > Hi
> >
> > - Mensaje original -
> > > On Fri, Feb 24, 2012 at 11:54:36AM +0100, Marc-André Lureau wrote:
> > >
> > > Is it just me or does this patch do way m
On Fri, Feb 24, 2012 at 06:08:38AM -0500, Marc-André Lureau wrote:
> Hi
>
> - Mensaje original -
> > On Fri, Feb 24, 2012 at 11:54:36AM +0100, Marc-André Lureau wrote:
> >
> > Is it just me or does this patch do way more then the subject says? I
> > don't feel I can review it the way it is
On Fri, Feb 24, 2012 at 12:11 PM, Alon Levy wrote:
> Shouldn't this be squashed to the previous one?
It was not used. It could be reordered as the first patch, or melt
into any other patch I sent.
--
Marc-André Lureau
___
Spice-devel mailing list
Spic
Hi
On Fri, Feb 24, 2012 at 12:10 PM, Alon Levy wrote:
>
> I was with you until you suggested to use ldpreload. Is there an actual
> easy way to do this to redirect error messages somewhere?
ldpreload can be useful if you want to override and use your own g_log
handler for debugging. I don't mean
On Fri, Feb 24, 2012 at 11:54:38AM +0100, Marc-André Lureau wrote:
Shouldn't this be squashed to the previous one?
> ---
> SpiceXPI/src/plugin/controller.cpp |2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/SpiceXPI/src/plugin/controller.cpp
> b/SpiceXPI/src/plugi
On Fri, Feb 24, 2012 at 11:54:37AM +0100, Marc-André Lureau wrote:
> GLib is used in the defacto library for desktop projects. It includes
> logging facilities that can be filtered by domain and level, and can
> be redirected or formated in various ways. Instead of pulling an extra
> large depedenc
Hi
- Mensaje original -
> On Fri, Feb 24, 2012 at 11:54:36AM +0100, Marc-André Lureau wrote:
>
> Is it just me or does this patch do way more then the subject says? I
> don't feel I can review it the way it is.
I cleans up a bit the build-sys
I thought there was no need for seperate pat
Hi
> > +close(pipe_fds[0]);
> > +pipe_fds[0] = -1;
> > +
> > +s_children[child] = this;
> > +
> > +close(pipe_fds[1]);
> > +pipe_fds[1] = -1;
> > +
>
> So you're not doing a write, but instead just a close, and so the
> child's read should return 0?
yes
On Fri, Feb 24, 2012 at 11:54:36AM +0100, Marc-André Lureau wrote:
Is it just me or does this patch do way more then the subject says? I
don't feel I can review it the way it is.
> ---
> .gitmodules |3 +
> Makefile.am |4 +-
> SpiceXPI/Makefile.am
On Fri, Feb 24, 2012 at 11:54:35AM +0100, Marc-André Lureau wrote:
> When the child exits quickly (failed to start etc..), it doesn't get
> tracked properly and when receiving sigchld, "fake_this" may be NULL
> leading to a crash (fake_this = s_children[info->si_pid])
> ---
> SpiceXPI/src/plugin/p
---
SpiceXPI/src/plugin/controller.cpp |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/SpiceXPI/src/plugin/controller.cpp
b/SpiceXPI/src/plugin/controller.cpp
index 131cfc5..23c853b 100644
--- a/SpiceXPI/src/plugin/controller.cpp
+++ b/SpiceXPI/src/plugin/controller.cpp
GLib is used in the defacto library for desktop projects. It includes
logging facilities that can be filtered by domain and level, and can
be redirected or formated in various ways. Instead of pulling an extra
large depedency for a small plugin, let's use what is common to the
desktop.
Afaict, nob
---
.gitmodules |3 +
Makefile.am |4 +-
SpiceXPI/Makefile.am| 17 +++
SpiceXPI/src/plugin/Makefile.am | 102 ++
autogen.sh |3 +
configure.ac| 21 +
When the child exits quickly (failed to start etc..), it doesn't get
tracked properly and when receiving sigchld, "fake_this" may be NULL
leading to a crash (fake_this = s_children[info->si_pid])
---
SpiceXPI/src/plugin/plugin.cpp | 34 +++---
1 files changed, 31 inse
Hey,
If you have some SPICE ideas that would be worth of a Summer of Code, they
probably can be added to this wiki...
Christophe
- Forwarded message from Stefan Hajnoczi -
> Date: Fri, 24 Feb 2012 09:19:17 +
> From: Stefan Hajnoczi
> To: qemu-devel , libvir-l...@redhat.com, kvm
>
On Fri, Feb 24, 2012 at 09:22:14AM +0100, Gianluca Cecchi wrote:
> On Thu, Feb 23, 2012 at 6:40 PM, David Jaša wrote:
> >> > * remote-viewer is modified so that it behaves like when run with
> >> > --spice-controller option if file speficied SPICE_XPI_SOCKET
> >> > exists, ig
On Thu, Feb 23, 2012 at 6:40 PM, David Jaša wrote:
>> > * remote-viewer is modified so that it behaves like when run with
>> > --spice-controller option if file speficied SPICE_XPI_SOCKET
>> > exists, ignoring other options
>>
>> AFAICT, there's no need for this, since
>> /u
31 matches
Mail list logo
