[Spice-devel] Windows binary download?

2012-02-09 Thread George Pyle
Is there a binary download of spice-gtk for Windows. I don't have a Windows development system but was asked for a Windows client. I only saw an older, non-gtk windows download. Or at least that is what I thought I saw. Thanks, George___ Spice-devel m

Re: [Spice-devel] [PATCH] Fix mandatory -Werror option

2012-02-09 Thread Christophe Fergeau
I've now pushed this patch, sorry for taking a bit of time for doing it :) Christophe On Fri, Jan 27, 2012 at 11:38:40AM -0200, Erlon Cruz wrote: > Compilation was breaking due to warning errors even when configuring with > --enable-werror=no. This patch fix this. > --- > configure.ac |3 +-

Re: [Spice-devel] [PATCH spice-gtk] display-name: g_strsplit result must be freed with g_strfreev

2012-02-09 Thread Hans de Goede
Hi, On 02/09/2012 02:55 PM, Marc-André Lureau wrote: - Mensaje original - Note I checked if we needed to propagate this change to gnome-desktop as we copied this from gnome-desktop, but gnome-desktop has since rewritten this bit to no longer us g_strsplit. Signed-off-by: Hans de Goed

Re: [Spice-devel] [PATCH spice-gtk 3/3] usbutil: Add support for getting strings from usb.ids

2012-02-09 Thread Hans de Goede
Hi, On 02/09/2012 02:53 PM, Marc-André Lureau wrote: Hi - Mensaje original - Unfortunately not all device makers go to the "trouble" of adding device identification strings to a device's descriptors. This patch makes spice-gtk translate vid/pid into strings if the device lacks the stri

Re: [Spice-devel] [PATCH] Don't warn if setsockopt(TCP_NDELAY) fails with errno==ENOTSUP

2012-02-09 Thread Daniel P. Berrange
On Tue, Feb 07, 2012 at 11:48:21AM -0500, Marc-André Lureau wrote: > ack, (will push if you don't have commit access) Yes please, I don't have access, though I have filed a freedesktop.org BZ to get an account created. Daniel > > - Mensaje original - > > From: "Daniel P. Berrange" > >

Re: [Spice-devel] [PATCH spice-gtk] display-name: g_strsplit result must be freed with g_strfreev

2012-02-09 Thread Marc-André Lureau
- Mensaje original - > Note I checked if we needed to propagate this change to gnome-desktop > as we copied this from gnome-desktop, but gnome-desktop has since > rewritten > this bit to no longer us g_strsplit. > > Signed-off-by: Hans de Goede > --- > gtk/display/display-name.c |2

Re: [Spice-devel] [PATCH spice-gtk 3/3] usbutil: Add support for getting strings from usb.ids

2012-02-09 Thread Marc-André Lureau
Hi - Mensaje original - > Unfortunately not all device makers go to the "trouble" of adding > device > identification strings to a device's descriptors. This patch makes > spice-gtk > translate vid/pid into strings if the device lacks the strings. Wouldn't it make more sense to have this

[Spice-devel] [PATCH spice-gtk] display-name: g_strsplit result must be freed with g_strfreev

2012-02-09 Thread Hans de Goede
Note I checked if we needed to propagate this change to gnome-desktop as we copied this from gnome-desktop, but gnome-desktop has since rewritten this bit to no longer us g_strsplit. Signed-off-by: Hans de Goede --- gtk/display/display-name.c |2 +- 1 files changed, 1 insertions(+), 1 deleti

[Spice-devel] [PATCH spice-gtk 3/3] usbutil: Add support for getting strings from usb.ids

2012-02-09 Thread Hans de Goede
Unfortunately not all device makers go to the "trouble" of adding device identification strings to a device's descriptors. This patch makes spice-gtk translate vid/pid into strings if the device lacks the strings. Signed-off-by: Hans de Goede --- configure.ac| 21 gtk/Makefile.am

[Spice-devel] [PATCH spice-gtk 2/3] usbutil: Add a spice_usb_util_get_device_strings helper function

2012-02-09 Thread Hans de Goede
Signed-off-by: Hans de Goede --- gtk/usb-device-manager.c | 32 gtk/usbutil.c| 31 +++ gtk/usbutil.h|8 +--- 3 files changed, 44 insertions(+), 27 deletions(-) diff --git a/gtk/usb-device-manager.c b

[Spice-devel] [PATCH spice-gtk 1/3] usb: Move various helper functions into usbutil.[c, h]

2012-02-09 Thread Hans de Goede
Signed-off-by: Hans de Goede --- gtk/Makefile.am |2 + gtk/channel-usbredir.c|5 +- gtk/usb-device-manager-priv.h |6 +-- gtk/usb-device-manager.c | 81 +++--- gtk/usb-device-manager.h |2 +- gtk/usbutil.c

Re: [Spice-devel] [Engine-devel] SPICE related features

2012-02-09 Thread David Jaša
Itamar Heim píše v Čt 09. 02. 2012 v 11:07 +0200: > On 02/09/2012 11:05 AM, Hans de Goede wrote: > > Hi, > > > > On 02/09/2012 09:33 AM, Itamar Heim wrote: > >> On 02/09/2012 10:31 AM, Hans de Goede wrote: > > > > > > > so this means we need to ask the user for linux guests if they want > >>>

Re: [Spice-devel] [Engine-devel] SPICE related features

2012-02-09 Thread Itamar Heim
On 02/09/2012 11:05 AM, Hans de Goede wrote: Hi, On 02/09/2012 09:33 AM, Itamar Heim wrote: On 02/09/2012 10:31 AM, Hans de Goede wrote: so this means we need to ask the user for linux guests if they want single head or multiple heads when they choose multi monitor? We could ask the user

Re: [Spice-devel] [Engine-devel] SPICE related features

2012-02-09 Thread Hans de Goede
Hi, On 02/09/2012 09:33 AM, Itamar Heim wrote: On 02/09/2012 10:31 AM, Hans de Goede wrote: so this means we need to ask the user for linux guests if they want single head or multiple heads when they choose multi monitor? We could ask the user, but I don't think that that is a good idea.

Re: [Spice-devel] [Engine-devel] SPICE related features

2012-02-09 Thread Itamar Heim
On 02/09/2012 10:31 AM, Hans de Goede wrote: Hi, On 02/09/2012 08:55 AM, Itamar Heim wrote: On 02/08/2012 04:36 PM, Hans de Goede wrote: Hi all, Dor, thanks for the forward. On 02/08/2012 12:49 PM, Dor Laor wrote: On 02/08/2012 01:43 PM, Oved Ourfalli wrote: Hello all, The following featu

Re: [Spice-devel] [Engine-devel] SPICE related features

2012-02-09 Thread Hans de Goede
Hi, On 02/09/2012 08:55 AM, Itamar Heim wrote: On 02/08/2012 04:36 PM, Hans de Goede wrote: Hi all, Dor, thanks for the forward. On 02/08/2012 12:49 PM, Dor Laor wrote: On 02/08/2012 01:43 PM, Oved Ourfalli wrote: Hello all, The following feature page describes the engine adjustments neede