Re: [Spice-devel] Delay in Gimp when using qxl driver

2012-01-20 Thread Yaniv Kaul
- Original Message - > On Wed, Jan 18, 2012 at 11:59:45AM +0100, Dominique Rodrigues wrote: > > Le 18/01/2012 11:48, Alon Levy a écrit : > > >On Wed, Jan 18, 2012 at 11:39:13AM +0100, Dominique Rodrigues > > >wrote: > > >>Le 18/01/2012 11:32, Alon Levy a écrit : > > >>>On Wed, Jan 18, 2012

Re: [Spice-devel] Delay in Gimp when using qxl driver

2012-01-20 Thread Dominique Rodrigues
I tried on CentOS 6.2, Debian Squeeze and Wheezy, Ubuntu 11, and, up to know, the new driver shows a clear improvement. I have just done another test on my CentOS guest and I did not have the kind of message you have, Nicolas. My test were done on a HD video, normal

Re: [Spice-devel] Delay in Gimp when using qxl driver

2012-01-20 Thread nicolas prochazka
hello, I've also tested this qxl driver under opensuse 12.1 it's very impressive ! youtube video is perfect. Just in fullscreen, video freeze sometime.  in Xorg.log msg : a lot of : 2205.579] Cache contents: null null null null null null null null null null null null null null null null null nul

Re: [Spice-devel] [Qemu-devel] Vioserial of Windows guest OS on Qemu 0.15

2012-01-20 Thread Vadim Rozenfeld
This code is slightly buggy. Please try Yan's repository at github (https://github.com/YanVugenfirer/). I believe that the most critical changes have been merged already by Yan into this public repository. I will ask to update binaries and sources at fedoraproject site as well. Best regards, Vadi

Re: [Spice-devel] [PATCH 7/7] Use found python binary to check for pyparsing

2012-01-20 Thread Hans de Goede
Looks good, ACK. Regards, Hans On 01/19/2012 09:10 PM, Dan McGee wrote: This matches what we do in client/Makefile.am to actually run the python scripts, which is to use the python binary we find first, preferring 'python2' over 'python'. This makes the compile work on odd systems such as Arc

Re: [Spice-devel] [PATCH 5/7] server: don't complain if setsockopt(SO_PRIORITY) call fails

2012-01-20 Thread Hans de Goede
I sort of deliberately did not add the if (errno != ENOTSUP) check for this one as it is not TCP/IP specific. But thinking about it more I can see that this makes sense, so: ACK. Regards, Hans On 01/19/2012 09:10 PM, Dan McGee wrote: From: Nahum Shalman dc7855967f4e did this for the TCP_NODE

Re: [Spice-devel] [PATCH 6/7] Remove epoll headers from client code

2012-01-20 Thread Hans de Goede
Looks good, ACK. Regards, Hans On 01/19/2012 09:10 PM, Dan McGee wrote: There is no more usage of epoll on the client side, so no need to include these header files. Signed-off-by: Dan McGee --- client/x11/named_pipe.cpp |1 - client/x11/platform.cpp |1 - 2 files changed, 0 in

Re: [Spice-devel] [PATCH 4/7] server/inputs_channel: don't set O_ASYNC option on socket

2012-01-20 Thread Hans de Goede
This looks like a good catch to me, but I would like to see a review by someone who knows this code a bit better then me. Alon ? Yonit? Regards, Hans On 01/19/2012 09:10 PM, Dan McGee wrote: output to send a SIGIO signal to the running program. However, we don't handle this signal anywhere in

Re: [Spice-devel] [PATCH 3/7] Update .gitignore with a few more generated files

2012-01-20 Thread Hans de Goede
Looks good, ACK. Regards, Hans On 01/19/2012 09:10 PM, Dan McGee wrote: Signed-off-by: Dan McGee --- .gitignore |2 ++ client/.gitignore |1 + client/x11/.gitignore |1 + common/.gitignore |1 + server/tests/.gitignore |2 ++ 5 files chang

Re: [Spice-devel] [PATCH 2/7] Fix git commit hook errors in red_worker

2012-01-20 Thread Hans de Goede
Looks good, ACK. Regards, Hans On 01/19/2012 09:09 PM, Dan McGee wrote: This ensures all line lengths are down below 100 characters as well as removing some trailing spaces. Signed-off-by: Dan McGee --- server/red_worker.c | 88 -- 1 files

Re: [Spice-devel] [PATCH 1/7] Fix line length errors in main_channel

2012-01-20 Thread Hans de Goede
Hi, First of all many thanks for the patches, and welcome to the Spice community! As for this patch: ACK. I realize you cannot push patches yourself, so I (or some other spice team member) will take care of getting these into git, but first lets get the entire set reviewed. Regards, Hans On