Re: [Spice-devel] [PATCH spice-gtk 04/10] usbredir: Use new libusbredirhost write flush callback

2012-01-02 Thread Christophe Fergeau
Let's ACK this patch after the discussion about it. Christophe On Mon, Dec 19, 2011 at 12:24:37PM +0100, Hans de Goede wrote: > The new (in usbredir-0.3.2) usbredirhost_open_full() > function allows us to be notified whenever usb packets completing > result in data to be send to the host. This re

Re: [Spice-devel] [PATCH spice-gtk 04/10] usbredir: Use new libusbredirhost write flush callback

2012-01-02 Thread Christophe Fergeau
On Mon, Jan 02, 2012 at 03:41:27PM +0100, Hans de Goede wrote: > On device close libusb kills any pending transfer *and* waits for any running > transfer > complete callbacks to finish, it does so in a thread safe manner. Ah ok, great thanks! Christophe pgpxoabnssqz9.pgp Description: PGP signa

Re: [Spice-devel] [PATCH spice-gtk 04/10] usbredir: Use new libusbredirhost write flush callback

2012-01-02 Thread Hans de Goede
Hi, On 01/02/2012 03:10 PM, Christophe Fergeau wrote: On Mon, Jan 02, 2012 at 03:01:39PM +0100, Hans de Goede wrote: Hi, On 01/02/2012 01:59 PM, Christophe Fergeau wrote: On Sat, Dec 24, 2011 at 10:27:40AM +0100, Hans de Goede wrote: On 12/23/2011 06:26 PM, Christophe Fergeau wrote: is ther

Re: [Spice-devel] [PATCH spice-gtk 04/10] usbredir: Use new libusbredirhost write flush callback

2012-01-02 Thread Christophe Fergeau
On Mon, Jan 02, 2012 at 03:01:39PM +0100, Hans de Goede wrote: > Hi, > > On 01/02/2012 01:59 PM, Christophe Fergeau wrote: > >On Sat, Dec 24, 2011 at 10:27:40AM +0100, Hans de Goede wrote: > >>On 12/23/2011 06:26 PM, Christophe Fergeau wrote: > >>>is there > >>>something preventing the check on pr

Re: [Spice-devel] [PATCH spice-gtk 07/10] usbredir: Handle usb events from a thread

2012-01-02 Thread Christophe Fergeau
On Mon, Jan 02, 2012 at 03:03:59PM +0100, Hans de Goede wrote: > Hi, > > On 01/02/2012 02:23 PM, Christophe Fergeau wrote: > >On Mon, Dec 19, 2011 at 12:24:40PM +0100, Hans de Goede wrote: > >>This solves various latency issues with USB handling. > >> > >>Signed-off-by: Hans de Goede > > > > >>

Re: [Spice-devel] [PATCH spice-gtk 03/10] usbredir: USB channels can not be read only

2012-01-02 Thread Hans de Goede
Hi, On 01/02/2012 02:39 PM, Christophe Fergeau wrote: And I think this is the last patch I hadn't looked at (let me know if I missed some in this series :) On Mon, Dec 19, 2011 at 12:24:36PM +0100, Hans de Goede wrote: A usbredir channel must always be bi-directional. spice-server allows only

Re: [Spice-devel] [PATCH spice-gtk 07/10] usbredir: Handle usb events from a thread

2012-01-02 Thread Hans de Goede
Hi, On 01/02/2012 02:23 PM, Christophe Fergeau wrote: On Mon, Dec 19, 2011 at 12:24:40PM +0100, Hans de Goede wrote: This solves various latency issues with USB handling. Signed-off-by: Hans de Goede +static gpointer spice_usb_device_magager_usb_ev_thread(gpointer user_data) s/magager/m

Re: [Spice-devel] [PATCH spice-gtk 04/10] usbredir: Use new libusbredirhost write flush callback

2012-01-02 Thread Hans de Goede
Hi, On 01/02/2012 01:59 PM, Christophe Fergeau wrote: On Sat, Dec 24, 2011 at 10:27:40AM +0100, Hans de Goede wrote: On 12/23/2011 06:26 PM, Christophe Fergeau wrote: is there something preventing the check on priv->state from racing with code running in the main thread? Oh, good one I must

Re: [Spice-devel] [PATCH spice-gtk 03/10] usbredir: USB channels can not be read only

2012-01-02 Thread Christophe Fergeau
And I think this is the last patch I hadn't looked at (let me know if I missed some in this series :) On Mon, Dec 19, 2011 at 12:24:36PM +0100, Hans de Goede wrote: > A usbredir channel must always be bi-directional. spice-server > allows only one client to connect even when in multi-client mode.

Re: [Spice-devel] [PATCH spice-gtk 07/10] usbredir: Handle usb events from a thread

2012-01-02 Thread Christophe Fergeau
On Mon, Dec 19, 2011 at 12:24:40PM +0100, Hans de Goede wrote: > This solves various latency issues with USB handling. > > Signed-off-by: Hans de Goede > --- > gtk/channel-usbredir.c |5 + > gtk/usb-device-manager.c | 45 - > 2 files change

Re: [Spice-devel] [PATCH spice-gtk 04/10] usbredir: Use new libusbredirhost write flush callback

2012-01-02 Thread Christophe Fergeau
On Sat, Dec 24, 2011 at 10:27:40AM +0100, Hans de Goede wrote: > On 12/23/2011 06:26 PM, Christophe Fergeau wrote: > >is there > >something preventing the check on priv->state from racing with code running > >in the main thread? > > Oh, good one I must admit I did not think about this. I believe t

Re: [Spice-devel] [PATCH spice-gtk 01/10] spice-channel: Allow spice_msg_out_send to be called from multiple threads

2012-01-02 Thread Christophe Fergeau
On Sat, Dec 24, 2011 at 09:23:15AM +0100, Hans de Goede wrote: > Hi, > > First of all thanks for the review of this series! > > On 12/23/2011 06:10 PM, Christophe Fergeau wrote: > >Hi, > > > >On Mon, Dec 19, 2011 at 12:24:34PM +0100, Hans de Goede wrote: > >>This is a preparation patch for handli

Re: [Spice-devel] Access local network printer from guest OS

2012-01-02 Thread Alon Levy
On Mon, Jan 02, 2012 at 07:08:23PM +0800, Charles.Tsai-蔡清海-工程部 wrote: > Alon, > > I have another question regarding the USB redirect for Windows client. In > current spice release, the USB redirect only support for Linux client. Right, but this is a temporary situation, it will be supported in

Re: [Spice-devel] Access local network printer from guest OS

2012-01-02 Thread Charles . Tsai-蔡清海-工程部
Alon, I have another question regarding the USB redirect for Windows client. In current spice release, the USB redirect only support for Linux client. If we send the printing data through the "spicevmc channel" to the Windows client(not Linux), what is the corresponding channel(file and functio

Re: [Spice-devel] Access local network printer from guest OS

2012-01-02 Thread Charles . Tsai-蔡清海-工程部
Alon, Thank you for your further explanation. It is very clear that I understand how the VirIO work now. Yes, the virtual printer driver I want to support at this moment is for Windows guest OS only. The support of the Linux guest OS will be considered latter on. -Original Message- F

Re: [Spice-devel] [PATCH spice-gtk 1/3] spice-channel: support SPICE_COMMON_CAP_HEADER_NO_SUB

2012-01-02 Thread Yonit Halperin
On 01/02/2012 12:17 PM, Christophe Fergeau wrote: Hey, What happens if we try to connect to a server with MSG_LIST support with a client which does not have these patches applied ? The server knows the client doesn't support it by testing the capability I added. And it uses the old header, whic

Re: [Spice-devel] Access local network printer from guest OS

2012-01-02 Thread Alon Levy
On Mon, Jan 02, 2012 at 10:06:34AM +0800, Charles.Tsai-蔡清海-工程部 wrote: > Alon, > > Let me recap what you suggest in case that I missed your point. sure. > > 1. Capturing the printing data from the virtual printer driver. > 2. send the captured data to the " cifs/ipp server" for printing data. >

Re: [Spice-devel] [PATCH spice-gtk 1/3] spice-channel: support SPICE_COMMON_CAP_HEADER_NO_SUB

2012-01-02 Thread Christophe Fergeau
Hey, What happens if we try to connect to a server with MSG_LIST support with a client which does not have these patches applied ? Christophe On Wed, Dec 28, 2011 at 07:15:42PM +0200, Yonit Halperin wrote: > --- > gtk/spice-channel-priv.h |3 +++ > gtk/spice-channel.c | 27 ++

Re: [Spice-devel] hi,everyone. anyone do spice client on mac os x?

2012-01-02 Thread Christophe Fergeau
Hi, On Tue, Dec 27, 2011 at 04:48:56PM +0800, wang.ch...@zte.com.cn wrote: > i try to compile the spice client on mac os x (darwin 10.7 ) ,but i faced > many troubles, anyone can help me? thanks > > 1. celt and qpixman , spice-prototol have compiled on mac os x , but > while compile the spice-

Re: [Spice-devel] [PATCH spice-protocol 1/2] Add support for a header without sub list.

2012-01-02 Thread Yonit Halperin
On 12/29/2011 10:30 AM, Alon Levy wrote: On Thu, Dec 29, 2011 at 08:11:27AM +0200, Yonit Halperin wrote: On 12/28/2011 10:04 PM, Yaniv Kaul wrote: On 12/28/2011 07:14 PM, Yonit Halperin wrote: Add SpiceDataHeaderNoSub. Introduce capability SPICE_COMMON_CAP_HEADER_NO_SUB. Introduce SPICE_MSG_LI

Re: [Spice-devel] [spice-xpi PATCH 0/3] logging: add various log messages (#753155)

2012-01-02 Thread Arnon Gilboa
ACK series Acked-by: Arnon Gilboa Uri Lublin wrote: Mostly debug messages to log variable values coming in (from java-script) and going out (to spice-client). Uri Lublin (3): logging: add logging of variable setting (#753155) logging: add logging of messages sent to the client (#753155)