Re: [Spice-devel] [PATCH spice-protocol 1/2] Add support for a header without sub list.

2011-12-28 Thread Yaniv Kaul
On 12/29/2011 08:11 AM, Yonit Halperin wrote: On 12/28/2011 10:04 PM, Yaniv Kaul wrote: On 12/28/2011 07:14 PM, Yonit Halperin wrote: Add SpiceDataHeaderNoSub. Introduce capability SPICE_COMMON_CAP_HEADER_NO_SUB. Introduce SPICE_MSG_LIST: the msg body is SpiceSubMessageList. The advantage of u

Re: [Spice-devel] [PATCH spice-protocol 1/2] Add support for a header without sub list.

2011-12-28 Thread Yonit Halperin
On 12/28/2011 10:04 PM, Yaniv Kaul wrote: On 12/28/2011 07:14 PM, Yonit Halperin wrote: Add SpiceDataHeaderNoSub. Introduce capability SPICE_COMMON_CAP_HEADER_NO_SUB. Introduce SPICE_MSG_LIST: the msg body is SpiceSubMessageList. The advantage of using a header without sub list is to spare the

Re: [Spice-devel] [PATCH spice-gtk] usbredir: Don't call spice_usbredir_channel_disconnect on channel reset

2011-12-28 Thread Marc-André Lureau
ack - Mensaje original - > channel_reset gets called from spice_channel_disconnect, and > spice_usbredir_channel_disconnect calls spice_channel_disconnect > (so as to disconnect the channel when a usb device gets > disconnected). > > So calling spice_usbredir_channel_disconnect from chann

Re: [Spice-devel] keyboard and Mouse Fails....

2011-12-28 Thread Naga Mohan Pothula
Hi Alon, Please refer my inline comments. Thanks/Mohan. From: Alon Levy To: Naga Mohan Pothula Cc: David Jaša ; "spice-devel@lists.freedesktop.org" ; Christophe Fergeau Sent: Wednesday, December 28, 2011 5:54 AM Subject: Re: [Spice-devel] keyboard and Mou

Re: [Spice-devel] [PATCH spice-protocol 1/2] Add support for a header without sub list.

2011-12-28 Thread Yaniv Kaul
On 12/28/2011 07:14 PM, Yonit Halperin wrote: Add SpiceDataHeaderNoSub. Introduce capability SPICE_COMMON_CAP_HEADER_NO_SUB. Introduce SPICE_MSG_LIST: the msg body is SpiceSubMessageList. The advantage of using a header without sub list is to spare the 4 bytes that were sent for a lot of messag

[Spice-devel] [PATCH spice-gtk 3/3] configure: spice-protocol >= 0.9.2 (Header without sub list)

2011-12-28 Thread Yonit Halperin
--- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 3c5689d..1747e45 100644 --- a/configure.ac +++ b/configure.ac @@ -61,7 +61,7 @@ AC_CHECK_HEADERS([sys/socket.h netinet/in.h arpa/inet.h]) dnl

[Spice-devel] [PATCH spice-gtk 2/3] spice-channel: support SPICE_MSG_LIST

2011-12-28 Thread Yonit Halperin
--- gtk/spice-channel.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c index 69a0571..2a0e371 100644 --- a/gtk/spice-channel.c +++ b/gtk/spice-channel.c @@ -1617,7 +1617,7 @@ void spice_channel_recv_msg(SpiceChannel *channel,

[Spice-devel] [PATCH spice-gtk 1/3] spice-channel: support SPICE_COMMON_CAP_HEADER_NO_SUB

2011-12-28 Thread Yonit Halperin
--- gtk/spice-channel-priv.h |3 +++ gtk/spice-channel.c | 27 +-- 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/gtk/spice-channel-priv.h b/gtk/spice-channel-priv.h index 5585f13..cf5caba 100644 --- a/gtk/spice-channel-priv.h +++ b/gtk/spice-ch

[Spice-devel] [PATCH spice 10/10] configure: spice-protocol >= 0.9.2 (Header without sub list)

2011-12-28 Thread Yonit Halperin
--- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 861e939..24a1839 100644 --- a/configure.ac +++ b/configure.ac @@ -132,7 +132,7 @@ AM_CONDITIONAL(SUPPORT_CLIENT, test "x$enable_client" = "xyes") dnl =

[Spice-devel] [PATCH spice 09/10] client/red_channel.cpp: support SPICE_MSG_LIST

2011-12-28 Thread Yonit Halperin
SPICE_MSG_LIST body is SpiceSubMessageList --- client/red_channel.h | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/client/red_channel.h b/client/red_channel.h index ee5b185..3b77ff3 100644 --- a/client/red_channel.h +++ b/client/red_channel.h @@ -305,10 +305,

[Spice-devel] [PATCH spice 08/10] client/red_channel: support SpiceDataHeaderNoSub

2011-12-28 Thread Yonit Halperin
--- client/red_channel.cpp | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/client/red_channel.cpp b/client/red_channel.cpp index e8c058c..1f3312f 100644 --- a/client/red_channel.cpp +++ b/client/red_channel.cpp @@ -215,6 +215,8 @@ void RedChannelBase::link(uint3

[Spice-devel] [PATCH spice 07/10] client/red_peer: support SpiceDataHeaderNoSub

2011-12-28 Thread Yonit Halperin
--- client/red_peer.cpp | 40 +++- client/red_peer.h | 11 +++ 2 files changed, 42 insertions(+), 9 deletions(-) diff --git a/client/red_peer.cpp b/client/red_peer.cpp index 17fcb45..22eb0a4 100644 --- a/client/red_peer.cpp +++ b/client/red_peer.c

[Spice-devel] [PATCH spice 06/10] server/snd_worker: support SpiceDataHeaderNoSub for sound channel

2011-12-28 Thread Yonit Halperin
Sound channels need special support since they still don't use red_channel for sending & receiving. --- server/red_channel.c |8 server/snd_worker.c | 36 +--- 2 files changed, 33 insertions(+), 11 deletions(-) diff --git a/server/red_channel.c b/se

[Spice-devel] [PATCH spice 05/10] server/red_worker: when SPICE_MSG_LIST will contain only one msg, send this message instead of the list

2011-12-28 Thread Yonit Halperin
In the above cases, this behavior will decrease the difference between using a header without sub list and a one with sub list to 4 bytes. --- server/red_worker.c | 27 ++- 1 files changed, 18 insertions(+), 9 deletions(-) diff --git a/server/red_worker.c b/server/red_wo

[Spice-devel] [PATCH spice 04/10] server/red_worker: support for SpiceDataHeaderNoSub

2011-12-28 Thread Yonit Halperin
When the display channel's peer uses SpiceDataHeaderNoSub, employ urgent marshaller and SPICE_MSG_LIST instead of sub_list in the header. --- server/red_worker.c | 67 +- 1 files changed, 55 insertions(+), 12 deletions(-) diff --git a/server/red_w

[Spice-devel] [PATCH spice 03/10] server/red_channel: support SPICE_COMMON_CAP_HEADER_NO_SUB

2011-12-28 Thread Yonit Halperin
--- server/red_channel.c | 27 --- server/red_channel.h |3 +++ 2 files changed, 23 insertions(+), 7 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index 86387cb..7772355 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -86,17 +8

[Spice-devel] [PATCH spice 02/10] server/red_worker: pass the correct remote caps to display/cursor red_channel_client's

2011-12-28 Thread Yonit Halperin
--- server/red_dispatcher.c | 16 + server/red_dispatcher.h |8 ++ server/red_worker.c | 56 -- 3 files changed, 68 insertions(+), 12 deletions(-) diff --git a/server/red_dispatcher.c b/server/red_dispatcher.c index 17b469e..

[Spice-devel] [PATCH spice 01/10] server/red_channel: introduce urgent marshaller

2011-12-28 Thread Yonit Halperin
When red_channel::red_channel_client_begin_send_message is called, the message that is pending in the urgent marshaller will be sent before the one in the main channel. The urgent marshaller should be used if in the middle of marshalling one message, you find out you need to send another message b

[Spice-devel] [PATCH spice-protocol 2/2] Release 0.9.2

2011-12-28 Thread Yonit Halperin
--- NEWS |4 configure.ac |2 +- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/NEWS b/NEWS index 2378b2c..0a9a412 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +Major changes in 0.9.2 +== +* Add support for a header without sublist + Major

[Spice-devel] [PATCH spice-protocol 1/2] Add support for a header without sub list.

2011-12-28 Thread Yonit Halperin
Add SpiceDataHeaderNoSub. Introduce capability SPICE_COMMON_CAP_HEADER_NO_SUB. Introduce SPICE_MSG_LIST: the msg body is SpiceSubMessageList. The advantage of using a header without sub list is to spare the 4 bytes that were sent for a lot of messages without sublist. Instead, messages that previ

[Spice-devel] [PATCH spice-protocol 0/2] Removing sub_list from messages header

2011-12-28 Thread Yonit Halperin
Hi, This patch series introduces SPICE_COMMON_CAP_HEADER_NO_SUB, in order to spare the 4 bytes of sub_list that were sent for all the messages. I replaced the sub_list functionality by using an additional marshaller in red_channel, which I named urgent marshaller. This marshaller allows marshallin

Re: [Spice-devel] [PATCH spice-gtk 06/10] usbredir: Add locking callbacks for libusbredirhost

2011-12-28 Thread Marc-André Lureau
On Mon, Dec 19, 2011 at 12:24 PM, Hans de Goede wrote: > +static void *usbredir_alloc_lock(void); > +static void usbredir_lock_lock(void *user_data); > +static void usbredir_unlock_lock(void *user_data); > +static void usbredir_free_lock(void *user_data); > + > Minor nitpicks, I think it would b

Re: [Spice-devel] keyboard and Mouse Fails....

2011-12-28 Thread Alon Levy
On Tue, Dec 27, 2011 at 12:04:28PM -0800, Naga Mohan Pothula wrote: >Can anyone please respond on this? >Thanks/Mohan. > >-- > >From: Naga Mohan Pothula >To: David Jaša >Cc: "spice-devel@lists.freede

Re: [Spice-devel] VideoStream - MJpeg Encode/Decode.

2011-12-28 Thread Naga Mohan Pothula
Hi Alon, After encoding the frame, the width and height of the frame would be changed. I haven't find producing Frame rect in Even format at Encoder. "red_display_marshall_stream_start" function at encoder receives ODD format Frame rect and this frame rect is continued in "red_marshall_stream_da