Re: [Spice-devel] [PATCH spice-gtk 10/10] usbredir: Give devices a user friendly description

2011-12-23 Thread Christophe Fergeau
On Mon, Dec 19, 2011 at 12:24:43PM +0100, Hans de Goede wrote: > Before this patch devices were described like this to the user: > USB device at 2-14 > After this patch the description is: > SanDisk Cruzer Blade [0781:5567] at 2-14 > > Signed-off-by: Hans de Goede > --- > gtk/usb-device-manager.

Re: [Spice-devel] [PATCH spice-gtk 08/10] usbredir: Remove spice_usb_device_manager_get main_context argument

2011-12-23 Thread Christophe Fergeau
looks good. On Mon, Dec 19, 2011 at 12:24:41PM +0100, Hans de Goede wrote: > Now that we no longer use a GUsbSource this is no longer needed. > > Note this is a change to our public API, but that is ok since we have not > yet done an official release with usbredir support. > > Signed-off-by: Hans

Re: [Spice-devel] [Qemu-devel] Seem thread Competition

2011-12-23 Thread Ademar de Souza Reis Jr.
On Thu, Dec 22, 2011 at 07:07:14PM +0800, ZhouPeng wrote: > On Thu, Dec 22, 2011 at 6:00 PM, Alon Levy wrote: > > On Thu, Dec 22, 2011 at 05:42:29PM +0800, ZhouPeng wrote: > >> On Thu, Dec 22, 2011 at 4:42 PM, Alon Levy wrote: > >> > On Thu, Dec 22, 2011 at 10:13:50AM +0800, ZhouPeng wrote: > >>

Re: [Spice-devel] VideoStream - MJpeg Encode/Decode.

2011-12-23 Thread David Jaša
Hello Mohan, Naga Mohan Pothula píše v Pá 23. 12. 2011 v 09:17 -0800: > Hi, > > > I have doubt on MJpeg encode/decode module. I've seen Frame rect with > ODD format is not accepting by MJpegDecoder at "convert_scanline" > function. > > > ASSERT(_width % 2 == 0); > ASSERT(_height % 2 == 0); > S

Re: [Spice-devel] [PATCH spice-gtk 06/10] usbredir: Add locking callbacks for libusbredirhost

2011-12-23 Thread Christophe Fergeau
On Mon, Dec 19, 2011 at 12:24:39PM +0100, Hans de Goede wrote: > This is a preparation patch for handling usb packet completion in a > separate thread. Looks good, except that g_mutex_new/g_mutex_free are being deprecated in glib 2.31. The old symbols are still here so we should be fine for now, t

Re: [Spice-devel] [PATCH spice-gtk 05/10] usbredir: Create USB event source on demand

2011-12-23 Thread Christophe Fergeau
Makes sense to me Christophe On Mon, Dec 19, 2011 at 12:24:38PM +0100, Hans de Goede wrote: > This is a preparation patch for handling usb packet completion in a > separate thread. > > Signed-off-by: Hans de Goede > --- > gtk/Makefile.am |1 + > gtk/channel-usbredir.c

Re: [Spice-devel] [PATCH spice-gtk 04/10] usbredir: Use new libusbredirhost write flush callback

2011-12-23 Thread Christophe Fergeau
On Mon, Dec 19, 2011 at 12:24:37PM +0100, Hans de Goede wrote: > The new (in usbredir-0.3.2) usbredirhost_open_full() > function allows us to be notified whenever usb packets completing > result in data to be send to the host. This removes the need for using > g_usb_source_set_callback and seeing i

[Spice-devel] VideoStream - MJpeg Encode/Decode.

2011-12-23 Thread Naga Mohan Pothula
Hi, I have doubt on MJpeg encode/decode module. I've seen Frame rect with ODD format is not accepting by MJpegDecoder at "convert_scanline" function. ASSERT(_width % 2 == 0); ASSERT(_height % 2 == 0); Spice session crash happens due to this assertion. Why the decoder accepts only EVEN format f

Re: [Spice-devel] [PATCH spice-gtk 02/10] usbredir: Stop setting private data explictly to NULL on init

2011-12-23 Thread Christophe Fergeau
ACK On Mon, Dec 19, 2011 at 12:24:35PM +0100, Hans de Goede wrote: > This is not necessary and as we get more private data it becomes > unyieldly. > > Signed-off-by: Hans de Goede > --- > gtk/usb-device-manager.c |6 -- > 1 files changed, 0 insertions(+), 6 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH spice-gtk 01/10] spice-channel: Allow spice_msg_out_send to be called from multiple threads

2011-12-23 Thread Christophe Fergeau
Hi, On Mon, Dec 19, 2011 at 12:24:34PM +0100, Hans de Goede wrote: > This is a preparation patch for handling usb packet completion in a > separate thread. I haven't looked at the patches extending this, but I have 2 comments already: * the xmit_queue_lock + xmit_queue combination looks a lot lik

[Spice-devel] [PATCH spice-gtk] usbredir: Don't call spice_usbredir_channel_disconnect on channel reset

2011-12-23 Thread Hans de Goede
channel_reset gets called from spice_channel_disconnect, and spice_usbredir_channel_disconnect calls spice_channel_disconnect (so as to disconnect the channel when a usb device gets disconnected). So calling spice_usbredir_channel_disconnect from channel_reset leads to undesirable recursion. More