Re: [Spice-devel] [PATCH spice-gtk 6/6] Support semi-seamless migration

2011-12-18 Thread Alon Levy
On Sun, Dec 18, 2011 at 06:27:25PM +0100, Marc-André Lureau wrote: > Yonit Halperin described the flow, that I followed: > > (1) when client_migrate_info is called SPICE_MSG_MAIN_MIGRATE_BEGIN is > sent to the client. > > Then, the client should link to the target server (SpiceLinkMess), > i.e.,

Re: [Spice-devel] [PATCH spice-gtk 4/6] display: try to reuse exisiting primary surface

2011-12-18 Thread Alon Levy
On Sun, Dec 18, 2011 at 06:27:23PM +0100, Marc-André Lureau wrote: nitpick: typo in subject, exisiting->existing. (Otherwise looks good but I'm not certain about gtk code). > --- > gtk/channel-display.c | 65 +++- > 1 files changed, 42 insertions(+),

[Spice-devel] [PATCH xf86-video-qxl] configure.ac: support autoconf 2.63

2011-12-18 Thread Alon Levy
AC_CHECK_FILE(cond,[not-empty],[]) in autoconf 2.63 produces an empty else that is illegal for bash, but forgoes the else when given a AC_CHECK_FILE(cond,[not-empty]). 2.68 produces correct output on both, so it's unaffected. --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletion

[Spice-devel] [PATCH spice-gtk 6/6] Support semi-seamless migration

2011-12-18 Thread Marc-André Lureau
Yonit Halperin described the flow, that I followed: (1) when client_migrate_info is called SPICE_MSG_MAIN_MIGRATE_BEGIN is sent to the client. Then, the client should link to the target server (SpiceLinkMess), i.e., connect all the channels, but it shouldn't poll from the target, only from the so

[Spice-devel] [PATCH spice-gtk 5/6] main: Handle semi-seamless MIGRATION_BEGIN

2011-12-18 Thread Marc-André Lureau
--- gtk/channel-main.c | 31 +++ 1 files changed, 23 insertions(+), 8 deletions(-) diff --git a/gtk/channel-main.c b/gtk/channel-main.c index 47e41ab..38a2c5d 100644 --- a/gtk/channel-main.c +++ b/gtk/channel-main.c @@ -1470,7 +1470,7 @@ static gboolean migrate_conne

[Spice-devel] [PATCH spice-gtk 4/6] display: try to reuse exisiting primary surface

2011-12-18 Thread Marc-André Lureau
--- gtk/channel-display.c | 65 +++- 1 files changed, 42 insertions(+), 23 deletions(-) diff --git a/gtk/channel-display.c b/gtk/channel-display.c index 47beaa1..08e3e16 100644 --- a/gtk/channel-display.c +++ b/gtk/channel-display.c @@ -122,13 +122,17

[Spice-devel] [PATCH spice-gtk 3/6] Add channel_reset method

2011-12-18 Thread Marc-André Lureau
This new private method is to reset the channel to its initial state, used by semi-seamless migration --- gtk/channel-cursor.c | 12 ++ gtk/channel-display.c| 18 ++ gtk/channel-main.c | 41 - gtk/channel-playback.c | 19 +

[Spice-devel] [PATCH spice-gtk 2/6] gio-coroutine: add a few more run-time checks

2011-12-18 Thread Marc-André Lureau
--- gtk/gio-coroutine.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/gtk/gio-coroutine.c b/gtk/gio-coroutine.c index ff37272..7470b43 100644 --- a/gtk/gio-coroutine.c +++ b/gtk/gio-coroutine.c @@ -158,6 +158,7 @@ struct signal_data gpointer params;

[Spice-devel] [PATCH spice-gtk 1/6] Update protocol and messages for semi-seamless migration

2011-12-18 Thread Marc-André Lureau
--- common/messages.h |2 ++ spice.proto |9 ++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/common/messages.h b/common/messages.h index 556496b..4a69c35 100644 --- a/common/messages.h +++ b/common/messages.h @@ -73,6 +73,8 @@ typedef struct SpiceMsgMainMigra

[Spice-devel] [PATCH spice-gtk 0/6] RFC: add semi-seamless migration support

2011-12-18 Thread Marc-André Lureau
Hi, Here is a patch series to add support for semi-seamless migration in spice-gtk. The long description of how that works by Yonit is in the last commit message. The first patches shouldn't be too complicated. I didn't test it thoroughly yet (with various systems, ssl etc..), but the normal cas

Re: [Spice-devel] Failure to compile xf86-video-qxl (SPICE_BITMAP_FMT_8BIT_A' undeclared)

2011-12-18 Thread Alon Levy
On Sun, Dec 18, 2011 at 05:47:18PM +0200, Yaniv Kaul wrote: > On 12/18/2011 05:37 PM, Alon Levy wrote: > >On Sat, Dec 17, 2011 at 08:54:48PM +0200, Yaniv Kaul wrote: > >>make[3]: Entering directory `/home/ykaul/xf86-video-qxl/src' > >> CC qxl_driver.lo > >> CC qxl_image.lo > >>qxl_image

Re: [Spice-devel] Failure to compile xf86-video-qxl (SPICE_BITMAP_FMT_8BIT_A' undeclared)

2011-12-18 Thread Yaniv Kaul
On 12/18/2011 05:37 PM, Alon Levy wrote: On Sat, Dec 17, 2011 at 08:54:48PM +0200, Yaniv Kaul wrote: make[3]: Entering directory `/home/ykaul/xf86-video-qxl/src' CC qxl_driver.lo CC qxl_image.lo qxl_image.c: In function 'qxl_image_create': qxl_image.c:215:29: error: 'SPICE_BITMAP_F

Re: [Spice-devel] Failure to compile xf86-video-qxl (SPICE_BITMAP_FMT_8BIT_A' undeclared)

2011-12-18 Thread Alon Levy
On Sat, Dec 17, 2011 at 08:54:48PM +0200, Yaniv Kaul wrote: > make[3]: Entering directory `/home/ykaul/xf86-video-qxl/src' > CC qxl_driver.lo > CC qxl_image.lo > qxl_image.c: In function 'qxl_image_create': > qxl_image.c:215:29: error: 'SPICE_BITMAP_FMT_8BIT_A' undeclared > (first use i

Re: [Spice-devel] [PATCH spice] spicevmc: Fix assert when still connected on session disconnect (fdo#43903)

2011-12-18 Thread Alon Levy
On Sun, Dec 18, 2011 at 11:32:26AM +0100, Hans de Goede wrote: > Currently when the main channel disconnects while a spicevmc channel > (such as a usbredir channel) is still connected, qemu will abort with the > following message: > ring_remove: ASSERT item->next != NULL && item->prev != NULL faile

[Spice-devel] [PATCH spice] spicevmc: Fix assert when still connected on session disconnect (fdo#43903)

2011-12-18 Thread Hans de Goede
Currently when the main channel disconnects while a spicevmc channel (such as a usbredir channel) is still connected, qemu will abort with the following message: ring_remove: ASSERT item->next != NULL && item->prev != NULL failed This is caused by red_client_destroy() first calling: rcc->channel->