[Spice-devel] vala is now needed?

2011-12-09 Thread Yaniv Kaul
1. Too bad there is no proper check for vala when running ./configure (or ./autogen.sh). 2. I've have vala installed and installed vala-devel, ./configure passes, yet with 'make' I'm getting: make[4]: Entering directory `/home/ykaul/spice-gtk/gtk/controller' *** Error: missing valac! *** Yo

Re: [Spice-devel] [PATCH spice-gtk 1/2] spice-widget: cleanup mouse handling.

2011-12-09 Thread Marc-André Lureau
ack - Mensaje original - > Some background on this patch, we currently behave > as follows in server mouse mode: > > 1) When spicy first connects, a frozen guest cursor is shown > (no mouse events are send to the guest) and the client cursor > is set to the standard right pointer, > >

Re: [Spice-devel] [PATCH spice-gtk 2/2] spice-widget: rename mouse_update to update_mouse_mode.

2011-12-09 Thread Marc-André Lureau
ack ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH spice-gtk 2/2] spice-widget: rename mouse_update to update_mouse_mode.

2011-12-09 Thread Hans de Goede
We already have update_mouse_pointer and update_mouse_grab, so having a mouse_update function without specifying what "part" of the mouse handling it exactly updates is confusing, rename it to update_mouse_mode to reflect what it does and to match the other names. Signed-off-by: Hans de Goede ---

[Spice-devel] [PATCH spice-gtk 1/2] spice-widget: cleanup mouse handling.

2011-12-09 Thread Hans de Goede
Some background on this patch, we currently behave as follows in server mouse mode: 1) When spicy first connects, a frozen guest cursor is shown (no mouse events are send to the guest) and the client cursor is set to the standard right pointer, 2) When one clicks on / inside the spice-widget, t

[Spice-devel] spice-gtk failing to build

2011-12-09 Thread Damien Churchill
Hi, I'm trying to build git HEAD and I'm receiving an error: CC SpiceClientGtk_la-spice-client-gtk-module.defs.lo tmp.c: In function '_wrap_spice_smartcard_manager_insert_card': tmp.c:1383:5: warning: implicit declaration of function 'spice_smartcard_manager_insert_card' [-Wimplicit-function

Re: [Spice-devel] [PATCH spice-gtk 1/2] Do not send ungrab key sequence to the server

2011-12-09 Thread Hans de Goede
Looks good, ack series. On 12/09/2011 05:03 PM, Marc-André Lureau wrote: --- gtk/spice-widget.c | 21 ++--- 1 files changed, 10 insertions(+), 11 deletions(-) diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c index 9e45979..3c2f6c0 100644 --- a/gtk/spice-widget.c +++ b/g

[Spice-devel] [PATCH spice-gtk 2/2] Take the grab when mouse switching to client mode

2011-12-09 Thread Marc-André Lureau
Only when the widget has the focus and the pointer is over the widget --- gtk/spice-widget.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c index 3c2f6c0..e270c06 100644 --- a/gtk/spice-widget.c +++ b/gtk/spice-widget.c

[Spice-devel] [PATCH spice-gtk 1/2] Do not send ungrab key sequence to the server

2011-12-09 Thread Marc-André Lureau
--- gtk/spice-widget.c | 21 ++--- 1 files changed, 10 insertions(+), 11 deletions(-) diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c index 9e45979..3c2f6c0 100644 --- a/gtk/spice-widget.c +++ b/gtk/spice-widget.c @@ -876,6 +876,16 @@ static gboolean key_event(GtkWidget *wi

Re: [Spice-devel] [PATCH spice-gtk] Do not send ungrab key sequence

2011-12-09 Thread Hans de Goede
Hi, On 12/09/2011 04:31 PM, Marc-André Lureau wrote: --- gtk/spice-widget.c | 20 +--- 1 files changed, 9 insertions(+), 11 deletions(-) diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c index 9e45979..d3647a4 100644 --- a/gtk/spice-widget.c +++ b/gtk/spice-widget.c @@ -

Re: [Spice-devel] spice-gtk mouse notes

2011-12-09 Thread Hans de Goede
Hi, On 12/09/2011 04:24 PM, Marc-André Lureau wrote: On Fri, Dec 9, 2011 at 4:13 PM, Hans de Goede mailto:hdego...@redhat.com>> wrote: I think we should fix it, currently this behavior leads to sending ";2~" to the commandline (bash) / whatever text document one has open inside an ed

[Spice-devel] [PATCH spice-gtk] Do not send ungrab key sequence

2011-12-09 Thread Marc-André Lureau
--- gtk/spice-widget.c | 20 +--- 1 files changed, 9 insertions(+), 11 deletions(-) diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c index 9e45979..d3647a4 100644 --- a/gtk/spice-widget.c +++ b/gtk/spice-widget.c @@ -876,6 +876,15 @@ static gboolean key_event(GtkWidget *widg

Re: [Spice-devel] spice-gtk mouse notes

2011-12-09 Thread Marc-André Lureau
On Fri, Dec 9, 2011 at 4:13 PM, Hans de Goede wrote: > I think we should fix it, currently this behavior leads to sending ";2~" > to the > commandline (bash) / whatever text document one has open inside an editor > inside > an xterm / gnome-terminal / foo-term, when ever one tries to ungrab the >

Re: [Spice-devel] spice-gtk mouse notes

2011-12-09 Thread Hans de Goede
Hi, On 12/09/2011 02:40 PM, Marc-André Lureau wrote: Hi On Thu, Dec 8, 2011 at 4:48 PM, Hans de Goede mailto:hdego...@redhat.com>> wrote: * When switching from client to server mode (do killall spice-vdagent in a linux guest), 2 things stand out: 1) The guest mouse cursor does

Re: [Spice-devel] [PATCH spice-gtk 1/3] Correctly hide client pointer (in server mode)

2011-12-09 Thread Hans de Goede
Hi, Series looks good with your revised version if this patch, ack series. Regards, Hans On 12/09/2011 03:59 PM, Marc-André Lureau wrote: The hide cursor event happen when the widget is not yet realized. Forcing realize may fail if the widget is not yet embedded for example. Instead, let's u

Re: [Spice-devel] [PATCH spice-gtk 1/3] Correctly hide client pointer (in server mode)

2011-12-09 Thread Marc-André Lureau
- Mensaje original - > The hide cursor event happen when the widget is not yet > realized. Forcing realize may fail if the widget is not yet embedded > for example. Instead, let's update the cursor whenever there is a > draw(). > > v2: do not call gdk_window_set_cursor() with the same cu

[Spice-devel] [PATCH spice-gtk 3/3] Don't leak cursor shape objects

2011-12-09 Thread Marc-André Lureau
--- gtk/spice-widget.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c index d9ee2f6..cfa5801 100644 --- a/gtk/spice-widget.c +++ b/gtk/spice-widget.c @@ -280,6 +280,21 @@ static void spice_display_finalize(GObjec

[Spice-devel] [PATCH spice-gtk 2/3] Refresh mouse shape/visibility when changing mouse mode

2011-12-09 Thread Marc-André Lureau
This fixes the dynamic mode changing when running/quitting the agent. --- gtk/spice-widget.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c index 07fb677..d9ee2f6 100644 --- a/gtk/spice-widget.c +++ b/gtk/spice-widget.c @@ -14

[Spice-devel] [PATCH spice-gtk 1/3] Correctly hide client pointer (in server mode)

2011-12-09 Thread Marc-André Lureau
The hide cursor event happen when the widget is not yet realized. Forcing realize may fail if the widget is not yet embedded for example. Instead, let's update the cursor whenever there is a draw(). v2: do not call gdk_window_set_cursor() with the same cursor --- gtk/spice-widget.c |9 +++

Re: [Spice-devel] spice-gtk mouse notes

2011-12-09 Thread Marc-André Lureau
Hi On Thu, Dec 8, 2011 at 4:48 PM, Hans de Goede wrote: > * When switching from client to server mode (do killall spice-vdagent in a > linux guest), 2 things stand out: > 1) The guest mouse cursor does not drawn until a mouse event happens, so > the > usual showing of 2 mouse cursors when

Re: [Spice-devel] deadlock / monitor qemu / spice

2011-12-09 Thread Christophe Fergeau
On Fri, Dec 09, 2011 at 12:34:50PM +0100, nicolas prochazka wrote: > hello again, > > linux 2.6.38.4 + qemu 1.0.0 > vm seven 64 bits > => no freeze Hmm ok, thanks. Can you make one last try with 2.6.38 and rc3? If that's too boring/time consuming, that's fine. I'm just curious whether you can rep

Re: [Spice-devel] deadlock / monitor qemu / spice

2011-12-09 Thread nicolas prochazka
hello again, linux 2.6.38.4 + qemu 1.0.0 vm seven 64 bits => no freeze Regards, Nicolas Prochazka. 2011/12/8 Christophe Fergeau : > Hi, > > On Thu, Dec 08, 2011 at 03:19:40PM +0100, nicolas prochazka wrote: >> Hello, >> >> buggy spice  : >> I'm using a linux based on gentoo >> Linux 2.6.38.4  

Re: [Spice-devel] [PATCH spice-gtk 10/11] Ignore the first mouse click when taking the grab

2011-12-09 Thread Hans de Goede
Hi, On 12/09/2011 10:55 AM, Marc-André Lureau wrote: hi On Thu, Dec 8, 2011 at 4:38 PM, Hans de Goede mailto:hdego...@redhat.com>> wrote: Hmm, this pointer ungrab seems weird, as soon as mouse_mode changes to something other then SERVER, which can only happen in mouse_update(), we

Re: [Spice-devel] [PATCH spice-gtk 10/11] Ignore the first mouse click when taking the grab

2011-12-09 Thread Marc-André Lureau
hi On Thu, Dec 8, 2011 at 4:38 PM, Hans de Goede wrote: > Hmm, this pointer ungrab seems weird, as soon as mouse_mode changes > to something other then SERVER, which can only happen in mouse_update(), > we do a try_mouse_ungrab, which already does a gdk_pointer_ungrab(), > so I believe that this