Re: [Spice-devel] [spice-list] Any update on page/SmartcardUsage

2011-12-05 Thread Christophe Fergeau
Hi, I've only used software smartcards so I've never tried the steps you mention On Mon, Dec 05, 2011 at 10:38:02AM -0500, Lubos Kocman wrote: > Hi, > > I followed steps (physical SC reader) on > http://spice-space.org/page/SmartcardUsage and felt into the same issue as > author. > > modutil

[Spice-devel] Any update on page/SmartcardUsage

2011-12-05 Thread Lubos Kocman
Hi, I followed steps (physical SC reader) on http://spice-space.org/page/SmartcardUsage and felt into the same issue as author. modutil -add "coolkey" -dbdir /etc/pki/nssdb -libfile /usr/lib/pkcs11/libcoolkeypk11.so produces following error (the same as mentioned by author Alon Levy) ERROR:

Re: [Spice-devel] [PATCH spice-gtk 2/2] channel-smartcard: unref in flight messages as soon as they are send

2011-12-05 Thread Hans de Goede
Hi, On 12/05/2011 12:07 PM, Christophe Fergeau wrote: s/send/sent in the subject On Sat, Dec 03, 2011 at 03:00:23PM +0100, Hans de Goede wrote: This is a preparation patch for making spice_msg_out_send() take ownership of the passed in msg. Have you run a test with a smartcard with this chan

Re: [Spice-devel] [PATCH spice-gtk 2/2] channel-smartcard: unref in flight messages as soon as they are send

2011-12-05 Thread Christophe Fergeau
s/send/sent in the subject On Sat, Dec 03, 2011 at 03:00:23PM +0100, Hans de Goede wrote: > This is a preparation patch for making spice_msg_out_send() take ownership > of the passed in msg. Have you run a test with a smartcard with this change? ACK anyway, I'm asking to know if this needs to be

Re: [Spice-devel] [PATCH spice-gtk 1/2] channels-smartcard, cleanup: remove test for impossible condition

2011-12-05 Thread Christophe Fergeau
On Sat, Dec 03, 2011 at 03:00:22PM +0100, Hans de Goede wrote: > There is only one caller of smartcard_message_complete_in_flight() and > that caller already checks that priv->in_flight_message != NULL, as > it dereferences the priv->in_flight_message pointer. Today this code will never be trigger