[Spice-devel] vdagent supported only for XP?

2011-11-23 Thread Todd And Margo Chester
Hi All, Is this still the case? From the spice_uses_manual, page 15, 6.1.2: Note: ▪ The service currently supports only Windows XP. Is there a work around for W7? (Not a real big issue, I hardly ever use W7.) Many thanks, -T ___ Spice-devel mailing l

Re: [Spice-devel] How do I install vioser in virt-manager?

2011-11-23 Thread Marian Krcmarik
- Original Message - > From: "Todd And Margo Chester" > To: "David Jaša" > Cc: "Spice Devel" > Sent: Wednesday, November 23, 2011 8:46:19 PM > Subject: Re: [Spice-devel] How do I install vioser in virt-manager? > > On 11/14/2011 01:13 AM, David Jaša wrote: > > Todd And Margo Chester píš

Re: [Spice-devel] How do I install vioser in virt-manager?

2011-11-23 Thread Todd And Margo Chester
On 11/14/2011 01:13 AM, David Jaša wrote: Todd And Margo Chester píše v Ne 13. 11. 2011 v 19:25 -0800: On 11/11/2011 03:36 AM, David Jaša wrote: Todd And Margo Chester píše v Čt 10. 11. 2011 v 10:58 -0800: On 11/09/2011 12:51 PM, Alon Levy wrote: On Wed, Nov 09, 2011 at 11:07:57AM -0800, Todd

[Spice-devel] [PATCH spice-gtk] Add disable-inputs on Spice widget

2011-11-23 Thread Marc-André Lureau
--- gtk/spice-widget-priv.h |1 + gtk/spice-widget.c | 88 ++ gtk/spicy.c |6 +++ 3 files changed, 79 insertions(+), 16 deletions(-) diff --git a/gtk/spice-widget-priv.h b/gtk/spice-widget-priv.h index a86168d..bd5eec6 100644

Re: [Spice-devel] [PATCH spice-gtk 6/8] Add read-only property on sessions

2011-11-23 Thread Hans de Goede
Ack, Note that after our discussion I also acked the old version where spice_session_get_read_only was kept private and g_object_get was used. So feel free to push which ever version you prefer. Regards, Hans On 11/23/2011 04:43 PM, Marc-André Lureau wrote: It is useful to have a way to prev

Re: [Spice-devel] [PATCH spice-gtk 5/8] Add disable-inputs on Spice widget

2011-11-23 Thread Hans de Goede
Hi, On 11/23/2011 04:43 PM, Marc-André Lureau wrote: --- gtk/spice-widget-priv.h |1 + gtk/spice-widget.c | 80 -- gtk/spicy.c |6 +++ 3 files changed, 76 insertions(+), 11 deletions(-) Hmm, although the patch should

Re: [Spice-devel] [PATCH spice-gtk 4/8] cleanup: the try_grab() functions should take a SpiceDisplay

2011-11-23 Thread Hans de Goede
Ack. On 11/23/2011 04:43 PM, Marc-André Lureau wrote: --- gtk/spice-widget.c | 31 +++ 1 files changed, 15 insertions(+), 16 deletions(-) diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c index f095130..0edc70f 100644 --- a/gtk/spice-widget.c +++ b/gtk/spice-

[Spice-devel] [PATCH spice-gtk 8/8] Do not send specific messages in read-only

2011-11-23 Thread Marc-André Lureau
--- gtk/channel-inputs.c | 22 +- gtk/channel-main.c |5 - gtk/channel-record.c |5 + gtk/channel-smartcard.c |3 +++ gtk/channel-usbredir.c |3 +++ gtk/spice-channel-priv.h |1 + gtk/spice-channel.c |8 +++- 7 files c

[Spice-devel] [PATCH spice-gtk 7/8] Check if msg are permitted to be sent in read-only

2011-11-23 Thread Marc-André Lureau
--- gtk/spice-channel-priv.h |1 + gtk/spice-channel.c | 35 +-- 2 files changed, 34 insertions(+), 2 deletions(-) diff --git a/gtk/spice-channel-priv.h b/gtk/spice-channel-priv.h index 86b22e1..df661f8 100644 --- a/gtk/spice-channel-priv.h +++ b/gtk/spi

[Spice-devel] [PATCH spice-gtk 6/8] Add read-only property on sessions

2011-11-23 Thread Marc-André Lureau
It is useful to have a way to prevent sending commands in read-only sessions (think of multi-client) No clipboard sharing allowed in this case in gtk-session. --- gtk/map-file |1 + gtk/spice-gtk-session-priv.h |1 + gtk/spice-gtk-session.c | 17 +++-- g

[Spice-devel] [PATCH spice-gtk 5/8] Add disable-inputs on Spice widget

2011-11-23 Thread Marc-André Lureau
--- gtk/spice-widget-priv.h |1 + gtk/spice-widget.c | 80 -- gtk/spicy.c |6 +++ 3 files changed, 76 insertions(+), 11 deletions(-) diff --git a/gtk/spice-widget-priv.h b/gtk/spice-widget-priv.h index a86168d..bd5eec6 100644

[Spice-devel] [PATCH spice-gtk 4/8] cleanup: the try_grab() functions should take a SpiceDisplay

2011-11-23 Thread Marc-André Lureau
--- gtk/spice-widget.c | 31 +++ 1 files changed, 15 insertions(+), 16 deletions(-) diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c index f095130..0edc70f 100644 --- a/gtk/spice-widget.c +++ b/gtk/spice-widget.c @@ -104,8 +104,8 @@ static HWND focus_window = NUL

[Spice-devel] [PATCH spice-gtk 3/8] Fix a few g-ir-scanner warnings

2011-11-23 Thread Marc-André Lureau
--- gtk/Makefile.am |2 ++ gtk/smartcard-manager.c |2 +- gtk/spice-util.c| 13 + 3 files changed, 16 insertions(+), 1 deletions(-) diff --git a/gtk/Makefile.am b/gtk/Makefile.am index 8a353dc..ebf908d 100644 --- a/gtk/Makefile.am +++ b/gtk/Makefile.am @@ -59

[Spice-devel] [PATCH spice-gtk 2/8] Export spice_g_signal_connect_object

2011-11-23 Thread Marc-André Lureau
The helper needs to be accessible from spice-client-gtk too. --- gtk/map-file |1 + gtk/spice-util-priv.h |5 - gtk/spice-util.c |1 - gtk/spice-util.h |5 + 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gtk/map-file b/gtk/map-file index

Re: [Spice-devel] [PATCH spice-gtk 6/8] RFC: Add read-only property on sessions

2011-11-23 Thread Hans de Goede
Hi, On 11/23/2011 04:37 PM, Marc-André Lureau wrote: On Wed, Nov 23, 2011 at 4:15 PM, Hans de Goede wrote: Ok, at least change the helper to use spice_session_get_read_only(priv->session), rather then g_object_get please :) I need to make it public then, but that's okay (spice-gtk in general

[Spice-devel] [PATCH spice-gtk 1/8] Regenerate map-file correctly

2011-11-23 Thread Marc-André Lureau
We should use update-map-file instead of modifying it manually --- gtk/Makefile.am |4 ++-- gtk/map-file| 22 +++--- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/gtk/Makefile.am b/gtk/Makefile.am index 5dfa9f3..8a353dc 100644 --- a/gtk/Makefile.am +++

Re: [Spice-devel] [PATCH spice-gtk 6/8] RFC: Add read-only property on sessions

2011-11-23 Thread Marc-André Lureau
On Wed, Nov 23, 2011 at 4:15 PM, Hans de Goede wrote: > Ok, at least change the helper to use > spice_session_get_read_only(priv->session), rather then g_object_get > please :) I need to make it public then, but that's okay (spice-gtk in general doesn't provide direct setter/getter). -- Marc-An

Re: [Spice-devel] [PATCH spice-gtk 6/8] RFC: Add read-only property on sessions

2011-11-23 Thread Hans de Goede
Hi, On 11/23/2011 03:49 PM, Marc-André Lureau wrote: On Wed, Nov 23, 2011 at 3:38 PM, Hans de Goede wrote: Why introduce a separate function for this, why not simply call spice_session_get_read_only(priv->session) in the places where you now call read_only(self) ? it was just a small local h

Re: [Spice-devel] [PATCH spice-gtk 4/8] Notify when property changed

2011-11-23 Thread Marc-André Lureau
You are right guys, and I keep getting it wrong.. Though emitting 2 times doesn't hurt ;) -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH spice-gtk 6/8] RFC: Add read-only property on sessions

2011-11-23 Thread Marc-André Lureau
On Wed, Nov 23, 2011 at 3:38 PM, Hans de Goede wrote: > Why introduce a separate function for this, why not simply call > spice_session_get_read_only(priv->session) in the places where you now call > read_only(self) ? it was just a small local helper, could be turned into a macro perhaps, but I a

Re: [Spice-devel] [PATCH spice-gtk 8/8] Do not send specific messages in read-only

2011-11-23 Thread Hans de Goede
Ack. On 11/23/2011 01:23 PM, Marc-André Lureau wrote: --- gtk/channel-inputs.c | 22 +- gtk/channel-main.c |5 - gtk/channel-record.c |5 + gtk/channel-smartcard.c |3 +++ gtk/channel-usbredir.c |3 +++ gtk/spice-channel-priv.

Re: [Spice-devel] [PATCH spice-gtk 7/8] Check if msg are permitted to be sent in read-only

2011-11-23 Thread Hans de Goede
Ack. On 11/23/2011 01:23 PM, Marc-André Lureau wrote: --- gtk/spice-channel-priv.h |1 + gtk/spice-channel.c | 35 +-- 2 files changed, 34 insertions(+), 2 deletions(-) diff --git a/gtk/spice-channel-priv.h b/gtk/spice-channel-priv.h index 86b22e1.

Re: [Spice-devel] [PATCH spice-gtk 4/8] Notify when property changed

2011-11-23 Thread Christophe Fergeau
On Wed, Nov 23, 2011 at 03:17:46PM +0100, Marc-André Lureau wrote: > Hi > > On Wed, Nov 23, 2011 at 3:13 PM, Hans de Goede wrote: > > Hmm, I don't think this is necessary: > > 1) AFAIK gobject will do the notify itself after calling the property > > setting, > > No it doesn't, you have to do it

Re: [Spice-devel] [PATCH spice-gtk 6/8] RFC: Add read-only property on sessions

2011-11-23 Thread Hans de Goede
Hi, See my comments below. On 11/23/2011 01:23 PM, Marc-André Lureau wrote: It is useful to have a way to prevent sending commands in read-only sessions (think of multi-client) No clipboard sharing allowed in this case in gtk-session. --- gtk/spice-gtk-session-priv.h |1 + gtk/spice-gtk

Re: [Spice-devel] [PATCH spice-gtk 4/8] Notify when property changed

2011-11-23 Thread Hans de Goede
Hi, On 11/23/2011 03:17 PM, Marc-André Lureau wrote: Hi On Wed, Nov 23, 2011 at 3:13 PM, Hans de Goede wrote: Hmm, I don't think this is necessary: 1) AFAIK gobject will do the notify itself after calling the property setting, No it doesn't, you have to do it yourself Are you sure? Becau

Re: [Spice-devel] [PATCH spice-gtk 5/8] Add disable-inputs on Spice widget

2011-11-23 Thread Marc-André Lureau
Hi On Wed, Nov 23, 2011 at 3:24 PM, Hans de Goede wrote: > Since spice_g_signal_connect_object was moved to spice-util.h, this > chunk seems unnecessary (or the include should be spice-util.h not > spice-util-priv.h). correct, I don't need it anymore (leftover from earlier approach) > This chan

Re: [Spice-devel] [PATCH spice-gtk 5/8] Add disable-inputs on Spice widget

2011-11-23 Thread Hans de Goede
Hi, Some small remarks below, also I'm afraid that this conflicts with my "Release our keyboard grab when we're going to invoke the usb acl helper" patch, which I just pushed. I should have pushed it sooner, but I was waiting to get my additional 3 patches in shape and push them all in one go, so

Re: [Spice-devel] [PATCH spice-gtk 4/8] Notify when property changed

2011-11-23 Thread Marc-André Lureau
Hi On Wed, Nov 23, 2011 at 3:13 PM, Hans de Goede wrote: > Hmm, I don't think this is necessary: > 1) AFAIK gobject will do the notify itself after calling the property > setting, No it doesn't, you have to do it yourself > 2) auto-usbredir is a new property and doesn't have any compat needs.

Re: [Spice-devel] [PATCH spice-gtk 4/8] Notify when property changed

2011-11-23 Thread Hans de Goede
Hi, On 11/23/2011 01:23 PM, Marc-André Lureau wrote: So that compatibility code with deprecated properties work --- gtk/spice-gtk-session.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/gtk/spice-gtk-session.c b/gtk/spice-gtk-session.c index 116eead..c181c7e 100644

Re: [Spice-devel] [PATCH spice-gtk 3/8] Fix a few g-ir-scanner warnings

2011-11-23 Thread Hans de Goede
Ack. On 11/23/2011 01:23 PM, Marc-André Lureau wrote: --- gtk/Makefile.am |2 ++ gtk/smartcard-manager.c |2 +- gtk/spice-util.c| 13 + 3 files changed, 16 insertions(+), 1 deletions(-) diff --git a/gtk/Makefile.am b/gtk/Makefile.am index d770ec1..992c

Re: [Spice-devel] [PATCH spice-gtk 2/8] Export spice_g_signal_connect_object

2011-11-23 Thread Hans de Goede
Ack. On 11/23/2011 01:23 PM, Marc-André Lureau wrote: The helper needs to be accessible from spice-client-gtk too. --- gtk/map-file |1 + gtk/spice-util-priv.h |5 - gtk/spice-util.c |1 - gtk/spice-util.h |5 + 4 files changed, 6 insertions(+), 6

Re: [Spice-devel] [PATCH spice-gtk 1/8] Regenerate map-file correctly

2011-11-23 Thread Hans de Goede
Ack. On 11/23/2011 01:23 PM, Marc-André Lureau wrote: We should use update-map-file instead of modifying it manually --- gtk/Makefile.am |4 ++-- gtk/map-file| 20 ++-- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/gtk/Makefile.am b/gtk/Makefile.a

[Spice-devel] [usbredir] Switch to autotools build system

2011-11-23 Thread Christophe Fergeau
Replace the current build system with an autotools based one. --- Make.rules | 28 Makefile| 18 --- Makefile.am |1 + autogen.sh |4 ++ config

[Spice-devel] [PATCH spice-gtk 8/8] Do not send specific messages in read-only

2011-11-23 Thread Marc-André Lureau
--- gtk/channel-inputs.c | 22 +- gtk/channel-main.c |5 - gtk/channel-record.c |5 + gtk/channel-smartcard.c |3 +++ gtk/channel-usbredir.c |3 +++ gtk/spice-channel-priv.h |1 + gtk/spice-channel.c |8 +++- 7 files c

[Spice-devel] [PATCH spice-gtk 7/8] Check if msg are permitted to be sent in read-only

2011-11-23 Thread Marc-André Lureau
--- gtk/spice-channel-priv.h |1 + gtk/spice-channel.c | 35 +-- 2 files changed, 34 insertions(+), 2 deletions(-) diff --git a/gtk/spice-channel-priv.h b/gtk/spice-channel-priv.h index 86b22e1..df661f8 100644 --- a/gtk/spice-channel-priv.h +++ b/gtk/spi

[Spice-devel] [PATCH spice-gtk 6/8] RFC: Add read-only property on sessions

2011-11-23 Thread Marc-André Lureau
It is useful to have a way to prevent sending commands in read-only sessions (think of multi-client) No clipboard sharing allowed in this case in gtk-session. --- gtk/spice-gtk-session-priv.h |1 + gtk/spice-gtk-session.c | 23 +++ gtk/spice-session-priv.h |

[Spice-devel] [PATCH spice-gtk 5/8] Add disable-inputs on Spice widget

2011-11-23 Thread Marc-André Lureau
--- gtk/spice-widget-priv.h |1 + gtk/spice-widget.c | 111 +++--- gtk/spicy.c |6 +++ 3 files changed, 91 insertions(+), 27 deletions(-) diff --git a/gtk/spice-widget-priv.h b/gtk/spice-widget-priv.h index a5791a4..5065f7c 100644

[Spice-devel] [PATCH spice-gtk 4/8] Notify when property changed

2011-11-23 Thread Marc-André Lureau
So that compatibility code with deprecated properties work --- gtk/spice-gtk-session.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/gtk/spice-gtk-session.c b/gtk/spice-gtk-session.c index 116eead..c181c7e 100644 --- a/gtk/spice-gtk-session.c +++ b/gtk/spice-gtk-session

[Spice-devel] [PATCH spice-gtk 3/8] Fix a few g-ir-scanner warnings

2011-11-23 Thread Marc-André Lureau
--- gtk/Makefile.am |2 ++ gtk/smartcard-manager.c |2 +- gtk/spice-util.c| 13 + 3 files changed, 16 insertions(+), 1 deletions(-) diff --git a/gtk/Makefile.am b/gtk/Makefile.am index d770ec1..992c1e9 100644 --- a/gtk/Makefile.am +++ b/gtk/Makefile.am @@ -55

[Spice-devel] [PATCH spice-gtk 2/8] Export spice_g_signal_connect_object

2011-11-23 Thread Marc-André Lureau
The helper needs to be accessible from spice-client-gtk too. --- gtk/map-file |1 + gtk/spice-util-priv.h |5 - gtk/spice-util.c |1 - gtk/spice-util.h |5 + 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gtk/map-file b/gtk/map-file index

[Spice-devel] [PATCH spice-gtk 1/8] Regenerate map-file correctly

2011-11-23 Thread Marc-André Lureau
We should use update-map-file instead of modifying it manually --- gtk/Makefile.am |4 ++-- gtk/map-file| 20 ++-- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/gtk/Makefile.am b/gtk/Makefile.am index a3960a7..d770ec1 100644 --- a/gtk/Makefile.am +++ b/