Re: [Spice-devel] [PATCH spice-gtk 8/8] Release our keyboard grab when we're going to invoke the usb acl helper

2011-11-21 Thread Hans de Goede
Hi, On 11/21/2011 02:58 PM, Marc-André Lureau wrote: Hi I wasn't sure about it myself either, but note that g_object_set is a va function, so sizeof arguments matters, and I think that FALSE will likely evaluate to an int, so if sizeof(int) != sizeof(gboolean) this may be an issue, hence the

Re: [Spice-devel] [PATCH spice-gtk 2/3] usb-device-manager: Don't show an error dialog on a cancelled device open

2011-11-21 Thread Hans de Goede
Hi, On 11/21/2011 03:04 PM, Marc-André Lureau wrote: Hi +if (err) +g_error_free(err); In general, we should favor g_clear_error(), which is also NULL tolerant. Hmm, I checked the docs before doing things this way and the docs say: voidg_clear_error

Re: [Spice-devel] [PATCH spice-gtk 2/3] usb-device-manager: Don't show an error dialog on a cancelled device open

2011-11-21 Thread Marc-André Lureau
Hi > >> +if (err) > >> +g_error_free(err); > > > > In general, we should favor g_clear_error(), which is also NULL > > tolerant. > > Hmm, I checked the docs before doing things this way and the docs > say: > > voidg_clear_error (GError > **err);

Re: [Spice-devel] [PATCH spice-gtk 8/8] Release our keyboard grab when we're going to invoke the usb acl helper

2011-11-21 Thread Marc-André Lureau
Hi > I wasn't sure about it myself either, but note that g_object_set is > a va function, so sizeof arguments matters, and I think that FALSE > will > likely evaluate to an int, so if sizeof(int) != sizeof(gboolean) this > may be an issue, hence the cast. Basically I'm going for better safe > the

[Spice-devel] [PATCH v3 vdagent-win] vdlog: change log times to human readable date & time rhbz#672828

2011-11-21 Thread Arnon Gilboa
-use RHEV log format -add log levels & macros -remove LOG_ENABLED ifdefs --- common/vdlog.cpp |4 --- common/vdlog.h | 62 - 2 files changed, 47 insertions(+), 19 deletions(-) diff --git a/common/vdlog.cpp b/common/vdlog.cpp index 1001de

Re: [Spice-devel] [PATCH v2 vdagent-win] vdlog: change log times to human readable date & time rhbz#672828

2011-11-21 Thread Arnon Gilboa
10x, see below. Uri Lublin wrote: On 11/21/2011 09:50 AM, Arnon Gilboa wrote: -use RHEV log format -add log levels & macros -remove LOG_ENABLED ifdefs --- common/vdlog.cpp |4 common/vdlog.h | 54 +++--- 2 files changed, 39 insert

Re: [Spice-devel] deadlock / monitor qemu / spice

2011-11-21 Thread nicolas prochazka
I can reproduce it with one vm but i need to start / stop it a lot With 20 vm, two or more are freezing state. I can give acces to my server, but it's only prod server without any tools ( no gdb ) Regards, Nicolas Prochazka. 2011/11/21 Christophe Fergeau : > Hey, > > On Mon, Nov 21, 2011 at

Re: [Spice-devel] deadlock / monitor qemu / spice

2011-11-21 Thread Christophe Fergeau
Hey, On Mon, Nov 21, 2011 at 01:13:24PM +0200, Alon Levy wrote: > On Mon, Nov 21, 2011 at 11:28:26AM +0100, nicolas prochazka wrote: > > hi again, > > if I delete -device virtio-serial -chardev > > spicevmc,id=vdagent,debug=0,name=vdagent -device > > virtserialport,chardev=vdagent,name=com.redhat.

Re: [Spice-devel] deadlock / monitor qemu / spice

2011-11-21 Thread Alon Levy
On Mon, Nov 21, 2011 at 11:28:26AM +0100, nicolas prochazka wrote: > hi again, > if I delete -device virtio-serial -chardev > spicevmc,id=vdagent,debug=0,name=vdagent -device > virtserialport,chardev=vdagent,name=com.redhat.spice.0 > from qemu command line, > vm freeze during boot process not occur

Re: [Spice-devel] deadlock / monitor qemu / spice

2011-11-21 Thread David Jaša
nicolas prochazka píše v Po 21. 11. 2011 v 11:28 +0100: > hi again, > if I delete -device virtio-serial -chardev > spicevmc,id=vdagent,debug=0,name=vdagent -device > virtserialport,chardev=vdagent,name=com.redhat.spice.0 > from qemu command line, > vm freeze during boot process not occurs anymore.

Re: [Spice-devel] [PATCH v2 vdagent-win] vdlog: change log times to human readable date & time rhbz#672828

2011-11-21 Thread Uri Lublin
On 11/21/2011 09:50 AM, Arnon Gilboa wrote: > -use RHEV log format > -add log levels & macros > -remove LOG_ENABLED ifdefs > --- > common/vdlog.cpp |4 > common/vdlog.h | 54 > +++--- > 2 files changed, 39 insertions(+), 19 deletions(-)

Re: [Spice-devel] deadlock / monitor qemu / spice

2011-11-21 Thread nicolas prochazka
hi again, if I delete -device virtio-serial -chardev spicevmc,id=vdagent,debug=0,name=vdagent -device virtserialport,chardev=vdagent,name=com.redhat.spice.0 from qemu command line, vm freeze during boot process not occurs anymore. (virtio-serial_20110725) /usr/local/bin/qemu -name spice020 -spic

Re: [Spice-devel] spice-vdagentd won't start -- missing /dev/virtio-ports/com.redhat.spice.0

2011-11-21 Thread David Jaša
Todd And Margo Chester píše v Pá 18. 11. 2011 v 21:31 -0800: > Ooops. Retransmitted without the HTML. > > > Hi Guys, > > I can not get /etc/rc.d/init.d/spice-vdagentd to start because of the line > > [ -c $port ] || exit 0# where "$port" = > "/dev/virtio-ports/com.redhat.spice.0" >

Re: [Spice-devel] spice-vdagentd won't start -- missing /dev/virtio-ports/com.redhat.spice.0

2011-11-21 Thread Christophe Fergeau
Hey, On Fri, Nov 18, 2011 at 09:31:50PM -0800, Todd And Margo Chester wrote: > Problem: I have no "/dev/virtio-ports" directory. "spice-vdagentd" exits as > it is suppose to. > > How do I get "/dev/virtio-ports/com.redhat.spice.0" to show up? What did I > not install? What am I doing wrong? I

Re: [Spice-devel] Virt-manager and spice

2011-11-21 Thread Christophe Fergeau
On Wed, Nov 16, 2011 at 12:03:11PM -0500, Scott Dowdle wrote: > I just tested virt-manager on one of my RHEL 6.1 boxes and it includes > QXL and SPICE but the system does not have the spice-gtk package > installed... since there isn't one. Some other package is providing the > functionality. At s

Re: [Spice-devel] [PATCH spice-gtk 3/3] usb-device-manager: Don't g_warning on autoconnect failure

2011-11-21 Thread Hans de Goede
Hi, On 11/21/2011 12:11 AM, Marc-André Lureau wrote: On Sat, Nov 19, 2011 at 4:29 PM, Hans de Goede wrote: We already emit a signal for this, either the app using spice-client-glib listens to this signals and does something with it, or it is not interested in this happening, at which point log

Re: [Spice-devel] [PATCH spice-gtk 2/3] usb-device-manager: Don't show an error dialog on a cancelled device open

2011-11-21 Thread Hans de Goede
Hi, On 11/21/2011 12:09 AM, Marc-André Lureau wrote: On Sat, Nov 19, 2011 at 4:29 PM, Hans de Goede wrote: If for example the user plugs in a new device, then gets the policykit agent authentication dialog and then unplugs the device, spice-gtk will cancel the acl-helper request, which in turn

Re: [Spice-devel] [PATCH spice-gtk 1/3] Suppress libusb open error messages when trying to open a device

2011-11-21 Thread Hans de Goede
Hi, On 11/20/2011 11:58 PM, Marc-André Lureau wrote: hi On Sat, Nov 19, 2011 at 4:29 PM, Hans de Goede wrote: /* Silence open failing (ie permission denied) errors */ +g_object_set(priv->context, "debug_level", 0, NULL); rc = libusb_open(_g_usb_device_get_device(priv->device),&ha

Re: [Spice-devel] [PATCH spice-gtk 8/8] Release our keyboard grab when we're going to invoke the usb acl helper

2011-11-21 Thread Hans de Goede
Hi, Thanks for all the reviews! On 11/20/2011 11:35 PM, Marc-André Lureau wrote: hi On Wed, Nov 16, 2011 at 6:49 PM, Hans de Goede wrote: +g_object_set(spice_channel_get_session(SPICE_CHANNEL(channel)), + "inhibit-keyboard-grab", (gboolean)FALSE, NULL); I don't think th