Re: [Spice-devel] spice broken with upstream qemu / qemu-kvm

2011-11-02 Thread Yonit Halperin
On 11/02/2011 10:06 PM, Hans de Goede wrote: Hi, Hi all, Today I've tried to build (succeeded) and run (failed) spice + qemu from upstream git (1.0-rc0) I tried both regular qemu as well as qemu-kvm. In both cases the qemu binary works fine as long as I don't start it with -vga qxl. What exact

[Spice-devel] spice broken with upstream qemu / qemu-kvm

2011-11-02 Thread Hans de Goede
Hi all, Today I've tried to build (succeeded) and run (failed) spice + qemu from upstream git (1.0-rc0) I tried both regular qemu as well as qemu-kvm. In both cases the qemu binary works fine as long as I don't start it with -vga qxl. This is with: seabios + vgabios from the Fedora 16 repositor

Re: [Spice-devel] [PATCH spice-gtk] Correctly parse RFC-conform URIs separating the host and the arguments by a '/'

2011-11-02 Thread Marc-André Lureau
On Tue, Nov 1, 2011 at 9:49 AM, Tiziano Müller wrote: > Little patch to make spice-gtk accept RFC-conform URLs of the form > "spice://host/?port=5901". acked and pushed, thanks! http://cgit.freedesktop.org/spice/spice-gtk/commit/?id=3726bcbb927e58dad80dc5934bd393ccad373aac -- Marc-André Lurea

Re: [Spice-devel] [RFC 3/3] server/red_worker: reuse dispatcher

2011-11-02 Thread Alon Levy
On Wed, Nov 02, 2011 at 06:00:46PM +0200, Yonit Halperin wrote: > On 11/01/2011 10:10 AM, Alon Levy wrote: > >This patch reuses Dispatcher in RedDispatcher. It adds two helpers > >to red_worker to keep RedWorker opaque to the outside. The dispatcher is > >abused in three places that use the underly

Re: [Spice-devel] [RFC 3/3] server/red_worker: reuse dispatcher

2011-11-02 Thread Yonit Halperin
On 11/01/2011 10:10 AM, Alon Levy wrote: This patch reuses Dispatcher in RedDispatcher. It adds two helpers to red_worker to keep RedWorker opaque to the outside. The dispatcher is abused in three places that use the underlying socket directly: once sending a READY after red_init completes on

Re: [Spice-devel] [RFC 2/3] server: introduce dispatcher

2011-11-02 Thread Alon Levy
On Wed, Nov 02, 2011 at 04:40:06PM +0200, Yonit Halperin wrote: > On 11/01/2011 10:10 AM, Alon Levy wrote: > >used for main_dispatcher only in this patch. > > > >Dispatcher is meant to be used for Main<->any low frequency messages. > just curious: what is the advantage of using a pipe over an expli

Re: [Spice-devel] [RFC 2/3] server: introduce dispatcher

2011-11-02 Thread Alon Levy
On Wed, Nov 02, 2011 at 04:24:05PM +0200, Yonit Halperin wrote: > On 11/01/2011 10:10 AM, Alon Levy wrote: > >used for main_dispatcher only in this patch. > > > >Dispatcher is meant to be used for Main<->any low frequency messages. > > > >It's interface is meant to include the red_dispatcher usage:

Re: [Spice-devel] [RFC 2/3] server: introduce dispatcher

2011-11-02 Thread Paolo Bonzini
On 11/02/2011 04:05 PM, Alon Levy wrote: On Wed, Nov 02, 2011 at 02:57:45PM +0100, Paolo Bonzini wrote: On 11/01/2011 09:10 AM, Alon Levy wrote: +/* + * read_with_eintr + * helper. reads until size bytes accumulated in buf, if an error other then + * EINTR is encountered returns -1, otherwise r

Re: [Spice-devel] [RFC 2/3] server: introduce dispatcher

2011-11-02 Thread Alon Levy
On Wed, Nov 02, 2011 at 02:57:45PM +0100, Paolo Bonzini wrote: > On 11/01/2011 09:10 AM, Alon Levy wrote: > >+/* > >+ * read_with_eintr > >+ * helper. reads until size bytes accumulated in buf, if an error other then > >+ * EINTR is encountered returns -1, otherwise returns 0. > >+ */ > >+int read_

Re: [Spice-devel] [RFC 1/3] server/red_dispatcher: support concurrent asyncs

2011-11-02 Thread Alon Levy
On Wed, Nov 02, 2011 at 02:38:19PM +0200, Yonit Halperin wrote: > Hi, > > One comment bellow. Besides that, Ack. > > On 11/01/2011 10:10 AM, Alon Levy wrote: > >This is part of the dispatcher update, extracting the dispatcher routine > >from red_dispatcher and main_dispatcher into dispatcher. > >

Re: [Spice-devel] [RFC 2/3] server: introduce dispatcher

2011-11-02 Thread Yonit Halperin
On 11/01/2011 10:10 AM, Alon Levy wrote: used for main_dispatcher only in this patch. Dispatcher is meant to be used for Main<->any low frequency messages. just curious: what is the advantage of using a pipe over an explicit ring of messages with signalling for writes and acks? __

Re: [Spice-devel] [RFC 2/3] server: introduce dispatcher

2011-11-02 Thread Yonit Halperin
On 11/01/2011 10:10 AM, Alon Levy wrote: used for main_dispatcher only in this patch. Dispatcher is meant to be used for Main<->any low frequency messages. It's interface is meant to include the red_dispatcher usage: fixed size messages per message type some messages require an ack Some me

Re: [Spice-devel] [RFC 2/3] server: introduce dispatcher

2011-11-02 Thread Paolo Bonzini
On 11/01/2011 09:10 AM, Alon Levy wrote: +/* + * read_with_eintr + * helper. reads until size bytes accumulated in buf, if an error other then + * EINTR is encountered returns -1, otherwise returns 0. + */ +int read_with_eintr(int fd, void *buf, size_t size) +{ +int read_size = 0; +int re

Re: [Spice-devel] [RFC 1/3] server/red_dispatcher: support concurrent asyncs

2011-11-02 Thread Yonit Halperin
Hi, One comment bellow. Besides that, Ack. On 11/01/2011 10:10 AM, Alon Levy wrote: This is part of the dispatcher update, extracting the dispatcher routine from red_dispatcher and main_dispatcher into dispatcher. Supporting multiple async operations will make it natural to support async monit

Re: [Spice-devel] USB Redirections support

2011-11-02 Thread Gianluca Cecchi
On Wed, Nov 2, 2011 at 10:13 AM, Bakyt Niyazov wrote: > Hello! I am going to test SPICE VDI thoroughly...can you tell what is the > status about > USB Redirection? (support of remote USB devices). Does it work? WHat is the > state of it? Does it support at least Printers and other basic devices?

[Spice-devel] USB Redirections support

2011-11-02 Thread Bakyt Niyazov
Hello! I am going to test SPICE VDI thoroughly...can you tell what is the status about USB Redirection? (support of remote USB devices). Does it work? WHat is the state of it? Does it support at least Printers and other basic devices? ___ Spice-devel mail

Re: [Spice-devel] [PATCH migration 09/19] server: handling semi-seamless migration in the target side

2011-11-02 Thread Yonit Halperin
On 11/01/2011 11:34 PM, Alon Levy wrote: On Wed, Oct 12, 2011 at 12:38:59PM +0200, Yonit Halperin wrote: (1) not sending anything to a migrated client till we recieve SPICE_MSGC_MIGRATE_END (2) start a new client migration (handle client_migrate_info) only after SPICE_MSGC_MIGRATE_END fro