Re: [Spice-devel] [PATCH migration 00/19] semi-seamless migration for master

2011-11-01 Thread Alon Levy
On Wed, Oct 12, 2011 at 12:38:50PM +0200, Yonit Halperin wrote: > Hi, > in the following patch series the same logic of semi-seamless for the 0.8 > branch was > adjusted to multiple clients (and to the refactoring of > red_channel/reds/main_channel). > The code differs from the 0.8 branch only fo

Re: [Spice-devel] [PATCH migration 10/19] server: turn spice_server_migrate_start into a valid call

2011-11-01 Thread Alon Levy
On Wed, Oct 12, 2011 at 12:39:00PM +0200, Yonit Halperin wrote: > We will add a qemu call to spice_server_migrate_start when migration starts. > For now, it does nothing, but we may need this notification in the future. > (cherry picked from commit b8213167717979e6f2fb52646e43eb458634e6a1 branch >

Re: [Spice-devel] [PATCH migration 09/19] server: handling semi-seamless migration in the target side

2011-11-01 Thread Alon Levy
On Wed, Oct 12, 2011 at 12:38:59PM +0200, Yonit Halperin wrote: > (1) not sending anything to a migrated client till we recieve > SPICE_MSGC_MIGRATE_END > (2) start a new client migration (handle client_migrate_info) only after > SPICE_MSGC_MIGRATE_END > from the previous migration was receiv

Re: [Spice-devel] [PATCH migration 08/19] server: move the linking of channels to a separate routine

2011-11-01 Thread Alon Levy
On Wed, Oct 12, 2011 at 12:38:58PM +0200, Yonit Halperin wrote: > ACK > Signed-off-by: Yonit Halperin > --- > server/reds.c | 45 - > 1 files changed, 28 insertions(+), 17 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index 20032a9

Re: [Spice-devel] [PATCH migration 07/19] server: handle spice_server_migrate_end

2011-11-01 Thread Alon Levy
On Wed, Oct 12, 2011 at 12:38:57PM +0200, Yonit Halperin wrote: > If the migration has completed successfully: > (1) send MSG_MAIN_MIGRATE_END to the clients that are connected to the target > (2) send MSG_MAIN_SWITCH_HOST to all the other clients > ACK. > If the migration failed, send MSG_MAIN_

Re: [Spice-devel] [PATCH migration 06/19] spice.proto: add SPICE_MSG_MAIN_MIGRATE_END & SPICE_MSGC_MAIN_MIGRATE_END (cherry picked from commit cfbd07710562e522179ae5a7085a789489a821bb branch 0.8)

2011-11-01 Thread Alon Levy
On Wed, Oct 12, 2011 at 12:38:56PM +0200, Yonit Halperin wrote: > > Signed-off-by: Yonit Halperin > --- > spice.proto |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > Cherry pick. ACK. > diff --git a/spice.proto b/spice.proto > index 78c1fad..266e03a 100644 > --- a/spice.pro

Re: [Spice-devel] [PATCH migration 05/19] server, proto: tell the clients to connect to the migration target before migraton starts

2011-11-01 Thread Alon Levy
On Wed, Oct 12, 2011 at 12:38:55PM +0200, Yonit Halperin wrote: > (1) send SPICE_MSG_MAIN_MIGRATE_BEGIN upon spice_server_migrate_connect > (to all the clients that support it) > (2) wait for SPICE_MSGC_MAIN_MIGRATE_(CONNECTED|CONNECT_ERROR) from all the > relevant clients, > or a timeout,

[Spice-devel] [PATCH spice-gtk] Correctly parse RFC-conform URIs separating the host and the arguments by a '/'

2011-11-01 Thread Tiziano Müller
Little patch to make spice-gtk accept RFC-conform URLs of the form "spice://host/?port=5901". I didn't add '/' to the list of the other characters to ignore (?;&) by intention since an URL like spice://host/?port=5901/somotherstuff should not be valid, resp. the password may contain '/' because

Re: [Spice-devel] [PATCH migration 04/19] configure: spice-protocol >= 0.9.1 (semi-seamless migration protocol) (cherry picked from commit 55ccc022ec9829523ebe36fdf0ec7c593ce76c22 branch 0.8)

2011-11-01 Thread Alon Levy
On Wed, Oct 12, 2011 at 12:38:54PM +0200, Yonit Halperin wrote: ACK > Conflicts: > > configure.ac > > Signed-off-by: Yonit Halperin > --- > configure.ac |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 2afc559..203e82f 1

Re: [Spice-devel] [PATCH migration 03/19] server: handle migration interface addition (cherry picked from commit 3ac0075cdac8fa42de47a7882022795e96cb1fee branch 0.8)

2011-11-01 Thread Alon Levy
On Wed, Oct 12, 2011 at 12:38:53PM +0200, Yonit Halperin wrote: > Conflicts: > ACK. Please move the "cherry-picked from" messages from the status to the commit body if possible (not critical). > server/reds.h > > Signed-off-by: Yonit Halperin > --- > server/reds.c | 29 ++

Re: [Spice-devel] [PATCH migration 02/19] server/spice.h: semi-seamless migration interface, RHBZ #738266

2011-11-01 Thread Alon Levy
On Wed, Oct 12, 2011 at 12:38:52PM +0200, Yonit Halperin wrote: > semi-seamless migration details: > ACK > migration source side > - > (1) spice_server_migrate_connect (*): tell client to link > to the target side - send SPICE_MSG_MAIN_MIGRATE_BEGIN. > This should be

[Spice-devel] [RFC 0/3] Dispatcher infrastructure

2011-11-01 Thread Alon Levy
These patches add a Dispatcher (dispatcher.[ch]) struct that is used to reimplement main_dispatcher.[ch] and red_dispatcher.[ch] + red_worker.c The first two patches I consider non RFC, the RFC is for the last patch: it adds 500 lines of code. it doesn't hide the underlying socket completely sin

[Spice-devel] [RFC 2/3] server: introduce dispatcher

2011-11-01 Thread Alon Levy
used for main_dispatcher only in this patch. Dispatcher is meant to be used for Main<->any low frequency messages. It's interface is meant to include the red_dispatcher usage: fixed size messages per message type some messages require an ack Some methods are added to be used by RedDispatcher l

[Spice-devel] [RFC 1/3] server/red_dispatcher: support concurrent asyncs

2011-11-01 Thread Alon Levy
This is part of the dispatcher update, extracting the dispatcher routine from red_dispatcher and main_dispatcher into dispatcher. Supporting multiple async operations will make it natural to support async monitor commands and async guest io requests that could overlap in time. Related bug: https: