ack (shit happens, and partly my fault)
- Original Message -
> Brown paper bag bug number 2 wrt spice-gtk-session-priv.h, sorry
> about this.
>
> Signed-off-by: Hans de Goede
> ---
> gtk/Makefile.am |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/gtk/Makef
Brown paper bag bug number 2 wrt spice-gtk-session-priv.h, sorry about this.
Signed-off-by: Hans de Goede
---
gtk/Makefile.am |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gtk/Makefile.am b/gtk/Makefile.am
index f4b595f..a3960a7 100644
--- a/gtk/Makefile.am
+++ b/gtk/M
On 10 October 2011 18:29, Hans de Goede wrote:
> Hi,
>
> On 10/10/2011 05:34 PM, Damien Churchill wrote:
>>
>> Hi,
>>
>> I was wondering how spice-gtk-session-priv.h is created. Using git
>> HEAD there doesn't appear to be such a file. The only references to it
>> are within spice-gtk-session.c an
Hi,
On 10/10/2011 05:34 PM, Damien Churchill wrote:
Hi,
I was wondering how spice-gtk-session-priv.h is created. Using git
HEAD there doesn't appear to be such a file. The only references to it
are within spice-gtk-session.c and spice-widget.c as far as I can
tell, so not too sure where it is.
On Mon, Oct 10, 2011 at 04:34:56PM +0100, Damien Churchill wrote:
> I was wondering how spice-gtk-session-priv.h is created. Using git
> HEAD there doesn't appear to be such a file. The only references to it
> are within spice-gtk-session.c and spice-widget.c as far as I can
> tell, so not too sure
Hi,
I was wondering how spice-gtk-session-priv.h is created. Using git
HEAD there doesn't appear to be such a file. The only references to it
are within spice-gtk-session.c and spice-widget.c as far as I can
tell, so not too sure where it is.
It doesn't seem as though it's required as touching it
ack
- Original Message -
> Signed-off-by: Hans de Goede
> ---
> gtk/spice-gtk-session.c | 55
> ++-
> gtk/spice-widget-priv.h |1 -
> gtk/spice-widget.c | 43
> gtk/spicy.c |6 +
ack
- Original Message -
> The SpiceGtkSession ones should be used instead.
>
> Signed-off-by: Hans de Goede
> ---
> gtk/spice-gtk-session.c | 20 +---
> gtk/spice-widget.c | 11 ++-
> 2 files changed, 19 insertions(+), 12 deletions(-)
>
> diff --git a/
ack
- Original Message -
> The auto-clipboard setting now lives in the SpiceGtkSession, if that
> was changed to FALSE (from the default of TRUE) and later a
> SpiceDisplay
> was created for this session that would change it back to TRUE again
> because
> it would set it to its default fro
Signed-off-by: Hans de Goede
---
gtk/spice-gtk-session.c | 55 ++-
gtk/spice-widget-priv.h |1 -
gtk/spice-widget.c | 43
gtk/spicy.c |6 ++--
4 files changed, 62 insertions(+), 43 deleti
Signed-off-by: Hans de Goede
---
gtk/spicy.c | 77 ++-
1 files changed, 60 insertions(+), 17 deletions(-)
diff --git a/gtk/spicy.c b/gtk/spicy.c
index 533d7f7..3034dbb 100644
--- a/gtk/spicy.c
+++ b/gtk/spicy.c
@@ -1,6 +1,6 @@
/* -*- Mod
The SpiceGtkSession ones should be used instead.
Signed-off-by: Hans de Goede
---
gtk/spice-gtk-session.c | 20 +---
gtk/spice-widget.c | 11 ++-
2 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/gtk/spice-gtk-session.c b/gtk/spice-gtk-session.c
in
The auto-clipboard setting now lives in the SpiceGtkSession, if that
was changed to FALSE (from the default of TRUE) and later a SpiceDisplay
was created for this session that would change it back to TRUE again because
it would set it to its default from its constructor. This patch fixes this.
Sig
Hi
- Original Message -
> Sorry about pushing that one patch to soon. You're reviews are
> appreciated and I'm not
> ignoring them, AFAIK I've been faithfully addressing every single
> remark. Including
> the deprecation remark, although maybe a bit late.
There are some other comments tha
Hi,
On 10/10/2011 04:07 PM, Marc-André Lureau wrote:
Hi
- Original Message -
We discussed adding the deprecation notes on Fri 7 Oct, I pushed the
initial
(and acked) patch moving the clipboard stuff to git.freedesktop.org
on Thu 6 Oct.
The day I gave a ack with the deprecation commen
Hi
- Original Message -
> We discussed adding the deprecation notes on Fri 7 Oct, I pushed the
> initial
> (and acked) patch moving the clipboard stuff to git.freedesktop.org
> on Thu 6 Oct.
The day I gave a ack with the deprecation comment. You shouldn't have pushed
before.
>
> Sorry
Hi
- Original Message -
> > Have you tried removing G_PARAM_CONSTRUCT from auto-clipboard
> > property?
> >
> > That should not set the value at construction time.
>
> Ah, good one, yes that fixes this in a much nicer way. Technically
> that
> is a backward compat API breaking change, but
Hi,
On 10/10/2011 03:23 PM, Marc-André Lureau wrote:
- Original Message -
Hi,
On 10/10/2011 02:51 PM, Marc-André Lureau wrote:
This should rather be done in GObjectClass.constructed()
That is too late we *must* chain up to the GObjectClass constructor
Have you tried removing G_PA
Hi,
On 10/10/2011 02:52 PM, Marc-André Lureau wrote:
Same comment as previous patch.
Same reply, I could merge this into the deprecation patch if you like, I was
not sure
since it is only partly related.
Regards,
Hans
On Mon, Oct 10, 2011 at 2:34 PM, Hans de Goede wrote:
Signed-off-b
Hi,
On 10/10/2011 02:52 PM, Marc-André Lureau wrote:
Why 0.10? We are 0.7.X right now. I don't see the need to bump version number.
My bad, I assumed the next release would be a minor increment rather then a
patchlevel
increment (given the addition of usbredir + SpiceGtkSession), but I messed
- Original Message -
> Hi,
>
> On 10/10/2011 02:51 PM, Marc-André Lureau wrote:
> > This should rather be done in GObjectClass.constructed()
>
> That is too late we *must* chain up to the GObjectClass constructor
Have you tried removing G_PARAM_CONSTRUCT from auto-clipboard property?
T
Hi,
On 10/10/2011 02:51 PM, Marc-André Lureau wrote:
This should rather be done in GObjectClass.constructed()
That is too late we *must* chain up to the GObjectClass constructor
as the first thing we do in our own constructor, and that calls
spice_display_set_property() for all our properties,
On Mon, Oct 10, 2011 at 02:49:51PM +0200, Marc-André Lureau wrote:
> Does this means that .gitignore will always show up in git status? If
> yes, then that's bad and I would rather keep it..
I prefer to have it in git status rather than in git diff :) you can add
.gitignore to .git/info/exclude if
ack
On Mon, Oct 10, 2011 at 2:34 PM, Hans de Goede wrote:
> Signed-off-by: Hans de Goede
> ---
> gtk/spice-gtk-session.c | 55
> ++-
> gtk/spice-widget-priv.h | 1 -
> gtk/spice-widget.c | 43
> gtk/sp
On Mon, Oct 10, 2011 at 2:52 PM, Hans de Goede wrote:
> Hi,
>
> On 10/10/2011 02:49 PM, Marc-André Lureau wrote:
>>
>> Does this means that .gitignore will always show up in git status? If
>> yes, then that's bad and I would rather keep it..
>>
>
> No (I just checked), it just means that when the
ack
On Mon, Oct 10, 2011 at 2:34 PM, Hans de Goede wrote:
> Signed-off-by: Hans de Goede
> ---
> gtk/spicy.c | 77
> ++-
> 1 files changed, 60 insertions(+), 17 deletions(-)
>
> diff --git a/gtk/spicy.c b/gtk/spicy.c
> index 533d7f7..30
Hi,
On 10/10/2011 02:49 PM, Marc-André Lureau wrote:
Does this means that .gitignore will always show up in git status? If
yes, then that's bad and I would rather keep it..
No (I just checked), it just means that when the .gitignore files get
regenerated
in a slightly different way (when mos
Same comment as previous patch.
On Mon, Oct 10, 2011 at 2:34 PM, Hans de Goede wrote:
> Signed-off-by: Hans de Goede
> ---
> gtk/spice-gtk-session.c | 9 +
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/gtk/spice-gtk-session.c b/gtk/spice-gtk-session.c
> index e0
Why 0.10? We are 0.7.X right now. I don't see the need to bump version number.
Also, I wish you would have added this changes in the previous
commits, as I requested.
On Mon, Oct 10, 2011 at 2:34 PM, Hans de Goede wrote:
> The SpiceGtkSession ones should be used instead.
>
> Signed-off-by: Hans
This should rather be done in GObjectClass.constructed()
On Mon, Oct 10, 2011 at 2:34 PM, Hans de Goede wrote:
> The auto-clipboard setting now lives in the SpiceGtkSession, if that
> was changed to FALSE (from the default of TRUE) and later another SpiceDisplay
> was created for this session th
Does this means that .gitignore will always show up in git status? If
yes, then that's bad and I would rather keep it..
On Mon, Oct 10, 2011 at 2:34 PM, Hans de Goede wrote:
> Auto-generated files do not belong in git. Having these in git causes
> changes to them accidentally ending up in other c
ack
On Mon, Oct 10, 2011 at 2:34 PM, Hans de Goede wrote:
> This was broken by the addition of SpiceGtkSession.
>
> Signed-off-by: Hans de Goede
> ---
> gtk/spice-client-gtk.override | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/gtk/spice-client-gtk.override b/gt
Signed-off-by: Hans de Goede
---
gtk/spice-gtk-session.c | 55 ++-
gtk/spice-widget-priv.h |1 -
gtk/spice-widget.c | 43
gtk/spicy.c |6 ++--
4 files changed, 62 insertions(+), 43 deleti
Signed-off-by: Hans de Goede
---
gtk/spicy.c | 77 ++-
1 files changed, 60 insertions(+), 17 deletions(-)
diff --git a/gtk/spicy.c b/gtk/spicy.c
index 533d7f7..3034dbb 100644
--- a/gtk/spicy.c
+++ b/gtk/spicy.c
@@ -1,6 +1,6 @@
/* -*- Mod
Signed-off-by: Hans de Goede
---
gtk/spice-gtk-session.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/gtk/spice-gtk-session.c b/gtk/spice-gtk-session.c
index e051286..acc69f1 100644
--- a/gtk/spice-gtk-session.c
+++ b/gtk/spice-gtk-session.c
@@ -244,6 +244,7 @@
The SpiceGtkSession ones should be used instead.
Signed-off-by: Hans de Goede
---
gtk/spice-gtk-session.c | 11 ---
gtk/spice-widget.c | 11 ++-
2 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/gtk/spice-gtk-session.c b/gtk/spice-gtk-session.c
index d3cdd
The auto-clipboard setting now lives in the SpiceGtkSession, if that
was changed to FALSE (from the default of TRUE) and later another SpiceDisplay
was created for this session that would change it back to TRUE again.
This patch fixes this.
Signed-off-by: Hans de Goede
---
gtk/spice-widget.c |
Auto-generated files do not belong in git. Having these in git causes
changes to them accidentally ending up in other commits.
Signed-off-by: Hans de Goede
---
.gitignore| 106 -
doc/.gitignore| 22 -
doc/referenc
This was broken by the addition of SpiceGtkSession.
Signed-off-by: Hans de Goede
---
gtk/spice-client-gtk.override |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gtk/spice-client-gtk.override b/gtk/spice-client-gtk.override
index 7b3543a..e393037 100644
--- a/gtk/spice-
On Mon, Oct 10, 2011 at 10:09:28AM +0200, Andrea Celestino wrote:
>Hi,
>I've a simple question about update_area() function in Spice. I see
>there is a QXLWorker interface, with a function called update_area.
>This function is called in qxl.c.
>During my testing with streaming v
On Sun, Oct 09, 2011 at 08:03:43PM -0700, Naga Mohan Pothula wrote:
>Hi Alon,
>Thank you for your prompt response.
>I can't work on xorg.conf to set resolution for each guest. This is not
>optimum soltuion for me that hundreds of guests need to be updated.
>Need to support clipb
On 10/10/2011 05:03 AM, Naga Mohan Pothula wrote:
Hi Alon,
Thank you for your prompt response.
I can't work on xorg.conf to set resolution for each guest. This is
not optimum soltuion for me that hundreds of guests need to be updated.
Regardless of Spice, if you have hundreds of guests you ne
Hi,
I've a simple question about update_area() function in Spice. I see there is
a QXLWorker interface, with a function called update_area. This function is
called in qxl.c.
During my testing with streaming video, this function was never called, so
it is not used to update streaming video area. Ca
43 matches
Mail list logo
